[PATCH] D147908: [clang-tidy] Add support for long double in bugprone-incorrect-roundings

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Support all floating po

[PATCH] D147908: [clang-tidy] Add support for long double in bugprone-incorrect-roundings

PiotrZSL updated this revision to Diff 512082. PiotrZSL edited the summary of this revision. PiotrZSL added a comment. Update dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147908/new/ https://reviews.llvm.org/D147908 Files: clang-tool

[PATCH] D147908: [clang-tidy] Add support for long double in bugprone-incorrect-roundings

PiotrZSL updated this revision to Diff 512085. PiotrZSL added a comment. iDependency fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147908/new/ https://reviews.llvm.org/D147908 Files: clang-tools-extra/clang-tidy/bugprone/IncorrectRoundingsC

[PATCH] D147911: [5/N][POC][Clang] Define tuple type variant of vlseg2e32ff

eopXD created this revision. Herald added subscribers: luke, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb. Herald added a project: All.

[PATCH] D147912: [6/N][POC][Clang] Define tuple type variant of vlsseg2e32

eopXD created this revision. Herald added subscribers: luke, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb. Herald added a project: All.

[PATCH] D147913: [7/N][POC][Clang] Define tuple type variant of vssseg2e32

eopXD created this revision. Herald added subscribers: luke, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb. Herald added a project: All.

[PATCH] D147914: [8/N][POC][Clang] Define tuple type variant of vloxseg2ei32 vluxseg2ei32

eopXD created this revision. Herald added subscribers: luke, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb. Herald added a project: All.

[PATCH] D147915: [9/N][POC][Clang] Define tuple type variant of vsoxseg2ei32 vsuxseg2ei32

eopXD created this revision. Herald added subscribers: luke, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb. Herald added a project: All.

[PATCH] D147916: [10/N][POC][Clang] Define vget for tuple type

eopXD created this revision. Herald added subscribers: luke, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb. Herald added a project: All.

[PATCH] D147917: [11/11][POC][Clang] Define vset for tuple type

eopXD created this revision. Herald added subscribers: luke, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb. Herald added a project: All.

[PATCH] D147918: [clang-tidy] Added IgnoreVirtual option to misc-unused-parameters

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Added option to ignore

[PATCH] D147909: [clang] Implement CWG 2397

zyounan created this revision. Herald added a project: All. zyounan added a comment. zyounan added reviewers: aaron.ballman, erichkeane, rsmith. zyounan published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Note GCC had implemented such feature

[PATCH] D147894: [clang-format] SortIncludes documentation: remove contradiction in its description

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Sorry I don’t get how this change helps. Removing the option values does make it clearer IMHO CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147894/new/ http

[PATCH] D147893: [clang-tidy] avoid colon in namespace cause false positve

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Except above llvm:errs, looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147893/new/ https://reviews.llvm.org/D147893 __

[PATCH] D144510: [clang-tidy] improve readability-identifier-naming hungarian options test

dougpuob added a comment. Herald added a subscriber: PiotrZSL. Hi @amurzeau I missed the review before landing. I have a suggestion regarding the customized prefix "cust" because it confused me when I found the Hungarian notation patterns in the output message. Perhaps using "my" instead of "cu

[PATCH] D147920: [clang] Add test for CWG399

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG399 is resolved by explicitly appealing to th

[PATCH] D147920: [clang] Add test for CWG399

Endill added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:1439 + +namespace dr399 { // dr399: 11 + // NB: reuse dr244 test Despite a couple of FIXME in CWG244 test (out of dozens of examples), it claims full availability since Clan

[PATCH] D147924: [clang-tidy] Exclude template instantiations in modernize-use-override

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixed false positive

[PATCH] D147661: [Sema] Tweak merging of availability attributes

rsandifo-arm added a comment. > I threw together a patch to make the constructors `explicit` and the only two > compile failures I have are with what you're fixing in this patch. If you'd > like, I can commandeer this patch and subsume it with the larger refactor. > Alternatively, we can land t

[clang-tools-extra] 01025dd - [clang-tidy][NFC] Rename test files for simplify-boolean-expr to match check name

Author: Piotr Zegar Date: 2023-04-10T09:50:59Z New Revision: 01025ddd6264737ebf617bd754173969af34243f URL: https://github.com/llvm/llvm-project/commit/01025ddd6264737ebf617bd754173969af34243f DIFF: https://github.com/llvm/llvm-project/commit/01025ddd6264737ebf617bd754173969af34243f.diff LOG: [

[PATCH] D147925: [Clang] Check type-constraints applied to placeholder types

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. (and deduced return types) Previously, only type constraints applied to type parameter were semantically checked. A diag

[clang] 6737a15 - [clang] Mark CWG536 as N/A

Author: Vlad Serebrennikov Date: 2023-04-10T13:18:19+03:00 New Revision: 6737a1520900a506a884db6677a03fa729c2f197 URL: https://github.com/llvm/llvm-project/commit/6737a1520900a506a884db6677a03fa729c2f197 DIFF: https://github.com/llvm/llvm-project/commit/6737a1520900a506a884db6677a03fa729c2f197.

[PATCH] D147564: [clang] Mark CWG536 as N/A

This revision was automatically updated to reflect the committed changes. Closed by commit rG6737a1520900: [clang] Mark CWG536 as N/A (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147564/new/ https://reviews.llvm.org/D147564 F

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

zahiraam updated this revision to Diff 512108. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147733/new/ https://reviews.llvm.org/D147733 Files: clang/lib/Sema/SemaAttr.cpp clang/test/CodeGen/pragma-fenv_access.c Index: clang/test/CodeGen/

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

IncludeGuardian created this revision. IncludeGuardian added a reviewer: clang. IncludeGuardian added a project: clang. Herald added a project: All. IncludeGuardian requested review of this revision. Herald added a subscriber: cfe-commits. The multiple-include optimization allows Clang to avoid op

[PATCH] D147929: [clang-tidy] Fix handling of UseAssignment option in cppcoreguidelines-prefer-member-initializer

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp. Herald added subscribers: shchenz, kbarton, xazax.hun, nemanjai. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-comm

[PATCH] D147876: [clang-tidy] Support specifying checks as a list in the config file

carlosgalvezp updated this revision to Diff 512114. carlosgalvezp marked 2 inline comments as done. carlosgalvezp retitled this revision from "[clang-tidy] Support introducing checks as a list in the config file" to "[clang-tidy] Support specifying checks as a list in the config file". carlosgalv

[PATCH] D147876: [clang-tidy] Support specifying checks as a list in the config file

carlosgalvezp marked an inline comment as done. carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:129-141 +// Special case for reading from YAML +// Must support reading from both a string or a list +Input &I = reinterp

[PATCH] D147918: [clang-tidy] Added IgnoreVirtual option to misc-unused-parameters

carlosgalvezp added a comment. Looks good, small comments! Comment at: clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp:183 +if (Method->isLambdaStaticInvoker() || +(IgnoreVirtual && Method->isVirtual())) return; Since these 2 cond

[PATCH] D147924: [clang-tidy] Exclude template instantiations in modernize-use-override

njames93 added a comment. I'm not sure this is really a great improvement. If the override candidate originates in a templated base class I think we should still warn struct Foo { virtual void foo(); }; template struct DirectBase : T { virtual void foo(); }; DirectBase

[PATCH] D147906: [clang-tidy] Avoid float compare in bugprone-incorrect-roundings

carlosgalvezp added a comment. Looks good, small suggestions! I appreciate having this small patch prior to the next one fixing the actual issue. Comment at: clang-tools-extra/clang-tidy/bugprone/IncorrectRoundingsCheck.cpp:28 + if ((&Node.getSemantics()) == &llvm::APFloat::I

[PATCH] D147908: [clang-tidy] Add support for long double in bugprone-incorrect-roundings

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. Nice cleanup and increased generality, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147908/new/ https://reviews.llvm.o

[PATCH] D147893: [clang-tidy] avoid colon in namespace cause false positve

HerrCai0907 updated this revision to Diff 512116. HerrCai0907 added a comment. remove debug log Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147893/new/ https://reviews.llvm.org/D147893 Files: clang-tools-extra/clang-tidy/modernize/ConcatNested

[PATCH] D147876: [clang-tidy] Support specifying checks as a list in the config file

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:129-141 +// Special case for reading from YAML +// Must support reading from both a string or a list +Input &I = reinterpret_cast(IO); +if (isa(I.getCurrentNode()) |

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

IncludeGuardian added a comment. Differences between the behaviors of compilers can be found here https://github.com/IncludeGuardian/multiple-inclusion-optimization-tests You can see the number of boost preprocessor files failing the include guard optimization when running IncludeGuardian

[clang-tools-extra] 72777dc - [clang-tidy] avoid colon in namespace cause false positve

Author: Congcong Cai Date: 2023-04-10T13:42:33+02:00 New Revision: 72777dc000ac432a99cf5f591553127432bd0365 URL: https://github.com/llvm/llvm-project/commit/72777dc000ac432a99cf5f591553127432bd0365 DIFF: https://github.com/llvm/llvm-project/commit/72777dc000ac432a99cf5f591553127432bd0365.diff

[PATCH] D147893: [clang-tidy] avoid colon in namespace cause false positve

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG72777dc000ac: [clang-tidy] avoid colon in namespace cause false positve (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D147929: [clang-tidy] Fix handling of UseAssignment option in cppcoreguidelines-prefer-member-initializer

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp:134 + Options.get("UseAssignment", + OptionsView("modernize-use-default-member-init", +

[PATCH] D147661: [Sema] Tweak merging of availability attributes

aaron.ballman commandeered this revision. aaron.ballman edited reviewers, added: rsandifo-arm; removed: aaron.ballman. aaron.ballman added a comment. In D147661#4255043 , @rsandifo-arm wrote: >> I threw together a patch to make the constructors `explicit

[PATCH] D147876: [clang-tidy] Support specifying checks as a list in the config file

njames93 accepted this revision. njames93 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:129-141 +// Special case for reading from YAML +// Must support reading from both a string or a

[PATCH] D147906: [clang-tidy] Avoid float compare in bugprone-incorrect-roundings

PiotrZSL marked an inline comment as done. PiotrZSL added a comment. D147908 fixes comments from this on, it's just split into 2 reviews, this as fixing issue, and other as introducing improvment. Comment at: clang-tools-extra/clang-tidy/bug

[PATCH] D147918: [clang-tidy] Added IgnoreVirtual option to misc-unused-parameters

njames93 added a comment. Have you thought about handling CRTP overrides template class Base { int getThing(int x) { return x; } }; class Derived : public Base { int getThing(int x) { return 0; } }; I'm not saying update this to work for that, but could

[PATCH] D147908: [clang-tidy] Add support for long double in bugprone-incorrect-roundings

PiotrZSL updated this revision to Diff 512119. PiotrZSL added a comment. Remove local variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147908/new/ https://reviews.llvm.org/D147908 Files: clang-tools-extra/clang-tidy/bugprone/IncorrectRoun

[PATCH] D147929: [clang-tidy] Fix handling of UseAssignment option in cppcoreguidelines-prefer-member-initializer

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp:134 + Options.get("UseAssignment", + OptionsView("modernize-use-default-member-init", + Cont

[PATCH] D147924: [clang-tidy] Exclude template instantiations in modernize-use-override

PiotrZSL added a comment. Problem is that you may have specialization of Bar class wihtout bar base, and that specialization can be local to some compilation unit. Like: template<> struct Bar { void bar(); // function wihout virtual or no function at all. }; And now your fix (overri

[clang] 636dd1e - Make explicit the single-argument constructors of AttributeCommonInfo; NFC

Author: Aaron Ballman Date: 2023-04-10T08:29:21-04:00 New Revision: 636dd1e8a1782e22f9bdee640428ed5c50a4a4f2 URL: https://github.com/llvm/llvm-project/commit/636dd1e8a1782e22f9bdee640428ed5c50a4a4f2 DIFF: https://github.com/llvm/llvm-project/commit/636dd1e8a1782e22f9bdee640428ed5c50a4a4f2.diff

[PATCH] D147661: [Sema] Tweak merging of availability attributes

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG636dd1e8a178: Make explicit the single-argument constructors of At

[PATCH] D147918: [clang-tidy] Added IgnoreVirtual option to misc-unused-parameters

PiotrZSL updated this revision to Diff 512122. PiotrZSL marked 6 inline comments as done. PiotrZSL added a comment. Review fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147918/new/ https://reviews.llvm.org/D147918 Files: clang-tools-extra/

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

aaron.ballman added a comment. The changes in this patch seem to have caused https://lab.llvm.org/buildbot/#/builders/clang-ppc64-aix to go down for the past 4 days -- can you revert and investigate? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D147918: [clang-tidy] Added IgnoreVirtual option to misc-unused-parameters

PiotrZSL added a comment. CRTP not planed. Not in scope of #55665. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147918/new/ https://reviews.llvm.org/D147918 ___ cfe-commits mailing list cfe-commits@list

[clang-tools-extra] 3defc3b - [clang-tidy][NFC] Remove trailing spaces from ReleaseNotes.rst

Author: Piotr Zegar Date: 2023-04-10T12:43:11Z New Revision: 3defc3b707fb29e64cb90822bbce12d040057357 URL: https://github.com/llvm/llvm-project/commit/3defc3b707fb29e64cb90822bbce12d040057357 DIFF: https://github.com/llvm/llvm-project/commit/3defc3b707fb29e64cb90822bbce12d040057357.diff LOG: [

[clang] 4624797 - Fix the buildbots after 636dd1e8a1782e22f9bdee640428ed5c50a4a4f2

Author: Aaron Ballman Date: 2023-04-10T08:46:53-04:00 New Revision: 4624797f816123f327d2c8b80f7ec65c90750024 URL: https://github.com/llvm/llvm-project/commit/4624797f816123f327d2c8b80f7ec65c90750024 DIFF: https://github.com/llvm/llvm-project/commit/4624797f816123f327d2c8b80f7ec65c90750024.diff

[PATCH] D141892: Implement modernize-use-constraints

njames93 added a reviewer: carlosgalvezp. njames93 added a comment. Would you consider supporting enable_if via parameters template void doStuff(T&, std::enable_if_t = nullptr) {} Comment at: clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp:71 + +return s

[PATCH] D147925: [Clang] Check type-constraints applied to placeholder types

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This looks fine to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147925/new/ https://reviews.llvm.org/D147925 _

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

erichkeane abandoned this revision. erichkeane added a comment. Superceded by https://reviews.llvm.org/D146178 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147722/new/ https://reviews.llvm.org/D147722 ___ cfe-commits mailing list cfe-commits

[PATCH] D147935: [RISCV] Add SiFive extension support

4vtomat created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, ni

[PATCH] D147924: [clang-tidy] Exclude template instantiations in modernize-use-override

njames93 added a comment. In D147924#4255209 , @PiotrZSL wrote: > Problem is that you may have specialization of Bar class wihtout bar base, > and that specialization can be local to some compilation unit. > Like: > > template<> > struct Bar { >

[PATCH] D147918: [clang-tidy] Added IgnoreVirtual option to misc-unused-parameters

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147918/new/ https://reviews.llvm.org/D147918 __

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

erichkeane abandoned this revision. erichkeane added a comment. Superceded by: https://reviews.llvm.org/D147655 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126818/new/ https://reviews.llvm.org/D126818 ___ cfe-commits mailing list cfe-commit

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

erichkeane added a comment. In D147655#4251984 , @rsmith wrote: > In D147655#4251042 , @aaron.ballman > wrote: > >> In D147655#4250922 , @royjacobson >> wrote: >> >>> In

[PATCH] D147901: [NFC][CLANG][API] Fix coverity remarks about large copies by values

aaron.ballman added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:138 APIRecord(RecordKind Kind, StringRef USR, StringRef Name, -PresumedLoc Location, AvailabilitySet Availabilities, +PresumedLoc Location, const AvailabilitySet &Avai

[PATCH] D147708: [NFC][clang] Fix static analyzer tool remarks about large copies by values

Manna closed this revision. Manna added a comment. I am closing this revision since it's already been pushed https://reviews.llvm.org/rG33cf2a39cb11 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147708/new/ https://reviews.llvm.org/D147708 _

[PATCH] D147574: [NFC][clang] Fix Coverity static analyzer tool concerns about auto_causes_copy

Manna closed this revision. Manna added a comment. I am closing this revision since it's already been pushed: https://reviews.llvm.org/rG59cb47015a18 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147574/new/ https://reviews.llvm.org/D147574 _

[PATCH] D147901: [NFC][CLANG][API] Fix coverity remarks about large copies by values

RKSimon added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:138 APIRecord(RecordKind Kind, StringRef USR, StringRef Name, -PresumedLoc Location, AvailabilitySet Availabilities, +PresumedLoc Location, const AvailabilitySet &Availabili

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

njames93 requested changes to this revision. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ForwardUsageCheck.cpp:45 + +inline SourceRange getAnglesLoc(const Expr *MatchedCallee) { + if (const auto *DeclRefExprCallee = Use `

[PATCH] D147708: [NFC][clang] Fix static analyzer tool remarks about large copies by values

erichkeane added a comment. Note, in the future, if in your commit message you do: `Differential Revision: ` the review will auto-close so you don't have to manually do so. AND it'll automatically link to the commit you made. It makes it easier to find your reviews as well from the git-log,

[PATCH] D107294: [clang-tidy] adds warning to suggest users replace symbols with words

njames93 added a comment. The for Pipe/BitwiseOr issue. One heuristic could be: - If it has any kind of template dependence don't diagnost - If its a `BinaryOperator`, its safe to diagnose. - If its a `CxxOperatorCallExpr`, the simplest case I can think of is to check the spelling of the operato

[clang] 3442aba - [NFC][tests] Disable new gmodules-preferred-name-* tests on AIX and z/OS

Author: Jake Egan Date: 2023-04-10T09:51:02-04:00 New Revision: 3442aba806b98ffe2d6afbbc629d8a6a3731a5f5 URL: https://github.com/llvm/llvm-project/commit/3442aba806b98ffe2d6afbbc629d8a6a3731a5f5 DIFF: https://github.com/llvm/llvm-project/commit/3442aba806b98ffe2d6afbbc629d8a6a3731a5f5.diff LOG

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:263 + if (SubstitutedAtomicExpr.get()->isValueDependent()) +return SubstitutedAtomicExpr; So this bit is concerning to me... we have been catching a ton of bugs in the MLTAL stuf

[PATCH] D147941: [Flang][Driver][OpenMP] Enable flags for filtering of offloading passes in flang

skatrak created this revision. skatrak added reviewers: dpalermo, jsjodin, domada, agozillon, TIFitis, awarzynski. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. skatrak requested review of this revision. Herald added a

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. Looks like `gmodules` isn't supported on AIX (based on other tests that use `-dwarf-ext-refs`. So I'll just disable the new tests Thanks for notifying @aaron.ballman , email notifications got lost in the inbox Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D147941: [Flang][Driver][OpenMP] Enable flags for filtering of offloading passes in flang

awarzynski added a comment. Could you add tests that demonstrate what these options actually do? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147941/new/ https://reviews.llvm.org/D147941 ___ cfe-commits

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a subscriber: Jake-Egan. Michael137 added a comment. Oh looks like @Jake-Egan already did Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.org/D145803 ___ c

[PATCH] D147941: [Flang][Driver][OpenMP] Enable flags for filtering of offloading passes in flang

skatrak added a comment. In D147941#4255458 , @awarzynski wrote: > Could you add tests that demonstrate what these options actually do? Thank you for the quick review! These options just modify which `flang-new -fc1` invocations are produced by the dri

[PATCH] D93240: [clang-format] Add SpaceBeforeCaseColon option

MyDeveloperDay added a comment. In D93240#4254439 , @sstwcw wrote: > A goto label isn't affected by this option. Is it intentional? why would it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93240/new/ h

[clang-tools-extra] 225d255 - [clang-tidy] Added IgnoreVirtual option to misc-unused-parameters

Author: Piotr Zegar Date: 2023-04-10T14:41:32Z New Revision: 225d255a583ea3d50bbba49d949ca76be6a880bf URL: https://github.com/llvm/llvm-project/commit/225d255a583ea3d50bbba49d949ca76be6a880bf DIFF: https://github.com/llvm/llvm-project/commit/225d255a583ea3d50bbba49d949ca76be6a880bf.diff LOG: [

[PATCH] D147918: [clang-tidy] Added IgnoreVirtual option to misc-unused-parameters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG225d255a583e: [clang-tidy] Added IgnoreVirtual option to misc-unused-parameters (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D147906: [clang-tidy] Avoid float compare in bugprone-incorrect-roundings

PiotrZSL updated this revision to Diff 512149. PiotrZSL added a comment. Fix review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147906/new/ https://reviews.llvm.org/D147906 Files: clang-tools-extra/clang-tidy/bugprone/IncorrectRoundin

[PATCH] D147908: [clang-tidy] Add support for long double in bugprone-incorrect-roundings

PiotrZSL updated this revision to Diff 512150. PiotrZSL added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147908/new/ https://reviews.llvm.org/D147908 Files: clang-tools-extra/clang-tidy/bugprone/IncorrectRoundingsCheck.cpp

[clang] 1cdc0e8 - [Clang] Check type-constraints applied to placeholder types

Author: Corentin Jabot Date: 2023-04-10T17:33:09+02:00 New Revision: 1cdc0e83c8ce35702ddbc6b26959a5da44776a49 URL: https://github.com/llvm/llvm-project/commit/1cdc0e83c8ce35702ddbc6b26959a5da44776a49 DIFF: https://github.com/llvm/llvm-project/commit/1cdc0e83c8ce35702ddbc6b26959a5da44776a49.diff

[PATCH] D147925: [Clang] Check type-constraints applied to placeholder types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1cdc0e83c8ce: [Clang] Check type-constraints applied to placeholder types (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D147946: [clang-tidy] support inline namespace in c++20

HerrCai0907 created this revision. HerrCai0907 added a reviewer: PiotrZSL. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a sub

[PATCH] D147941: [Flang][Driver][OpenMP] Enable flags for filtering of offloading passes in flang

awarzynski added a comment. In D147941#4255461 , @skatrak wrote: > In D147941#4255458 , @awarzynski > wrote: > >> Could you add tests that demonstrate what these options actually do? > > Thank you for the quick r

[PATCH] D147946: [clang-tidy] support nested inline namespace in c++20 for modernize-concat-nested-namespaces

HerrCai0907 updated this revision to Diff 512165. HerrCai0907 added a comment. remove lamda Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147946/new/ https://reviews.llvm.org/D147946 Files: clang-tools-extra/clang-tidy/modernize/ConcatNestedName

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

aaron.ballman added a comment. In D144218#4254021 , @barannikov88 wrote: > There is something wrong with the `#if`s in the test, isn't it? They all look > no-op. Those are verifying that the macro expands to a value that can be used by the preprocesso

[PATCH] D147875: [clang][Diagnostics] WIP: Show line numbers when printing code snippets

aaron.ballman added a comment. GCC emits line numbers by default these days, so it seems reasonable for Clang to do so as well. Having a way to disable the feature is important though as some folks have scripts that scrap diagnostic results and changing the format may break those scripts in cha

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added reviewers: aaron.ballman, rsmith, lhames, sgraenitz. v.g.vassilev added a comment. I think it is a good time to invite more reviewers to take a look at this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https:/

[clang] 711b70d - Fix wording in a release note; NFC

Author: Aaron Ballman Date: 2023-04-10T12:54:30-04:00 New Revision: 711b70d77e99dd4101b9dfa94d9ea0d4149997ab URL: https://github.com/llvm/llvm-project/commit/711b70d77e99dd4101b9dfa94d9ea0d4149997ab DIFF: https://github.com/llvm/llvm-project/commit/711b70d77e99dd4101b9dfa94d9ea0d4149997ab.diff

[PATCH] D146986: Downgrade reserved module identifier error into a warning

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:92 + `_ and allows easier + building of precompiled modules. This diagnostic may be strengthened into an + error again in the future once there is a

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:263 + if (SubstitutedAtomicExpr.get()->isValueDependent()) +return SubstitutedAtomicExpr; erichkeane wrote: > So this bit is concerning to me... we have been catching

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:773 + // ConstrExpr for the inner template will properly adjust the depths. + if (isa(ND) && isa(OtherND)) +ForConstraintInstantiation = true; erichkeane wrote: > Hmm..

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:263 + if (SubstitutedAtomicExpr.get()->isValueDependent()) +return SubstitutedAtomicExpr; alexander-shaposhnikov wrote: > erichkeane wrote: > > So this bit is concerning to me...

[PATCH] D147834: [clang][driver] Pass `-femulated-tls` through to the linker in LTO mode

paulkirth updated this revision to Diff 512189. paulkirth marked an inline comment as done. paulkirth added a comment. Fix formatting in CHECK lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147834/new/ https://reviews.llvm.org/D147834 Files:

[PATCH] D147834: [clang][driver] Pass `-femulated-tls` through to the linker in LTO mode

paulkirth added inline comments. Comment at: clang/test/Driver/emulated-tls.cpp:57 +// LTO related checks +//LTO_NOEMUTLS: plugin-opt=-emulated-tls=0 +//LTO_NOEMUTLS-NOT: plugin-opt=-emulated-tls=1 vit9696 wrote: > Maybe add a space before LTO here? Good catch. F

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

aaron.ballman added a comment. In D147175#4251852 , @philnik wrote: > In D147175#4251076 , @aaron.ballman > wrote: > >> One thing I can't quite determine is whether we expect to call this type >> trait often or

[PATCH] D147875: [clang][Diagnostics] WIP: Show line numbers when printing code snippets

cjdb added a comment. I have no opinion on this addition. If folks find it useful in GCC, happy to see it added. Comment at: clang/lib/Frontend/TextDiagnostic.cpp:1139 +return 7; + return 0; +} I'd prefer this to be an assert rather than returning a value

[PATCH] D147836: [clang] Add test for CWG1822

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. Thank you! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147836/new/ https://reviews.llvm.org/D147836

[PATCH] D147834: [clang][driver] Pass `-femulated-tls` through to the linker in LTO mode

paulkirth updated this revision to Diff 512190. paulkirth added a comment. Remove extra newlines in emulated-tls.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147834/new/ https://reviews.llvm.org/D147834 Files: clang/lib/Driver/ToolChains/Co

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:773 + // ConstrExpr for the inner template will properly adjust the depths. + if (isa(ND) && isa(OtherND)) +ForConstraintInstantiation = true; alexander-shaposhnikov wrote: > erich

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

barannikov88 added a comment. In D144218#4255686 , @aaron.ballman wrote: > In D144218#4254021 , @barannikov88 > wrote: > >> There is something wrong with the `#if`s in the test, isn't it? They all >> look no-op

  1   2   3   >