[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

chapuni added a comment. This is an obvious fix and builds are still broken. Go ahead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147764/new/ https://reviews.llvm.org/D147764 ___ cfe-commits mailing l

[clang] 53d8b59 - Fix the two gmoules-prefered-name-* tests

Author: YongKang Zhu Date: 2023-04-07T00:12:29-07:00 New Revision: 53d8b59307d4e1bbaa1632efbe762014c9f6575e URL: https://github.com/llvm/llvm-project/commit/53d8b59307d4e1bbaa1632efbe762014c9f6575e DIFF: https://github.com/llvm/llvm-project/commit/53d8b59307d4e1bbaa1632efbe762014c9f6575e.diff

[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG53d8b59307d4: Fix the two gmoules-prefered-name-* tests (authored by yozhu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D147742: [python] Enable bindings tests on Windows

R2RT added a comment. According to CI logs, these tests are still not run on Windows builder. Line below, present in Debian's log, is missing. [9746/10613] cd /var/lib/buildkite-agent/builds/llvm-project/clang/bindings/python && /usr/bin/cmake -E env CLANG_NO_DEFAULT_CONFIG=1 CLANG_LIBRARY_P

[clang] f197521 - [Clang] Fix markup in cxx_status

Author: Corentin Jabot Date: 2023-04-07T09:42:54+02:00 New Revision: f1975216846ed69d608e669c37efa5ee0e16276e URL: https://github.com/llvm/llvm-project/commit/f1975216846ed69d608e669c37efa5ee0e16276e DIFF: https://github.com/llvm/llvm-project/commit/f1975216846ed69d608e669c37efa5ee0e16276e.diff

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber updated this revision to Diff 511630. Krishna-13-cyber added a comment. Thanks a lot everyone for helping me out with my first patch. I have uploaded the patch again after rebase. Yes, It would be great if you could land it on my behalf. Name: Krishna Narayanan Email: Thanks ag

[PATCH] D137782: [clang-tidy]bugprone-fold-init-type

courbet updated this revision to Diff 511634. courbet added a comment. Fix release note placement and phrase it more consistenly with other notes in that section. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137782/new/ https://reviews.llvm.org/D

[PATCH] D147731: [3/N][POC][Clang] Add typedef of the tuple type and define tuple type variant of vlseg2e32

eopXD updated this revision to Diff 511635. eopXD added a comment. Change: Add overloaded name `vlseg2e32_tuple` for the tuple type variant to avoid naming collision to the existing non-tuple type overloaded intrinsics of `vlseg2e32`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D146376: Update static_assert message for redundant cases

xbolva00 added a comment. So.. new diagnostic is: :4:1: error: static assertion failed due to requirement 'is_gitlab' static_assert(is_gitlab and is_weekend); ^ ~ Okay, a dev changes is_gitlab to true, compiles it again and boom, new error: static assertion failed due

[PATCH] D147774: [4/N][POC][Clang] Define tuple type variant of vsseg2e32

eopXD created this revision. eopXD added reviewers: craig.topper, rogfer01, frasercrmck, reames, kito-cheng, nikic. Herald added subscribers: luke, StephenFan, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, jrtc27, nios

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall added a comment. doh, forgot to send Comment at: clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp:128 +*OS << "" << HTMLLogger_css << "\n"; +*OS << "" << HTMLLogger_js << "\n"; + gribozavr2 wrote: > Now that we have an HTML template file, you c

[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

Michael137 added a comment. Thanks for fixing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147764/new/ https://reviews.llvm.org/D147764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

royjacobson added a comment. In D147655#4250056 , @rsmith wrote: > There has not been any stable ABI from any compiler targeting the Itanium C++ > ABI for constrained templates prior to this change. I don't think we need to > worry too much about people

[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

dougpuob created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. dougpuob requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fix hungarian

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

aaron.ballman added a comment. In D147655#4250922 , @royjacobson wrote: > In D147655#4250056 , @rsmith wrote: > >> There has not been any stable ABI from any compiler targeting the Itanium >> C++ ABI for constra

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

hazohelet added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2357-2361 +if (SubobjectDecl) { + Info.FFDiag(DiagLoc, diag::note_constexpr_uninitialized) << SubobjectDecl; + Info.Note(SubobjectDecl->getLocation(), +diag::note_constexpr_

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

hazohelet updated this revision to Diff 511659. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146358/new/ https://reviews.llvm.org/D146358 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticASTKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/AST/Interp/Interp

[PATCH] D137782: [clang-tidy]bugprone-fold-init-type

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137782/new/ https://reviews.llvm.org/D137782 ___

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

aaron.ballman added a comment. In D147175#4249212 , @philnik wrote: > In D147175#4246513 , @aaron.ballman > wrote: > >> Ah, I like this approach -- it keeps things roughly in sync with checking >> for unique obj

[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:367-379 +if (const auto *TD = dyn_cast(ND)) { + QualType QT = TD->getType(); + + size_t PtrCount = 0; + if (QT->isPointerType()) { +

[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

PiotrZSL added a comment. Missing release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147779/new/ https://reviews.llvm.org/D147779 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito updated this revision to Diff 511663. ManuelJBrito added a comment. Update to remove multiple uses of freeze poison. I am unsure about the code style used in the 128 to 512 casts. Any comments are appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D147673: [Clang] Improve designated inits diagnostic location

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/cxx2b-designated-initializers.cpp:13 + const S result { // expected-error {{field designator (null) does not refer to any field in type 'const S'}} +.a = x + }; rsmith wrote: > Why are we

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

nlopes accepted this revision. nlopes added a comment. This revision is now accepted and ready to land. LGTM, but please wait for another reviewer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143287/new/ https://reviews.llvm.org/D143287

[PATCH] D147782: [clang] Fix 'operator=' lookup in nested class

J-Camilleri created this revision. Herald added a project: All. J-Camilleri requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If implicitly declared 'operator=' declarations are generated before encountering a use in a nested class, custom de

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

aaron.ballman added a comment. In D147717#4249929 , @cjdb wrote: > In D147717#4248989 , @erichkeane > wrote: > >> @cjdb has been running some GDB test suites against our compiler: I am >> wondering if we could a

[PATCH] D147762: [Clang] Fix filtering of inline namespaces for friend functions

aaron.ballman added a comment. Good catch! Let's skip the release note for this for now, because I think we should cherry-pick this to the 16.0.2 milestone -- but you should add the release note when landing on that branch so users know about the fix. CHANGES SINCE LAST ACTION https://review

[PATCH] D146376: Update static_assert message for redundant cases

aaron.ballman added a comment. In D146376#4250814 , @xbolva00 wrote: > The patch description mixes "or" and "and" in examples, please fix it. > > SO probably you meant > > :4:1: error: static assertion failed due to requirement 'is_gitlab' > static_as

[PATCH] D137782: [clang-tidy]bugprone-fold-init-type

courbet added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137782/new/ https://reviews.llvm.org/D137782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang-tools-extra] 1012677 - [clang-tidy]bugprone-fold-init-type

Author: Clement Courbet Date: 2023-04-07T14:17:03+02:00 New Revision: 1012677284b87091f76542c3c79da641101578ae URL: https://github.com/llvm/llvm-project/commit/1012677284b87091f76542c3c79da641101578ae DIFF: https://github.com/llvm/llvm-project/commit/1012677284b87091f76542c3c79da641101578ae.dif

[PATCH] D137782: [clang-tidy]bugprone-fold-init-type

This revision was automatically updated to reflect the committed changes. Closed by commit rG1012677284b8: [clang-tidy]bugprone-fold-init-type (authored by courbet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137782/new/ https://reviews.llvm.org/

[clang] 06c6fac - Update static_assert message for redundant cases

Author: Krishna Narayanan Date: 2023-04-07T08:22:04-04:00 New Revision: 06c6fac696e46fe58dd48ce8b15fafc308688828 URL: https://github.com/llvm/llvm-project/commit/06c6fac696e46fe58dd48ce8b15fafc308688828 DIFF: https://github.com/llvm/llvm-project/commit/06c6fac696e46fe58dd48ce8b15fafc308688828.d

[PATCH] D146376: Update static_assert message for redundant cases

This revision was automatically updated to reflect the committed changes. Closed by commit rG06c6fac696e4: Update static_assert message for redundant cases (authored by Krishna-13-cyber, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. In D147714#4249531 , @xbolva00 wrote: > Added location when emiting diagnostic about failed TCO in the backend. Will the diagnostic behavior change based on optimization level? Wi

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

erichkeane added a comment. I think it is probably a good idea to revert that one until you get a chance to figure out that problem (and #61993 if it is related!). Other than the test being dependent on your change (and perhaps failing without your change), this is otherwise unrelated, so I mi

[PATCH] D147782: [clang] Fix 'operator=' lookup in nested class

J-Camilleri added a reviewer: aaron.ballman. J-Camilleri added a comment. Firstly, If there are other reviewers which I should include instead please let me know, the developers that changed around this area did so a long time ago and I do not know who to add. I have described the problem in th

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

erichkeane added a comment. Yeah, I think the diagnostics result of this attribute are unacceptable. I understand the goal here, but I suspect the more ergonomic (albeit, perhaps surprising) is a `[[should_tail]]` attribute sort of thing: a tail-hint where we do 'best effort with no promises',

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

jp4a50 marked 29 inline comments as done. jp4a50 added a comment. Marked comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146101/new/ https://reviews.llvm.org/D146101 ___ cfe-commits maili

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

xbolva00 added a subscriber: jacobsa. xbolva00 added a comment. >> Could we instead encode the platform specific tail-call rules in Sema? We >> definitely have attributes that differ in behavior between platforms, and >> this seems like a perfect candidate. But then you break promise of musttai

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

erichkeane added a comment. In D147714#4251208 , @xbolva00 wrote: >>> Could we instead encode the platform specific tail-call rules in Sema? We >>> definitely have attributes that differ in behavior between platforms, and >>> this seems like a perfect c

[PATCH] D141307: Add -f[no-]loop-versioning option

awarzynski added a comment. Mats, thanks for working on this! Just a few minor suggestions from me. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:55 +static bool shouldLoopVersion(const ArgList &Args) { + if (Arg *A = Args.getLastArg(options::OPT_Ofast, options::OPT_O, -

[clang] 8385ee0 - [clang-format] NFC Document the other space before colon option

Author: sstwcw Date: 2023-04-07T13:52:18Z New Revision: 8385ee05e59d2e05f0040c5dbdd0580b3e75f36b URL: https://github.com/llvm/llvm-project/commit/8385ee05e59d2e05f0040c5dbdd0580b3e75f36b DIFF: https://github.com/llvm/llvm-project/commit/8385ee05e59d2e05f0040c5dbdd0580b3e75f36b.diff LOG: [clang

[PATCH] D147422: [clang-format] NFC Document the other space before colon option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8385ee05e59d: [clang-format] NFC Document the other space before colon option (authored by sstwcw). Changed prior to commit: https://reviews.llvm.

[clang] 653a82e - [clang] Add test for CWG191

Author: Vlad Serebrennikov Date: 2023-04-07T17:54:38+04:00 New Revision: 653a82e95257a7cd3f22c24e40d54459a6608429 URL: https://github.com/llvm/llvm-project/commit/653a82e95257a7cd3f22c24e40d54459a6608429 DIFF: https://github.com/llvm/llvm-project/commit/653a82e95257a7cd3f22c24e40d54459a6608429.

[PATCH] D147530: [clang] Add test for CWG191

This revision was automatically updated to reflect the committed changes. Closed by commit rG653a82e95257: [clang] Add test for CWG191 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147530/new/ https://reviews.llvm.org/D147530

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

xbolva00 added a comment. >> Will the diagnostic be emitted to the correct location if there's no debug >> info? I did some experiments and with no debug info, I got atleast the location of the caller. If we consider than currently there is no location, anything is improvement and this is prob

[PATCH] D137782: [clang-tidy]bugprone-fold-init-type

Eugene.Zelenko added a comment. Please rebase from latest `main`. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:294 +- Improved :doc:`bugprone-fold-init-type + ` to handle iterators that do not Please keep alphabetical order (by check name) in this se

[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

PiotrZSL added a comment. Overall looks +- fine, these are last comments from me. Comment at: clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:127 + + for (size_t Index = 0; Index < Namespaces.size(); Index++) { +if (Namespaces[Index]->isNested()) --

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 updated this revision to Diff 511683. kpdev42 edited the summary of this revision. kpdev42 added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new/ https://reviews.llvm.org/D143347 Files: lldb/so

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1483 +// base with all fields having [[no_unique_address]] attribute. +for (auto it = base_classes.rbegin(); it != base_classes.rend(); ++it) { + clang::CXXRecordD

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1483 +// base with all fields having [[no_unique_address]] attribute. +for (auto it = base_classes.rbegin(); it != base_classes.rend(); ++it) { + clang::CXXRecordD

[clang-tools-extra] d880d4e - [doc][clang-tidy] Sort release notes by check name.

Author: Clement Courbet Date: 2023-04-07T16:11:37+02:00 New Revision: d880d4e7c228e27bd8040e7e2616cfd8c02678bf URL: https://github.com/llvm/llvm-project/commit/d880d4e7c228e27bd8040e7e2616cfd8c02678bf DIFF: https://github.com/llvm/llvm-project/commit/d880d4e7c228e27bd8040e7e2616cfd8c02678bf.dif

[PATCH] D137782: [clang-tidy]bugprone-fold-init-type

courbet marked an inline comment as done. courbet added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:294 +- Improved :doc:`bugprone-fold-init-type + ` to handle iterators that do not Eugene.Zelenko wrote: > Please keep alphabetical orde

[clang] 33e8431 - [clang] Add test for CWG255

Author: Vlad Serebrennikov Date: 2023-04-07T18:33:33+04:00 New Revision: 33e84315e7d674cf6327d23f035aa4a2f28ac8ee URL: https://github.com/llvm/llvm-project/commit/33e84315e7d674cf6327d23f035aa4a2f28ac8ee DIFF: https://github.com/llvm/llvm-project/commit/33e84315e7d674cf6327d23f035aa4a2f28ac8ee.

[PATCH] D147549: [clang] Add test for CWG255

This revision was automatically updated to reflect the committed changes. Closed by commit rG33e84315e7d6: [clang] Add test for CWG255 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147549/new/ https://reviews.llvm.org/D147549

[clang] 154825b - [clang] Mark CWG562 as N/A

Author: Vlad Serebrennikov Date: 2023-04-07T18:33:56+04:00 New Revision: 154825bdf6fb5ec5b4cd7d53cf93d68b185ca55d URL: https://github.com/llvm/llvm-project/commit/154825bdf6fb5ec5b4cd7d53cf93d68b185ca55d DIFF: https://github.com/llvm/llvm-project/commit/154825bdf6fb5ec5b4cd7d53cf93d68b185ca55d.

[PATCH] D147554: [clang] Mark CWG562 as N/A

This revision was automatically updated to reflect the committed changes. Closed by commit rG154825bdf6fb: [clang] Mark CWG562 as N/A (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147554/new/ https://reviews.llvm.org/D147554 F

[PATCH] D147590: [clang] Add test for CWG607

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b0386940255: [clang] Add test for CWG607 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] 4b03869 - [clang] Add test for CWG607

Author: Vlad Serebrennikov Date: 2023-04-07T18:40:35+04:00 New Revision: 4b03869402558d6aa24ce08766825eef34d6aff6 URL: https://github.com/llvm/llvm-project/commit/4b03869402558d6aa24ce08766825eef34d6aff6 DIFF: https://github.com/llvm/llvm-project/commit/4b03869402558d6aa24ce08766825eef34d6aff6.

[PATCH] D147535: [clang][Interp] Don't create global variables more than once

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I keep trying to find some way to test this change... and instead, I've filed several new crashing issues in the issue tracker. The changes look correct to me despite the lack of

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

sstwcw added inline comments. Comment at: clang/docs/tools/dump_format_style.py:72 - subtype, napplied = re.subn(r'^std::vector<(.*)>$', r'\1', typestr) - if napplied == 1: -return 'List of ' + pluralize(to_yaml_type(subtype)) + match = re.match(r'std::vector<(.*)>$', ty

[PATCH] D147534: [clang][Interp] Make sure we have a variable scope for initializers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Generally LGTM but had an additional test request. Comment at: clang/test/AST/Interp/records.cpp:315 + auto T = Test(Arr, Pos); + // End of scope, sho

[clang] b7e20aa - [Doc][NFC] Fix a typo

Author: Phoebe Wang Date: 2023-04-07T23:34:26+08:00 New Revision: b7e20aa9b7d31e91db6df82baba30b8d33050638 URL: https://github.com/llvm/llvm-project/commit/b7e20aa9b7d31e91db6df82baba30b8d33050638 DIFF: https://github.com/llvm/llvm-project/commit/b7e20aa9b7d31e91db6df82baba30b8d33050638.diff L

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

python3kgae updated this revision to Diff 511697. python3kgae added a comment. Revert change for self-assign-field which deserve its own pull request. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146897/new/ https://reviews.llvm.org/D146897 Files

[PATCH] D146240: [libc++][format] Use granularized charconv.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57e20cab5a1d: [libc++][format] Use granularized charconv. (authored by Mordante). Herald added projects: clang, clang-format. Herald added a subscrib

[PATCH] D144328: [libc++][format][chrono] Addresses LWG3842.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf07b882e2c1: [libc++][format][chrono] Addresses LWG3842. (authored by Mordante). Herald added projects: clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, Hazardy

[PATCH] D137302: [clang-tidy] Add modernize-type-traits check

njames93 updated this revision to Diff 511702. njames93 added a comment. Rebased and sorted release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137302/new/ https://reviews.llvm.org/D137302 Files: clang-tools-extra/clang-tidy/modernize/CM

[clang] d89c653 - [Clang] Fix filtering of inline namespaces for friend functions

Author: Shafik Yaghmour Date: 2023-04-07T08:58:39-07:00 New Revision: d89c6530fdb57da31f4750bf941a0e4a090c4474 URL: https://github.com/llvm/llvm-project/commit/d89c6530fdb57da31f4750bf941a0e4a090c4474 DIFF: https://github.com/llvm/llvm-project/commit/d89c6530fdb57da31f4750bf941a0e4a090c4474.dif

[PATCH] D147762: [Clang] Fix filtering of inline namespaces for friend functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGd89c6530fdb5: [Clang] Fix filtering of inline namespaces for friend functions (authored by shafik). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D147791: [NFC][CLANG] Fix static analyzer tool remarks about unchecked return values

Manna created this revision. Manna added reviewers: erichkeane, aaron.ballman. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added projects: All, clang, clang-format. Herald added reviewers: rymiel

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 511704. paulkirth marked an inline comment as done. paulkirth added a comment. Remove unrelated whitespace changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463

[clang] f9b854b - [Clang] Fix buildbots after Fix filtering of inline namespaces for friend functions commit

Author: Shafik Yaghmour Date: 2023-04-07T09:18:15-07:00 New Revision: f9b854bc8f0bfe2a38b00fab401bb1982eb8e61e URL: https://github.com/llvm/llvm-project/commit/f9b854bc8f0bfe2a38b00fab401bb1982eb8e61e DIFF: https://github.com/llvm/llvm-project/commit/f9b854bc8f0bfe2a38b00fab401bb1982eb8e61e.dif

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

Mordante marked 4 inline comments as done. Mordante added a comment. Herald added projects: clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. Thanks for the review! Comment at: libcxx/test/

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

Mordante updated this revision to Diff 511705. Mordante marked 2 inline comments as done. Mordante added a comment. Rebased, addresses review comment, and get a CI run. Herald added a comment. NOTE: Clang-Format Team Automated Review Comment It looks like your clang-format review does not cont

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

Mordante updated this revision to Diff 511709. Mordante added a comment. CI fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331 Files: libcxx/docs/FeatureTestMacroTable.rst libcxx/docs/ReleaseNotes

[PATCH] D147791: [NFC][CLANG] Fix static analyzer tool remarks about unchecked return values

erichkeane added a comment. I don't see much value in these changes. In the cases I know anything about, the change in state (or out params) is the error checking that we need. The casts add nothing but noise, so I don't think these are good changes. Repository: rG LLVM Github Monorepo CH

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

andrew.w.kaylor added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:1340 + if (!IsEnabled) +NewFPFeatures.setDisallowFenvAccess(IsEnabled); FpPragmaStack.Act(Loc, PSK_Set, StringRef(), NewFPFeatures); Why is this only needed for "!IsEnabled"? W

[PATCH] D147791: [NFC][CLANG] Fix static analyzer tool remarks about unchecked return values

Manna added a comment. In D147791#4251497 , @erichkeane wrote: > I don't see much value in these changes. In the cases I know anything about, > the change in state (or out params) is the error checking that we need. The > casts add nothing but noise,

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

andrew.w.kaylor added inline comments. Comment at: clang/test/CodeGen/pragma-fenv_access.c:239 +// CHECK-LABEL: @func_20 +// STRICT: call float @llvm.experimental.constrained.fadd.f32(float {{.*}}, float {{.*}}, metadata !"round.tonearest", metadata !"fpexcept.strict") +// DEFAU

[PATCH] D147791: [NFC][CLANG] Fix static analyzer tool remarks about unchecked return values

erichkeane added a comment. That sounds appropriate to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147791/new/ https://reviews.llvm.org/D147791 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

Mordante updated this revision to Diff 511715. Mordante added a comment. CI fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331 Files: libcxx/docs/FeatureTestMacroTable.rst libcxx/docs/ReleaseNotes.

[PATCH] D137302: [clang-tidy] Add modernize-type-traits check

njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/TypeTraitsCheck.cpp:170 + +static constexpr char Bind[] = ""; + ccotter wrote: > NIT: should the bound node have some meaningful non-empt

[clang-tools-extra] 376168b - [clang-tidy] Add modernize-type-traits check

Author: Nathan James Date: 2023-04-07T18:38:15+01:00 New Revision: 376168babb51aa08bc864d4797db4a6dbd53fdbc URL: https://github.com/llvm/llvm-project/commit/376168babb51aa08bc864d4797db4a6dbd53fdbc DIFF: https://github.com/llvm/llvm-project/commit/376168babb51aa08bc864d4797db4a6dbd53fdbc.diff

[PATCH] D137302: [clang-tidy] Add modernize-type-traits check

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. njames93 marked 2 inline comments as done. Closed by commit rG376168babb51: [clang-tidy] Add modernize-type-traits check (authored by njames9

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

zahiraam added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:1340 + if (!IsEnabled) +NewFPFeatures.setDisallowFenvAccess(IsEnabled); FpPragmaStack.Act(Loc, PSK_Set, StringRef(), NewFPFeatures); andrew.w.kaylor wrote: > Why is this only needed f

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

haberman added a comment. > is a [[should_tail]] attribute sort of thing: a tail-hint where we do 'best > effort with no promises', and make no guarantees that we're going to tail it. I'm not sure I see the value in that. The compiler already optimizes tail calls when it can in a best-effort ma

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

ayermolo added a comment. OK was able to create small(ish) repro main.h #include enum class Enums { ACCESS = 0, MAP = 1, }; template class DMap { public: template requires std::is_convertible_v void getOrCreate(TIDR v); }; template

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

erichkeane added a comment. In D147714#4251690 , @haberman wrote: >> is a [[should_tail]] attribute sort of thing: a tail-hint where we do 'best >> effort with no promises', and make no guarantees that we're going to tail it. > > I'm not sure I see the v

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

xbolva00 added a comment. So to make some conclusion - there is a need for less strict version of musttail in LLVM, right? Ideally platform specific, like x86_musttail? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147714/new/ https://reviews.llvm.org/D147714 _

[PATCH] D146240: [libc++][format] Use granularized charconv.

owenpan removed a reviewer: owenpan. Herald added a reviewer: owenpan. Herald added a comment. NOTE: Clang-Format Team Automated Review Comment It looks like your clang-format review does not contain any unit tests, please try to ensure all code changes have a unit test (unless this is an `NFC`

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

erichkeane added a comment. In D147714#4251752 , @xbolva00 wrote: > So to make some conclusion - there is a need for less strict version of > musttail in LLVM, right? Ideally platform specific, like x86_musttail? I'm not sure what the rules for the LLVM

[PATCH] D147673: [Clang] Improve designated inits diagnostic location

void marked an inline comment as done. void added inline comments. Comment at: clang/test/SemaCXX/cxx2b-designated-initializers.cpp:13 + const S result { // expected-error {{field designator (null) does not refer to any field in type 'const S'}} +.a = x + }; --

[clang] 2cbf512 - [Clang] Improve designated inits diagnostic location

Author: Bill Wendling Date: 2023-04-07T11:37:05-07:00 New Revision: 2cbf5127d58553fd6224a1ec809536bccc5b8510 URL: https://github.com/llvm/llvm-project/commit/2cbf5127d58553fd6224a1ec809536bccc5b8510 DIFF: https://github.com/llvm/llvm-project/commit/2cbf5127d58553fd6224a1ec809536bccc5b8510.diff

[PATCH] D147673: [Clang] Improve designated inits diagnostic location

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2cbf5127d585: [Clang] Improve designated inits diagnostic location (authored by void). Changed prior to commit: https://reviews.llvm.org/D147673?v

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

haberman added a comment. `[[nonportable_musttail]]` makes sense to me as a semantic. It indicates that the algorithm requires tail calls, but the author is willing to accept that the algorithm may be non-portable. "Non-portable" here can mean architecture-specific, but it can also mean "sensi

[clang] 13d44a8 - Revert "[Clang][Sema] Fix comparison of constraint expressions"

Author: Alexander Shaposhnikov Date: 2023-04-07T18:41:57Z New Revision: 13d44a8f5647819efd3ef57af384a3666f99d066 URL: https://github.com/llvm/llvm-project/commit/13d44a8f5647819efd3ef57af384a3666f99d066 DIFF: https://github.com/llvm/llvm-project/commit/13d44a8f5647819efd3ef57af384a3666f99d066.d

[PATCH] D147580: [Clang][NFC] Refactor "Designators" to be more similar

void added a comment. In D147580#4250232 , @shafik wrote: > I guess I should have waited till I saw: https://reviews.llvm.org/D147673 Yeah, sorry about that. I realized that I still needed to add the testcase before continuing. :-) Repository: rG LL

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15660 case BO_Assign: +// Skip diagnose on compound assignment. +DiagnoseSelfAssignment(S, LHS, RHS, OpLoc, false); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D147802: [clangd] Handle destructors in DefineOutline tweak

njames93 created this revision. njames93 added reviewers: kadircet, sammccall. Herald added a subscriber: arphaman. Herald added a project: All. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fix

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

erichkeane updated this revision to Diff 511753. erichkeane added a comment. Made changes as requested by Richard. "SkipForInstantiation" needed to be added when we added levels, but I think this is something that probably needs to be looked at and removed in the future. I also see the change

  1   2   >