This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57e20cab5a1d: [libc++][format] Use granularized charconv. (authored by Mordante). Herald added projects: clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146240/new/ https://reviews.llvm.org/D146240 Files: libcxx/include/__format/formatter_floating_point.h libcxx/include/__format/formatter_integral.h libcxx/include/__format/formatter_output.h libcxx/include/chrono libcxx/test/libcxx/transitive_includes/cxx03.csv libcxx/test/libcxx/transitive_includes/cxx11.csv libcxx/test/libcxx/transitive_includes/cxx14.csv libcxx/test/libcxx/transitive_includes/cxx17.csv libcxx/test/libcxx/transitive_includes/cxx20.csv libcxx/test/libcxx/transitive_includes/cxx2b.csv
Index: libcxx/test/libcxx/transitive_includes/cxx2b.csv =================================================================== --- libcxx/test/libcxx/transitive_includes/cxx2b.csv +++ libcxx/test/libcxx/transitive_includes/cxx2b.csv @@ -68,7 +68,6 @@ charconv initializer_list charconv limits chrono array -chrono charconv chrono cmath chrono compare chrono cstddef @@ -227,7 +226,7 @@ filesystem system_error filesystem version format array -format charconv +format cmath format cstddef format cstdint format cstdlib Index: libcxx/test/libcxx/transitive_includes/cxx20.csv =================================================================== --- libcxx/test/libcxx/transitive_includes/cxx20.csv +++ libcxx/test/libcxx/transitive_includes/cxx20.csv @@ -326,7 +326,7 @@ filesystem type_traits filesystem version format array -format charconv +format cmath format cstddef format cstdint format cstdlib Index: libcxx/test/libcxx/transitive_includes/cxx17.csv =================================================================== --- libcxx/test/libcxx/transitive_includes/cxx17.csv +++ libcxx/test/libcxx/transitive_includes/cxx17.csv @@ -319,7 +319,7 @@ filesystem type_traits filesystem version format array -format charconv +format cmath format cstddef format cstdint format cstdlib Index: libcxx/test/libcxx/transitive_includes/cxx14.csv =================================================================== --- libcxx/test/libcxx/transitive_includes/cxx14.csv +++ libcxx/test/libcxx/transitive_includes/cxx14.csv @@ -319,7 +319,7 @@ filesystem type_traits filesystem version format array -format charconv +format cmath format cstddef format cstdint format cstdlib Index: libcxx/test/libcxx/transitive_includes/cxx11.csv =================================================================== --- libcxx/test/libcxx/transitive_includes/cxx11.csv +++ libcxx/test/libcxx/transitive_includes/cxx11.csv @@ -317,7 +317,7 @@ filesystem type_traits filesystem version format array -format charconv +format cmath format cstddef format cstdint format cstdlib Index: libcxx/test/libcxx/transitive_includes/cxx03.csv =================================================================== --- libcxx/test/libcxx/transitive_includes/cxx03.csv +++ libcxx/test/libcxx/transitive_includes/cxx03.csv @@ -317,7 +317,7 @@ filesystem type_traits filesystem version format array -format charconv +format cmath format cstddef format cstdint format cstdlib Index: libcxx/include/chrono =================================================================== --- libcxx/include/chrono +++ libcxx/include/chrono @@ -797,4 +797,8 @@ # include <cstring> #endif +#if !defined(_LIBCPP_REMOVE_TRANSITIVE_INCLUDES) && _LIBCPP_STD_VER == 20 +# include <charconv> +#endif + #endif // _LIBCPP_CHRONO Index: libcxx/include/__format/formatter_output.h =================================================================== --- libcxx/include/__format/formatter_output.h +++ libcxx/include/__format/formatter_output.h @@ -14,9 +14,12 @@ #include <__algorithm/ranges_fill_n.h> #include <__algorithm/ranges_for_each.h> #include <__algorithm/ranges_transform.h> +#include <__charconv/to_chars_integral.h> +#include <__charconv/to_chars_result.h> #include <__chrono/statically_widen.h> #include <__concepts/same_as.h> #include <__config> +#include <__errc> #include <__format/buffer.h> #include <__format/concepts.h> #include <__format/escaped_output_table.h> @@ -29,7 +32,6 @@ #include <__type_traits/make_unsigned.h> #include <__utility/move.h> #include <__utility/unreachable.h> -#include <charconv> #include <cstddef> #include <string> #include <string_view> Index: libcxx/include/__format/formatter_integral.h =================================================================== --- libcxx/include/__format/formatter_integral.h +++ libcxx/include/__format/formatter_integral.h @@ -10,9 +10,13 @@ #ifndef _LIBCPP___FORMAT_FORMATTER_INTEGRAL_H #define _LIBCPP___FORMAT_FORMATTER_INTEGRAL_H +#include <__charconv/to_chars_integral.h> +#include <__charconv/to_chars_result.h> +#include <__charconv/traits.h> #include <__concepts/arithmetic.h> #include <__concepts/same_as.h> #include <__config> +#include <__errc> #include <__format/concepts.h> #include <__format/format_error.h> #include <__format/formatter_output.h> @@ -20,7 +24,6 @@ #include <__type_traits/make_unsigned.h> #include <__utility/unreachable.h> #include <array> -#include <charconv> #include <limits> #include <string> #include <string_view> Index: libcxx/include/__format/formatter_floating_point.h =================================================================== --- libcxx/include/__format/formatter_floating_point.h +++ libcxx/include/__format/formatter_floating_point.h @@ -16,9 +16,13 @@ #include <__algorithm/min.h> #include <__algorithm/rotate.h> #include <__algorithm/transform.h> +#include <__charconv/chars_format.h> +#include <__charconv/to_chars_floating_point.h> +#include <__charconv/to_chars_result.h> #include <__concepts/arithmetic.h> #include <__concepts/same_as.h> #include <__config> +#include <__errc> #include <__format/concepts.h> #include <__format/format_parse_context.h> #include <__format/formatter.h> @@ -29,7 +33,8 @@ #include <__type_traits/conditional.h> #include <__utility/move.h> #include <__utility/unreachable.h> -#include <charconv> +#include <cmath> +#include <cstddef> #ifndef _LIBCPP_HAS_NO_LOCALIZATION # include <locale>
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
