[PATCH] D147326: [clang][dataflow][NFC] Share code between Environment ctor and pushCallInternal().

mboehme updated this revision to Diff 510413. mboehme marked 2 inline comments as done. mboehme added a comment. Rename function again to be consistent with `getFieldsAndGlobalVars()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147326/new/ https

[PATCH] D147326: [clang][dataflow][NFC] Share code between Environment ctor and pushCallInternal().

mboehme added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:465 + /// referenced in `FuncDecl`. `FuncDecl` must have a body. + void initVars(const FunctionDecl *FuncDecl); ymandel wrote: > xazax.hun wrote: > > I

[PATCH] D147302: [clang][dataflow] Add `create()` methods to `Environment` and `DataflowAnalysisContext`.

mboehme updated this revision to Diff 510416. mboehme added a comment. Changes in response to review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147302/new/ https://reviews.llvm.org/D147302 Files: clang/include/clang/Analysis/FlowSens

[PATCH] D147302: [clang][dataflow] Add `create()` methods to `Environment` and `DataflowAnalysisContext`.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:100 +// used `StorageLocation` subclasses and make them use a `BumpPtrAllocator`. +Locs.push_back(std::make_unique(s

[PATCH] D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape-coro.cpp:115 + +// CHECK-MESSAGES add tests with c_yield and co_await Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. Hi @haowei, thanks for the report and revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146987/new/ https://reviews.llvm.org/D146987 ___ cfe-commits mailing list cfe-commits@

[PATCH] D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

ChuanqiXu added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape-coro.cpp:75-79 + // CHECK-MESSAGES-NOT: :[[@LINE-1]]:11: warning: an exception may be thrown in function 'b_ShouldNotDiag' which should not throw exceptions + if

[PATCH] D146941: [clangd] Use all inputs to SystemIncludeExtractor in cache key

nridge added inline comments. Comment at: clang-tools-extra/clangd/SystemIncludeExtractor.cpp:80 + std::string Driver; + std::string Directory; + // Whether certain includes should be part of query. It looks like the purpose of including `Directory` in the key

[clang] ce0ab9d - [clang][dataflow][NFC] Share code between Environment ctor and pushCallInternal().

Author: Martin Braenne Date: 2023-04-03T08:25:10Z New Revision: ce0ab9d11cec0a81c4e48645a23fa8eddea926ab URL: https://github.com/llvm/llvm-project/commit/ce0ab9d11cec0a81c4e48645a23fa8eddea926ab DIFF: https://github.com/llvm/llvm-project/commit/ce0ab9d11cec0a81c4e48645a23fa8eddea926ab.diff LOG

[PATCH] D147326: [clang][dataflow][NFC] Share code between Environment ctor and pushCallInternal().

This revision was automatically updated to reflect the committed changes. Closed by commit rGce0ab9d11cec: [clang][dataflow][NFC] Share code between Environment ctor and pushCallInternal… (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D145868: [clang][ASTImporter] Fix import of typedef with unnamed structures

balazske added a comment. ping This is a solution for a problem at least until a better fix is found. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145868/new/ https://reviews.llvm.org/D145868 ___ cfe-co

[PATCH] D146987: [Assignment Tracking] Enable by default

uabelho added a comment. We've also seen crashes with this patch, e.g. clang -cc1 -triple x86_64-unknown-linux -emit-obj -debug-info-kind=constructor -O1 bbi-80938.c crashes with clang: ../include/llvm/ADT/IntervalMap.h:1187: bool llvm::IntervalMap >::overlaps(KeyT, KeyT) const [KeyT =

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

hans added a comment. I'm not familiar with this code. I suppose the question is whether it's reasonable for this code to expect that the source locations are always valid or not? Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:605 +// If the either location is inv

[PATCH] D146234: [clang] Fix crash when handling nested immediate invocations

Fznamznon added a comment. @aaron.ballman , @cor3ntin are you ok with the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146234/new/ https://reviews.llvm.org/D146234 ___ cfe-commits mailing list cf

[PATCH] D147422: [clang-format] NFC Document the other space before colon option

owenpan added a comment. Should we extend `SpacesInContainerLiterals` so that it controls JSON colons too? If yes, then we don't need `SpaceBeforeJsonColon`. Otherwise, IMO we should leave the doc alone. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D147422: [clang-format] NFC Document the other space before colon option

MyDeveloperDay added a comment. In D147422#4240021 , @owenpan wrote: > Should we extend `SpacesInContainerLiterals` so that it controls JSON colons > too? If yes, then we don't need `SpaceBeforeJsonColon`. Otherwise, IMO we > should leave the doc alone.

[PATCH] D147422: [clang-format] NFC Document the other space before colon option

MyDeveloperDay added a comment. In D147422#4239701 , @Herald wrote: > NOTE: Clang-Format Team Automated Review Comment > > It looks like your clang-format review does not contain any unit tests, > please try to ensure all code changes have a unit test (u

[clang] 968b417 - [clang][Interp] Fix derived-to-base casts for >1 levels

Author: Timm Bäder Date: 2023-04-03T11:35:55+02:00 New Revision: 968b4172f6a9878e56dc911f3f9df089d2a9134f URL: https://github.com/llvm/llvm-project/commit/968b4172f6a9878e56dc911f3f9df089d2a9134f DIFF: https://github.com/llvm/llvm-project/commit/968b4172f6a9878e56dc911f3f9df089d2a9134f.diff LO

[PATCH] D143480: [clang][Interp] Fix derived-to-base casts for >1 levels

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG968b4172f6a9: [clang][Interp] Fix derived-to-base casts for >1 levels (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D14

[PATCH] D146757: [Driver] Enable defining multilib print options independently of flags

michaelplatings added a comment. @phosek ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146757/new/ https://reviews.llvm.org/D146757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta updated this revision to Diff 510442. tkuchta added a comment. Applied the latest review comments for strsep CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141389/new/ https://reviews.llvm.org/D141389 Files: compiler-rt/lib/dfsan/dfsan_custom.cpp compiler-rt/lib/dfsan/done_a

[PATCH] D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance

This revision was automatically updated to reflect the committed changes. Closed by commit rGedd6a33984ee: [clang-tidy] support unscoped enumerations in readability-static-accessed… (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang-tools-extra] edd6a33 - [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance

Author: Congcong Cai Date: 2023-04-03T12:58:35+02:00 New Revision: edd6a33984eeb57bd4e8d3459878cc7a66825389 URL: https://github.com/llvm/llvm-project/commit/edd6a33984eeb57bd4e8d3459878cc7a66825389 DIFF: https://github.com/llvm/llvm-project/commit/edd6a33984eeb57bd4e8d3459878cc7a66825389.diff

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

hokein added a comment. Thanks for the contribution! Comment at: clang-tools-extra/clangd/Config.h:151 +// Limit the length of type names in inlay hints. +size_t TypeNameLimit = 32; } InlayHints; I would extend it a bit more -- 0 means no limit. Ca

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. Thank you @uabelho for the reproducer- I've added a fix in D147435 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146987/new/ https://reviews.llvm.org/D146987 _

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis marked 2 inline comments as not done. TIFitis added a comment. Polite request for reviews. Thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 ___

[clang] db3dcdc - [clang][Interp] Fix initializing base class members

Author: Timm Bäder Date: 2023-04-03T13:51:04+02:00 New Revision: db3dcdc08ce06e301cdcc75e2849315a47d7a28d URL: https://github.com/llvm/llvm-project/commit/db3dcdc08ce06e301cdcc75e2849315a47d7a28d DIFF: https://github.com/llvm/llvm-project/commit/db3dcdc08ce06e301cdcc75e2849315a47d7a28d.diff LO

[PATCH] D143466: [clang][Interp] Fix initializing base class members

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdb3dcdc08ce0: [clang][Interp] Fix initializing base class members (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D147414: [python] Expose clang_Location_isInSystemHeader

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need someone to land this on your behalf? If so, please let me know what name and email address you would like for patch attribution. In D147414#4239453

[PATCH] D147369: [clang][Interp] Support empty initlist initializers for complex types

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147369/new/ https://reviews.llvm.org/D147369 _

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:443 + // No match for this provider in the includes list. + return {}; +} `return std::nullopt` Comment at: clang-tools-extra/clangd/IncludeCleaner.h:87 +

[PATCH] D147307: [clang] Consider artificial always inline builtin as inline builtins

aaron.ballman added a reviewer: rjmccall. aaron.ballman added a comment. I don't feel particularly qualified to review this, but my reading of the GCC docs suggest that this attribute should only impact debug information and nothing else about codegen. However, `FunctionDecl::isInlineBuiltinDec

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I'm fine with this approach. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141497/new/ https://reviews.llvm.org/D141497 ___

[clang] fd86789 - [clang-format] Don't allow variable decls to have trailing return arrows

Author: Emilia Dreamer Date: 2023-04-03T15:54:21+03:00 New Revision: fd86789962964a98157e8159c3d95cdc241942e3 URL: https://github.com/llvm/llvm-project/commit/fd86789962964a98157e8159c3d95cdc241942e3 DIFF: https://github.com/llvm/llvm-project/commit/fd86789962964a98157e8159c3d95cdc241942e3.diff

[PATCH] D147377: [clang-format] Don't allow variable decls to have trailing return arrows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd8678996296: [clang-format] Don't allow variable decls to have trailing return arrows (authored by rymiel). Repository: rG LLVM Github Monorepo

[PATCH] D146376: Update static_assert message for redundant cases

aaron.ballman added a comment. The changes need a release note and please do add more text to the `expected-error` comments so we can see what the diagnostic actually produces (instead of just `{{failed}}`). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 510467. VincentWu added a comment. Herald added subscribers: jobnoorman, jdoerfert. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Files: clang/test/Prepr

[PATCH] D147144: [include-cleaner] Report references to operator calls as implicit

kadircet updated this revision to Diff 510474. kadircet marked an inline comment as done. kadircet added a comment. - Update to treat operator calls to members as "explicit" fater offline discussions. This better aligns with what we do for regular member exprs. Repository: rG LLVM Github Mono

[PATCH] D147144: [include-cleaner] Report references to operator calls as implicit

hokein accepted this revision. hokein added a comment. still LG. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147144/new/ https://reviews.llvm.org/D147144 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D146234: [clang] Fix crash when handling nested immediate invocations

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146234/new/ https://reviews.llvm.org/D146234 ___ cfe-commits mailing list cfe-comm

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 510484. VitaNuo marked 5 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-too

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/IncludeCleaner.h:87 +std::optional +firstMatchedProvider(const include_cleaner::Includes &Includes, + llvm::ArrayRef Providers); kadircet wrote: > can you

[clang] 58cf70b - [clang][Interp] Fix diagnostics for calling non-constexpr constructors

Author: Timm Bäder Date: 2023-04-03T15:42:08+02:00 New Revision: 58cf70b2cdc17a905f7db2ec5a6f9d497f9bd133 URL: https://github.com/llvm/llvm-project/commit/58cf70b2cdc17a905f7db2ec5a6f9d497f9bd133 DIFF: https://github.com/llvm/llvm-project/commit/58cf70b2cdc17a905f7db2ec5a6f9d497f9bd133.diff LO

[PATCH] D145841: [clang][Interp] Fix diagnostics for calling non-constexpr constructors

This revision was automatically updated to reflect the committed changes. Closed by commit rG58cf70b2cdc1: [clang][Interp] Fix diagnostics for calling non-constexpr constructors (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D145841?vs=504406&id=510485#toc Repository:

[PATCH] D147302: [clang][dataflow] Add `create()` methods to `Environment` and `DataflowAnalysisContext`.

ymandel accepted this revision. ymandel added a comment. Thanks! Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:215 /// Creates an atomic boolean value. - AtomicBoolValue &createAtomicBoolValue() { -return takeOwnership(std::make_uniqu

[PATCH] D147144: [include-cleaner] Report references to operator calls as implicit

This revision was automatically updated to reflect the committed changes. Closed by commit rG26ff268b80c5: [include-cleaner] Report references to operator calls as implicit (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147144/

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

jhuber6 added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146973/new/ https://reviews.llvm.org/D146973 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang-tools-extra] 26ff268 - [include-cleaner] Report references to operator calls as implicit

Author: Kadir Cetinkaya Date: 2023-04-03T15:49:28+02:00 New Revision: 26ff268b80c589fd9f71c1c214af77cd972642ca URL: https://github.com/llvm/llvm-project/commit/26ff268b80c589fd9f71c1c214af77cd972642ca DIFF: https://github.com/llvm/llvm-project/commit/26ff268b80c589fd9f71c1c214af77cd972642ca.dif

[clang] 056042d - [clang][Interp] Fix initializing fields after base class members

Author: Timm Bäder Date: 2023-04-03T15:55:11+02:00 New Revision: 056042d21b72a86653f88719c0b54b07e35d2144 URL: https://github.com/llvm/llvm-project/commit/056042d21b72a86653f88719c0b54b07e35d2144 DIFF: https://github.com/llvm/llvm-project/commit/056042d21b72a86653f88719c0b54b07e35d2144.diff LO

[PATCH] D145860: [clang][Interp] Fix initializing fields after base class members

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG056042d21b72: [clang][Interp] Fix initializing fields after base class members (authored by tbaeder). Changed prior to commit: https://reviews.llv

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

aaron.ballman added a comment. Hmmm, is this effectively `std::has_unique_object_representations` (ensuring that all bits of the object representation contribute to the value)? Comment at: clang/lib/AST/Type.cpp:2610 + + if (const auto *RecordDecl = CanonicalType->getAsCXXRec

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

steakhal added a comment. In D144269#4237539 , @dkrupp wrote: > This is a totally rewritten version of the patch which solely relies on the > existing "interestingness" utility to track back the taint propagation. (And > does not introduce a new FlowI

[PATCH] D146595: [clang] Add "transparent_stepping" attribute

aaron.ballman added a comment. In D146595#4237228 , @aprantl wrote: > I think `debug_trampoline` both captures the semantics and makes it clear > that this is related to debugging. I'd be fine with this, or `transparent_debug_stepping`, etc. Just someth

[clang-tools-extra] f323e7f - [include-cleaner] Treat member operator calls as implicit

Author: Kadir Cetinkaya Date: 2023-04-03T16:27:23+02:00 New Revision: f323e7f3ca760be786d2584c926edade34c3fbde URL: https://github.com/llvm/llvm-project/commit/f323e7f3ca760be786d2584c926edade34c3fbde DIFF: https://github.com/llvm/llvm-project/commit/f323e7f3ca760be786d2584c926edade34c3fbde.dif

[clang] 8c8b4d2 - [Clang] Update test checks (NFC)

Author: Nikita Popov Date: 2023-04-03T16:33:34+02:00 New Revision: 8c8b4d24f019e51900f15e008b52a05cf1e66381 URL: https://github.com/llvm/llvm-project/commit/8c8b4d24f019e51900f15e008b52a05cf1e66381 DIFF: https://github.com/llvm/llvm-project/commit/8c8b4d24f019e51900f15e008b52a05cf1e66381.diff

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

aaron.ballman added reviewers: erichkeane, rjmccall, efriedma. aaron.ballman added a comment. Adding Erich as attributes code owner and John/Eli as ABI code owners. Comment at: clang/lib/Sema/SemaType.cpp:8265 + // The attribute vector size must match -mrvv-vector-bits. + //

[clang] b15a946 - [clang][Interp][NFC] Refactor VisitDeclRefExpr

Author: Timm Bäder Date: 2023-04-03T16:42:25+02:00 New Revision: b15a946b9f59f91518ae5e2cb6125592d9c1bf3c URL: https://github.com/llvm/llvm-project/commit/b15a946b9f59f91518ae5e2cb6125592d9c1bf3c DIFF: https://github.com/llvm/llvm-project/commit/b15a946b9f59f91518ae5e2cb6125592d9c1bf3c.diff LO

[PATCH] D147302: [clang][dataflow] Add `create()` methods to `Environment` and `DataflowAnalysisContext`.

mboehme updated this revision to Diff 510496. mboehme marked an inline comment as done. mboehme added a comment. Changes in response to review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147302/new/ https://reviews.llvm.org/D147302 File

[PATCH] D147302: [clang][dataflow] Add `create()` methods to `Environment` and `DataflowAnalysisContext`.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:215 /// Creates an atomic boolean value. - AtomicBoolValue &createAtomicBoolValue() { -return takeOwnership(std::make

[clang] 192c2c5 - [clang][Interp] Ignore StaticAssertDecls

Author: Timm Bäder Date: 2023-04-03T16:56:58+02:00 New Revision: 192c2c5c89477e28d0129f37a7d262112585b353 URL: https://github.com/llvm/llvm-project/commit/192c2c5c89477e28d0129f37a7d262112585b353 DIFF: https://github.com/llvm/llvm-project/commit/192c2c5c89477e28d0129f37a7d262112585b353.diff LO

[PATCH] D144272: [clang][Interp] Ignore StaticAssertDecls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG192c2c5c8947: [clang][Interp] Ignore StaticAssertDecls (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.org/D145803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] 82facc2 - [clang][Interp] Add missing static_assert message

Author: Timm Bäder Date: 2023-04-03T17:12:05+02:00 New Revision: 82facc2b2462441a83ca35d2d6ef1ab28244a1b3 URL: https://github.com/llvm/llvm-project/commit/82facc2b2462441a83ca35d2d6ef1ab28244a1b3 DIFF: https://github.com/llvm/llvm-project/commit/82facc2b2462441a83ca35d2d6ef1ab28244a1b3.diff LO

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Ping for review. Specifically, the option is renamed to `-mxcoff-roptr` and `-mno-xcoff-roptr` to indicate that this option only affects the `XCOFF` binary format, so it is expected to not affect `ELF` or other formats. Thanks! Repository: rG LLVM Github Monorepo

[PATCH] D147419: [clang-tidy] ignore NRVO const variables in performance-no-automatic-move.

PiotrZSL accepted this revision. PiotrZSL added a comment. Current change is correct. This check could be improved in future. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147419/new/ https://reviews.llvm.org/D147419

[PATCH] D147419: [clang-tidy] ignore NRVO const variables in performance-no-automatic-move.

PiotrZSL added a comment. Add release notes entry !. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147419/new/ https://reviews.llvm.org/D147419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape-coro.cpp:91 +const auto d_ShouldNotDiag = [](const int a, const int b) -> task { + // CHECK-MESSAGES-NOT: :[[@LINE-1]]:30: warning: an exception may be thrown in fu

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

zhangyi1357 updated this revision to Diff 510508. zhangyi1357 added a comment. Add uint32Value() for uint32_t type parsing in config file. For TypeNameLimit config, support no limit with value 0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147395/

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

zhangyi1357 marked 2 inline comments as done. zhangyi1357 added a comment. In D147395#4240227 , @hokein wrote: > Thanks for the contribution! It's really interesting for me. Thanks for your time reviewing! Comment at: clang-tools-extr

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu marked an inline comment as done. zequanwu added a comment. In D147073#4240017 , @hans wrote: > I'm not familiar with this code. I suppose the question is whether it's > reasonable for this code to expect that the source locations are always val

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu updated this revision to Diff 510514. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147073/new/ https://reviews.llvm.org/D147073 Files: clang/lib/CodeGen/CoverageMappingGen.cpp clang/test/Co

[PATCH] D147449: [include-cleaner] Only ignore builtins without a header

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Certain standard library functions (e.g. std::move) are also implemented as

[PATCH] D147349: [C2x] Implement support for empty brace initialization (WG14 N2900 and WG14 N3011)

erichkeane added a comment. So not necessary to this patch, but I suspect the non-trivially constructible types could just be solved the same way we do for zero-init of these types in fixed-size arrays, right? Its a bit more complicated, but the IR is probably just as do-able: https://godbolt.

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

zhangyi1357 updated this revision to Diff 510521. zhangyi1357 marked an inline comment as not done. zhangyi1357 added a comment. Try to fix the build problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147395/new/ https://reviews.llvm.org/D14739

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

zhangyi1357 added a comment. In D147395#4240227 , @hokein wrote: > Thanks for the contribution! It's quite interesting for me. Thanks for your time reviewing and your great advice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D147307: [clang] Consider artificial always inline builtin as inline builtins

efriedma added a comment. I'd be fine with just dropping the check for GNUInline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147307/new/ https://reviews.llvm.org/D147307 ___ cfe-commits mailing list c

[PATCH] D147419: [clang-tidy] ignore NRVO const variables in performance-no-automatic-move.

gnanabit updated this revision to Diff 510532. gnanabit added a comment. Add release notes entry. Thanks for the reviews! Happy to reword the release notes if they are unclear. @courbet or @PiotrZSL, I don't have commit access. Can you land this patch for me? Please use "Logan Gnanapragasam (gna

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:8234 + ParsedAttr &Attr, Sema &S) { + // Target must have SVE. + if (!S.Context.getTargetInfo().hasFeature("zve32x")) { I need to fix this co

[PATCH] D147411: [clang-tidy] Fix readability-static-accessed-through-instance check for anonymous structs

AMS21 updated this revision to Diff 510537. AMS21 marked 2 inline comments as done. AMS21 added a comment. Implement suggested way of checking for anonymous structs Add a new more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147411/new/ http

[PATCH] D147414: [python] Expose clang_Location_isInSystemHeader

R2RT updated this revision to Diff 510542. R2RT added a comment. Bring back Python section in release notes and document new `is_in_system_header` property. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147414/new/ https://reviews.llvm.org/D147414 Files: clang/bindings/python/clang/

[clang-tools-extra] e51f467 - [clang-tidy] ignore NRVO const variables in performance-no-automatic-move.

Author: Logan Gnanapragasam Date: 2023-04-03T17:01:59Z New Revision: e51f46705e2876fbbdb59d4f1ba43fa6ecf78611 URL: https://github.com/llvm/llvm-project/commit/e51f46705e2876fbbdb59d4f1ba43fa6ecf78611 DIFF: https://github.com/llvm/llvm-project/commit/e51f46705e2876fbbdb59d4f1ba43fa6ecf78611.diff

[PATCH] D147419: [clang-tidy] ignore NRVO const variables in performance-no-automatic-move.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe51f46705e28: [clang-tidy] ignore NRVO const variables in performance-no-automatic-move. (authored by gnanabit, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1196-1197 + // If we are compiling for a GPU target we want to override the system headers + // with ones created by the

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1196-1197 + // If we are compiling for a GPU target we want to override the system headers + // with ones created by the 'libc' project if present. + if (!Args.hasArg(options::OPT_nostdinc) &&

[PATCH] D147414: [python] Expose clang_Location_isInSystemHeader

R2RT added a comment. In D147414#4240343 , @aaron.ballman wrote: > LGTM! Do you need someone to land this on your behalf? If so, please let me > know what name and email address you would like for patch attribution. > > In D147414#4239453

[PATCH] D147411: [clang-tidy] Fix readability-static-accessed-through-instance check for anonymous structs

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147411/new/ https://reviews.llvm.org/D147411 ___

[PATCH] D147349: [C2x] Implement support for empty brace initialization (WG14 N2900 and WG14 N3011)

aaron.ballman marked 4 inline comments as done. aaron.ballman added a comment. In D147349#4240847 , @erichkeane wrote: > So not necessary to this patch, but I suspect the non-trivially constructible > types could just be solved the same way we do for ze

[PATCH] D143704: [flang] Feature list plugin

elmcdonough updated this revision to Diff 510553. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 Files: flang/examples/CMakeLists.txt flang/examples/FeatureList/CMakeLists.txt flang/examples/FeatureL

[PATCH] D147349: [C2x] Implement support for empty brace initialization (WG14 N2900 and WG14 N3011)

erichkeane added inline comments. Comment at: clang/test/C/C2x/n2900_n3011_2.c:51 + // CHECK: define {{.*}} void @test_vla + // CHECK-NEXT: entry: + // CHECK-NEXT: %[[I:.+]] = alloca i32 so 'entry' isn't really a stable name AFAIK. So this might fail in test

[clang] f263bd8 - [Clang] Implicitly include LLVM libc headers for the GPU

Author: Joseph Huber Date: 2023-04-03T12:57:21-05:00 New Revision: f263bd8f7d4c82af9672803e6d8d57f25c929d00 URL: https://github.com/llvm/llvm-project/commit/f263bd8f7d4c82af9672803e6d8d57f25c929d00 DIFF: https://github.com/llvm/llvm-project/commit/f263bd8f7d4c82af9672803e6d8d57f25c929d00.diff

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf263bd8f7d4c: [Clang] Implicitly include LLVM libc headers for the GPU (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1196-1197 + // If we are compiling for a GPU target we want to override the system headers + // with ones created by the 'libc' project if present. + if (!Args.hasArg(options::OPT_nostdinc) &&

[PATCH] D147461: [Headers] Add some intrinsic function descriptions to immintrin.h

probinson created this revision. probinson added reviewers: RKSimon, pengfei. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D147461 Files: clang/lib/Headers/immintrin.h Index: clang/lib/Headers/immintrin.h ===

[PATCH] D147461: [Headers] Add some intrinsic function descriptions to immintrin.h

probinson added a comment. FTR, I'll be working my way through a bunch of intrinsics over the next month or so, trying not to do too many at once. Mostly AVX2 but also some others. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147461/new/ https://reviews.llvm.org/D147461 _

[PATCH] D147349: [C2x] Implement support for empty brace initialization (WG14 N2900 and WG14 N3011)

aaron.ballman updated this revision to Diff 510574. aaron.ballman marked 4 inline comments as done. aaron.ballman added a comment. Update based on review feedback: - Added an assertion to codegen that a VLA with an initializer is an empty initializer - Updated the codegen tests to use better ide

[PATCH] D147383: [clang-tidy] Allow bugprone-unchecked-optional-access to handle calls to `std::forward`

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:589-591 + if (LocArg == nullptr) { +return; + } ``` if (

[clang] 5d8aaad - [C2x] Implement support for empty brace initialization (WG14 N2900 and WG14 N3011)

Author: Aaron Ballman Date: 2023-04-03T15:22:52-04:00 New Revision: 5d8aaad4452f60ba8902e921d9bed606713a8f26 URL: https://github.com/llvm/llvm-project/commit/5d8aaad4452f60ba8902e921d9bed606713a8f26 DIFF: https://github.com/llvm/llvm-project/commit/5d8aaad4452f60ba8902e921d9bed606713a8f26.diff

[PATCH] D147349: [C2x] Implement support for empty brace initialization (WG14 N2900 and WG14 N3011)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d8aaad4452f: [C2x] Implement support for empty brace initialization (WG14 N2900 and WG14… (authored by aaron.ballman). Repository: rG LLVM Github

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

rsmith added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:775-776 +static bool IsInsideImplicitFullTemplateSpecialization(const DeclContext *DC) { + auto *CTSDecl = dyn_cast_or_null( + DC->getOuterLexicalRecordContext()); + return CTSDecl && !isa(CTSDecl) &&

cfe-commits@lists.llvm.org

NoQ accepted this revision. NoQ added a comment. Looks great! LGTM except there's some dead code. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:570-573 +if (const auto *ArraySubst = +dyn_cast(Node->getSubExpr())) + if (const auto *DRE = +

  1   2   >