MyDeveloperDay added a comment. In D147422#4239701 <https://reviews.llvm.org/D147422#4239701>, @Herald wrote:
> NOTE: Clang-Format Team Automated Review Comment > > It looks like your clang-format review does not contain any unit tests, > please try to ensure all code changes have a unit test (unless this is an > `NFC` or refactoring, adding documentation etc..) > > Add you unit tests in `clang/unittests/Format` and build `ninja FormatTests` > we recommend using the `verifyFormat(xxx)` format of unit tests rather than > `EXPECT_EQ` as this will ensure you change is tolerant to random whitespace > changes (see FormatTest.cpp as an example) > > For situations where your change is altering the TokenAnnotator.cpp which can > happen if you are trying to improve the annotation phase to ensure we are > correctly identifying the type of a token, please add a token annotator test > in `TokenAnnotatorTest.cpp` Thanks for testing this automated comment ;-) , I've fixed some of the grammatical issue and made it so it won't fire if NFC is in the title. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147422/new/ https://reviews.llvm.org/D147422 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
