[PATCH] D146582: [clang] Fix wrong highlight for _Complex

1lyasm updated this revision to Diff 507254. 1lyasm added a comment. Deleted comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146582/new/ https://reviews.llvm.org/D146582 Files: clang/lib/Sema/SemaInit.cpp Index: clang/lib/Sema/SemaInit.

[PATCH] D146582: [clang] Fix wrong highlight for _Complex

tbaeder added a comment. Sorry but this is already being worked on in https://reviews.llvm.org/D146503. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146582/new/ https://reviews.llvm.org/D146582 ___ cfe-

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

tbaeder added a subscriber: aaron.ballman. tbaeder added a comment. LGTM but I'll wait for @aaron.ballman to maybe comment on the diagnostic differences in C. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146503/new/ https://reviews.llvm.org/D1465

[PATCH] D146582: [clang] Fix wrong highlight for _Complex

1lyasm added a comment. In D146582#4212300 , @tbaeder wrote: > Sorry but this is already being worked on in https://reviews.llvm.org/D146503. Ok, did not know, closing this. Thanks for mentioning. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] 558b46f - [analyzer] Fix crashing getSValFromInitListExpr for nested initlists

Author: Balazs Benics Date: 2023-03-22T08:43:09+01:00 New Revision: 558b46fde2db2215794336bbd08e411fee5240d7 URL: https://github.com/llvm/llvm-project/commit/558b46fde2db2215794336bbd08e411fee5240d7 DIFF: https://github.com/llvm/llvm-project/commit/558b46fde2db2215794336bbd08e411fee5240d7.diff

[PATCH] D146538: [analyzer] Fix crashing getSValFromInitListExpr for nested initlists

This revision was automatically updated to reflect the committed changes. Closed by commit rG558b46fde2db: [analyzer] Fix crashing getSValFromInitListExpr for nested initlists (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1465

[PATCH] D142905: [Driver] Change multilib selection algorithm

phosek added inline comments. Comment at: clang/lib/Driver/MultilibBuilder.cpp:88 +static Multilib::flags_list getPrintOptions(const Multilib::flags_list &Flags) { + // Derive print options from flags. Would it be possible to move this method directly into `M

[PATCH] D146608: [CMake] Build runtimes for riscv64-unknown-fuchsia

phosek updated this revision to Diff 507260. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146608/new/ https://reviews.llvm.org/D146608 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/caches/Fuchsia-stage2.cmake ===

[PATCH] D44745: [HWASan] Port HWASan to Linux x86-64 (clang)

Enna1 added a comment. Herald added subscribers: yaneury, supersymetrie, Chia-hungDuan, pengfei. Herald added a project: All. Hi, I'm curious about why hwasan requires PIE. Is there any documents mentioned this? Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D146538: [analyzer] Fix crashing getSValFromInitListExpr for nested initlists

steakhal added a comment. Speaking of issue tracking, I think it would be much more valuable to our users if we had a proper release notes section for CSA. Right now it is so ad-hoc. That is also true for crash fixes and backports. Maybe we should put more emphasis on that part for the next majo

[PATCH] D145579: [Flang][AMDGPU][OpenMP] Save target features in OpenMP MLIR dialect

domada updated this revision to Diff 507269. domada retitled this revision from "[WIP][Flang][AMDGPU][OpenMP] Save target features in OpenMP MLIR dialect" to "[Flang][AMDGPU][OpenMP] Save target features in OpenMP MLIR dialect". domada added a comment. Patch rebased CHANGES SINCE LAST ACTION

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 updated this revision to Diff 507272. kpdev42 added a comment. Update patch after landing D145057 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new/ https://reviews.llvm.org/D143347 Files: lldb/s

[PATCH] D146376: Update static_assert message for redundant cases

tbaeder added a comment. Since we only handle `BinaryOperator`s in the toplevel assertion expression, I think it should just be safe to never diagnose for them if it's an `BO_LOr` opcode, so you should be able to just check for that in `DiagnoseStaticAssertDetails()`. Repository: rG LLVM Gi

[PATCH] D145579: [Flang][AMDGPU][OpenMP] Save target features in OpenMP MLIR dialect

domada added a comment. D146612 presents the lowering from MLIR attributes to LLVM IR. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145579/new/ https://reviews.llvm.org/D145579 ___ cfe-commits mailing list

[PATCH] D145579: [Flang][AMDGPU][OpenMP] Save target features in OpenMP MLIR dialect

awarzynski added a comment. Really nice to see some shared code being elevated out of Clang into LLVM, thanks! I've only reviewed on the Flang driver changes. I will let the OpenMP experts to review the remaining bits. All in all looks good, I've only made some small suggestions. Thanks for w

[PATCH] D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func.

mboehme added a comment. In D146514#4209931 , @xazax.hun wrote: > This fix looks good for me for this particular problem, but I wonder whether > the solution is general enough. In case the analysis figures out that a call > would not return (e.g., the `

[PATCH] D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func.

mboehme updated this revision to Diff 507287. mboehme added a comment. Reworded comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146514/new/ https://reviews.llvm.org/D146514 Files: clang/include/clang/Analysis/FlowSensitive/ControlFlowCont

[clang] ee2cd60 - [dataflow] Log flow condition to the correct stream.

Author: Sam McCall Date: 2023-03-22T10:57:21+01:00 New Revision: ee2cd606abd98380bc71974863354a0d54ccfab3 URL: https://github.com/llvm/llvm-project/commit/ee2cd606abd98380bc71974863354a0d54ccfab3 DIFF: https://github.com/llvm/llvm-project/commit/ee2cd606abd98380bc71974863354a0d54ccfab3.diff LO

[PATCH] D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func.

mboehme updated this revision to Diff 507288. mboehme added a comment. Reworded comment again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146514/new/ https://reviews.llvm.org/D146514 Files: clang/include/clang/Analysis/FlowSensitive/ControlFl

[PATCH] D146527: [dataflow] Log flow condition to the correct stream.

This revision was automatically updated to reflect the committed changes. Closed by commit rGee2cd606abd9: [dataflow] Log flow condition to the correct stream. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146527/new/ https:

[PATCH] D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:174-175 + if (RHSVal == nullptr) { +// If the RHS isn't reachable, this implies that if we end up evaluating +// this BinaryOpe

[PATCH] D146507: [clang][dataflow][NFC] Eliminate StmtToEnvMap interface.

mboehme added a comment. After some offline discussion with reviewers, we've come to the conclusion that `AnalysisContext` isn't a sufficiently clear abstraction to warrant putting it in a header. For the time being, I'll therefore pursue the less ambitious approach of simply eliminating the `

[PATCH] D146507: [clang][dataflow][NFC] Eliminate StmtToEnvMap interface.

mboehme updated this revision to Diff 507297. mboehme added a comment. Pursue a less ambitious approach, as described in the previous comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146507/new/ https://reviews.llvm.org/D146507 Files: clan

[PATCH] D146507: [clang][dataflow][NFC] Eliminate StmtToEnvMap interface.

mboehme added a comment. @gribozavr2 @xazax.hun Just wanted to confirm that you still regard this as ready to land now that I've changed the patch as we discussed offline? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146507/new/ https://reviews.l

[PATCH] D146401: [clang-format] Don't squash Verilog escaped identifiers

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTestVerilog.cpp:897 } +} // namespace +} // namespace test is this correct? do you have an anonymous namespace? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

MarcoFalke updated this revision to Diff 507304. MarcoFalke added a comment. NFC CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146288/new/ https://reviews.llvm.org/D146288 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp clang-tools-extra/docs/ReleaseNotes.rst c

[PATCH] D146247: [clang-format] Support TypeScript satisfies operator

MyDeveloperDay added a comment. 1. your diff is messed up 2. you have to get an accept before anyone will commit for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146247/new/ https://reviews.llvm.org/D146247 __

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

MarcoFalke marked 2 inline comments as done. MarcoFalke added a comment. Minor NFC, I plan to land this tomorrow or Friday CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146288/new/ https://reviews.llvm.org/D146288 ___ cfe-commits mailing list

[PATCH] D146247: [clang-format] Support TypeScript satisfies operator

MyDeveloperDay added a comment. Can you add a github issue and reference it here Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:1445 + EXPECT_TOKEN(Tokens[3], tok::identifier, TT_Unknown); + EXPECT_TOKEN(Tokens[4], tok::identifier, TT_StartOfName); + EXPECT_TOKEN(

[PATCH] D145813: [clang-format] Respect Cpp11BraceListStyle when aligning array of structures

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:20273 + Style.ColumnLimit = 20; + EXPECT_EQ( + "demo = std::array<\n" hch12907 wrote: > MyDeveloperDay wrote: > > any reason you didn't use verifyFormat here? > No part

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs and fields

JiruiWu marked 2 inline comments as done. JiruiWu added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5811 +// For alignment adjusted HFAs, cap the argument alignment to 16, otherwise +// set it to 8 according to the AAPCS64 document. unsigned Align =

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

mhalk added a comment. In D145591#4182360 , @jhuber6 wrote: > I'm not a fan of the same warning being copied in 24 places. Why do we set > `LangOpts.IsOpenMP` on the GPU compilation side, couldn't we just filter out > the `-fopenmp` or whatever it is fo

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

tblah updated this revision to Diff 507321. tblah added a comment. Thanks for the suggestion - Added a test to check that hlfir is not output without the flag - clang-formatted CLOptions.inc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146278/new/

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo updated this revision to Diff 507326. VitaNuo marked 10 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146244/new/ https://reviews.llvm.org/D146244 Files: clang-to

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/Hover.cpp:1158 + const SourceManager &SM = AST.getSourceManager(); + std::set UsedSymbolNames; + include_cleaner::walkUsed( hokein wrote: > just want to check the intentio

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

aaron.ballman added a comment. Thanks for this! One thing that's missing is test coverage for the highlight itself, as that was what the original issue was about. You should add a test that uses `-fcaret-diagnostics-max-lines` and `FileCheck` so that you can test that the caret shows up where

[PATCH] D146507: [clang][dataflow][NFC] Eliminate StmtToEnvMap interface.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Transfer.h:35 + /// The result is guaranteed never to be null. + virtual const Environment *getEnvironment(const Stmt &S) const { +auto BlockIt = CFCt

[PATCH] D144115: [clang] Extend pragma dump to support expressions

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:15-17 #include "clang/Basic/TargetInfo.h" +#include "clang/Lex/LexDiagnostic.h" #include "clang/Lex/Preprocessor.h" Endill wrote: > aaron.ballman wrote: > > > I'm using `warn_prag

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Ping for review/comments. Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: flang/test/HLFIR/flang-experimental-hlfir-flag.f90:19 +! CHECK-NEXT: } +! NO-HLFIR-NOT: hlfir. [ultra nit] I would separat

[PATCH] D146513: Add missing nearbyintf16 builtin functions

aaron.ballman added a subscriber: cfe-commits. aaron.ballman added a comment. Please also add a release note and add documentation for the builtin. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146513/new/ https://reviews.llvm.org/D146513 ___

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

aaron.ballman added reviewers: rjmccall, serge-sans-paille. aaron.ballman added a comment. > Where do you suggest I add the documentation? Somewhere around https://clang.llvm.org/docs/LanguageExtensions.html#extensions-to-specify-floating-point-flags where we document `clang fp eval_method`.

[PATCH] D146557: [MLIR][OpenMP] Added OMPIRBuilder support for use_device_ptr clause

TIFitis updated this revision to Diff 507337. TIFitis added a comment. Removed use_dev_ptr clause related code. This patch only refactors the map clause prcoessing now. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1465

[PATCH] D145579: [Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada updated this revision to Diff 507333. domada retitled this revision from "[Flang][AMDGPU][OpenMP] Save target features in OpenMP MLIR dialect" to "[Flang][AMDGPU] Add support for AMDGPU to Flang driver". domada edited the summary of this revision. domada added a comment. Applied remarks.

[PATCH] D146507: [clang][dataflow][NFC] Eliminate StmtToEnvMap interface.

ymandel accepted this revision. ymandel added a comment. thanks! Comment at: clang/include/clang/Analysis/FlowSensitive/Transfer.h:36-40 +auto BlockIt = CFCtx.getStmtToBlock().find(&ignoreCFGOmittedNodes(S)); +assert(BlockIt != CFCtx.getStmtToBlock().end()); +const

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall updated this revision to Diff 507339. sammccall added a comment. Use a process-shared counter for HTML output filenames to avoid clobbering. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146591/new/ https://reviews.llvm.org/D146591 Files

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. @alexander-shaposhnikov : Are you working on @rsmith 's suggestion? I finally have time to look into it, but dont want to repeat effort if you're already 1/2 way into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D145579: [Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada marked an inline comment as done. domada added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:93 +std::string CodeGenAction::getAllTargetFeatures() { + std::string allFeaturesStr; awarzynski wrote: > This method could be simplified

[clang] acf6a32 - [flang] add -flang-experimental-hlfir flag to flang-new

Author: Tom Eccles Date: 2023-03-22T13:36:54Z New Revision: acf6a3224955779724a35a383d63c48af2163171 URL: https://github.com/llvm/llvm-project/commit/acf6a3224955779724a35a383d63c48af2163171 DIFF: https://github.com/llvm/llvm-project/commit/acf6a3224955779724a35a383d63c48af2163171.diff LOG: [f

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGacf6a3224955: [flang] add -flang-experimental-hlfir flag to flang-new (authored by tblah). Changed prior to commit: https://reviews.llvm.org/D1462

[PATCH] D146530: [clang][diagnostics]Removed "sorry" from all the required files

aaron.ballman added a subscriber: AryanGodara. aaron.ballman added a comment. This appears to be the same efforts that have been going on in https://reviews.llvm.org/D146041. Can you coordinate with @AryanGodara so that there's only one patch for this? Repository: rG LLVM Github Monorepo CH

[PATCH] D145579: [Flang][AMDGPU] Add support for AMDGPU to Flang driver

awarzynski added a comment. A few more comments, but mostly nits. Btw, is this patch sufficient to generate code for AMDGPU? Or, put differently, what's the level of support atm? Comment at: clang/lib/Driver/ToolChains/Flang.cpp:107 break; + case llvm::Triple::r600: + c

[clang] 893ce57 - docs: add some documentation on Windows SDK search

Author: Saleem Abdulrasool Date: 2023-03-22T09:46:36-04:00 New Revision: 893ce5759fe2e450dc637d4c76e779f883535882 URL: https://github.com/llvm/llvm-project/commit/893ce5759fe2e450dc637d4c76e779f883535882 DIFF: https://github.com/llvm/llvm-project/commit/893ce5759fe2e450dc637d4c76e779f883535882.

[PATCH] D146165: docs: add some documentation on Windows SDK search

This revision was automatically updated to reflect the committed changes. Closed by commit rG893ce5759fe2: docs: add some documentation on Windows SDK search (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D146165?vs=506978&id=507346#toc Repository: rG LLVM Github M

[PATCH] D146530: [clang][diagnostics]Removed "sorry" from all the required files

ipriyanshi1708 added a comment. In D146530#4213045 , @aaron.ballman wrote: > This appears to be the same efforts that have been going on in > https://reviews.llvm.org/D146041. Can you coordinate with @AryanGodara so > that there's only one patch for th

[PATCH] D146530: [clang][diagnostics]Removed "sorry" from all the required files

aaron.ballman added a comment. In D146530#4213076 , @ipriyanshi1708 wrote: > In D146530#4213045 , @aaron.ballman > wrote: > >> This appears to be the same efforts that have been going on in >> https://reviews.l

[PATCH] D146604: [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

tahonermann added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:5890-5892 + TargetOpts.EABIVersion = llvm::EABI::Default; + // Initialize CodeObjectVersion with default i.e., 4 + TargetOpts.CodeObjectVersion = TargetOptions::CodeObjectVersionKind::COV_4; -

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 507360. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaType.cpp clang/test/Sema/Inputs/m

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

yaxunl added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8635 + "HIP does not support OpenMP target directives; directive has been ignored">, + InGroup; + mhalk wrote: > >>! In D145591#4182945, @jdoerfert wrote: > > I would emi

[PATCH] D146625: [dataflow] handle missing case in value debug strings

sammccall created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall published this revision for review. sammccall added a reviewer: gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rep

[PATCH] D146417: [clangd] Fix AddUsing in the face of typo-correction

kadircet closed this revision. kadircet added a comment. relanded in 35c2aac6e3957c2e82bf92269039fa02bab0e1d9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146417/new/ https://r

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

skatrak updated this revision to Diff 507365. skatrak marked 6 inline comments as done. skatrak added a comment. Changes to tests and path manipulation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146075/new/ https://reviews.llvm.org/D146075 File

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

skatrak added a comment. Thanks again for helping improving this patch. I made most of the changes requested, and tried to clarify a bit better the approach followed for this implementation, to see if it is acceptable or if some more fundamental changes have to be done. Comm

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. @erichkeane - yes, I'm working on it, I hope to have a new version ~soon (within a few days). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 _

[PATCH] D146507: [clang][dataflow][NFC] Eliminate StmtToEnvMap interface.

xazax.hun accepted this revision. xazax.hun added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146507/new/ https://reviews.llvm.org/D146507 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. In D146178#4213235 , @alexander-shaposhnikov wrote: > @erichkeane - yes, I'm working on it, I hope to have a new version ~soon > (within a few days). Ok, thanks for the update then! I'll do just enough looking into it to be

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:728 bool SkipForSpecialization = false) { MultiLevelTemplateArgumentList MLTAL = S.getTemplateInstantiationArgs( ND, /*Final=*/false, /*Innermost=*/nullptr

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

usaxena95 added a comment. > starting a line with an opening paren is pretty weird!) I do not think this is weird. On the contrary, this is more readable to me and separates the requires clause from the parameters list. For example this one looks so much better: // trunk. template void

[PATCH] D144569: [Clang][OpenMP] Fix accessing of aligned arrays in offloaded target regions

doru1004 closed this revision. doru1004 added a comment. Commit: 65a0d669b4625c34775436a6d3643d15bbc2465a Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144569/new/ https://revie

[PATCH] D146634: [clang][USR] Prevent crashes when parameter lists have nulls

kadircet created this revision. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Similar to D146426 Repository: rG LLVM Github

[PATCH] D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func.

xazax.hun added a comment. In D146514#4212528 , @mboehme wrote: > No, I think this is a different case. Sorry, I might have been unclear. I am 100% agree that these are different cases. I was wondering whether we can/should have a single code path suppo

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

xazax.hun added a comment. While I am OK with this approach, I wonder if it would be too much work to split the HTML generation and emitting data up. E.g., the logger could emit YAML or JSON that could be parsed by a python script to create the HTML (or the HTML itself could use JS to parse it

[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:186 + Logger &logger() const { +return DACtx->getOptions().Log ? *DACtx->getOptions().Log : Logger::null(); + } If we already have a `NullLogger`,

[PATCH] D146530: [clang][diagnostics]Removed "sorry" from all the required files

ipriyanshi1708 added a comment. In D146530#4213078 , @aaron.ballman wrote: > In D146530#4213076 , > @ipriyanshi1708 wrote: > >> In D146530#4213045 , >> @aaron.ballman w

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

ipriyanshi1708 added a comment. Hi @AryanGodara , I am an Outreachy applicant. I was also working on this issue and also created a patch for this issue i.e., https://reviews.llvm.org/D146530 . Can we collaborate to solve this issue so that only one patch will be there for a issue as told by @aa

[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Logger.cpp:17 +Logger &Logger::null() { + struct NullLogger : Logger {}; + static auto *Instance = new NullLogger(); Adding `final`? Just in case it can help with devirtualization.

[PATCH] D146595: [clang] Add clang trampoline attribute

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. So this attribute will lower into a `DW_AT_trampoline("target_func_name")` attribute on the `DW_TAG_subprogram` of the function definition? The debug info parts LGTM. It would be nice to hea

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

rjmccall added a comment. The user isn't modifying the `float_t` type definition, they're using it. I think the diagnostic should say something like `cannot use type 'float_t' within '#pragma clang fp eval_method'; type is set according to the default eval method for the translation unit`. Is

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

gulfem added a comment. We started seeing a test failure in `avr-ld.c`. /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/avr-ld.c:48:11: error: // LINKP: {{".*ld.*"}} {{.*}} "--defsym=__DATA_REGION_ORIGIN__=0x800100" "-plugin" {{.*}} "-plugin-opt=mcpu=atmega328" ^ :1:1: note:

[PATCH] D146338: [MSVC compatibility][dllimport/dllexport][PS] Allow dllexport/dllimport for classes with UniqueExternalLinkage

wolfgangp added a comment. In D146338#4206222 , @hans wrote: >> In D145271 it was suggested that we drop >> the attribute in such contexts, and this is effectively what happens. The >> compiler does not produce any exp

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

mhalk updated this revision to Diff 507409. mhalk added a comment. Patch rework, implementing the mentioned changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145591/new/ https://reviews.llvm.org/D145591 Files: clang/include/clang/Basic/Diag

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall added a comment. In D146591#4213319 , @xazax.hun wrote: > While I am OK with this approach, I wonder if it would be too much work to > split the HTML generation and emitting data up. E.g., the logger could emit > YAML or JSON that could be par

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber updated this revision to Diff 507413. Krishna-13-cyber added a comment. Have worked on the top level with Boolean literals unlike the previous diffs.I have updated the test case as well with this new upcoming change. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D146155: [clang][NFC] Fix location of 2>&1 in a few -print tests

ldionne added a reviewer: aaron.ballman. ldionne added a comment. Gentle ping, this was likely a copy-paste error. Adding Aaron in case he has time to take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146155/new/ https://reviews.llvm.org/

[PATCH] D146376: Update static_assert message for redundant cases

cjdb added inline comments. Comment at: clang/test/SemaCXX/static-assert.cpp:261-265 static_assert(invert(true) == invert(false), ""); // expected-error {{failed}} \ -// expected-note {{evaluates to 'false == true'}} /

[PATCH] D146155: [clang][NFC] Fix location of 2>&1 in a few -print tests

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146155/new/ https://reviews.llvm.org/D146155 ___

[PATCH] D146644: [documentation]Fixed Random Typos

ipriyanshi1708 created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. ipriyanshi1708 added reviewers: samtebbs, aaron.ballman. ipriyanshi1708 published this revision for review. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Fixes https://

[PATCH] D146595: [clang] Add clang trampoline attribute

augusto2112 added a comment. In D146595#4213412 , @aprantl wrote: > So this attribute will lower into a `DW_AT_trampoline("target_func_name")` > attribute on the `DW_TAG_subprogram` of the function definition? Exactly, there's already functionality to l

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

xazax.hun added a comment. In D146591#4213614 , @sammccall wrote: > (e.g. does the MLIR dataflow framework have the same idea about how the > analysis timeline relates to the CFG and elements within it? And if we want > to show the clang AST or the Stor

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

jp4a50 added a comment. In D146101#4208962 , @MyDeveloperDay wrote: > What I'd really like to see, is... in the event that > `ContinuationIndentWidth` is set and I do NOTset > `DesignatedInitializerIndentWidth` , then > `DesignatedInitializerIndentW

[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

sammccall updated this revision to Diff 507418. sammccall marked 3 inline comments as done. sammccall added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144730/new/ https://reviews.llvm.org/D144730 Files: clan

[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

sammccall added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:186 + Logger &logger() const { +return DACtx->getOptions().Log ? *DACtx->getOptions().Log : Logger::null(); + } xazax.hun wrote: > If we already ha

[PATCH] D146595: [clang] Add clang trampoline attribute

augusto2112 updated this revision to Diff 507422. augusto2112 added a comment. Herald added a subscriber: jdoerfert. Fix pragma-attribute-supported-attributes-list.test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146595/new/ https://reviews.llvm.

[clang] 77044a4 - [CMake] Build runtimes for riscv64-unknown-fuchsia

Author: Petr Hosek Date: 2023-03-22T17:30:14Z New Revision: 77044a47b4dec308e02c796e7951ab1745a7f53c URL: https://github.com/llvm/llvm-project/commit/77044a47b4dec308e02c796e7951ab1745a7f53c DIFF: https://github.com/llvm/llvm-project/commit/77044a47b4dec308e02c796e7951ab1745a7f53c.diff LOG: [C

[PATCH] D146608: [CMake] Build runtimes for riscv64-unknown-fuchsia

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77044a47b4de: [CMake] Build runtimes for riscv64-unknown-fuchsia (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D146604: [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

schittir updated this revision to Diff 507425. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146604/new/ https://reviews.llvm.org/D146604 Files: clang/include/clang/Basic/TargetOptions.h Index: clang/include/clang/Basic/TargetOptions.h

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

jp4a50 added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:21918-21927 + verifyFormat("Result doSomething(Promise promise) {\n" + " return promise.then(\n" + " [this, obj = std::move(s)](int evaluated) mutable {\n" +

[PATCH] D72940: Add a support for clang tidy to import another configurations files from .clang-tidy

LegalizeAdulthood resigned from this revision. LegalizeAdulthood added a comment. This revision now requires review to proceed. Herald added a reviewer: njames93. Herald added a subscriber: PiotrZSL. Herald added a project: All. No action taken, removing myself as a reviewer Repository: rG LLV

[PATCH] D130630: [clang-tidy] Add readability-nested-ifs check

LegalizeAdulthood added a comment. Herald added a subscriber: PiotrZSL. How does this check interact with macros that expand to `if` statements? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130630/new/ https://reviews.llvm.org/D130630 ___

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

LegalizeAdulthood added a comment. Herald added a subscriber: PiotrZSL. I'm not certain that the result of the transformation is more "readable"; is this check intended to aid conformance to a style guide? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

  1   2   3   >