[PATCH] D146466: [clang] diagnose function fallthrough

2023-03-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D146466#4208216 , @dblaikie wrote: > If the issue is with the actual fallthrough - that's been discussed elsewhere > recently, and I think it'd be reasonable to turn on TrapOnUnreachable > everywhere, basically (with No

[PATCH] D146436: [clang][Interp][NFC] Add tests for __fp16

2023-03-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146436/new/ https://reviews.llvm.org/D146436 ___ cfe-commits mailing list

[PATCH] D146535: [Clang] Fix evaluation of parameters of lambda call operator attributes

2023-03-21 Thread Elizabeth Andrews via Phabricator via cfe-commits
eandrews accepted this revision. eandrews added a comment. This revision is now accepted and ready to land. In D146535#4210268 , @cor3ntin wrote: > In D146535#4210198 , @eandrews > wrote: > >>> Attributes of lamb

[PATCH] D144115: [clang] Extend pragma dump to support expressions

2023-03-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. You should also add a release note to clang/docs/ReleaseNotes.rst so users know about the new functionality. Comment at: clang/docs/LanguageExtensions.rst:4884 +Syntax is the following: `#pragma clang __debug `. +Note that all of them are a subj

[PATCH] D146557: [MLIR][OpenMP] Added OMPIRBuilder support for use_device_ptr clause

2023-03-21 Thread Akash Banerjee via Phabricator via cfe-commits
TIFitis created this revision. TIFitis added reviewers: kiranchandramohan, raghavendhra, dpalermo, jsjodin, domada, jdoerfert, skatrak. Herald added subscribers: sunshaoce, Moerafaat, zero9178, bzcheeseman, awarzynski, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifonte

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

2023-03-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. (Note, precommit CI on Windows still shows a valid failure.) Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:214 void SARIFDiagnostic::emitIncludeLocation(FullSourceLoc Loc, PresumedLoc PLoc) { - assert(false && "Not implemented in SARIF mod

[PATCH] D145639: [Coroutines] Fix premature conversion of return object

2023-03-21 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno updated this revision to Diff 507084. bruno added a comment. Put dependency in place for D145641 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145639/new/ https://reviews.llvm.org/D145639 Files: clang/inc

[PATCH] D145641: [Coroutines] Implement fix for cwg2563 issue and enable RVO under certain conditions

2023-03-21 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno updated this revision to Diff 507085. bruno added a comment. Address last round of review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145641/new/ https://reviews.llvm.org/D145641 Files: clang/include/clang/AST/StmtCXX.h clang/lib/CodeG

[PATCH] D146552: [Clang][OpenMP] Enable device-mapped constexpr class members to not be optimized out

2023-03-21 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. We should have a clang test as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146552/new/ https://reviews.llvm.org/D146552 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D146557: [MLIR][OpenMP] Added OMPIRBuilder support for use_device_ptr clause

2023-03-21 Thread Akash Banerjee via Phabricator via cfe-commits
TIFitis added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4181-4191 +for (auto &UseDeviceOp : UseDeviceInfos) { + auto *UseDeviceVal = UseDeviceOp.first; + auto &UseDeviceInfo = UseDeviceOp.second; + SmallDenseSet ReplaceUses; +

[PATCH] D145641: [Coroutines] Implement fix for cwg2563 issue and enable RVO under certain conditions

2023-03-21 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno updated this revision to Diff 507087. bruno added a comment. Add release notes entry. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145641/new/ https://reviews.llvm.org/D145641 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/S

[PATCH] D144651: [Serialization] Place command line defines in the correct file

2023-03-21 Thread Felipe de Azevedo Piovezan via Phabricator via cfe-commits
fdeazeve added a comment. According to git-bisect, this patch is causing the LLDB bots to crash. https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/52690/console (They were failed for other reasons before, which is why it took a while for this to be identified) Clang is crashing with: `A

[PATCH] D146465: [clang] Fix 2 bugs with parenthesized aggregate initialization

2023-03-21 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:1582-1596 + MultiExprArg ExprsToPass; + if (Exprs.size() == 1 && isa(Exprs[0])) { +// C++20 [expr.static.cast]p4: +// An expression E can be explicitly converted to a type T...if T is an +//

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

2023-03-21 Thread NagaChaitanya Vellanki via Phabricator via cfe-commits
chaitanyav updated this revision to Diff 507090. chaitanyav added a comment. Only proceed with scalar initialization if number of elements is less than 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146503/new/ https://reviews.llvm.org/D146503 Fi

[PATCH] D146448: [CUDA] Update cached kernel handle when the function instance changes.

2023-03-21 Thread Artem Belevich via Phabricator via cfe-commits
tra updated this revision to Diff 507091. tra added a comment. Improved kernel handle cache invalidation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146448/new/ https://reviews.llvm.org/D146448 Files: clang/lib/CodeGen/CGCUDANV.cpp clang/te

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

2023-03-21 Thread NagaChaitanya Vellanki via Phabricator via cfe-commits
chaitanyav added a comment. test outputs for C, C++ _Complex float invalid2 = { 1, 2, 3 }; ^ test.cpp:2:34: error: excess elements in scalar initializer _Complex double dd = {1.0, 2.0 , 3.0}; ^~~ test.cpp:3:32: error:

[PATCH] D146448: [CUDA] Update cached kernel handle when the function instance changes.

2023-03-21 Thread Artem Belevich via Phabricator via cfe-commits
tra updated this revision to Diff 507093. tra added a comment. Deallocate replaced Var. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146448/new/ https://reviews.llvm.org/D146448 Files: clang/lib/CodeGen/CGCUDANV.cpp clang/test/CodeGenCUDA/bug

[PATCH] D146448: [CUDA] Update cached kernel handle when the function instance changes.

2023-03-21 Thread Artem Belevich via Phabricator via cfe-commits
tra updated this revision to Diff 507094. tra added a comment. Cosmetic cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146448/new/ https://reviews.llvm.org/D146448 Files: clang/lib/CodeGen/CGCUDANV.cpp clang/test/CodeGenCUDA/bug-kerner-

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

2023-03-21 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam updated this revision to Diff 507097. zahiraam marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaType.cpp clang/test/Sema/I

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

2023-03-21 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:662-665 +def err_type_definition_cannot_be_modified : Error< + "%0 type definition cannot be modified inside a scope containing " + "'#pragma clang fp eval_method(%1)' when a command l

[PATCH] D146448: [CUDA] Update cached kernel handle when the function instance changes.

2023-03-21 Thread Artem Belevich via Phabricator via cfe-commits
tra updated this revision to Diff 507101. tra added a comment. Simplify invalidation logic. No need to replace HIP's handle variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146448/new/ https://reviews.llvm.org/D146448 Files: clang/lib/Cod

[PATCH] D146448: [CUDA] Update cached kernel handle when the function instance changes.

2023-03-21 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. I've updated the patch with a more robust version of the handle/stub invalidation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146448/new/ https://reviews.llvm.org/D146448 ___ cfe

[PATCH] D146552: [Clang][OpenMP] Enable device-mapped constexpr class members to not be optimized out

2023-03-21 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
doru1004 added a comment. In D146552#4210757 , @jhuber6 wrote: > We should have a clang test as well Agreed, working on one currently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146552/new/ https://rev

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

2023-03-21 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Looks fine, and looks like it's working. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146520/new/ https://reviews.llvm.org/D146520 ___

[PATCH] D146552: [Clang][OpenMP] Enable device-mapped constexpr class members to not be optimized out

2023-03-21 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
doru1004 updated this revision to Diff 507114. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146552/new/ https://reviews.llvm.org/D146552 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_target_constexpr_codegen.cpp openm

[PATCH] D146376: Update static_assert message for redundant cases

2023-03-21 Thread Krishna Narayanan via Phabricator via cfe-commits
Krishna-13-cyber updated this revision to Diff 507113. Krishna-13-cyber added a comment. I have updated the patch without removing the whole of the previous block.I have added a condition to find the case where we don't need a diagnostic message to be printed or warned. Repository: rG LLVM G

[PATCH] D146188: [Clang][DOC] Add documentation in for __builtin_flt_rounds and __builtin_set_flt_rounds

2023-03-21 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Okay. I was looking at a version of the standard that makes reading the environment UB. If that's been relaxed, then I agree that it would be much more natural to talk about *changing* the environment than just *accessing* it. And yeah, I agree it would make sense to

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

2023-03-21 Thread Itay Bookstein via Phabricator via cfe-commits
nextsilicon-itay-bookstein updated this revision to Diff 507121. nextsilicon-itay-bookstein added a comment. Herald added subscribers: mattd, asavonic, zzheng, kbarton, nemanjai. Update relevant test outputs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140722/new/ https://reviews.llvm

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

2023-03-21 Thread Itay Bookstein via Phabricator via cfe-commits
nextsilicon-itay-bookstein added a comment. I had to cut context lines to 2 to fit in the 8MB limit. It looks like there are a few files that absorb way more line diff than makes sense, but I haven't investigated way. One particular offender is `clang/test/OpenMP/nvptx_SPMD_codegen.cpp`, which

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

2023-03-21 Thread Ben Barham via Phabricator via cfe-commits
bnbarham added inline comments. Comment at: clang/lib/Index/USRGeneration.cpp:1032 + case TemplateArgument::UncommonValue: +// FIXME: Visit value. +break; bolshakov-a wrote: > bnbarham wrote: > > bolshakov-a wrote: > > > bnbarham wrote: > > > > bolshakov

[PATCH] D146448: [CUDA] Update cached kernel handle when the function instance changes.

2023-03-21 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146448/new/ https://reviews.llvm.org/D146448 __

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

2023-03-21 Thread David Goldblatt via Phabricator via cfe-commits
davidtgoldblatt updated this revision to Diff 507133. davidtgoldblatt added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136515/new/ https://reviews.llvm.org/D136515 Files: clang/docs/LanguageExtensions.rst clang/docs/Releas

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

2023-03-21 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb updated this revision to Diff 507137. cjdb added a comment. fixes breakage and adds FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145201/new/ https://reviews.llvm.org/D145201 Files: clang/include/clang/Frontend/SARIFDiagnostic.h cla

[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

2023-03-21 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. I love such debugging facilities! They're a massive boost to developer productivity compared to ad-hoc debug prints, and they allow new contributors to study how the tool works. I'm excited to see how this thing turns out. In the static analyzer's path-sensitive engine we'v

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

2023-03-21 Thread garvit gupta via Phabricator via cfe-commits
garvitgupta08 updated this revision to Diff 507144. garvitgupta08 marked an inline comment as not done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145726/new/ https://reviews.llvm.org/D145726 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/t

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

2023-03-21 Thread garvit gupta via Phabricator via cfe-commits
garvitgupta08 added a comment. In D145726#4194142 , @nickdesaulniers wrote: > The description needs to be rewritten to elucidate that this is purely to > support old versions of the GNU assembler still in use by various Linux LTS > distros. This probl

[PATCH] D146578: [AIX][r] Do not call AddFilePathLibArgs with -r

2023-03-21 Thread Michael Francis via Phabricator via cfe-commits
francii created this revision. Herald added a project: All. francii requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. We do not want to add file path lib args when -r is specified. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

2023-03-21 Thread garvit gupta via Phabricator via cfe-commits
garvitgupta08 added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:978-986 + if (Arg *A = Args.getLastArg(options::OPT_g_Flag, options::OPT_gN_Group, + options::OPT_gdwarf_2, options::OPT_gdwarf_3, +

[PATCH] D146582: [clang] Fix wrong highlight for _Complex

2023-03-21 Thread Ilyas Mustafazade via Phabricator via cfe-commits
1lyasm created this revision. 1lyasm added a reviewer: tbaeder. Herald added a project: All. 1lyasm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix https://github.com/llvm/llvm-project/issues/61518 by adding check for _Complex Reposi

[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

2023-03-21 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. In D144730#4211222 , @NoQ wrote: > I love such debugging facilities! They're a massive boost to developer > productivity compared to ad-hoc debug prints, and they allow new contributors > to study how the tool works. I'm excit

[clang] 2aa90da - [CUDA] Update cached kernel handle when the function instance changes.

2023-03-21 Thread Artem Belevich via cfe-commits
Author: Artem Belevich Date: 2023-03-21T15:36:12-07:00 New Revision: 2aa90da012596712a4166e96d2a40fc90598c7fb URL: https://github.com/llvm/llvm-project/commit/2aa90da012596712a4166e96d2a40fc90598c7fb DIFF: https://github.com/llvm/llvm-project/commit/2aa90da012596712a4166e96d2a40fc90598c7fb.diff

[PATCH] D146448: [CUDA] Update cached kernel handle when the function instance changes.

2023-03-21 Thread Artem Belevich via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2aa90da01259: [CUDA] Update cached kernel handle when the function instance changes. (authored by tra). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

2023-03-21 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With -dataflow-log=/dir we will write /dir/0

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

2023-03-21 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Added a bunch of reviewers for feedback on how this should work. Happy to have detailed comments on the JS/HTML generator implementation too of course, but it may inevitably be a bit of a mess (ugly, weird languages, undertested). I've added things like this to a few

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

2023-03-21 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. Generally, I think this is fine. I left comments below. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:1261 +std::string CGOpenMPRuntime::getOutlinedHelperName(StringRef Name) const { + std::string Suffix = getName({"omp_outlined", ""}); + return

[PATCH] D146552: [Clang][OpenMP] Enable device-mapped constexpr class members to not be optimized out

2023-03-21 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10384 // Do not create a "ref-variable" if the original is not also available // on the host. if (!OffloadEntriesInfoManager.hasDeviceGlobalVarEntryInfo(VarName)) -

[PATCH] D146342: [WIP][-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

2023-03-21 Thread Ziqing Luo via Phabricator via cfe-commits
ziqingluo-90 added a comment. >> Current tests are mostly fine except that some notes with message "in >> instantiation of ... " are missing. Although these notes are not emitted by >> our analysis, we better understand why things change. > > This sounds familiar, I think @usama54321 ran into a

[PATCH] D146595: [clang] Add clang trampoline attribute

2023-03-21 Thread Augusto Noronha via Phabricator via cfe-commits
augusto2112 created this revision. augusto2112 added reviewers: aprantl, arphaman, jingham. Herald added a subscriber: hiraditya. Herald added a reviewer: aaron.ballman. Herald added a project: All. augusto2112 requested review of this revision. Herald added projects: clang, LLVM. Herald added subs

[PATCH] D146552: [Clang][OpenMP] Enable device-mapped constexpr class members to not be optimized out

2023-03-21 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
doru1004 updated this revision to Diff 507190. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146552/new/ https://reviews.llvm.org/D146552 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_target_constexpr_codegen.cpp openmp/libomptarget/test/offloading/target_c

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

2023-03-21 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141672/new/ https://reviews.llvm.org/D141672 ___

[PATCH] D145641: [Coroutines] Implement fix for cwg2563 issue and enable RVO under certain conditions

2023-03-21 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Comment at: clang/docs/ReleaseNotes.rst:222-223 template function. +- Fix coroutines issue where return object is being prematurely + converted. This

[clang] 4dc0455 - [AIX][r] Do not call AddFilePathLibArgs with -r

2023-03-21 Thread Michael Francis via cfe-commits
Author: Michael Francis Date: 2023-03-22T02:25:46Z New Revision: 4dc04557d71c1752c53eb8025957df8f1bdbb1e1 URL: https://github.com/llvm/llvm-project/commit/4dc04557d71c1752c53eb8025957df8f1bdbb1e1 DIFF: https://github.com/llvm/llvm-project/commit/4dc04557d71c1752c53eb8025957df8f1bdbb1e1.diff LO

[PATCH] D146578: [AIX][r] Do not call AddFilePathLibArgs with -r

2023-03-21 Thread Michael Francis via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG4dc04557d71c: [AIX][r] Do not call AddFilePathLibArgs with -r (authored by francii). Repository: rG LLVM Github Monorep

[PATCH] D146552: [Clang][OpenMP] Enable device-mapped constexpr class members to not be optimized out

2023-03-21 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. This is as good as it gets until we rip out $ref. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146552/new/ https://reviews.llvm.org/D146552 ___

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

2023-03-21 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added a comment. ping ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145646/new/ https://reviews.llvm.org/D145646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D146603: [docs] Document -fomit-frame-pointer

2023-03-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added reviewers: aabhinavg, vitalybuka. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D146603 Fil

[PATCH] D145840: [Docs] Added -fomit-frame-pointer and -fno-omit-frame-pointer flag documentation

2023-03-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Sorry for my belated response as I was on a trip for quite a few days. We don't need to document the negative form. "Produce better stack traces," is not necessarily correct. See https://maskray.me/blog/2020-11-08-stack-unwinding I created D146603

[PATCH] D146603: [docs] Document -fomit-frame-pointer

2023-03-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 507220. MaskRay added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146603/new/ https://reviews.llvm.org/D146603 Files: clang/include/clang/Driver/Options.td Index: clang/include/clang/Driver/

[PATCH] D146557: [MLIR][OpenMP] Added OMPIRBuilder support for use_device_ptr clause

2023-03-21 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. Conceptually, I am very confused but mostly because this patch conflates things. I would suggest to split this part: > This also refactors how the map clause is processed and separates the mlir > and IRBuilder parts of the code similar to Clang. it that is a better w

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

2023-03-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. "Close" seems more appropriate to me as this isn't a bug (previously not an intended use case). Comment at: clang/test/Driver/avr-ld.c:59 +// LINKS: {{".*ld.*"}} {{.*}} "-

[PATCH] D146604: [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

2023-03-21 Thread Sindhu Chittireddy via Phabricator via cfe-commits
schittir created this revision. schittir added reviewers: tahonermann, shafik. Herald added a project: All. schittir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Found by Coverity static analysis tool. Repository: rG LLVM Github Mono

[PATCH] D145641: [Coroutines] Implement fix for cwg2563 issue and enable RVO under certain conditions

2023-03-21 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno updated this revision to Diff 507224. bruno added a comment. Apply last round of reviews before landing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145641/new/ https://reviews.llvm.org/D145641 Files: clang/docs/ReleaseNotes.rst clang/i

[clang] 43f5085 - [Coroutines] Fix premature conversion of return object

2023-03-21 Thread Bruno Cardoso Lopes via cfe-commits
Author: Bruno Cardoso Lopes Date: 2023-03-21T21:42:25-07:00 New Revision: 43f5085fa80f716acf93870618b1d93ec85c1d01 URL: https://github.com/llvm/llvm-project/commit/43f5085fa80f716acf93870618b1d93ec85c1d01 DIFF: https://github.com/llvm/llvm-project/commit/43f5085fa80f716acf93870618b1d93ec85c1d01

[clang] fa0d4e1 - [Coroutines] Implement fix for cwg2563 issue and enable RVO under certain conditions

2023-03-21 Thread Bruno Cardoso Lopes via cfe-commits
Author: Bruno Cardoso Lopes Date: 2023-03-21T21:42:31-07:00 New Revision: fa0d4e1f12a3f69dd0afb07c0928c867ab921537 URL: https://github.com/llvm/llvm-project/commit/fa0d4e1f12a3f69dd0afb07c0928c867ab921537 DIFF: https://github.com/llvm/llvm-project/commit/fa0d4e1f12a3f69dd0afb07c0928c867ab921537

[PATCH] D145639: [Coroutines] Fix premature conversion of return object

2023-03-21 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG43f5085fa80f: [Coroutines] Fix premature conversion of return object (authored by bruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145639/new/ https://

[PATCH] D145641: [Coroutines] Implement fix for cwg2563 issue and enable RVO under certain conditions

2023-03-21 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa0d4e1f12a3: [Coroutines] Implement fix for cwg2563 issue and enable RVO under certain… (authored by bruno). Repository: rG LLVM Github Monorepo

[clang] 0d37efd - [clang][driver] Enable '-flto' on AVR

2023-03-21 Thread Ben Shi via cfe-commits
Author: Ben Shi Date: 2023-03-22T12:57:58+08:00 New Revision: 0d37efdbc599e61ce2a0418723a66d6b45aea8d7 URL: https://github.com/llvm/llvm-project/commit/0d37efdbc599e61ce2a0418723a66d6b45aea8d7 DIFF: https://github.com/llvm/llvm-project/commit/0d37efdbc599e61ce2a0418723a66d6b45aea8d7.diff LOG:

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

2023-03-21 Thread Ben Shi via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d37efdbc599: [clang][driver] Enable '-flto' on AVR (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D145646?vs=503607&i

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

2023-03-21 Thread NagaChaitanya Vellanki via Phabricator via cfe-commits
chaitanyav added a comment. Please review this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146503/new/ https://reviews.llvm.org/D146503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D143704: [flang] Feature list plugin

2023-03-21 Thread Ethan Luis McDonough via Phabricator via cfe-commits
elmcdonough updated this revision to Diff 507231. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 Files: flang/examples/CMakeLists.txt flang/examples/FeatureList/CMakeLists.txt flang/examples/FeatureList/FeatureList.cpp flang/test/CMakeL

[PATCH] D146608: [CMake] Build runtimes for riscv64-unknown-fuchsia

2023-03-21 Thread Petr Hosek via Phabricator via cfe-commits
phosek created this revision. phosek added reviewers: abrachet, mcgrathr. Herald added subscribers: VincentWu, vkmr, evandro, luismarques, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, rogfer01, shiva0217, kito-cheng, simoncook, asb, arichardson. Herald added a project: All. phosek request

[PATCH] D142905: [Driver] Change multilib selection algorithm

2023-03-21 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings added a comment. @phosek ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D142905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D144115: [clang] Extend pragma dump to support expressions

2023-03-21 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added a comment. Thank you for review! Comment at: clang/lib/Parse/ParsePragma.cpp:15-17 #include "clang/Basic/TargetInfo.h" +#include "clang/Lex/LexDiagnostic.h" #include "clang/Lex/Preprocessor.h" aaron.ballman wrote: > I'm using `warn_pragma_debug_

<    1   2