jdoerfert added a comment.
Generally, I think this is fine. I left comments below.
================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:1261
+std::string CGOpenMPRuntime::getOutlinedHelperName(StringRef Name) const {
+ std::string Suffix = getName({"omp_outlined", ""});
+ return (Name + Suffix).str();
----------------
why the empty string?
================
Comment at: clang/test/OpenMP/declare_target_codegen_globalization.cpp:65
-//
-//
// CHECK1-LABEL: define {{[^@]+}}@_Z3fooRi
----------------
This might be easier to debug than the SPMD test. For some reason the function
is gone, which is bad. My money is on the trailing $ which prevents us from
matching it as a function in the update test script. That said, I really doubt
we want that $ anyway.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140722/new/
https://reviews.llvm.org/D140722
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
