[clang] 696f8b3 - Revert "[clang-format] Add a space between an overloaded operator and '>'"

Author: Kadir Cetinkaya Date: 2023-03-20T08:07:44+01:00 New Revision: 696f8b32d4bfe7e96f6fdb425fb4768a0508da83 URL: https://github.com/llvm/llvm-project/commit/696f8b32d4bfe7e96f6fdb425fb4768a0508da83 DIFF: https://github.com/llvm/llvm-project/commit/696f8b32d4bfe7e96f6fdb425fb4768a0508da83.dif

[PATCH] D146269: MIPS: allow o32 abi with 64bit CPU and 64 abi with 32bit triple

wzssyqa updated this revision to Diff 506482. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146269/new/ https://reviews.llvm.org/D146269 Files: clang/lib/Basic/Targets/Mips.cpp clang/test/Driver/mips-cpu64abi32.c Index: clang/test/Driver/mips-cpu64abi32.c ===

[PATCH] D146269: MIPS: allow o32 abi with 64bit CPU and 64 abi with 32bit triple

wzssyqa added a comment. In D146269#4201150 , @jrtc27 wrote: > Tests? Added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146269/new/ https://reviews.llvm.org/D146269 ___ cfe-commits mailing list c

[PATCH] D146406: [IncludeCleaner][clangd] Mark umbrella headers as users of private

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. Private h

[PATCH] D146377: [clangd] Remove reundant use of getSpellingLoc()

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146377/new/ https://reviews.llvm.org/D146377

[PATCH] D146408: [clang][Interp] Start supporting complex types

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Trying a different approach here where I split the

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 506499. pmatos added a comment. Rebase on main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/include/clang/AST/Expr.h clang/include/clang/AST/Type.

[PATCH] D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments.

mboehme updated this revision to Diff 506507. mboehme added a comment. Changes in response to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145581/new/ https://reviews.llvm.org/D145581 Files: clang-tools-extra/clang-tidy/utils/E

[PATCH] D143755: [clang-format] Add a space between an overloaded operator and '>'

owenpan added a comment. @kadircet thanks for reporting the crash and reverting the commit. I will fix it and reland the patch. Comment at: clang/lib/Format/TokenAnnotator.cpp:1229 + consumeToken(); +assert(CurrentToken); +auto Previous = CurrentToken-

[PATCH] D144987: [clang][dataflow] Fix missed fields in field set construction.

gribozavr2 added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/DataflowEnvironmentTest.cpp:141 + }; + S foo(); + )cc"; Is `foo()` used for anything in this test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments.

mboehme updated this revision to Diff 506510. mboehme added a comment. Added entry to release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145581/new/ https://reviews.llvm.org/D145581 Files: clang-tools-extra/clang-tidy/utils/ExprSequenc

[clang] 28997fe - [LLVM][OHOS] Clang toolchain and targets

Author: Pavel Kosov Date: 2023-03-20T12:53:24+03:00 New Revision: 28997feb0c3ac243cb5cc89d7682993e23463ca7 URL: https://github.com/llvm/llvm-project/commit/28997feb0c3ac243cb5cc89d7682993e23463ca7 DIFF: https://github.com/llvm/llvm-project/commit/28997feb0c3ac243cb5cc89d7682993e23463ca7.diff L

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

This revision was automatically updated to reflect the committed changes. Closed by commit rG28997feb0c3a: [LLVM][OHOS] Clang toolchain and targets (authored by kpdev42). Herald added a subscriber: asb. Changed prior to commit: https://reviews.llvm.org/D145227?vs=504994&id=506511#toc Repositor

[PATCH] D145906: [clang-tidy] Correctly handle evaluation order of designated initializers.

mboehme added a comment. In D145906#4198583 , @PiotrZSL wrote: > Regarding release-notes: > I would probably wrote something like "fixed handling for designated > initializers", nonene will understand things like "sequence point". Thanks, makes sense.

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

kpdev42 added a comment. In D145227#4192628 , @DavidSpickett wrote: > Also failing on our Windows on Arm bot: > https://lab.llvm.org/buildbot/#/builders/65/builds/8607 > > I think some lines need to account for Windows slashes, `{{/|}}` should > do

[clang] 682808d - Reland [clang-format] Add a space between an overloaded operator and '>'

Author: Owen Pan Date: 2023-03-20T03:01:22-07:00 New Revision: 682808d9c9c81306c0a08a1fdb496b4f572566b4 URL: https://github.com/llvm/llvm-project/commit/682808d9c9c81306c0a08a1fdb496b4f572566b4 DIFF: https://github.com/llvm/llvm-project/commit/682808d9c9c81306c0a08a1fdb496b4f572566b4.diff LOG:

[PATCH] D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments.

mboehme added a comment. Sorry for the delay in replying -- I was caught up in other projects. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:224 + `: + - Fixed handling for designated initializers. + - Fix: In C++17 and later, the callee of a function is guaranteed to

[PATCH] D146396: [clang-tidy] Use checks dependences for Analyzer checks

PiotrZSL added a comment. I have feeling that hidden checks that none other check depend on should be enabled by default. Also I have feeling that those hidden checks shouldn't be visible to end user. But need to confirm this first with Static Analyser developers. Repository: rG LLVM Github M

[PATCH] D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments.

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/use-after-move.cpp:1304 + std::unique_ptr a; + a->foo(std::move(a)); +} mboehme wrote: > PiotrZSL wrote: > > What about scenario like this: > > > > ``` > > b.foo(a

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 506521. pmatos added a comment. Remove references to table subscript. Simplify patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/include/clang/AST/

[PATCH] D144976: [clangd] Add provider info on symbol hover.

hokein added a comment. Thanks, this looks great, some more comments (most are nits) Comment at: clang-tools-extra/clangd/Hover.cpp:1099 + const SourceManager &SM = AST.getSourceManager(); + llvm::SmallVector Headers = + include_cleaner::headersForSymbol(Sym, SM, AST.get

[PATCH] D146412: [NFC] Fix potential use-after-free in DumpModuleInfoAction::ExecuteAction()

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since each `DumpModuleInfoAction` can now contain a pointer to a `raw_ostream`, saving there a poiter that owned by a lo

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142907/new/ https://reviews.llvm.org/D142907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D146417: [clangd] Fix AddUsing in the face of typo-correction

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes https://g

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

tblah updated this revision to Diff 506544. tblah marked 2 inline comments as done. tblah added a comment. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendo

[PATCH] D146187: [docs] Update the status for coroutines

aaron.ballman added a comment. In D146187#4205271 , @ChuanqiXu wrote: >> Ugh, that does sort of change the calculus for whether we do or don't claim >> support on Windows. If removing the definition of that macro on Windows >> causes significant code br

[PATCH] D146187: [docs] Update the status for coroutines

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146187/new/ https://reviews.llvm.org/D146187 ___ cfe-commits

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

hokein added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1141 +std::string getRefName(include_cleaner::SymbolReference Ref) { + std::string Name; we have a similar function `symbolName` in include-cleaner's `FindHeaders.cpp`, but it is not

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (5/7)

jmmartinez accepted this revision. jmmartinez added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:712-714 + assert(!getAbstractScopeDIEs().count(DS) && + "Abstract DIE for this scope

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos added inline comments. Comment at: clang/test/SemaCXX/wasm-refs-and-tables.cpp:16-17 +__externref_t **t2; // expected-error {{pointer to WebAssembly reference type is not allowed}} +__externref_t **t3; // expected-error {{pointer to WebAssembly

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 506552. pmatos marked 4 inline comments as done. pmatos added a comment. Address concerns about table subscripting. Add warnings for that. Address a few other smaller comments like testing for table comparisons. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D146279: [clangd] Extend CollectMainFileMacros.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/CollectMacros.h:48 public: - explicit CollectMainFileMacros(const SourceManager &SM, MainFileMacros &Out) - : SM(SM),

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

RitanyaB created this revision. RitanyaB added reviewers: sandeepkosuri, koops, soumitra, dreachem, ABataev, cchen. Herald added subscribers: sunshaoce, mattd, asavonic, guansong, yaxunl. Herald added a project: All. RitanyaB requested review of this revision. Herald added a reviewer: jdoerfert. H

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

erichkeane added a comment. Added the code owners here. There doesn't seem to be anything questionable here to me, but I want to make sure someone who really knows what is going on takes a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14638

[PATCH] D146406: [IncludeCleaner][clangd] Mark umbrella headers as users of private

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:100 + // Check if main file is the public interface for a private header. If so + // we shouldn't diagnose it as unused. + if (auto PHeader = PI->getPublic(I.Resolved); !PH

[PATCH] D146406: [IncludeCleaner][clangd] Mark umbrella headers as users of private

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:100 + // Check if main file is the public interface for a private header. If so + // we shouldn't diagnose it as unused. + if (auto PHeader = PI->getPublic(I.Resolved); !

[PATCH] D146417: [clangd] Fix AddUsing in the face of typo-correction

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146417/new/ https://reviews.llvm.org/D146417

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

ABataev added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2093-2115 +void ParseImplicitDeclareTargetAttr(Decl *TargetDecl) { + if (TargetDecl && TargetDecl->hasAttr() && + isa(TargetDecl)) { +VarDecl *TargetVarDecl = cast(TargetDecl); +Expr *Ex = Targ

[clang-tools-extra] 6f23fee - [clangd] Fix AddUsing in the face of typo-correction

Author: Kadir Cetinkaya Date: 2023-03-20T14:30:36+01:00 New Revision: 6f23fee4ef98a695062aa128a177478ba7d742d4 URL: https://github.com/llvm/llvm-project/commit/6f23fee4ef98a695062aa128a177478ba7d742d4 DIFF: https://github.com/llvm/llvm-project/commit/6f23fee4ef98a695062aa128a177478ba7d742d4.dif

[PATCH] D146417: [clangd] Fix AddUsing in the face of typo-correction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f23fee4ef98: [clangd] Fix AddUsing in the face of typo-correction (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 506563. TIFitis added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp llvm/include/llvm/Frontend/

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

awarzynski added inline comments. Comment at: flang/test/Driver/mlir-pass-pipeline.f90:15-18 +! O2-NEXT: Canonicalizer +! ALL-NEXT: LowerHLFIRIntrinsics +! ALL-NEXT: BufferizeHLFIR +! ALL-NEXT: ConvertHLFIRtoFIR It looks like these passes are run unconditionally

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

daltenty added a comment. LGTM, with a small nit about the test that should be addressed before committing Comment at: clang/test/Driver/aix-ld.c:1085 +// RUN:--sysroot %S/Inputs/aix_ppc_tree \ +// RUN:--unwindlib=libunwind \ +// RUN:-r \ ---

[PATCH] D144987: [clang][dataflow] Fix missed fields in field set construction.

ymandel added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/DataflowEnvironmentTest.cpp:141 + }; + S foo(); + )cc"; gribozavr2 wrote: > Is `foo()` used for anything in this test? not that I can see. looks left over from some previo

[PATCH] D146385: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef

dang requested changes to this revision. dang added a comment. This revision now requires changes to proceed. I think there might be some code missing here. Also can you add a test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146385/new/ https://

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

RitanyaB added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2107 + DeclVar->addAttr(TargetDecl->getAttr()); + ParseImplicitDeclareTargetAttr(DeclVar); +} ABataev wrote: > Try to avoid recursion here Consider th

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

erichkeane added a subscriber: asl. erichkeane added a comment. I've got the 1 concern with the mangling that I REALLY want one of our codegen owners to chime in on, otherwise this LGTM. Comment at: clang/lib/AST/ItaniumMangle.cpp:4397 +// argument. +// As proposed in

[PATCH] D146354: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM! I think it's fine to go ahead and land this (premerge check are not a requirement). Have you contributed to LLVM before? If not I will need to commit it on your behalf. Once that is done you

[PATCH] D146420: Document the Clang policies on claiming support for a feature

aaron.ballman created this revision. aaron.ballman added reviewers: clang-language-wg, rsmith. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. We do not currently have this written down anywhere, and as a result, we're sometimes inconsi

[PATCH] D146165: docs: add some documentation on Windows SDK search

compnerd added a comment. > Looks reasonable I guess - but I think it would be good to mention the env > variables INCLUDE and LIB too, for alternative ways of finding the same > things - even if it's not strictly the same as what this new section talks > about. Yes, I agree, I did miss that i

[PATCH] D146420: Document the Clang policies on claiming support for a feature

erichkeane added inline comments. Comment at: clang/docs/InternalsManual.rst:3276 +Some of these feature tests are standardized, like ``__has_cpp_attribute`` or +``__cpp_decltype``, while others are Clang extensions, like ``__has_builtin``. +The common theme among all the various

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

ABataev added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2107 + DeclVar->addAttr(TargetDecl->getAttr()); + ParseImplicitDeclareTargetAttr(DeclVar); +} RitanyaB wrote: > ABataev wrote: > > Try to avoid recursi

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

tblah added inline comments. Comment at: flang/include/flang/Tools/CLOptions.inc:235 +/// passes pipeline +inline void createHLFIRToFIRPassPipeline(mlir::PassManager &pm, +llvm::OptimizationLevel optLevel = defaultOptLevel) { vzakhari wrote: > Would you min

[PATCH] D146420: Document the Clang policies on claiming support for a feature

cor3ntin added inline comments. Comment at: clang/docs/InternalsManual.rst:3285 + * Are there known issues with the feature that reject valid code? + * Are there known issues that fail to reject invalid code? + * Are there known crashes, failed assertions, or miscompilations?

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii updated this revision to Diff 506575. francii added a comment. Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146399/new/ https://reviews.llvm.org/D146399 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolC

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Ping for review/comments. Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D144870: [Clang][DebugInfo] Emit zero size bitfields in the debug info to delimit bitfields in different allocation units.

jmmartinez added a comment. In D144870#4202121 , @probinson wrote: > (Of course it's possible that finding the preceding field can be done only by > iterating, but I'd hope that isn't necessary.) Sadly, this is the case. `field_iterator` and the underly

[PATCH] D146422: Fix typo

1lyasm created this revision. 1lyasm added reviewers: evansmal, zero9178. Herald added a project: All. 1lyasm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D146422 Files:

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 506577. francii added a comment. Update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/aix

[PATCH] D146338: [MSVC compatibility][dllimport/dllexport][PS] Allow dllexport/dllimport for classes with UniqueExternalLinkage

hans added a comment. > In D145271 it was suggested that we drop > the attribute in such contexts, and this is effectively what happens. The > compiler does not produce any exported definitions (or import any symbols) > for such classes. The patch is simply to

[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

This revision was automatically updated to reflect the committed changes. kpdev42 marked an inline comment as done. Closed by commit rG21cd04c46fe0: [clang][ASTImport] Add support for import of empty records (authored by kpdev42). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii updated this revision to Diff 506580. francii added a comment. Clean up test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146399/new/ https://reviews.llvm.org/D146399 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/

[clang] 21cd04c - [clang][ASTImport] Add support for import of empty records

Author: Pavel Kosov Date: 2023-03-20T17:33:04+03:00 New Revision: 21cd04c46fe0a2bee224899f56518a09bce5306e URL: https://github.com/llvm/llvm-project/commit/21cd04c46fe0a2bee224899f56518a09bce5306e DIFF: https://github.com/llvm/llvm-project/commit/21cd04c46fe0a2bee224899f56518a09bce5306e.diff L

[PATCH] D146165: docs: add some documentation on Windows SDK search

hans accepted this revision. hans added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/UsersManual.rst:4504 +programs against the Windows system packages. Underlying the Windows SDK is the +UCRT, the universal C runtime. + -

[PATCH] D145843: [clangd] Add option to always insert headers with <> instead of ""

kadircet added a comment. sorry but I am not sure what's the value proposed by this patch in its current form. in https://github.com/clangd/clangd/issues/1247 and other places we've discussed this, i believe the sentiment was towards providing a config option that'll let people customize header

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

MarcoFalke updated this revision to Diff 506586. MarcoFalke marked an inline comment as done. MarcoFalke added a comment. Took some review suggestions (Thanks!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146288/new/ https://reviews.llvm.org/D146288 Files: clang-tools-extra/clang-t

[PATCH] D146426: [Sema] Fix crash on __fp16 parameters in template instantiations

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added a project: All. ilya-biryukov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, Clang stores `nullptr` in the parameter lists inside `Funct

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

MarcoFalke added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp:400 void UseAfterMoveCheck::registerMatchers(MatchFinder *Finder) { auto CallMoveMatcher = + callExpr( PiotrZSL wrote: > This is correct but conside

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 updated this revision to Diff 506588. Michael137 added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - Fix cycle in `DIDerivedType` when we deal with forward declarations and complete explicitly via `completeClassData` (e.g., with `-gmodules`) - Add

[PATCH] D146420: Document the Clang policies on claiming support for a feature

aaron.ballman marked 5 inline comments as done. aaron.ballman added inline comments. Comment at: clang/docs/InternalsManual.rst:3285 + * Are there known issues with the feature that reject valid code? + * Are there known issues that fail to reject invalid code? + * Are there k

[PATCH] D146420: Document the Clang policies on claiming support for a feature

aaron.ballman updated this revision to Diff 506591. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Updating based on review feedback. (Note: Phab seems to be confused about the changes being at the end of the file -- it claims there's no trailing context for the p

[PATCH] D146427: [clang-tools-extra] Fix linking ClangdTests when using libclang-cpp

mgorny created this revision. mgorny added reviewers: DmitryPolukhin, kadircet, tstellar, MaskRay. Herald added subscribers: mikhail.ramalho, arphaman. Herald added a project: All. mgorny requested review of this revision. Herald added a subscriber: ilya-biryukov. Herald added a project: clang-tool

[clang] fa326c2 - Revert "[clang][ASTImport] Add support for import of empty records"

Author: Pavel Kosov Date: 2023-03-20T18:20:41+03:00 New Revision: fa326c21919faea33b0470b7083dccbd3c1fc3f2 URL: https://github.com/llvm/llvm-project/commit/fa326c21919faea33b0470b7083dccbd3c1fc3f2 DIFF: https://github.com/llvm/llvm-project/commit/fa326c21919faea33b0470b7083dccbd3c1fc3f2.diff L

[PATCH] D146393: [Clang] Support free positioning of labels inside compound statements in C

aaron.ballman added subscribers: jyu2, mikerice, jdoerfert. aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:745 SubStmt = Actions.ActOnNullStmt(ColonLoc); LabelDecl *LD = Actions.LookupOrCreateLabel(IdentTok.getIdentifierInfo(), --

[PATCH] D146354: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments

chaitanyav added a comment. Thank you, Please go ahead and Commit the change. I don't have commit access, Will follow the instructions on the page to get access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146354/new/ https://reviews.llvm.org/D1

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

awarzynski added inline comments. Comment at: flang/test/Driver/mlir-pass-pipeline.f90:15-18 +! O2-NEXT: Canonicalizer +! ALL-NEXT: LowerHLFIRIntrinsics +! ALL-NEXT: BufferizeHLFIR +! ALL-NEXT: ConvertHLFIRtoFIR tblah wrote: > awarzynski wrote: > > It looks like

[PATCH] D146354: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments

chaitanyav added a comment. Name: NagaChaitanya Vellanki email: pnag...@protonmail.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146354/new/ https://reviews.llvm.org/D146354 ___ cfe-commits mailing l

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp:400 void UseAfterMoveCheck::registerMatchers(MatchFinder *Finder) { auto CallMoveMatcher = + callExpr( MarcoFalke wrote: > PiotrZSL wrote: > > This is

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/use-after-move.cpp:1431 std::string val_; }; MarcoFalke wrote: > PiotrZSL wrote: > > Missing tests: > > - Test with A derive from B, C, D, and argument is moved i

[PATCH] D146354: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGafce10c5b60f: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration… (authored by chaitanyav, committed by dang). Repository: r

[clang] afce10c - [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments

Author: NagaChaitanya Vellanki Date: 2023-03-20T15:43:00Z New Revision: afce10c5b60fada1db369d3770f4389da7ef30ef URL: https://github.com/llvm/llvm-project/commit/afce10c5b60fada1db369d3770f4389da7ef30ef DIFF: https://github.com/llvm/llvm-project/commit/afce10c5b60fada1db369d3770f4389da7ef30ef.d

[PATCH] D144870: [Clang][DebugInfo] Emit zero size bitfields in the debug info to delimit bitfields in different allocation units.

jmmartinez updated this revision to Diff 506611. jmmartinez added a comment. - Updated to use `elements` array to avoid the complicated loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144870/new/ https://reviews.llvm.org/D144870 Files: clang

[PATCH] D146426: [Sema] Fix crash on __fp16 parameters in template instantiations

shafik added a comment. Please edit the summary to indicate this fixes: https://github.com/llvm/llvm-project/issues/61441 I am happy someone had more time to dig into this problem after my initial investigation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D146426: [Sema] Fix crash on __fp16 parameters in template instantiations

ilya-biryukov added a comment. In D146426#4206519 , @shafik wrote: > Please edit the summary to indicate this fixes: > https://github.com/llvm/llvm-project/issues/61441 > I am happy someone had more time to dig into this problem after my initial > inves

[PATCH] D146426: [Sema] Fix crash on __fp16 parameters in template instantiations

shafik added inline comments. Comment at: clang/test/SemaCXX/crash-params.cpp:3 + +template +int foo() { If this test really does not fit into any other test set the please rename the test file `GH61441.cpp` so we know it is a regression test for that github bu

[PATCH] D146426: [Sema] Fix crash on __fp16 parameters in template instantiations

shafik added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1714 /// Check whether a function's parameter types are all literal types. If so, /// return true. If not, produce a suitable diagnostic and return false. static bool CheckConstexprParameterTypes(Sema &Se

[PATCH] D146426: [Sema] Fix crash on __fp16 parameters in template instantiations

shafik added a comment. In D146426#4206525 , @ilya-biryukov wrote: > In D146426#4206519 , @shafik wrote: > >> Please edit the summary to indicate this fixes: >> https://github.com/llvm/llvm-project/issues/61441

[PATCH] D146426: [Sema] Fix crash on __fp16 parameters in template instantiations

shafik added a reviewer: clang-language-wg. shafik added a comment. Adding clang-language-wg for more visibility Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146426/new/ https://reviews.llvm.org/D146426 ___

[PATCH] D146420: Document the Clang policies on claiming support for a feature

cor3ntin added inline comments. Comment at: clang/docs/InternalsManual.rst:3285 + * Are there known issues with the feature that reject valid code? + * Are there known issues that fail to reject invalid code? + * Are there known crashes, failed assertions, or miscompilations?

[PATCH] D146420: Document the Clang policies on claiming support for a feature

aaron.ballman added inline comments. Comment at: clang/docs/InternalsManual.rst:3285 + * Are there known issues with the feature that reject valid code? + * Are there known issues that fail to reject invalid code? + * Are there known crashes, failed assertions, or miscompilati

[PATCH] D146420: Document the Clang policies on claiming support for a feature

cor3ntin added inline comments. Comment at: clang/docs/InternalsManual.rst:3285 + * Are there known issues with the feature that reject valid code? + * Are there known issues that fail to reject invalid code? + * Are there known crashes, failed assertions, or miscompilations?

[PATCH] D146426: [Sema] Fix crash on __fp16 parameters in template instantiations

ilya-biryukov updated this revision to Diff 506623. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - rename test file to GH61441.cpp, add a comment this checks for no crash - Update outdated comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146426: [Sema] Fix crash on __fp16 parameters in template instantiations

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1714 /// Check whether a function's parameter types are all literal types. If so, /// return true. If not, produce a suitable diagnostic and return false. static bool CheckConstexprParameterTypes(S

[PATCH] D146434: [clang-format] Fix support for ObjC blocks with pointer return types

jaredgrubb created this revision. jaredgrubb added reviewers: djasper, egorzhdan, benhamilton. jaredgrubb added a project: clang-format. Herald added a project: All. jaredgrubb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The ObjC-block

[PATCH] D145391: [HIP] Supports env var HIP_PATH

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145391/new/ https://reviews.llvm.org/D145391 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D146420: Document the Clang policies on claiming support for a feature

aaron.ballman updated this revision to Diff 506624. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Update based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146420/new/ https://reviews.llvm.org/D146420 Files: clang/docs/InternalsMa

[PATCH] D146436: [clang][Interp][NFC] Add tests for __fp16

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This should already work just fine since our `Float

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

MarcoFalke updated this revision to Diff 506632. MarcoFalke added a comment. address feedback about matcher, clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146288/new/ https://reviews.llvm.org/D146288 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp cl

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

nemanjai added a comment. In D143467#4195474 , @qiucf wrote: > - For builtins with matching instruction, use the required ISA/vector version > - For the rest builtins used in altivec.h, use requirements specified by the > header > - Keep the feature chec

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

MarcoFalke marked 3 inline comments as done. MarcoFalke added a comment. Thanks, addressed some more review comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/use-after-move.cpp:1431 std::string val_; }; PiotrZSL wrote: > MarcoFalke

  1   2   3   >