[clang] 33ba940 - [clang][Interp][NFCI] Support more expression in initializers

Author: Timm Bäder Date: 2023-03-05T09:57:52+01:00 New Revision: 33ba940de0401c91b4d7e12d98972e6ba0f0f662 URL: https://github.com/llvm/llvm-project/commit/33ba940de0401c91b4d7e12d98972e6ba0f0f662 DIFF: https://github.com/llvm/llvm-project/commit/33ba940de0401c91b4d7e12d98972e6ba0f0f662.diff LO

[clang] 78e4237 - [clang][Interp] Support destructors

Author: Timm Bäder Date: 2023-03-05T10:02:42+01:00 New Revision: 78e4237460bf58f3d6b75f275e0424f38e3b1d04 URL: https://github.com/llvm/llvm-project/commit/78e4237460bf58f3d6b75f275e0424f38e3b1d04 DIFF: https://github.com/llvm/llvm-project/commit/78e4237460bf58f3d6b75f275e0424f38e3b1d04.diff LO

[PATCH] D137070: [clang][Interp] Support destructors

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG78e4237460bf: [clang][Interp] Support destructors (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D137070?vs=494660&id=50

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

ManuelJBrito added a comment. It seems the build failure was caused by a known crash https://github.com/llvm/llvm-project/issues/55263. I tried to find some workaround but unsuccessfully. So I'm thinking I can drop the end-to-end tests for now and commit them when the crash is fixed and for n

[clang] 5e12002 - Revert "[clang][Interp] Support destructors"

Author: Timm Bäder Date: 2023-03-05T13:18:13+01:00 New Revision: 5e12002c6cea7601073888c2281525131caa77e3 URL: https://github.com/llvm/llvm-project/commit/5e12002c6cea7601073888c2281525131caa77e3 DIFF: https://github.com/llvm/llvm-project/commit/5e12002c6cea7601073888c2281525131caa77e3.diff LO

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan added reviewers: nridge, kadircet. zyounan published this revision for review. zyounan added inline comments. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added

[PATCH] D145303: clang-tidy altera-id-dependent-backward-branch: print notes after warning

carlosgalvezp added a comment. Thanks for the fix! Can you land the patch or would need that we do it for you? If so please provide Github name and email for attribution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145303/new/ https://reviews.ll

[PATCH] D144216: [clang-tidy] Extract string header from redundant-string-cstr checker

carlosgalvezp accepted this revision. carlosgalvezp added a comment. Sounds good, should we land this? If you don't have commit rights, please let us know Github name and email for attribution. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144216/new/ https://reviews.llvm.org/D144216

[PATCH] D145303: clang-tidy altera-id-dependent-backward-branch: print notes after warning

yeputons-gh added a comment. Hi, @carlosgalvezp ! I don't have any commit rights for the LLVM project, so I probably need help. My GitHub handle is `yeputons` (https://github.com/yeputons/), my email for attribution is `egor.suvo...@gmail.com` (that's my first name, last name) Repository: r

[PATCH] D143375: clang-tidy: Count template constructors in modernize-use-default-member-init

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. Thanks for the fix! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143375/new/ https://reviews.llvm.org/D143375 ___ cfe-commi

[PATCH] D144216: [clang-tidy] Extract string header from redundant-string-cstr checker

mikecrowe added a comment. > Sounds good, should we land this? If you're happy to do so, then so am I. > If you don't have commit rights, please let us know Github name and email for > attribution. These are my first code contributions to LLVM, so I don't really know the process. I don't beli

[PATCH] D144216: [clang-tidy] Extract string header from redundant-string-cstr checker

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/string:4-5 + +// For size_t +#include + Sorry I just noticed this - should we keep using the `__SYZE_TYPE__` macro that existed in the previous patch? The

[clang-tools-extra] c6d195b - clang-tidy altera-id-dependent-backward-branch: print notes after warning

Author: Egor Suvorov Date: 2023-03-05T16:06:55Z New Revision: c6d195b366c8256184ff40c5e46339eed96b4a81 URL: https://github.com/llvm/llvm-project/commit/c6d195b366c8256184ff40c5e46339eed96b4a81 DIFF: https://github.com/llvm/llvm-project/commit/c6d195b366c8256184ff40c5e46339eed96b4a81.diff LOG:

[PATCH] D145303: clang-tidy altera-id-dependent-backward-branch: print notes after warning

This revision was automatically updated to reflect the committed changes. Closed by commit rGc6d195b366c8: clang-tidy altera-id-dependent-backward-branch: print notes after warning (authored by yeputons-gh, committed by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D144216: [clang-tidy] Extract string header from redundant-string-cstr checker

mikecrowe added a comment. > The purpose of this header is to not include any standard header, and yet > this is done in line 5 so it kinda defeats the purpose. I believe that this `` header is including `clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/string.h` rather than the syste

[PATCH] D144216: [clang-tidy] Extract string header from redundant-string-cstr checker

mikecrowe added a comment. > I will double check that this is true once my current build is complete. Yes, it's true. I stuck a `#error` in `clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/string.h` and I saw the expected error from a file including ``. CHANGES SINCE LAST ACTION h

[PATCH] D145125: [RISCV] Make D extension imply F extension.

asb accepted this revision. asb added a comment. I think this is in line with how we now handle implication of specs - when the code was first written IIRC we were much stricter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145125/new/ https://re

[PATCH] D144216: [clang-tidy] Extract string header from redundant-string-cstr checker

carlosgalvezp added a comment. In D144216#4169764 , @mikecrowe wrote: >> I will double check that this is true once my current build is complete. > > Yes, it's true. I stuck a `#error` in > `clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/strin

[PATCH] D144216: [clang-tidy] Extract string header from redundant-string-cstr checker

mikecrowe added a comment. In D144216#4169772 , @carlosgalvezp wrote: > In D144216#4169764 , @mikecrowe > wrote: > >>> I will double check that this is true once my current build is complete. >> >> Yes, it's tru

[clang-tools-extra] ae25e2f - [clang-tidy] Extract string header from redundant-string-cstr checker

Author: Mike Crowe Date: 2023-03-05T17:16:20Z New Revision: ae25e2f19decb94198301f0726ee613f945cc405 URL: https://github.com/llvm/llvm-project/commit/ae25e2f19decb94198301f0726ee613f945cc405 DIFF: https://github.com/llvm/llvm-project/commit/ae25e2f19decb94198301f0726ee613f945cc405.diff LOG: [c

[PATCH] D144216: [clang-tidy] Extract string header from redundant-string-cstr checker

This revision was automatically updated to reflect the committed changes. Closed by commit rGae25e2f19dec: [clang-tidy] Extract string header from redundant-string-cstr checker (authored by mikecrowe, committed by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144216: [clang-tidy] Extract string header from redundant-string-cstr checker

carlosgalvezp added a comment. In D144216#4169781 , @mikecrowe wrote: > In D144216#4169772 , @carlosgalvezp > wrote: > >> In D144216#4169764 , @mikecrowe >> wrote: >> >>

[PATCH] D145310: [clang-tidy] Make readability-container-data-pointer use header

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, would you mind rebasing to get the pre-merge jobs green? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145310/new/ https://reviews.llvm.org/D145310 __

[PATCH] D145313: [clang-tidy] Make readability-container-size-empty check using header

carlosgalvezp added a comment. Could you upload the patch with full context? I believe you need to do something like `git show HEAD -U99` as per the guidelines . Otherwise `arc diff` should do the job automatically. Reason I ask is that I cannot see t

[PATCH] D145312: [clang-tidy] Make readability-string-compare check use header

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/string-compare.cpp:4-8 -template -class allocator {}; -template -class char_traits {}; -template , typename A = std::allocator> Would it make sense to add

[PATCH] D145313: [clang-tidy] Make readability-container-size-empty check using header

mikecrowe added a comment. In D145313#4169790 , @carlosgalvezp wrote: > Could you upload the patch with full context? I believe you need to do > something like `git show HEAD -U99` as per the guidelines > . O

[PATCH] D145304: [clang-tidy] altera-id-dependent-backward-branch: refactor test

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145304/new/ https://reviews.llvm.org/D145304

[PATCH] D145304: [clang-tidy] altera-id-dependent-backward-branch: refactor test

carlosgalvezp added a comment. It seems I'm having trouble to download the patch with arcanist, would you mind rebasing on top of the main branch? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145304/new/ https://reviews.llvm.org/D145304

[PATCH] D145304: [clang-tidy] altera-id-dependent-backward-branch: refactor test

yeputons-gh added a comment. Absolutely, give we few minutes. Maybe it conflicts with the previous revision that has already landed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145304/new/ https://reviews.llvm.org/D145304 __

[PATCH] D145304: [clang-tidy] altera-id-dependent-backward-branch: refactor test

yeputons-gh updated this revision to Diff 502442. yeputons-gh added a comment. Rebased on top of the recent 'main'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145304/new/ https://reviews.llvm.org/D145304 Files: clang-tools-extra/test/clang-t

[PATCH] D145305: [clang-tidy] altera-id-dependent-backward-branch: do not mark all variables

yeputons-gh updated this revision to Diff 502445. yeputons-gh added a comment. Rebased on top of the recent `main`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145305/new/ https://reviews.llvm.org/D145305 Files: clang-tools-extra/clang-tidy/al

[PATCH] D145321: [clang-tidy] altera-id-dependent-backward-branch: fix direct assignment notes

yeputons-gh created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. yeputons-gh requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Previously a note

[PATCH] D145321: [clang-tidy] altera-id-dependent-backward-branch: fix direct assignment notes

yeputons-gh updated this revision to Diff 502447. yeputons-gh added a comment. Test inferred assignments and fix notes for them as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145321/new/ https://reviews.llvm.org/D145321 Files: clang-tool

[clang-tools-extra] 9fda832 - [clang-tidy] altera-id-dependent-backward-branch: refactor test

Author: Egor Suvorov Date: 2023-03-05T18:22:10Z New Revision: 9fda8322243168cbfcb78c4cf80afa838473a573 URL: https://github.com/llvm/llvm-project/commit/9fda8322243168cbfcb78c4cf80afa838473a573 DIFF: https://github.com/llvm/llvm-project/commit/9fda8322243168cbfcb78c4cf80afa838473a573.diff LOG:

[PATCH] D145304: [clang-tidy] altera-id-dependent-backward-branch: refactor test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9fda83222431: [clang-tidy] altera-id-dependent-backward-branch: refactor test (authored by yeputons-gh, committed by carlosgalvezp). Repository:

[PATCH] D145304: [clang-tidy] altera-id-dependent-backward-branch: refactor test

carlosgalvezp added a comment. In D145304#4169810 , @yeputons-gh wrote: > Absolutely, give we few minutes. Maybe it conflicts with the previous > revision that has already landed? I believe so. I'm quite new to arcanist so I might be missing some trick

[PATCH] D145321: [clang-tidy] altera-id-dependent-backward-branch: fix assignment notes

yeputons-gh added inline comments. Comment at: clang-tools-extra/clang-tidy/altera/IdDependentBackwardBranchCheck.cpp:126 IdDepFieldsMap[Field] = IdDependencyRecord( Field, Statement->getBeginLoc(), Twine("assignment of ID-dependent field ") + Field->getNameAsSt

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

PiotrZSL marked 4 inline comments as done. PiotrZSL added a comment. "But maybe when we emit a warning for a specified include, we could put it in a set to not warn on that include again" I don't think so, in such case we hide include paths, and most of the time header guards should help here in

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

PiotrZSL updated this revision to Diff 502464. PiotrZSL added a comment. Added support for --include Added support for self-include of source file Added more tests Reworked include stack. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144828/new/ ht

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

PiotrZSL added a comment. TODO: Add option: ExcludeHeadersRegexp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144828/new/ https://reviews.llvm.org/D144828 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

PiotrZSL planned changes to this revision. PiotrZSL added a comment. Option need to be added Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144828/new/ https://reviews.llvm.org/D144828 ___ cfe-commits mai

[PATCH] D144036: [clang-tidy] Add bugprone-enum-to-bool-conversion check

PiotrZSL planned changes to this revision. PiotrZSL added a comment. Documentation to be updated, option need to be changed to list Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144036/new/ https://reviews.llvm.org/D144036

[PATCH] D144135: [clang-tidy] Add performance-enum-size check

PiotrZSL planned changes to this revision. PiotrZSL added a comment. Option need to be changed from Regex to List Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144135/new/ https://reviews.llvm.org/D144135 __

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach updated this revision to Diff 502474. dmaclach added a comment. Moved to `REQUIRES: asan-static-runtime` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672 Files: clang/include/clang/Basic/Diagnos

[clang] 7f8d844 - [CodeGen] guarantee variable templates are initialized in the reverse instantiation order

Author: Yuanfang Chen Date: 2023-03-05T15:31:23-08:00 New Revision: 7f8d844df5e91f8f689d0e9658e811d21bc4a605 URL: https://github.com/llvm/llvm-project/commit/7f8d844df5e91f8f689d0e9658e811d21bc4a605 DIFF: https://github.com/llvm/llvm-project/commit/7f8d844df5e91f8f689d0e9658e811d21bc4a605.diff

[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE_OPTION`

yaxunl created this revision. yaxunl added reviewers: tra, b-sumner, arsenm. Herald added subscribers: kosarev, kerbowa, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: wdng. Predefine `__AMDGCN_CUMODE_OPTION` as

[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE_OPTION`

arsenm added a comment. I think exposing whether or not the flag was used is weird/broken, as is including _OPTION in the name. Should just define to whether it's enabled or not CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145343/new/ https://reviews.llvm.org/D145343

[PATCH] D145344: [clang-format] Don't annotate left brace of class as FunctionLBrace

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `l_brace` of

[PATCH] D145345: [HIP] Fix regression about `__fp16` args and return value

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: kosarev, kerbowa, jvesely. Herald added a project: All. yaxunl requested review of this revision. HIP allows `__fp16` as function arguments and return value by passing `-fallow-half-arguments-and-returns` to clan

[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE_OPTION`

yaxunl added a comment. In D145343#4170250 , @arsenm wrote: > I think exposing whether or not the flag was used is weird/broken, as is > including _OPTION in the name. Should just define to whether it's enabled or > not I agree. @b-sumner What do you t

[PATCH] D145346: [clang][ast]: refactor printstmt merge the two for loop

zkkxu created this revision. zkkxu added reviewers: arcbbb, craig.topper. Herald added a project: All. zkkxu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145346 Files: c

[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE_OPTION`

b-sumner added a comment. In D145343#4170305 , @yaxunl wrote: > In D145343#4170250 , @arsenm wrote: > >> I think exposing whether or not the flag was used is weird/broken, as is >> including _OPTION in the name.

[PATCH] D144454: Add builtin for llvm set rounding

xiongji90 updated this revision to Diff 502507. xiongji90 added a comment. Update the builtin name to __builtin_set_flt_rounds and restrict it to be used only on x86, x86_64, arm, aarch64 target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144454

[PATCH] D145346: [NFC] Format printstmt

zkkxu updated this revision to Diff 502510. zkkxu added a comment. 1. Updating D145346 : [NFC] Format printstmt # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subject, next lines as comment. # 4. If you intend

[clang] 5b769ff - [NFC] Add an invalid test case for C++20 Modules

Author: Chuanqi Xu Date: 2023-03-06T14:39:32+08:00 New Revision: 5b769ff3e6a47eb2ffe8aa9e86f701ef046cf0a9 URL: https://github.com/llvm/llvm-project/commit/5b769ff3e6a47eb2ffe8aa9e86f701ef046cf0a9 DIFF: https://github.com/llvm/llvm-project/commit/5b769ff3e6a47eb2ffe8aa9e86f701ef046cf0a9.diff LO