mikecrowe added a comment. In D145313#4169790 <https://reviews.llvm.org/D145313#4169790>, @carlosgalvezp wrote:
> Could you upload the patch with full context? I believe you need to do > something like `git show HEAD -U999999` as per the guidelines > <https://llvm.org/docs/Phabricator.html>. Otherwise `arc diff` should do the > job automatically. Reason I ask is that I cannot see the new line numbers > referred to by the `note` comments - Phab says "Context not available". Of course. It had been sufficiently long since I last uploaded a new diff that I forgot that part of the instructions and just used `git format-patch` for this batch. I shall try to learn how to use `arc diff` because the copying and pasting of diffs was getting rather tedious and I knew I was bound to make a mistake with it eventually. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145313/new/ https://reviews.llvm.org/D145313 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits