[PATCH] D142627: [analyzer] Fix crash exposed by D140059

steakhal added a comment. I'm backporting this to clang-16. https://github.com/llvm/llvm-project/issues/61149 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142627/new/ https://reviews.llvm.org/D142627 __

[PATCH] D127259: [CodeGen] guarantee templated static variables are initialized in the reverse instantiation order

ychen added a comment. In D127259#4156314 , @erichkeane wrote: > I don't see much compile-time concerns myself, Indeed. http://llvm-compile-time-tracker.com/compare.php?from=54faf22f7b947464a070669711100211e87f3ea8&to=ad87d0dbd44f3a8f66c31fa9b731aea34c

[PATCH] D127259: [CodeGen] guarantee templated static variables are initialized in the reverse instantiation order

ychen updated this revision to Diff 502068. ychen added a comment. This revision is now accepted and ready to land. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127259/new/ https://reviews.llvm.org/D127259 Files: clang/include/clang/Se

[clang] e423885 - [CodeGen] guarantee templated static variables are initialized in the reverse instantiation order

Author: Yuanfang Chen Date: 2023-03-03T00:12:28-08:00 New Revision: e423885e272c0e57c6d240d07bc934e0a8649417 URL: https://github.com/llvm/llvm-project/commit/e423885e272c0e57c6d240d07bc934e0a8649417 DIFF: https://github.com/llvm/llvm-project/commit/e423885e272c0e57c6d240d07bc934e0a8649417.diff

[PATCH] D127259: [CodeGen] guarantee templated static variables are initialized in the reverse instantiation order

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe423885e272c: [CodeGen] guarantee templated static variables are initialized in the reverse… (authored by ychen). Repository: rG LLVM Github Monor

[PATCH] D145034: [Clang][Sema] Preparations to fix handling of out-of-line definitions of constrained templates

alexander-shaposhnikov updated this revision to Diff 502067. alexander-shaposhnikov added a comment. 1/ Add support for out-of-line definitions of member enums + add tests 2/ Updated comments DeclSpec.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] be437f3 - [clang][RISCV] Enable -fasynchronous-unwind-tables by default on Linux

Author: Kito Cheng Date: 2023-03-03T16:13:53+08:00 New Revision: be437f3bb8b657f4d2de4603734f24daa624d204 URL: https://github.com/llvm/llvm-project/commit/be437f3bb8b657f4d2de4603734f24daa624d204 DIFF: https://github.com/llvm/llvm-project/commit/be437f3bb8b657f4d2de4603734f24daa624d204.diff LO

[PATCH] D145164: [clang][RISCV] Enable -fasynchronous-unwind-tables by default on Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe437f3bb8b6: [clang][RISCV] Enable -fasynchronous-unwind-tables by default on Linux (authored by kito-cheng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 27ab138 - [clang][ASTImporter] Import TemplateName correctly

Author: Balázs Kéri Date: 2023-03-03T09:16:43+01:00 New Revision: 27ab138c69fc61b22ef898a0f4d0f5c9bad649bd URL: https://github.com/llvm/llvm-project/commit/27ab138c69fc61b22ef898a0f4d0f5c9bad649bd DIFF: https://github.com/llvm/llvm-project/commit/27ab138c69fc61b22ef898a0f4d0f5c9bad649bd.diff L

[PATCH] D144622: [clang][ASTImporter] Import TemplateName correctly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27ab138c69fc: [clang][ASTImporter] Import TemplateName correctly (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D144622

[PATCH] D145150: clang: Emit nofpclass(nan inf) for -ffinite-math-only

nikic resigned from this revision. nikic added a comment. (Sounds reasonable conceptually, but I'm not familiar enough with clang codegen for the details.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145150/new/ https://reviews.llvm.org/D145150 __

[PATCH] D145034: [Clang][Sema] Preparations to fix handling of out-of-line definitions of constrained templates

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:1677-1678 CXXScopeSpec Spec; +if (TemplateInfo.TemplateParams) + Spec.setTemplateParamLists(*TemplateInfo.TemplateParams); + rsmith wrote: > I think we'll nee

[PATCH] D115456: [MS] Implement on-demand TLS initialization for Microsoft CXX ABI

doughnutlifetime added a comment. Herald added a project: All. @dumb ways to die This article was very helpful to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115456/new/ https://reviews.llvm.org/D115456 __

[clang] 2408f97 - Recommit [C++20] [Modules] Trying to compare the trailing require clause from the primary template function

Author: Chuanqi Xu Date: 2023-03-03T17:27:37+08:00 New Revision: 2408f97652caadf733a879e1d7d9c0702a80d609 URL: https://github.com/llvm/llvm-project/commit/2408f97652caadf733a879e1d7d9c0702a80d609 DIFF: https://github.com/llvm/llvm-project/commit/2408f97652caadf733a879e1d7d9c0702a80d609.diff LO

[PATCH] D144603: Add option to disable compiler launcher on external projects

phosek added a comment. In D144603#4165569 , @fangism wrote: > In D144603#4163751 , @phosek wrote: > >> In D144603#4162974 , @haowei wrote: >> >>> I think remove the compi

[PATCH] D145187: [Fuchsia] Add other necessary components to LLDB install.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145187/new/ https://reviews.llvm.org/D145187 ___

[PATCH] D145074: [clang][RISCV] Fix ABI lowering for _Float16 for FP ABIs

kito-cheng added a comment. LGTM, just a nit :) Comment at: clang/test/CodeGen/RISCV/riscv64-abi.c:1909 - NOTE: These prefixes are unused and the list is autogenerated. Do not add tests below this line: -// LP64F: {{.*}} This seems removed accidentally, I

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 502084. VitaNuo marked 23 inline comments as done. VitaNuo added a comment. Improve test coverage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-tool

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo marked an inline comment as done. VitaNuo added a comment. Thank you for all the thoughtful comments! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:414 + +std::string findResolvedPath(const include_cleaner::Header &SymProvider) { + std::string ResolvedPath; -

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

kpdev42 created this revision. kpdev42 added reviewers: DavidSpickett, echristo. kpdev42 added a project: LLVM. Herald added subscribers: yaneury, supersymetrie, Chia-hungDuan, s.egerton, ormris, cryptoad, simoncook, hiraditya, kristof.beyls. Herald added a reviewer: aaron.ballman. Herald added a

[PATCH] D144273: [clang][ASTImporter] Add VaList declaration to lookup table.

balazske updated this revision to Diff 502089. balazske added a comment. Changed the lit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144273/new/ https://reviews.llvm.org/D144273 Files: clang/lib/AST/ASTImporterLookupTable.cpp clang/tes

[PATCH] D144273: [clang][ASTImporter] Add VaList declaration to lookup table.

balazske added a comment. The new test should be better, it imports the `f` function without `new` and no VaList should exist in the imported translation unit. It looks like the `test.cpp` is appended to the AST after the import of the other files. I changed function `CreateVaListDecl` to alway

[clang] 71b0658 - [NVPTX] Add f16 and v2f16 ldg builtins

Author: Jakub Chlanda Date: 2023-03-03T12:49:18+01:00 New Revision: 71b06585857a77691761a7bfd16b5b91454a6894 URL: https://github.com/llvm/llvm-project/commit/71b06585857a77691761a7bfd16b5b91454a6894 DIFF: https://github.com/llvm/llvm-project/commit/71b06585857a77691761a7bfd16b5b91454a6894.diff

[PATCH] D145228: [clangd] Add clangd headers to install targets

ivanmurashko created this revision. ivanmurashko added reviewers: sammccall, alexfh, smeenai, aaron.ballman. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ivanmurashko requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Hera

[PATCH] D144961: [NVPTX] Add f16 and v2f16 ldg builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG71b06585857a: [NVPTX] Add f16 and v2f16 ldg builtins (authored by jchlanda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144961/new/ https://reviews.llvm.

[PATCH] D144273: [clang][ASTImporter] Add VaList declaration to lookup table.

donat.nagy accepted this revision. donat.nagy added a comment. LGTM, the test result sounds promising, let's hope that it'll work in the CI as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144273/new/ https://reviews.llvm.org/D144273 __

[PATCH] D145229: [analyzer] Improve the documentation of the alpha.security.taint.TaintPropagation checker

dkrupp created this revision. dkrupp added a project: clang. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. dkrupp requested review of th

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

usama54321 added inline comments. Comment at: compiler-rt/test/asan/TestCases/replaceable_new_delete_static.cpp:10-11 + +// darwin only supports shared-libsan, so this should fail. +// XFAIL: darwin + yln wrote: > zixuw wrote: > > dmaclach wrote: > > > yln wrot

[PATCH] D144967: [PowerPC] Recognize long CPU name for -mtune in Clang

amyk added a comment. In D144967#4164858 , @nathanchance wrote: > Could this be merged into `main` and backported to `release/16.x`? If this > makes 16.0.0 final, I think the kernel can avoid working around this issue > altogether, as `-mtune` was only

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added a comment. @kiranchandramohan I've added the MLIR test as requested. Please let me know if any other changes are required :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

mgabka added a comment. In D144179#4146599 , @MaskRay wrote: > This looks like introducing a footgun (when something behaves differently > from an upstream Clang, it would be difficult for toolchain maintainers to > know why). > Why can't your user spec

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin updated this revision to Diff 502110. DmitryPolukhin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clangd/CompileCommands.cpp clang-to

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan requested changes to this revision. kiranchandramohan added a comment. This revision now requires changes to proceed. Thanks for making the change. I am still going through the patch, I have a few comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBu

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin updated this revision to Diff 502112. jrmolin added a comment. Finally figured out how to run the latest `git-clang-format` on the code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.org/D125171 Files: cla

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

DavidSpickett added a comment. I'm not familiar with the details of toolchain config, but added some general comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1404 + // OHOS-specific defaults for PIC/PIE + if (Triple.isOHOSFamily()) { +switch (Triple.getAr

[PATCH] D145238: [NVPTX] Expose LDU builtins

jchlanda created this revision. jchlanda added a reviewer: tra. Herald added subscribers: mattd, gchakrabarti, asavonic. Herald added a project: All. jchlanda requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jholewinski. Herald added projects: clang, LLVM. Al

[PATCH] D65956: clang: Diag running out of file handles while looking for files

karies added a comment. Herald added a project: All. Similar to the concern raised at https://github.com/llvm/llvm-project/commit/50fcf7285eeb001d751eadac5d001a0e216fd701 we have received user reports about this patch: with `-Ino-access-permissions -Iall-good`, clang will throw an error (EACCES

[PATCH] D145178: [clang][NFC] reformats the SARIF diagnostic test so it's human readable

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, this is incremental progress. Hopefully we won't be adding too many more RUN lines to this file though (sticking too many tests into one file is also tech debt). Reposito

[PATCH] D145244: [clang-format] Add ability to trace tokens.

klimek created this revision. klimek added a reviewer: sammccall. Herald added a project: All. klimek requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145244 Files: clang/lib/Format/CMakeLists.txt clang/lib/Form

[PATCH] D145244: [clang-format] Add ability to trace tokens.

klimek updated this revision to Diff 502123. klimek added a comment. Remove superfluous include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145244/new/ https://reviews.llvm.org/D145244 Files: clang/lib/Format/CMakeLists.txt clang/lib/Format

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

aaron.ballman added a comment. It looks like there's a valid precommit CI failure that needs to be addressed: Failed Tests (1): Clang :: Frontend/sarif-diagnostics.cpp Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:214 void SARIFDiagnostic::em

[PATCH] D142328: [clang][Interp] Fix compound assign operator types

steakhal added a comment. Hi @tbaeder, I was looking for commits that mentions "fix" "assertion" or "crash" in the title, that are part of the `main` branch but not backported to `release/16.x` to be eventually released as `clang-16`. I wonder what's the status of this and the related patches gi

[PATCH] D144967: [PowerPC] Recognize long CPU name for -mtune in Clang

nathanchance added a comment. @amyk thank you so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144967/new/ https://reviews.llvm.org/D144967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D142384: [C++20] Fix a crash with modules.

steakhal added a comment. @usaxena95 @ilya-biryukov, @hans, I wonder if we should backport this change to `release/16.x`. Otherwise, clang-16 won't have this fix. WDYT? I'm also a bit worried that we don't have tests. And that we have "unexpected" sideeffects like what you mentioned @hans. Give

[PATCH] D144546: [clang][dataflow] Fix assert for CXXConstructExpr argument number

steakhal added a comment. By looking at the title, I get the impression that this fixes an assertion violation. I also observed that this commit is part of `main` but not part of `release/16.x`, hence the `clang-16` would be released without this fix. I want to raise awareness of backporting cr

[PATCH] D145098: [clang][deps] Preserve input ordering in the full output

Jake-Egan added a comment. Hi, this new test fails on AIX, could you take a look please? https://lab.llvm.org/buildbot/#/builders/214/builds/6148/steps/6/logs/FAIL__Clang__modules-full-output-tu-order_c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D127259: [CodeGen] guarantee templated static variables are initialized in the reverse instantiation order

shafik added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:19907 + if (Iter != I.end()) { +SemaRef.PendingInstantiations.push_back(*Iter); +I.erase(Iter); Doesn't this invalidate the iterators? Repository: rG LLVM

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon updated this revision to Diff 502134. agozillon added a comment. - [MLIR][OpenMP] Fix attribute helpers to apply to more than builtin.module - [Flang][mlir] Adding space at the end of the omp-is-device test file - [Clang][Flang][Driver][Test] Add flang-omp.f90 to test fopenmp/fopenmp-is

[PATCH] D145229: [analyzer] Improve the documentation of the alpha.security.taint.TaintPropagation checker

donat.nagy added inline comments. Comment at: clang/docs/analyzer/checkers.rst:78-80 +The ``SuppressAddressSpaces`` option suppresses warnings for null dereferences of all pointers with address spaces. You can disable this behavior with the option Why is this p

[PATCH] D143418: [libclang] Add API to override preamble storage path

aaron.ballman added inline comments. Comment at: clang/include/clang-c/Index.h:329 + * CXIndexOptions Opts = { sizeof(CXIndexOptions), + * clang_getDefaultGlobalOptions() }; + * \endcode vedgy wrote: > aaron.ballman wrote: > > vedgy wrote:

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach updated this revision to Diff 502138. dmaclach marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach added a comment. Went with unsupported. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon updated this revision to Diff 502139. agozillon added a comment. - [Flang][MLIR][Test] Add newline at end of test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144864/new/ https://reviews.llvm.org/D144864 Files: clang/include/clan

[clang] 4679d7a - [NFC][ARM][AArch64] Cleanup TargetParser includes

Author: Archibald Elliott Date: 2023-03-03T16:24:55Z New Revision: 4679d7a26a5f42f1128fac6fdf49488d13066c52 URL: https://github.com/llvm/llvm-project/commit/4679d7a26a5f42f1128fac6fdf49488d13066c52 DIFF: https://github.com/llvm/llvm-project/commit/4679d7a26a5f42f1128fac6fdf49488d13066c52.diff

[PATCH] D143751: [clang][analyzer][NFC] Refactor code of StdLibraryFunctionsChecker.

balazske updated this revision to Diff 502143. balazske added a comment. changed comments, small variable rename Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143751/new/ https://reviews.llvm.org/D143751 Files: clang/lib/StaticAnalyzer/Checkers/

[clang] 637ce0f - [C2x] Claim support for WG14 N2838

Author: Aaron Ballman Date: 2023-03-03T11:57:21-05:00 New Revision: 637ce0f7139015735d7e50cf12ad312a382f6283 URL: https://github.com/llvm/llvm-project/commit/637ce0f7139015735d7e50cf12ad312a382f6283 DIFF: https://github.com/llvm/llvm-project/commit/637ce0f7139015735d7e50cf12ad312a382f6283.diff

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142907/new/ https://reviews.llvm.org/D142907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D145251: [clang] Treat function parameter scope as an immediate function context

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This results in expressions that appear in default function argument not being checked for being actual constant express

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon added a comment. The new update adds the suggested new tests! Thank you very much @awarzynski for suggesting them that was a great help. Hopefully the new additions cover what you have requested, if not I am of course happy to change or add more tests as needed. Co

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

yln added inline comments. Comment at: compiler-rt/test/asan/TestCases/replaceable_new_delete_static.cpp:10-11 + +// darwin only supports shared-libsan, so this should fail. +// XFAIL: darwin + usama54321 wrote: > yln wrote: > > zixuw wrote: > > > dmaclach wrot

[PATCH] D143751: [clang][analyzer][NFC] Refactor code of StdLibraryFunctionsChecker.

balazske updated this revision to Diff 502153. balazske added a comment. rebase, reformatted code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143751/new/ https://reviews.llvm.org/D143751 Files: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunct

[PATCH] D145093: Add map info for dereference pointer.

jyu2 updated this revision to Diff 502144. jyu2 added a comment. Thanks Alexey for the code review. I removed loop by using last expression in the component for checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145093/new/ https://reviews.l

[PATCH] D145093: Add map info for dereference pointer.

jyu2 marked an inline comment as done. jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7487-7497 + auto TNext = Next; + bool IsVarDerefAssoWithArray = false; + if (UO && UO->getOpcode() == UO_Deref) +for (; TNext != CE; TNext =

[PATCH] D145093: Add map info for dereference pointer.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7489-7493 + if (UO && UO->getOpcode() == UO_Deref) +if (isa(Last->getAssociatedExpression()) || +isa(Last->getAssociatedExpression()) || +isa(Last->getAssociatedE

[PATCH] D144454: Add builtin for llvm set rounding

rjmccall added a comment. Okay, so if we're adding this builtin, and it's not just imitating a stdlib function, we should definitely document it as a language extension. There's a section in the manual about controlling FP modes which is probably an appropriate place for this. I assume we nee

[clang] 34d6a6e - Fix bots by adding a triple to the test

Author: Aaron Ballman Date: 2023-03-03T12:26:52-05:00 New Revision: 34d6a6e23a6d8d78c86fad06bc219107ce6b5780 URL: https://github.com/llvm/llvm-project/commit/34d6a6e23a6d8d78c86fad06bc219107ce6b5780 DIFF: https://github.com/llvm/llvm-project/commit/34d6a6e23a6d8d78c86fad06bc219107ce6b5780.diff

[clang] 7ac0551 - [HLSL] add max/min library functions

Author: Joshua Batista Date: 2023-03-03T09:31:50-08:00 New Revision: 7ac0551e77f4adab18f3ac6ae428d4c09f9b6c49 URL: https://github.com/llvm/llvm-project/commit/7ac0551e77f4adab18f3ac6ae428d4c09f9b6c49 DIFF: https://github.com/llvm/llvm-project/commit/7ac0551e77f4adab18f3ac6ae428d4c09f9b6c49.diff

[PATCH] D144309: [HLSL] add max/min library functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ac0551e77f4: [HLSL] add max/min library functions (authored by bob80905). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144309/new/ https://reviews.llvm.or

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. > Thank you very much @awarzynski for suggesting them that was a great help. I'm happy that I could help :) The driver logic LGTM, but please wait for either @jdoerfert and/or @kiranch

[PATCH] D142800: [Clang][Diagnostic] Add `-Wcomparison-op-parentheses` to warn on chained comparisons

hazohelet updated this revision to Diff 502166. hazohelet added a comment. Update the differential - Revise warning messages based on ideas from @aaron.ballman. - Introduce a new warning flag `-Wchaining-comparisons` that is enabled by default, to warn about chaining relationals or equal operato

[PATCH] D142800: [Clang][Diagnostic] Add `-Wcomparison-op-parentheses` to warn on chained comparisons

hazohelet added a comment. In D142800#4165090 , @aaron.ballman wrote: > In D142800#4104241 , @hazohelet > wrote: > >>> Also, why are these diagnostics off by default? Do we have some idea as to >>> the false po

[clang] c65fb80 - [Fuchsia] Add other necessary components to LLDB install.

Author: Daniel Thornburgh Date: 2023-03-03T10:07:08-08:00 New Revision: c65fb80b73aa5087a4bba79e61d96b4d652e1b54 URL: https://github.com/llvm/llvm-project/commit/c65fb80b73aa5087a4bba79e61d96b4d652e1b54 DIFF: https://github.com/llvm/llvm-project/commit/c65fb80b73aa5087a4bba79e61d96b4d652e1b54.d

[PATCH] D145187: [Fuchsia] Add other necessary components to LLDB install.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc65fb80b73aa: [Fuchsia] Add other necessary components to LLDB install. (authored by mysterymath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145187/new/

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 502175. TIFitis marked 7 inline comments as done. TIFitis added a comment. Addressed reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Files: clang/

[PATCH] D143128: [-Wunsafe-buffer-usage] Fix-Its transforming `&DRE[any]` to `(DRE.data() + any)`

jkorous added a comment. This is an interesting topic. In the abstract I see the question as should the Fix-Its prioritize how the code will fit the desired end state (presumably modern idiomatic C++) or carefully respect the state of the code as is now. The only thing I feel pretty strongly ab

[clang] 3ac8d32 - [clang][deps] Fix test failing on AIX

Author: Jan Svoboda Date: 2023-03-03T10:22:39-08:00 New Revision: 3ac8d322100bc72aaacb67f13eb21d9b644f9930 URL: https://github.com/llvm/llvm-project/commit/3ac8d322100bc72aaacb67f13eb21d9b644f9930 DIFF: https://github.com/llvm/llvm-project/commit/3ac8d322100bc72aaacb67f13eb21d9b644f9930.diff L

[PATCH] D145098: [clang][deps] Preserve input ordering in the full output

jansvoboda11 added a comment. In D145098#4167163 , @Jake-Egan wrote: > Hi, this new test fails on AIX, could you take a look please? > https://lab.llvm.org/buildbot/#/builders/214/builds/6148/steps/6/logs/FAIL__Clang__modules-full-output-tu-order_c `-fno

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4052-4060 + // LLVM utilities like blocks with terminators. + auto *UI = Builder.CreateUnreachable(); + Instruction *ThenTI = UI, *ElseTI = nullptr; + if (IfCond) { +SplitBlockAndInsertIf

[PATCH] D145178: [clang][NFC] reformats the SARIF diagnostic test so it's human readable

cjdb added a comment. In D145178#4167103 , @aaron.ballman wrote: > LGTM, this is incremental progress. Hopefully we won't be adding too many > more RUN lines to this file though (sticking too many tests into one file is > also tech debt). Thanks! 100%

[PATCH] D143128: [-Wunsafe-buffer-usage] Fix-Its transforming `&DRE[any]` to `(DRE.data() + any)`

ymandel added a comment. In D143128#4167626 , @jkorous wrote: > This is an interesting topic. In the abstract I see the question as: "Should > the Fix-Its prioritize how the code will fit the desired end state > (presumably modern idiomatic C++) or care

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon added a comment. Thank you very much @awarzynski I will wait for further approval! Comment at: clang/test/Driver/flang/flang-omp.f90:1 +! Check that flang -fc1 is invoked when in --driver-mode=flang +! and the relevant openmp and openmp offload flags are utilised ---

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

usama54321 added inline comments. Comment at: compiler-rt/test/asan/TestCases/replaceable_new_delete_static.cpp:10-11 + +// darwin only supports shared-libsan, so this should fail. +// XFAIL: darwin + yln wrote: > usama54321 wrote: > > yln wrote: > > > zixuw wr

[PATCH] D142328: [clang][Interp] Fix compound assign operator types

tbaeder added a comment. All the interpreter work is experimental so it doesn't really need to be in the release branch. This should all be fine, thanks for asking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142328/new/ https://reviews.llvm.org

[PATCH] D145256: [clang/Diagnostic] Use `optional` to disambiguate between a `StoredDiagMessage` that is not set vs set as empty string

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. "But when would you have a completely empty diagnostic message", you ask dear reader? That is when there is an empty "#warn

[PATCH] D145228: [clangd] Add clangd headers to install targets

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145228/new/ https://reviews.llvm.org/D145228 _

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

cjdb updated this revision to Diff 502186. cjdb added a comment. Herald added a subscriber: mgrang. sorts artifacts so that they're output in index order Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145201/new/ https://reviews.llvm.org/D145201 Fi

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

cjdb added a comment. That test is kinda problematic because it seems that the artifacts aren't ordered. I think we should change this from a Comment at: clang/lib/Basic/Sarif.cpp:314-317 + llvm::sort(*Artifacts, [](const json::Value &x, const json::Value &y) { +return x.

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

cjdb updated this revision to Diff 502190. cjdb added a comment. fixes string goof Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145201/new/ https://reviews.llvm.org/D145201 Files: clang/include/clang/Frontend/SARIFDiagnostic.h clang/lib/Basic

[PATCH] D145256: [clang/Diagnostic] Use `optional` to disambiguate between a `StoredDiagMessage` that is not set vs set as empty string

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145256/new/ https://reviews.llvm.org/D145256 ___

[PATCH] D145256: [clang/Diagnostic] Use `optional` to disambiguate between a `StoredDiagMessage` that is not set vs set as empty string

akyrtzi updated this revision to Diff 502201. akyrtzi added a comment. Avoid passing a new `IgnoringDiagConsumer` for the test since it's unused. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145256/new/ https://reviews.llvm.org/D145256 Files: c

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6327 } - if (Arg *A = Args.getLastArgNoClaim(options::OPT_p)) { + if (Arg *A = Args.getLastArg(options::OPT_p)) { if (TC.getTriple().isOSAIX()) { daltenty wrote: > Actually

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 502204. francii added a comment. Fix missing bracket Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/T

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon added inline comments. Comment at: clang/test/Driver/flang/flang-omp.f90:1 +! Check that flang -fc1 is invoked when in --driver-mode=flang +! and the relevant openmp and openmp offload flags are utilised agozillon wrote: > awarzynski wrote: > > This te

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

owenpan added a comment. Please see https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.org/D125171 _

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

owenpan added a comment. See also https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.org/D125171 ___

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

jaredgrubb created this revision. jaredgrubb added reviewers: HazardyKnusperkeks, djasper, egorzhdan. jaredgrubb added a project: clang-format. Herald added a project: All. jaredgrubb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I notice

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

owenpan added a comment. Please add unit tests to relevant files in `clang/unittests/Format/`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.org/D125171 ___ cfe-commits m

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

HazardyKnusperkeks added a comment. Please reupload with the complete context. Please add tests. Comment at: clang/include/clang/Format/Format.h:827 + /// \code + /// someFunction( + /// int argument1, That's not a valid declaration (missing return

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

HazardyKnusperkeks added reviewers: rymiel, owenpan, MyDeveloperDay. HazardyKnusperkeks added a comment. Our tests reside in `clang/unittests/Format`, you want to look into the `TokenAnnotatorTests`. In fact **I** can't read the tests you wrote there. And could you please provide an example what

[PATCH] D145264: [OpenMP][MLIR] Lower and apply RTLModuleFlagsAttr

agozillon created this revision. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, awarzynski, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle,

  1   2   >