steakhal added a comment.
By looking at the title, I get the impression that this fixes an assertion
violation.
I also observed that this commit is part of `main` but not part of
`release/16.x`, hence the `clang-16` would be released without this fix.
I want to raise awareness of backporting crash fixes to llvm releases. IMO
that's a good practice.
So my question is, should we backport this patch to the release branch?
If so, could you please check if there are more commits like this for the
dataflow library @ymandel?
I used `git log release/16.x..main --oneline
clang/lib/{Analysis,AST,ASTMatchers,StaticAnalyzer}
clang/include/clang/{Analysis,AST,ASTMatchers,StaticAnalyzer} | grep -i
'crash\|fix\|assert'` to check for relevant commits.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144546/new/
https://reviews.llvm.org/D144546
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
