[PATCH] D143560: clang-format.el: fix warnings

augfab marked 5 inline comments as done. augfab added a comment. All comments were addressed, marking them as Done. I don't have commit access, here's my name and email: Augustin Fabre . Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143560/new/ https://reviews.llvm.org/D14356

[PATCH] D144844: [C++20] [Modules] Offer -fno-import-inter-module-function-defs to avoid duplicated compilation in modules

ChuanqiXu created this revision. ChuanqiXu added reviewers: iains, Bigcheese, dblaikie. ChuanqiXu added a project: clang-modules. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Close https://g

[PATCH] D144780: Explicit cast on customized offsetof should not be ignored when evaluating as const

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I love it. Short, to the point. Thanks. I think this is the right way to fix this. Good job. Can you merge the change? Or should I do it on you behalf? Repository: rG LLVM Github Monorep

[clang-tools-extra] b6f4834 - [include-cleaner] Fix an unintended early return when checking the

Author: Haojian Wu Date: 2023-02-27T10:09:40+01:00 New Revision: b6f48341c5956a5b1d60ceb9963a2a9e5937788d URL: https://github.com/llvm/llvm-project/commit/b6f48341c5956a5b1d60ceb9963a2a9e5937788d DIFF: https://github.com/llvm/llvm-project/commit/b6f48341c5956a5b1d60ceb9963a2a9e5937788d.diff LO

[PATCH] D144709: [clang-format] Improve left to right const

AlexanderHederstaf updated this revision to Diff 500697. AlexanderHederstaf added a comment. Rebase after change to pointer to member was merged. Add case for typename used for nested dependent names. Add assertions for template closers/openers. Add commented-out tests for two cases where right t

[PATCH] D144709: [clang-format] Improve left to right const

AlexanderHederstaf marked 6 inline comments as done. AlexanderHederstaf added a comment. Fixed comments and rebased. Tested right to left on the output of left to right and discovered two cases where the output code would not compile. Added new tests for those cases and I am working on improveme

[PATCH] D144622: [clang[[ASTImporter] Import TemplateName correctly

balazske added a comment. I think these patches are fix for separate problems and can be applied independently. It is not better if these are moved into one change. The other patch D144273 is not finished (it can get bigger), and a test for this change is need

[PATCH] D125402: [clang][diag] warn if function returns class type by-const-value

cor3ntin added a comment. This has been sitting in the queue for a while, sorry about that. I think this makes sense in its current iteration, with the warning always on. Have you tried to build a large project like chrome with it? Comment at: clang/lib/Sema/SemaChecking.cpp:1

[PATCH] D144626: [C++20] [Modules] Trying to compare the trailing require clause of the primary template when performing ODR checking

cor3ntin added a comment. In D144626#4154122 , @ChuanqiXu wrote: > In D144626#4150378 , @erichkeane > wrote: > >> That looks reasonable to me, though I fear all the libcxx failures are going >> to be related to

[PATCH] D144853: [Clang][RISCV] Add CMake options to configure default CPU

pcwang-thead created this revision. pcwang-thead added reviewers: asb, jrtc27, kito-cheng, craig.topper, reames, eopXD. Herald added subscribers: luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, Mar

[PATCH] D144626: [C++20] [Modules] Trying to compare the trailing require clause of the primary template when performing ODR checking

ChuanqiXu updated this revision to Diff 500703. ChuanqiXu added a comment. Rebase and push again to trigger the bot. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144626/new/ https://reviews.llvm.org/D144626 Files: clang/lib/AST/ASTContext.cpp clang/test/Modules/pr60890.cppm Index

[PATCH] D144780: Explicit cast on customized offsetof should not be ignored when evaluating as const

danix800 added a comment. In D144780#4154487 , @steakhal wrote: > I love it. Short, to the point. Thanks. > I think this is the right way to fix this. > Good job. > Can you merge the change? Or should I do it on you behalf? I've no permission to merge, p

[PATCH] D144709: [clang-format] Improve left to right const

AlexanderHederstaf updated this revision to Diff 500710. AlexanderHederstaf added a comment. Fix simple types not moving all the way right. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144709/new/ https://reviews.llvm.org/D144709 Files: clang/l

[clang] 95c3c2b - [clang-format] clang-format.el: fix warnings

Author: Augustin Fabre Date: 2023-02-27T01:56:24-08:00 New Revision: 95c3c2b8570d307ad91c603856336acf32e5021f URL: https://github.com/llvm/llvm-project/commit/95c3c2b8570d307ad91c603856336acf32e5021f DIFF: https://github.com/llvm/llvm-project/commit/95c3c2b8570d307ad91c603856336acf32e5021f.diff

[PATCH] D143560: clang-format.el: fix warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rG95c3c2b8570d: [clang-format] clang-format.el: fix warnings (authored by augfab, committed by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143560/n

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. @kadircet friendly ping, could you please take a look to this diff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 ___ cfe-comm

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

uabelho added a comment. I noticed that gvn-hoist doesn't handle this very nicely, I just wrote https://github.com/llvm/llvm-project/issues/61023 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.llvm.org/D136497 _

[PATCH] D143260: [clangd] Add semantic token for labels

ckandeler added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143260/new/ https://reviews.llvm.org/D143260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D144638: [lit] Detect Consistent File Access Times

michaelplatings added a comment. Thanks very much for looking into this, the flakiness of these tests has been bugging me for ages. Comment at: llvm/utils/lit/lit/llvm/config.py:171 +# in the tests that do the same thing. +(_, try_touch_err) = self.get_

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

0xdc03 updated this revision to Diff 500715. 0xdc03 edited the summary of this revision. 0xdc03 added a comment. - Update to address reviewer comments - Add release note - Redo notes to match reviewer comments - Make the fix-it highlight the whole attribute - Update tests to check new diagnostics

[PATCH] D143375: clang-tidy: Count template constructors in modernize-use-default-member-init

MarcoFalke updated this revision to Diff 500716. MarcoFalke added a comment. Thanks. Added release note. Lmk if I should go ahead and merge this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143375/new/ https://reviews.llvm.org/D143375 Files: clang-tools-extra/clang-tidy/modernize/U

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

0xdc03 added a comment. Okay, I have now modified the diagnostic to look something like (as per the discussion at https://discord.com/channels/636084430946959380/636732781086638081/1079356357024694363): ../../bug/ifunc-#59164.cpp:17:16: error: ifunc must point to a defined function __attri

[clang] f600a5a - [clang-format] Add macro replacement to fuzzing.

Author: Manuel Klimek Date: 2023-02-27T10:40:22Z New Revision: f600a5aec52c0aa56e4e47c992b6f10e5cd7b7af URL: https://github.com/llvm/llvm-project/commit/f600a5aec52c0aa56e4e47c992b6f10e5cd7b7af DIFF: https://github.com/llvm/llvm-project/commit/f600a5aec52c0aa56e4e47c992b6f10e5cd7b7af.diff LOG:

[clang] ec67d70 - [SVE] Add intrinsics for uniform dsp operations that explicitly undefine the result for inactive lanes.

Author: chendewen Date: 2023-02-27T18:44:55+08:00 New Revision: ec67d703cfb021c705510f9d626e2b800b155b79 URL: https://github.com/llvm/llvm-project/commit/ec67d703cfb021c705510f9d626e2b800b155b79 DIFF: https://github.com/llvm/llvm-project/commit/ec67d703cfb021c705510f9d626e2b800b155b79.diff LOG

[PATCH] D144704: [SVE] Add intrinsics for uniform dsp operations that explicitly undefine the result for inactive lanes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGec67d703cfb0: [SVE] Add intrinsics for uniform dsp operations that explicitly undefine the… (authored by dewen, committed by Allen). Herald added a

[PATCH] D144638: [lit] Detect Consistent File Access Times

lenary added a comment. Updates incoming to add a specific check for netbsd and windows, which are currently excluding the affected tests anyway. Comment at: llvm/utils/lit/lit/llvm/config.py:165 +# +# This check hopefully detects both cases, and disables tests that re

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

steakhal added a comment. First and foremost, I want to deeply apologize about my rushed response. When I say that the `Taint originated here` note remained, I **wrongly** draw conclusions. Won't happen again. __Taint-flow IDs__: I would challenge that we need a flow ID (number) because for me

[clang] 398cddf - [clang-format] Fix assertion that doesn't hold under fuzzing.

Author: Manuel Klimek Date: 2023-02-27T10:50:42Z New Revision: 398cddf6acecfb12b5997c2d639ee3cf31b787ad URL: https://github.com/llvm/llvm-project/commit/398cddf6acecfb12b5997c2d639ee3cf31b787ad DIFF: https://github.com/llvm/llvm-project/commit/398cddf6acecfb12b5997c2d639ee3cf31b787ad.diff LOG:

[PATCH] D144780: Explicit cast on customized offsetof should not be ignored when evaluating as const

steakhal added a comment. In D144780#4154619 , @danix800 wrote: > In D144780#4154487 , @steakhal > wrote: > >> I love it. Short, to the point. Thanks. >> I think this is the right way to fix this. >> Good job. >>

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

steakhal added a comment. If we worry about having taint-related reports without a Note message explaining where the taint was introduced, we could just assert that in a `BugReportVisitor` at the `finalizeVisitor()` callback. I think such an assertion would make a lot of sense. To achieve this,

[PATCH] D53953: [clang-tidy] Get ClangTidyContext out of the business of storing diagnostics. NFC

MillyMe added a comment. Thank you! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53953/new/ https://reviews.llvm.org/D53953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D144780: Explicit cast on customized offsetof should not be ignored when evaluating as const

danix800 added a comment. danix800 (danix...@gmail.com) is OK, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144780/new/ https://reviews.llvm.org/D144780 ___ cfe-commits mailing list cfe-commits@

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

jolanta.jensen added a comment. In D144179#4146599 , @MaskRay wrote: > This looks like introducing a footgun (when something behaves differently > from an upstream Clang, it would be difficult for toolchain maintainers to > know why). > Why can't your u

[PATCH] D144638: [lit] Detect Consistent File Access Times

michaelplatings added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:171 +# in the tests that do the same thing. +(_, try_touch_err) = self.get_process_output(["touch", "-a", "-t", "199505050555.55", f.name]) +if try_touch_err

[PATCH] D144371: [LLVM-COV] Fix an issue: a statement after calling 'assert()' function is wrongly marked as 'not executed'

MaggieYi added a comment. Gentle ping ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144371/new/ https://reviews.llvm.org/D144371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D144638: [lit] Detect Consistent File Access Times

lenary added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:171 +# in the tests that do the same thing. +(_, try_touch_err) = self.get_process_output(["touch", "-a", "-t", "199505050555.55", f.name]) +if try_touch_err != "": --

[PATCH] D144862: Include highlighed, include on hover, code lense for used symbols

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

aaron.ballman added a comment. > Hmmm, I'm coming around to reusing hasBody() like you've done here. I think > it's pretty weird to read: > functionDecl(hasBody(coroutineBodyStmt(hasBody(stmt().bind(...))) because of > the duplicated calls to hasBody, but I think it's more defensible now than I

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon created this revision. Herald added subscribers: sunshaoce, Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle, m

[PATCH] D143751: [clang][analyzer][NFC] Refactor code of StdLibraryFunctionsChecker.

Szelethus added a comment. A high level comment before getting into (even more) nitty gritty stuff. But shut me down if I misunderstood whats happening. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:124-125 // requirement would render the ini

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary retitled this revision from "[lit] Detect Consistent File Access Times" to "[lit] Detect Inconsistent File Access Times". lenary edited the summary of this revision. lenary updated this revision to Diff 500742. Herald added a subscriber: krytarowski. Repository: rG LLVM Github Monorepo

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary marked 2 inline comments as done. lenary added a comment. Hopefully this addresses the feedback so far. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144638/new/ https://reviews.llvm.org/D144638 _

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon updated this revision to Diff 500744. agozillon added a comment. Forgot to add an additional test in initial patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144864/new/ https://reviews.llvm.org/D144864 Files: clang/include/clang/D

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Constant evaluator only considered access to `this` pointer to be possible if `this` poitners was captured. However `thi

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

jolanta.jensen updated this revision to Diff 500747. jolanta.jensen added a comment. Adjusting the test for Windows. Setting the read bits only for the config file as Windows does not have full support for chmod. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

erichkeane added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:3036 if (!std::is_trivially_destructible::value) { - auto DestroyPtr = [](void *V) { static_cast(V)->~T(); }; - AddDeallocation(DestroyPtr, Ptr); + auto DestroyPtr = [](void *V)

[PATCH] D144870: [Clang][DebugInfo] Emit zero size bitfields in the debug info to delimit bitfields in different allocation units.

jmmartinez created this revision. jmmartinez added reviewers: dblaikie, probinson. Herald added subscribers: kosarev, tpr. Herald added a project: All. jmmartinez requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I'm looking for some feedback

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

michaelplatings added a comment. I see some of these tests previously had `UNSUPPORTED: system-netbsd` but not `UNSUPPORTED: system-windows` - do you know why? Comment at: llvm/utils/lit/lit/llvm/config.py:190 +return False +if "1995" not in touch_r

[PATCH] D143630: [clang] update test case

nikic requested changes to this revision. nikic added a comment. This revision now requires changes to proceed. (Marking this as changes requested per previous comment.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143630/new/ https://reviews.llvm

[PATCH] D144873: [OpenMP] Ignore implicit casts on assertion for `use_device_ptr`

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, ABataev, ronlieb, carlo.bertolli. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a p

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

erichkeane added a comment. In D143803#4154736 , @0xdc03 wrote: > Okay, I have now modified the diagnostic to look something like (as per the > discussion at > https://discord.com/channels/636084430946959380/636732781086638081/1079356357024694363): > >

[PATCH] D144873: [OpenMP] Ignore implicit casts on assertion for `use_device_ptr`

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144873/new/ https://reviews.llvm.org/D144873 _

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

0xdc03 added a comment. In D143803#4155266 , @erichkeane wrote: > I think updating that test with this additional note is the right thing to do. Will do, will also add checks for the fix-its. > As far as that note, saying 'mangled name' is perhaps not

[PATCH] D136100: [clang-format] Do not parse certain characters in pragma directives

jhuber6 added a comment. I would prefer that this doesn't get reverted, see the summary for the awful results for OpenMP without this patch. A potential solution would be to parse the next token and only add the indent if it's `omp`. Comment at: clang/unittests/Format/FormatT

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

erichkeane added a subscriber: shafik. erichkeane added a comment. In D143803#4155345 , @0xdc03 wrote: > In D143803#4155266 , @erichkeane > wrote: > >> I think updating that test with this additional note is the

[PATCH] D144709: [clang-format] Improve left to right const

AlexanderHederstaf updated this revision to Diff 500792. AlexanderHederstaf added a comment. Update right to left analyzer Add support for requires clauses Ignore usages of struct/class keyword Add new, and uncomment old tests Fix invalid tests with 'const Foo b* const;' Repository: rG LLVM G

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie created this revision. karapsinie added reviewers: klimek, aaron.ballman. Herald added subscribers: luke, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simonc

[PATCH] D144709: [clang-format] Improve left to right const

AlexanderHederstaf added a comment. There are a lot of complicated cases when trying to extend this functionality. I addressed a few more and thought that it might be acceptable to avoid adjusting the qualifiers for variable declared as struct Foo const; -> const struct Foo; const struct Fo

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf updated this revision to Diff 500799. AlexanderHederstaf added a comment. Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144709/new/ https://reviews.llvm.org/D144709 Files: clang/lib/Format/QualifierAlignm

[PATCH] D144853: [Clang][RISCV] Add CMake options to configure default CPU

asb added a comment. If this is a useful thing to have, would it make more sense as a target-independent option? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144853/new/ https://reviews.llvm.org/D144853 __

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

donat.nagy added a comment. @vabridgers Thanks for testing these commits! As @balazske wrote on D144622 , I'd suggest handling the three commits (this one = D140562 , D144622 and D144273

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

dkrupp planned changes to this revision. dkrupp added a comment. @steakhal , @NoQ thanks for the reviews. I will try to implement an alternative solution based on your suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144269/new/ https://reviews.llvm.org/D144269

[PATCH] D144352: Do not emit exception diagnostics from coroutines and coroutine lambdas

denizevrenci added a comment. Author info for the commit: Deniz Evrenci (denizevre...@gmail.com) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144352/new/ https://reviews.llvm.org/D144352 ___ cfe-commits

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 500807. TIFitis added a comment. Added MLIR test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp llvm/include/llvm/F

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie updated this revision to Diff 500809. karapsinie added a comment. Execute "arc diff `git merge-base HEAD origin` --update D144878 " Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https://revi

[PATCH] D144884: [clang-format] Only add pragma continuation indentation for 'omp' clauses

jhuber6 created this revision. jhuber6 added reviewers: owenpan, MyDeveloperDay, HazardyKnusperkeks, hans. Herald added a project: All. jhuber6 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. The

[clang] 853d405 - [OpenMP] Ignore implicit casts on assertion for `use_device_ptr`

Author: Joseph Huber Date: 2023-02-27T10:48:20-06:00 New Revision: 853d4059135bdadf74d67f59215b21026b6f939e URL: https://github.com/llvm/llvm-project/commit/853d4059135bdadf74d67f59215b21026b6f939e DIFF: https://github.com/llvm/llvm-project/commit/853d4059135bdadf74d67f59215b21026b6f939e.diff

[PATCH] D144873: [OpenMP] Ignore implicit casts on assertion for `use_device_ptr`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG853d4059135b: [OpenMP] Ignore implicit casts on assertion for `use_device_ptr` (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES

RE: [clang] 398cddf - [clang-format] Fix assertion that doesn't hold under fuzzing.

Should that have been an "else if" and not just an "if" otherwise clang-format should be applied. -Original Message- From: cfe-commits On Behalf Of Manuel Klimek via cfe-commits Sent: Monday, February 27, 2023 2:51 AM To: cfe-commits@lists.llvm.org Subject: [clang] 398cddf - [clang-for

[PATCH] D144889: [C2x] Support in freestanding

aaron.ballman created this revision. aaron.ballman added reviewers: clang-language-wg, jyknight, efriedma, joerg. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. This implements most of the support for WG14 N2524 (https://www.open-std.o

[PATCH] D144889: [C2x] Support in freestanding

efriedma requested changes to this revision. efriedma added a comment. This revision now requires changes to proceed. Providing this header doesn't do anything useful without an actual implementation; all of these "__builtin" calls just lower to libc calls in the general case. How do you plan t

[clang] 2e73111 - [Sema] Use isSVESizelessBuiltinType instead of isSizelessBuiltinType to prevent crashing on RISC-V.

Author: Craig Topper Date: 2023-02-27T09:19:27-08:00 New Revision: 2e7311170201e07e5e067e397aed8fa482d2fb8b URL: https://github.com/llvm/llvm-project/commit/2e7311170201e07e5e067e397aed8fa482d2fb8b DIFF: https://github.com/llvm/llvm-project/commit/2e7311170201e07e5e067e397aed8fa482d2fb8b.diff

[PATCH] D144772: [Sema] Use isSVESizelessBuiltinType instead of isSizelessBuiltinType to prevent crashing on RISC-V.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e7311170201: [Sema] Use isSVESizelessBuiltinType instead of isSizelessBuiltinType to prevent… (authored by craig.topper). Repository: rG LLVM Git

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

shafik added a comment. Thank you for this patch, it looks good. Comment at: clang/lib/AST/ExprConstant.cpp:8763 if (isLambdaCallOperator(Info.CurrentCall->Callee)) { - // Ensure we actually have captured 'this'. (an error will have - // been previously reported

[PATCH] D144884: [clang-format] Only add pragma continuation indentation for 'omp' clauses

jdoerfert added a comment. I'm assuming they have tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144884/new/ https://reviews.llvm.org/D144884 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144884: [clang-format] Only add pragma continuation indentation for 'omp' clauses

jhuber6 added a comment. In D144884#4155730 , @jdoerfert wrote: > I'm assuming they have tests? I could add a test for the comment case in the bug report. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1448

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

shafik added a comment. Also please add a release note before landing the fix, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144866/new/ https://reviews.llvm.org/D144866 ___ cfe-commits mailin

[PATCH] D144802: clang: Add __builtin_elementwise_round

bob80905 added a comment. Should the addition of this builtin be mentioned in clang\docs\ReleaseNotes.rst? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144802/new/ https://reviews.llvm.org/D144802 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D144802: clang: Add __builtin_elementwise_round

erichkeane added a comment. Yep! this does need a release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144802/new/ https://reviews.llvm.org/D144802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D144196: [C2x] Remove the ATOMIC_VAR_INIT macro from stdatomic.h

ldionne added a comment. Thanks for the heads up. As noted in another comment, I don't think this impacts libc++ because C++23 (unfortunately) still provides the macro AFAICT. We define it ourselves in `libcxx/include/__atomic/atomic_init.h`. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D144889: [C2x] Support in freestanding

aaron.ballman added a comment. In D144889#4155686 , @efriedma wrote: > Providing this header doesn't do anything useful without an actual > implementation; all of these "__builtin" calls just lower to libc calls in > the general case. How do you plan t

[PATCH] D144894: [clang] Documents clang-scan-deps requirements.

Mordante created this revision. Mordante added a reviewer: ChuanqiXu. Herald added a project: All. Mordante requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was discussed in https://llvm.org/PR61006. Repository: rG LLVM Github Monor

[PATCH] D143524: Make the -Wunused-template default.

ldionne added inline comments. Comment at: clang/test/SemaCXX/warn-func-not-needed.cpp:13 namespace test1_template { -template static void f() {} +template static void f() {} // expected-warning {{unused function template}} template <> void f() {} // expected-warning {{funct

[PATCH] D144878: __builtin_FILE_NAME()

shafik added inline comments. Comment at: clang/lib/AST/Expr.cpp:2283 + case SourceLocExpr::FileName: { +SmallString<256> Path; +// builtin_FILE_NAME() is a Clang-specific extension that expands to the It looks like a copy of the code from `ExpandBuiltin

[PATCH] D144232: [PowerPC] Correctly use ELFv2 ABI on FreeBSD/powerpc64

adalava added a comment. In D144232#4137367 , @dim wrote: > In D144232#4136787 , @brad wrote: > >> I noticed this review. I have provided a more complete diff for review at >> D144321

[PATCH] D143415: LibclangTest: remove libclang-test-* tmp dir reliably

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143415/new/ https://reviews.llvm.org/D143415

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a small change to the test coverage. Comment at: clang/test/Headers/limits.cpp:8 +// Specifically test 16-bit int platforms. +// RUN: %clang_cc1 -trip

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16824-16841 if (InnerCond && isa(InnerCond)) { // Drill down into concept specialization expressions to see why they // weren't satisfied. Diag(StaticAssertLoc, diag:

[PATCH] D144889: [C2x] Support in freestanding

efriedma added a comment. Historically, the required functions for a "freestanding" C implementation were very restricted. Freestanding headers didn't export library functions, just constants and types. As a practical matter, we actually do need a few functions to support code generation for

[PATCH] D144680: [Coroutines] Avoid creating conditional cleanup markers in suspend block

weiwang added a comment. In D144680#4149149 , @ChuanqiXu wrote: > BTW, what is the conclusion for the concern about sanitizers? Would change > make sanitizers to perform false positive diagnostics? This change is limited to the `await.suspend` block, wh

Re: [clang] 6ed67cc - [Coroutines] Remove -fcoroutines-ts

Hi Chuanqi, I know the warning mentions it to be removed in clang-17, but a heads up "landing in a week" or so would have been great :) I understand that the name "coroutines-ts" isn't meaningful these days, but it also sounds like this commit does more than remove the flag, it caps useful functi

[PATCH] D144889: [C2x] Support in freestanding

bcraig added a comment. A freestanding implementation doesn't necessarily mean that everything is header-only. It's fine to require linking against a (freestanding) C runtime library. All header-only is fine too though, if you want to make that work. Architecturally, I don't feel it is requir

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath updated this revision to Diff 500861. mysterymath marked an inline comment as done. mysterymath added a comment. Add C++ version of test for AVR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144218/new/ https://reviews.llvm.org/D144218

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath added a comment. Thanks for your help in getting this right! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144218/new/ https://reviews.llvm.org/D144218 ___ cfe-commits mailing list cfe-commit

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

ManuelJBrito created this revision. ManuelJBrito added a reviewer: RKSimon. Herald added subscribers: pengfei, hiraditya. Herald added a project: All. ManuelJBrito requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Ignoring f

[PATCH] D144884: [clang-format] Only add pragma continuation indentation for 'omp' clauses

HazardyKnusperkeks added a comment. In D144884#4155739 , @jhuber6 wrote: > In D144884#4155730 , @jdoerfert > wrote: > >> I'm assuming they have tests? > > I could add a test for the comment case in the bug report

[PATCH] D144884: [clang-format] Only add pragma continuation indentation for 'omp' clauses

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1279 + if (State.Line->InPragmaDirective) { +FormatToken *PragmaType = State.Line->First->Next->Next; +if (PragmaType && PragmaType->TokenText.equals("omp"))

[PATCH] D144884: [clang-format] Only add pragma continuation indentation for 'omp' clauses

jhuber6 added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1279 + if (State.Line->InPragmaDirective) { +FormatToken *PragmaType = State.Line->First->Next->Next; +if (PragmaType && PragmaType->TokenText.equals("omp")) HazardyKnus

[PATCH] D143418: [libclang] Add API to override preamble storage path

aaron.ballman added inline comments. Comment at: clang/include/clang-c/Index.h:319 + */ + size_t Size; + /** vedgy wrote: > The type is `size_t` instead of the agreed upon `unsigned`, because the > addition of `unsigned GlobalOptions` below means that `unsig

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

cor3ntin updated this revision to Diff 500866. cor3ntin marked an inline comment as done. cor3ntin added a comment. Address Aaron's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144285/new/ https://reviews.llvm.org/D144285 Files: clang/

  1   2   >