[PATCH] D143509: Move the BySpelling map to IncludeStructure.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:164 + llvm::StringMap> + buildMainFileIncludesBySpelling() const { +llvm::StringMap> BySpelling; instead of building this on-demand, what about building it as we're collecting d

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

clementval added inline comments. Comment at: flang/test/Fir/external-mangling.fir:36 + +// CHECK-NOUNDER: func @foo +// CHECK-NOUNDER: %{{.*}} = fir.address_of(@a) : !fir.ref> You should check at least the character after it because here the check line would al

[clang] 2929683 - [clang][codegen] Fix emission of consteval constructor of derived type

Author: Mariya Podchishchaeva Date: 2023-02-09T04:43:48-05:00 New Revision: 2929683eef27e6b3ac95325d955cd39bc2e416c0 URL: https://github.com/llvm/llvm-project/commit/2929683eef27e6b3ac95325d955cd39bc2e416c0 DIFF: https://github.com/llvm/llvm-project/commit/2929683eef27e6b3ac95325d955cd39bc2e416

[PATCH] D142534: [clang][codegen] Fix emission of consteval constructor of derived type

This revision was automatically updated to reflect the committed changes. Closed by commit rG2929683eef27: [clang][codegen] Fix emission of consteval constructor of derived type (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D143632: [clang] Handle __declspec() attributes in using

thieta created this revision. thieta added reviewers: aaron.ballman, rsmith, tbaeder, saudi. Herald added a project: All. thieta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes so that declspec attributes are forwarded to t

[clang] f28c28e - Simplify test from change D73904

Author: Michael Platings Date: 2023-02-09T10:05:01Z New Revision: f28c28e6645723c01c73478a9d18f0bf0551767a URL: https://github.com/llvm/llvm-project/commit/f28c28e6645723c01c73478a9d18f0bf0551767a DIFF: https://github.com/llvm/llvm-project/commit/f28c28e6645723c01c73478a9d18f0bf0551767a.diff L

[PATCH] D143590: [NFC] Simplify test from change D73904

This revision was automatically updated to reflect the committed changes. Closed by commit rGf28c28e66457: Simplify test from change D73904 (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143590/new/ https://reviews.llvm

[PATCH] D138254: [llvm] Fix the build on OpenBSD by removing LLVM_VERSION_SUFFIX from created shared library names

thieta added a comment. @brad is this something you still need for OpenBSD? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138254/new/ https://reviews.llvm.org/D138254 ___ cfe-commits mailing list cfe-com

[PATCH] D142094: [Clang][Doc] Add release note for changes of the RVV intrinsics

eopXD abandoned this revision. eopXD added a comment. This was cherry-picked into the release branch of LLVM 16. Closing the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142094/new/ https://reviews.llvm.org/D142094

[PATCH] D143634: [ModuleUtils] Assert correct linkage and visibility of structors' COMDAT key

melver created this revision. melver added reviewers: MaskRay, vitalybuka, fmayer, pcc. Herald added subscribers: luke, Enna1, kosarev, frasercrmck, kerbowa, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc2

[PATCH] D143634: [ModuleUtils] Assert correct linkage and visibility of structors' COMDAT key

melver added a comment. This is currently more an RFC - there might be other side-effects not yet accounted for, so please review carefully. Although I have been able to reproduce the issue with an LTO and ASan build quite easily. If this is a common usecase for us, we might potentially save a

[clang] 0b704d9 - [Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows

Author: Andrew Ng Date: 2023-02-09T10:39:09Z New Revision: 0b704d9db7e15723922ee29c6f245d108a09c214 URL: https://github.com/llvm/llvm-project/commit/0b704d9db7e15723922ee29c6f245d108a09c214 DIFF: https://github.com/llvm/llvm-project/commit/0b704d9db7e15723922ee29c6f245d108a09c214.diff LOG: [Su

[PATCH] D142224: [Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b704d9db7e1: [Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows (authored by andrewng). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Gi

[PATCH] D143142: [clang][lex] Enable Lexer to grow its buffer

v.g.vassilev added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:211 + L->BufferOffset = + StrData - InputFile.getBufferStart(); // FIXME: this is wrong + L->BufferSize = L->BufferOffset + TokLen; Is that an outdated comment? If not maybe elaborate

[PATCH] D143635: [clangd] Refactor new include cleaner functionality into a separate class.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D143587: [Docs] Multilib design

amilendra added a comment. Thanks for the design docs. At a high-level this gives a good summary on what you intend the multilib feature to do. Couple of suggestions. Comment at: clang/docs/Multilib.rst:86-89 + a match. + If more than one variant matches then a toolchain m

[PATCH] D143587: [Docs] Multilib design

amilendra added inline comments. Comment at: clang/docs/Multilib.rst:89 + the *last* matching multilib variant, or may use all matching variants, + thereby layering them. +#. Generate ``-isystem`` and ``-L`` arguments. Iterate in reverse order over What would

[PATCH] D143496: [clangd] Add support for missing includes analysis.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Config.h:91 + enum class MissingIncludesPolicy { +/// Diagnose missing includes. rather than duplicating, what about renaming `UnusedIncludesPolicy` to `IncludesPolicy` and use it for bo

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 496072. michaelplatings added a comment. Made changes requested by @amilendra Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst

[PATCH] D143587: [Docs] Multilib design

michaelplatings marked 3 inline comments as done. michaelplatings added inline comments. Comment at: clang/docs/Multilib.rst:86-89 + a match. + If more than one variant matches then a toolchain may opt to either use only + the *last* matching multilib variant, or may use al

[PATCH] D143638: [clangd] Move function body to out-of-line: unnamed class method incorrect moving

denis-fatkulin created this revision. denis-fatkulin added reviewers: kadircet, sammccall. Herald added a subscriber: arphaman. Herald added a project: All. denis-fatkulin requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

david-arm added a comment. Thanks a lot for making all the changes @bryanpkc - it's looking really good now! I just have a few minor comments/suggestions and then I think it looks good to go. Comment at: clang/include/clang/Basic/arm_sme.td:22 +let TargetGuard = "sme" in { +

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

sdesmalen added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:332 + # Generate arm_sme.h + clang_generate_header(-gen-arm-sme-header arm_sme.td arm_sme.h) # Generate arm_bf16.h The ACLE specification is still in a draft (ALP) state, which mea

[PATCH] D143640: [Tooling/Inclusion] Support overload symbols in the stdlib.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added projects: clang, clang-tools-extra. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D143640 Fil

[clang-tools-extra] 2706919 - [clang-tidy][doc] Improve clang-tidy documentation

Author: Carlos Galvez Date: 2023-02-09T12:19:36Z New Revision: 2706919f91977f3859ad625d4fb624fb04857e4f URL: https://github.com/llvm/llvm-project/commit/2706919f91977f3859ad625d4fb624fb04857e4f DIFF: https://github.com/llvm/llvm-project/commit/2706919f91977f3859ad625d4fb624fb04857e4f.diff LOG:

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rG2706919f9197: [clang-tidy][doc] Improve clang-tidy documentation (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ http

[PATCH] D143501: [clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 updated this revision to Diff 496089. Michael137 added a comment. - Reword commit - Use different debuginfo kind in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143501/new/ https://reviews.llvm.org/D143501 Files: clang/lib/Code

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

kadircet added inline comments. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp:218 + if (!D) // global scope. +return getMappingPerLang(L)->NamespaceSymbols->lookup(""); auto It = NamespaceCache.find(D); oh i actually missed the behav

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

kadircet added a comment. thanks a lot for the patch! we're migrating IWYU related functionality in clangd to make use of include-cleaner library nowadays. so can you actually move the IWYU no_include pragma handling logic into https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/i

[PATCH] D143375: clang-tidy: Count template constructors in modernize-use-default-member-init

MarcoFalke updated this revision to Diff 496094. MarcoFalke added a comment. Simplify patch and remove test case failing on Windows, but passing on Linux CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143375/new/ https://reviews.llvm.org/D143375 Files: clang-tools-extra/clang-tidy/mod

[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

sidorovd added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10980 +/// Construct a SPIR-V target extension type for the given OpenCL image type. +static llvm::Type *getSPIRVType(llvm::LLVMContext &Ctx, StringRef BaseType, +StringRe

[PATCH] D143632: [clang] Handle __declspec() attributes in using

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. Please be sure to add a release note for the fix. Comment at: clang/lib/Parse/ParseDecl.cpp:61-63 + for (ParsedAttr &AL : DS.getAttributes()) +if (AL.isDeclspecAttribute()) + ToBeMoved.push_bac

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

hokein updated this revision to Diff 496102. hokein added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143214/new/ https://reviews.llvm.org/D143214 Files: clang-tools-extra/clangd/unittests/StdLibTests.cpp clang/inc

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

hokein added inline comments. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp:218 + if (!D) // global scope. +return getMappingPerLang(L)->NamespaceSymbols->lookup(""); auto It = NamespaceCache.find(D); kadircet wrote: > oh i actually

[PATCH] D136864: [Clang] Create opaque type for AArch64 SVE2p1/SME2 svcount_t.

sdesmalen updated this revision to Diff 496103. sdesmalen added a comment. Rebased patch to use target("aarch64.svcount") Changed debug info for svcount to only print the first 2 bytes (rather than vscale x 2 bytes) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D143375: clang-tidy: Count template constructors in modernize-use-default-member-init

MarcoFalke updated this revision to Diff 496104. MarcoFalke edited the summary of this revision. MarcoFalke added a comment. Remove both test cases that pass on current `main` on Linux, but fail on Windows. Seems unrelated to add/fix them here. CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

kadircet accepted this revision. kadircet added a comment. thanks, lgtm again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143214/new/ https://reviews.llvm.org/D143214 ___ cfe-commits mailing list cfe-c

[PATCH] D143638: [clangd] Move function body to out-of-line: unnamed class method incorrect moving

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:395 // Bail out in templated classes, as it is hard to spell the class name, i.e // if the template parameter is unnamed. could you move this comme

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman added a comment. In D140756#4100387 , @aaron.ballman wrote: > @diseraluca -- do you need this cherry picked into Clang 16 or are you fine > if this goes into Clang 17 instead? I'll go with the assumption this is fine going into Clang 17 a

[clang] c812ab7 - [include-mapping] Add C-compatibility symbol entries.

Author: Haojian Wu Date: 2023-02-09T15:34:41+01:00 New Revision: c812ab731243f9d5fe1764eb995809a22409ca71 URL: https://github.com/llvm/llvm-project/commit/c812ab731243f9d5fe1764eb995809a22409ca71 DIFF: https://github.com/llvm/llvm-project/commit/c812ab731243f9d5fe1764eb995809a22409ca71.diff LO

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc812ab731243: [include-mapping] Add C-compatibility symbol entries. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143214/new/ https://

[clang] de4321c - [libclang] Tweaks for clang_CXXMethod_isExplicit

Author: Aaron Ballman Date: 2023-02-09T09:55:11-05:00 New Revision: de4321cf2cf28f2bae7fc0f1897957e73b726f89 URL: https://github.com/llvm/llvm-project/commit/de4321cf2cf28f2bae7fc0f1897957e73b726f89 DIFF: https://github.com/llvm/llvm-project/commit/de4321cf2cf28f2bae7fc0f1897957e73b726f89.diff

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman added a comment. In D140756#4115363 , @aaron.ballman wrote: > In D140756#4100387 , @aaron.ballman > wrote: > >> @diseraluca -- do you need this cherry picked into Clang 16 or are you fine >> if th

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito updated this revision to Diff 496129. ManuelJBrito retitled this revision from "[Clang][x86] Change x86 cast intrinsics to use __builtin_nondeterministic_value" to "[Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value". ManuelJBrito added a comment. Match

[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

kiranchandramohan accepted this revision. kiranchandramohan added a comment. LG. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141910/new/ https://reviews.llvm.org/D141910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D143587: [Docs] Multilib design

peter.smith added a comment. Thanks very much for writing this. Will be worth updating the RFC with a link as I think that this is an approachable place to comment on the format and selection model without the implementation detail. I'm happy with what has been written so far. My suggestions ar

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

ahatanak updated this revision to Diff 496132. ahatanak marked 4 inline comments as done. ahatanak added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142584/new/ https://reviews.llvm.org/D142584 Files: clang/

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

ahatanak added inline comments. Comment at: clang/lib/CodeGen/Address.h:65 : Pointer(Pointer), ElementType(ElementType) { if (Alignment.isZero()) return; efriedma wrote: > Do you need to do something with IsKnownNonNull in the `Alignment.isZero

[PATCH] D143501: [clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/TestDataFormatterLibcxxSharedPtr.py:61 if self.expectedCompilerVersion(['>', '16.0']): +string_type = "std::string"

[PATCH] D143657: [Clang][RISCV] Guard vector float16 type correctly under Sema

eopXD created this revision. eopXD added reviewers: craig.topper, aaron.ballman, kito-cheng, asb. Herald added subscribers: luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, e

[clang] 7f85c56 - [Clang][AIX][p]Enable -p Functionality

Author: Michael Francis Date: 2023-02-09T16:13:51Z New Revision: 7f85c560b43bd1b2ebf77cc443281b474b5e19c6 URL: https://github.com/llvm/llvm-project/commit/7f85c560b43bd1b2ebf77cc443281b474b5e19c6 DIFF: https://github.com/llvm/llvm-project/commit/7f85c560b43bd1b2ebf77cc443281b474b5e19c6.diff LO

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f85c560b43b: [Clang][AIX][p]Enable -p Functionality (authored by francii). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.o

[clang] ec094d2 - [z/OS][pg] Throw error when using -pg on z/OS

Author: Michael Francis Date: 2023-02-09T16:14:29Z New Revision: ec094d259ecfdd82b951f644bc9a28e487e53c60 URL: https://github.com/llvm/llvm-project/commit/ec094d259ecfdd82b951f644bc9a28e487e53c60 DIFF: https://github.com/llvm/llvm-project/commit/ec094d259ecfdd82b951f644bc9a28e487e53c60.diff LO

[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

This revision was automatically updated to reflect the committed changes. Closed by commit rGec094d259ecf: [z/OS][pg] Throw error when using -pg on z/OS (authored by francii). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137756/new/ https://reviews

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

ahatanak added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:1723 + Addr = + Addr.withPointer(Builder.CreateThreadLocalAddress(GV), KnownNonNull); `KnownNonNull` is being passed here because the address of a load must be non-null. Do

[PATCH] D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis

craig.topper added a comment. Are you going to do f32, f64, and i64 as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143657/new/ https://reviews.llvm.org/D143657 ___ cfe-commits mailing list cfe-co

[PATCH] D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis

eopXD added a comment. In D143657#4115721 , @craig.topper wrote: > Are you going to do f32, f64, and i64 as well? Yes, going to add them once this commit lands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D143663: [clangd] Show used symbols on hover.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D143142: [clang][lex] Enable Lexer to grow its buffer

sunho added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:211 + L->BufferOffset = + StrData - InputFile.getBufferStart(); // FIXME: this is wrong + L->BufferSize = L->BufferOffset + TokLen; v.g.vassilev wrote: > Is that an outdated comment? If not m

[PATCH] D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis

eopXD added a comment. Forward declaration (snippet below) is still allowed after this commit. #include vfloat16m1_t foo(); I see the same behavior under https://github.com/llvm/llvm-project/blob/main/clang/test/Sema/x86_64-no-x87.cpp. If I add type check under `SemaDecl.cpp::Sema::Ac

[PATCH] D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis

eopXD updated this revision to Diff 496160. eopXD added a comment. Update code: rename error for vector support, remove dead code under SemaRISCVVectorLoopup.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143657/new/ https://reviews.llvm.org/D1

[PATCH] D143613: [clang][deps] Migrate ModuleDepCollector to LexedFileChanged NFCI

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM, but would be nice to have a test for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143613/new/ https://reviews.llvm.org/

[PATCH] D143664: [SanitizerBinaryMetadata] Support ignore list

melver created this revision. melver added reviewers: dvyukov, vitalybuka. Herald added subscribers: Enna1, ormris, hiraditya. Herald added a project: All. melver requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. Fo

[PATCH] D143665: [Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis

eopXD created this revision. eopXD added reviewers: craig.topper, aaron.ballman, kito-cheng, asb. Herald added subscribers: luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, e

[PATCH] D143666: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a project: All. michaelplatings requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If clang is part of a toolchain that can locate clang_rt libraries

[PATCH] D143613: [clang][deps] Migrate ModuleDepCollector to LexedFileChanged NFCI

benlangmuir updated this revision to Diff 496173. benlangmuir added a comment. Add a test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143613/new/ https://reviews.llvm.org/D143613 Files: clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h clang/lib/Tooling/Dependen

[PATCH] D143613: [clang][deps] Migrate ModuleDepCollector to LexedFileChanged NFCI

benlangmuir added a comment. In D143613#4115857 , @jansvoboda11 wrote: > LGTM, but would be nice to have a test for this. Oh, I didn't realize we didn't have one already. Added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143613/new/ https

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

vedgy added a comment. In D140756#4115381 , @aaron.ballman wrote: > The spare moment came sooner than expected, I've made the changes in > de4321cf2cf28f2bae7fc0f1897957e73b726f89 > .

[PATCH] D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace

tom-anders added a comment. Thanks for reviewing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140915/new/ https://reviews.llvm.org/D140915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman added a comment. In D140756#4115963 , @vedgy wrote: > In D140756#4115381 , @aaron.ballman > wrote: > >> The spare moment came sooner than expected, I've made the changes in >> de4321cf2cf28f2bae7fc

[PATCH] D143613: [clang][deps] Migrate ModuleDepCollector to LexedFileChanged NFCI

jansvoboda11 added a comment. In D143613#4115935 , @benlangmuir wrote: > In D143613#4115857 , @jansvoboda11 > wrote: > >> LGTM, but would be nice to have a test for this. > > Oh, I didn't realize we didn't have

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aeubanks added a comment. __clang_hip_math.hip is annoying... We'll need to remove the `MandatoryFirst` inliner in `ModuleInlinerWrapperPass`, although not sure if @mtrofin has any issues with that or not This isn't quite what I had initially thought, but this might be better. (I was thinking

[clang-tools-extra] ce87b03 - [clangd] Fix getQueryScopes for using-directive with inline namespace

Author: Tom Praschan Date: 2023-02-09T20:53:33+01:00 New Revision: ce87b031437071f011026bb850a2fb2e5f9a72b4 URL: https://github.com/llvm/llvm-project/commit/ce87b031437071f011026bb850a2fb2e5f9a72b4 DIFF: https://github.com/llvm/llvm-project/commit/ce87b031437071f011026bb850a2fb2e5f9a72b4.diff

[PATCH] D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce87b0314370: [clangd] Fix getQueryScopes for using-directive with inline namespace (authored by tom-anders). Changed prior to commit: https://rev

[PATCH] D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis

eopXD updated this revision to Diff 496183. eopXD added a comment. Update code: check for `experimental-zvfh` instead of `zvfh`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143657/new/ https://reviews.llvm.org/D143657 Files: clang/include/clan

[PATCH] D143665: [Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis

eopXD updated this revision to Diff 496185. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143665/new/ https://reviews.llvm.org/D143665 Files: clang/include/clang/AST/Type.h clang/include/clang/Basic/RISCVVTypes.

[PATCH] D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:318 +if (Subtarget.is64Bit()) + setOperationAction({ISD::CTLZ, ISD::CTLZ_ZERO_UNDEF}, MVT::i32, Custom); + } philipp.tomsich wrote: > craig.topper wrote: > > wit

[clang] 4c84c13 - [libclang] Add "global:" to the module map explicitly; NFC intended

Author: Aaron Ballman Date: 2023-02-09T14:01:54-05:00 New Revision: 4c84c1314716392061215aac7f299493bdf3cc93 URL: https://github.com/llvm/llvm-project/commit/4c84c1314716392061215aac7f299493bdf3cc93 DIFF: https://github.com/llvm/llvm-project/commit/4c84c1314716392061215aac7f299493bdf3cc93.diff

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman added a comment. In D140756#4115979 , @aaron.ballman wrote: > In D140756#4115963 , @vedgy wrote: > >> In D140756#4115381 , >> @aaron.ballman wrote: >> >>>

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aemerson added a comment. In D143624#4115986 , @aeubanks wrote: > __clang_hip_math.hip is annoying... > > We'll need to remove the `MandatoryFirst` inliner in > `ModuleInlinerWrapperPass`, although not sure if @mtrofin has any issues with > that or not

[PATCH] D143634: [ModuleUtils] Assert correct linkage and visibility of structors' COMDAT key

pcc added a comment. I've always considered that this should be fixed by extending the resolution-based LTO API to also include resolutions for comdats. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143634/new/ https://reviews.llvm.org/D143634 __

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

aaron.ballman created this revision. aaron.ballman added reviewers: clang-language-wg, erichkeane, rsmith, hubert.reinterpretcast. Herald added a subscriber: jdoerfert. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. The `[[carries_depe

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aeubanks added a comment. In D143624#4116080 , @aemerson wrote: > In D143624#4115986 , @aeubanks > wrote: > >> __clang_hip_math.hip is annoying... >> >> We'll need to remove the `MandatoryFirst` inliner in >> `M

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Thanks for doing this Aaron. Did you look in libc++ if they used it anywhere? (I assume they don't) Comment at: clang/docs/ReleaseNotes.rst:131 +- Clang no longer claims

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

philnik added a comment. In D143670#4116118 , @cor3ntin wrote: > Thanks for doing this Aaron. > Did you look in libc++ if they used it anywhere? (I assume they don't) I'm not aware of any uses, and I would be quite surprised if it was used anywhere give

[PATCH] D143613: [clang][deps] Migrate ModuleDepCollector to LexedFileChanged NFCI

This revision was automatically updated to reflect the committed changes. Closed by commit rG8711120e8bcf: [clang][deps] Migrate ModuleDepCollector to LexedFileChanged NFCI (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1436

[clang] 8711120 - [clang][deps] Migrate ModuleDepCollector to LexedFileChanged NFCI

Author: Ben Langmuir Date: 2023-02-09T11:42:03-08:00 New Revision: 8711120e8bcf891f3c316e20869493e93472f200 URL: https://github.com/llvm/llvm-project/commit/8711120e8bcf891f3c316e20869493e93472f200 DIFF: https://github.com/llvm/llvm-project/commit/8711120e8bcf891f3c316e20869493e93472f200.diff

[PATCH] D143501: [clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

dblaikie added a comment. In D143501#4110302 , @Michael137 wrote: > The alternative would be attaching the preferred name as a new attribute or > an existing attribute like `DW_AT_description`. I'd recommend a possible long-term solution would be simpl

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

mtrofin added a comment. In D143624#4115986 , @aeubanks wrote: > __clang_hip_math.hip is annoying... > > We'll need to remove the `MandatoryFirst` inliner in > `ModuleInlinerWrapperPass`, although not sure if @mtrofin has any issues with > that or not

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

HazardyKnusperkeks added a comment. In D143546#4114341 , @owenpan wrote: > In D143546#4113721 , @rymiel wrote: > >> In D143546#4112077 , @owenpan >> wrote: >> >>> As this

[PATCH] D143501: [clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 added a comment. > I'd recommend a possible long-term solution would be simplified template > names (so we don't have to worry about encoding this in the `DW_AT_name` > anyway) and a "DW_AT_LLVM_preferred_name" or similar attribute on a type that > refers to the typedef that is the p

[PATCH] D143592: [flang][driver] Rename `flang-new -flang-experimental-exec` to `flang`

everythingfunctional updated this revision to Diff 496213. everythingfunctional added a comment. rebase to get fix for build/test failure CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143592/new/ https://reviews.llvm.org/D143592 Files: clang/include/clang/Driver/Options.td clang/li

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

aaron.ballman added a subscriber: jkorous. aaron.ballman added a comment. In D143418#4111990 , @vedgy wrote: > I hoped to avoid applying an unrelated `git clang-format`'s include > reordering, but the CI fails because of that. Will apply it along with >

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aemerson added a comment. In D143624#4116114 , @aeubanks wrote: > In D143624#4116080 , @aemerson > wrote: > >> In D143624#4115986 , @aeubanks >> wrote: >> >>> __clang_hi

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aeubanks added a comment. In D143624#4116171 , @mtrofin wrote: > In D143624#4115986 , @aeubanks > wrote: > >> __clang_hip_math.hip is annoying... >> >> We'll need to remove the `MandatoryFirst` inliner in >> `Mo

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aeubanks added a comment. In D143624#4116318 , @aemerson wrote: > Sure, the exponential compile time case is actually just a side benefit here. > The motivating reason for this change is actually to improve code size when > building codebases that make

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143546/new/ https://reviews.llvm.org/D143546 ___ cfe-commits mailing list cfe-com

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

MyDeveloperDay added a comment. In D143546#4114341 , @owenpan wrote: > In D143546#4113721 , @rymiel wrote: > >> In D143546#4112077 , @owenpan >> wrote: >> >>> As this one

[clang] b4e35c6 - [clang-format] Insert a space between a numeric UDL and a dot

Author: Owen Pan Date: 2023-02-09T13:34:57-08:00 New Revision: b4e35c63711b4bde10b83607d04dab4bfdb86482 URL: https://github.com/llvm/llvm-project/commit/b4e35c63711b4bde10b83607d04dab4bfdb86482 DIFF: https://github.com/llvm/llvm-project/commit/b4e35c63711b4bde10b83607d04dab4bfdb86482.diff LOG:

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4e35c63711b: [clang-format] Insert a space between a numeric UDL and a dot (authored by owenpan). Changed prior to commit: https://reviews.llvm.o

  1   2   >