[clang] 56313f6 - [clang-format] Put peekNextToken(/*SkipComment=*/true) to good use

Author: Owen Pan Date: 2023-01-24T18:40:14-08:00 New Revision: 56313f65cce71366fdc659d1d08e0eeaa5d40b63 URL: https://github.com/llvm/llvm-project/commit/56313f65cce71366fdc659d1d08e0eeaa5d40b63 DIFF: https://github.com/llvm/llvm-project/commit/56313f65cce71366fdc659d1d08e0eeaa5d40b63.diff LOG:

[PATCH] D142412: [clang-format] Put peekNextToken(/*SkipComment=*/true) to good use

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56313f65cce7: [clang-format] Put peekNextToken(/*SkipComment=*/true) to good use (authored by owenpan). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D142412: [clang-format] Put peekNextToken(/*SkipComment=*/true) to good use

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3592-3601 case tok::kw_bool: // bool is only allowed if it is directly followed by a paren for a cast: // concept C = bool(...); // and bool is the only type, all other t

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

tianshilei1992 added a subscriber: aaron.ballman. tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:2501 + LValue Src = MakeAddrLValue(Arg.getIndirectAddress(), Ty); + callCStructCopyConstructor(Dst, Src); + PushCleanupIfNeeded(Arg.getI

[PATCH] D142412: [clang-format] Put peekNextToken(/*SkipComment=*/true) to good use

rymiel added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3592-3601 case tok::kw_bool: // bool is only allowed if it is directly followed by a paren for a cast: // concept C = bool(...); // and bool is the only type, all other ty

[clang] 0f07ff8 - [Clang] Fix test that sometimes fails depending on the temp name

Author: Joseph Huber Date: 2023-01-24T21:12:00-06:00 New Revision: 0f07ff8b71e6c5f899b99b445eccd4323395b33f URL: https://github.com/llvm/llvm-project/commit/0f07ff8b71e6c5f899b99b445eccd4323395b33f DIFF: https://github.com/llvm/llvm-project/commit/0f07ff8b71e6c5f899b99b445eccd4323395b33f.diff

[clang] 5ba8ecb - [Clang][OpenMP] Find the type `omp_allocator_handle_t` from identifier table

Author: Shilei Tian Date: 2023-01-24T22:49:05-05:00 New Revision: 5ba8ecb6cc7b76e7124566e53a3bce9393763a20 URL: https://github.com/llvm/llvm-project/commit/5ba8ecb6cc7b76e7124566e53a3bce9393763a20 DIFF: https://github.com/llvm/llvm-project/commit/5ba8ecb6cc7b76e7124566e53a3bce9393763a20.diff L

[PATCH] D142297: [Clang][OpenMP] Find the type `omp_allocator_handle_t` from identifier table

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ba8ecb6cc7b: [Clang][OpenMP] Find the type `omp_allocator_handle_t` from identifier table (authored by tianshilei1992). Repository: rG LLVM Githu

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 491989. ccotter added a comment. - Use match instead of bespoke traversal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files: clang-tools-extra/clang-tidy/cppcor

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter marked an inline comment as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/RvalueReferenceParamNotMovedCheck.cpp:13 + +#include + carlosgalvezp wrote: > Not sure if this is allowed in the repo or if we sh

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter marked an inline comment as done. ccotter added a comment. In D141569#4048359 , @njames93 wrote: > What happens with code like this > > void foo(bar&& B) { > std::move(B); > } https://github.com/isocpp/CppCoreGuidelines/issues/2026#issuec

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/rvalue-reference-param-not-moved.cpp:1 +// RUN: %check_clang_tidy -std=c++14-or-later %s cppcoreguidelines-rvalue-reference-param-not-moved %t -- -- -fno-delayed-templ

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/rvalue-reference-param-not-moved.cpp:1 +// RUN: %check_clang_tidy -std=c++14-or-later %s cppcoreguidelines-rvalue-reference-param-not-moved %t -- -- -fno-delayed-template-pa

cfe-commits@lists.llvm.org

dkt01 added a comment. Sounds good. I don't believe I have permissions to add commits to three repo anyway, so someone can add on my behalf after the 16 branch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141959/new/ https://reviews.llvm.org/D141959

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/rvalue-reference-param-not-moved.cpp:1 +// RUN: %check_clang_tidy -std=c++14-or-later %s cppcoreguidelines-rvalue-reference-param-not-moved %t -- -- -fno-delayed-templ

[clang-tools-extra] c7575fc - Revert "[clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options"

Author: Carlos Galvez Date: 2023-01-25T05:17:00Z New Revision: c7575fcb685a15f5384c137c76913e0bb11d1320 URL: https://github.com/llvm/llvm-project/commit/c7575fcb685a15f5384c137c76913e0bb11d1320 DIFF: https://github.com/llvm/llvm-project/commit/c7575fcb685a15f5384c137c76913e0bb11d1320.diff LOG:

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 491992. ccotter added a comment. - Use multiple runs on the same test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files: clang-tools-extra/clang-tidy/cppco

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter marked an inline comment as done. ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/rvalue-reference-param-not-moved.cpp:1 +// RUN: %check_clang_tidy -std=c++14-or-later %s cppcoreguidelines-rvalue-reference-param-no

[clang] b0daacf - [CodeGen] Use llvm::bit_ceil (NFC)

Author: Kazu Hirata Date: 2023-01-24T22:54:53-08:00 New Revision: b0daacf58f417634f7c7c9496589d723592a8f5a URL: https://github.com/llvm/llvm-project/commit/b0daacf58f417634f7c7c9496589d723592a8f5a DIFF: https://github.com/llvm/llvm-project/commit/b0daacf58f417634f7c7c9496589d723592a8f5a.diff L

[libunwind] 603c286 - Bump the trunk major version to 17

Author: Tom Stellard Date: 2023-01-24T22:57:27-08:00 New Revision: 603c286334b07f568d39f6706c848f576914f323 URL: https://github.com/llvm/llvm-project/commit/603c286334b07f568d39f6706c848f576914f323 DIFF: https://github.com/llvm/llvm-project/commit/603c286334b07f568d39f6706c848f576914f323.diff

[clang-tools-extra] 603c286 - Bump the trunk major version to 17

Author: Tom Stellard Date: 2023-01-24T22:57:27-08:00 New Revision: 603c286334b07f568d39f6706c848f576914f323 URL: https://github.com/llvm/llvm-project/commit/603c286334b07f568d39f6706c848f576914f323 DIFF: https://github.com/llvm/llvm-project/commit/603c286334b07f568d39f6706c848f576914f323.diff

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

Mordante added a comment. FYI I tested this patch with libc++ and as expected it does not fix the libc++ modular build ICE. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142500/new/ https://reviews.llvm.org/D142500 ___ cfe-commits mailing li

[PATCH] D142328: [clang][Interp] Fix compound assign operator types

tbaeder added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142328/new/ https://reviews.llvm.org/D142328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6244982 - [1/15][Clang][RISCV][NFC] Extract common utility to RISCVVIntrinsicUtils

Author: eopXD Date: 2023-01-24T00:01:23-08:00 New Revision: 62449823476bf71c2510c174e387c9c99d219722 URL: https://github.com/llvm/llvm-project/commit/62449823476bf71c2510c174e387c9c99d219722 DIFF: https://github.com/llvm/llvm-project/commit/62449823476bf71c2510c174e387c9c99d219722.diff LOG: [1

[PATCH] D141573: [1/15][Clang][RISCV][NFC] Extract common utility to RISCVVIntrinsicUtils

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62449823476b: [1/15][Clang][RISCV][NFC] Extract common utility to RISCVVIntrinsicUtils (authored by eopXD). Repository: rG LLVM Github Monorepo C

[PATCH] D141574: [2/15][Clang][RISCV][NFC] Rename Policy::IsPolicyNone to IsUnspecifed

eopXD added a comment. For the record here, `IsUnspecified` will be removed in D142016 , so the un-addressed comment will be resolved by then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141574/new/ https://rev

[clang] 74252fb - [2/15][Clang][RISCV][NFC] Rename Policy::IsPolicyNone to IsUnspecifed

Author: eopXD Date: 2023-01-24T00:05:31-08:00 New Revision: 74252fb115b42bab2c050086603c1385c8a2ffb6 URL: https://github.com/llvm/llvm-project/commit/74252fb115b42bab2c050086603c1385c8a2ffb6 DIFF: https://github.com/llvm/llvm-project/commit/74252fb115b42bab2c050086603c1385c8a2ffb6.diff LOG: [2

[PATCH] D141574: [2/15][Clang][RISCV][NFC] Rename Policy::IsPolicyNone to IsUnspecifed

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG74252fb115b4: [2/15][Clang][RISCV][NFC] Rename Policy::IsPolicyNone to IsUnspecifed (authored by eopXD). Repository: rG LLVM Github Monorepo CHAN

[clang] 0638028 - [3/15][Clang][RISCV][NFC] Clarify edge cases of RVVIntrinsic::getSupportedMaskedPolicies for clarity

Author: eopXD Date: 2023-01-24T00:07:33-08:00 New Revision: 063802843c20a49cf53a1fd380565ebfe29ee83f URL: https://github.com/llvm/llvm-project/commit/063802843c20a49cf53a1fd380565ebfe29ee83f DIFF: https://github.com/llvm/llvm-project/commit/063802843c20a49cf53a1fd380565ebfe29ee83f.diff LOG: [3

[PATCH] D141575: [3/15][Clang][RISCV][NFC] Clarify edge cases of RVVIntrinsic::getSupportedMaskedPolicies for clarity

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG063802843c20: [3/15][Clang][RISCV][NFC] Clarify edge cases of RVVIntrinsic… (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D141577: [4/15][Clang][RISCV][NFC] Remove unnecessary logic under RVVIntrinsic::computeBuiltinTypes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf8ec44b2a0e2: [4/15][Clang][RISCV][NFC] Remove unnecessary logic under RVVIntrinsic… (authored by eopXD). Repository: rG LLVM Github Monorepo CHA

[clang] f8ec44b - [4/15][Clang][RISCV][NFC] Remove unnecessary logic under RVVIntrinsic::computeBuiltinTypes

Author: eopXD Date: 2023-01-24T00:09:14-08:00 New Revision: f8ec44b2a0e29fa6edf3cc3b48c42e862a112039 URL: https://github.com/llvm/llvm-project/commit/f8ec44b2a0e29fa6edf3cc3b48c42e862a112039 DIFF: https://github.com/llvm/llvm-project/commit/f8ec44b2a0e29fa6edf3cc3b48c42e862a112039.diff LOG: [4

[clang] 6f0d0be - [5/15][Clang][RISCV][NFC] Remove extra attribute Policy::IntrinsicWithoutMU by reusing HasTailPolicy and HasMaskPolicy

Author: eopXD Date: 2023-01-24T00:10:48-08:00 New Revision: 6f0d0be567e85747bf7525ea4ebf100968b7ec9d URL: https://github.com/llvm/llvm-project/commit/6f0d0be567e85747bf7525ea4ebf100968b7ec9d DIFF: https://github.com/llvm/llvm-project/commit/6f0d0be567e85747bf7525ea4ebf100968b7ec9d.diff LOG: [5

[PATCH] D141754: [5/15][Clang][RISCV][NFC] Remove extra attribute Policy::IntrinsicWithoutMU by reusing HasTailPolicy and HasMaskPolicy

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f0d0be567e8: [5/15][Clang][RISCV][NFC] Remove extra attribute Policy::IntrinsicWithoutMU by… (authored by eopXD). Changed prior to commit: https:

[PATCH] D118493: Set rpath on openmp executables

JonChesterfield added a comment. That works if you have one toolchain installed globally or you are happy to cobble together a working system using environment variables. If you have multiple toolchains, they can't all sit in the global directory. If you don't have root, you can't install them

[PATCH] D142412: [clang-format] Put peekNextToken(/*SkipComment=*/true) to good use

MyDeveloperDay accepted this revision. MyDeveloperDay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3592-3601 case tok::kw_bool: // bool is only allowed if it is directly followed by a pare

[PATCH] D140845: [clang][Interp] Fix left-/right-shifting more than sizeof(unsigned)

tbaeder updated this revision to Diff 491633. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140845/new/ https://reviews.llvm.org/D140845 Files: clang/lib/AST/Interp/Integral.h clang/lib/AST/Interp/Interp.h clang/test/AST/Interp/shifts.cpp

[PATCH] D140874: [clang][Interp] Support pointer types in compound assignment operations

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:727-728 +this->emitSubOffset(*RT, E); + else +return false; + aaron.ballman wrote: > Should this be an early return before we visit anything? Or an assert on the > assum

[PATCH] D142316: [clang] Add test for CWG2396

Endill added a comment. In D142316#4073771 , @shafik wrote: > You mention CWG2385 as na but you don't explain > how it was resolved, was it superceded by p1787 >

[PATCH] D139926: [clangd] Add semantic token for angle brackets

nridge added a comment. I played around with the patch a little, and found some cases where semantic tokens should be present but aren't: template class S { public: template class Nested; }; // explicit specialization // parameter list is missing semantic tokens template <>

[PATCH] D139926: [clangd] Add semantic token for angle brackets

nridge added a comment. One other thought that has occurred to me is that as we add more semantic tolens for punctuation, the test cases in `GetsCorrectTokens` become harder to read. What would you think about omitting punctuation tokens in the `GetsCorrectTokens` test cases (both `Operator` a

[PATCH] D140803: [clang][Interp] Implement C++ Range-for loops

tbaeder updated this revision to Diff 491643. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140803/new/ https://reviews.llvm.org/D140803 Files: clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.h clang/test/AST/I

<    1   2   3   4