nridge added a comment. One other thought that has occurred to me is that as we add more semantic tolens for punctuation, the test cases in `GetsCorrectTokens` become harder to read.
What would you think about omitting punctuation tokens in the `GetsCorrectTokens` test cases (both `Operator` and `Bracket`, and any future ones), similarly to the way we already omit scope modifiers like `_classScope`, and have another test case like `GetsCorrectPunctuationTokens` where we put specifically test cases that test for punctuation tokens? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139926/new/ https://reviews.llvm.org/D139926 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
