[PATCH] D140292: [OpenMP] Migrate OpenMPOffloadMappingFlags from Clang CodeGen to OMPConstants

TIFitis marked 2 inline comments as done. TIFitis added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:193 - OMP_TGT_EXEC_MODE_GENERIC | OMP_TGT_EXEC_MODE_SPMD, - LLVM_MARK_AS_BITMASK_ENUM(/* LargestValue */ OMP_TGT_EXEC_MODE_GENERIC_SPMD) };

[PATCH] D140018: [clang-tidy] Support std::string_view in readability-redundant-string-cstr

njames93 accepted this revision. njames93 added a comment. LGTM, thank you for the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140018/new/ https://reviews.llvm.org/D140018 ___ cfe-commits mailing

[PATCH] D86881: Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin

sberg added a comment. Herald added a project: All. In D86881#2777808 , @arphaman wrote: > Hey, thanks for following up on this PR. I've done some more digging and I > think we can remove this Darwin-specific workaround in the near future. I'm > hoping t

[clang-tools-extra] 01303f6 - [clang-tidy] Fix crash in bugprone-suspicious-realloc-usage.

Author: Balázs Kéri Date: 2022-12-21T09:29:20+01:00 New Revision: 01303f6d1bba5f8640aab022469f9e9a9d66f877 URL: https://github.com/llvm/llvm-project/commit/01303f6d1bba5f8640aab022469f9e9a9d66f877 DIFF: https://github.com/llvm/llvm-project/commit/01303f6d1bba5f8640aab022469f9e9a9d66f877.diff L

[PATCH] D140194: [clang-tidy] Fix crash in bugprone-suspicious-realloc-usage.

This revision was automatically updated to reflect the committed changes. Closed by commit rG01303f6d1bba: [clang-tidy] Fix crash in bugprone-suspicious-realloc-usage. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140194/new/

[PATCH] D140195: [Clang][CGDebugInfo][ObjC] Mark objc bitfields with the DIFlagBitfield flag

jmmartinez added a comment. In D140195#4008724 , @aprantl wrote: >> Unluckly, I wasn't able to test the combination of >> https://reviews.llvm.org/D96334 and this patch together. If you have some >> pointers about how to trigger a test job on "Green Dra

[clang] 1341780 - [clang][AST] Compare UnresolvedLookupExpr in structural equivalence.

Author: Balázs Kéri Date: 2022-12-21T09:58:50+01:00 New Revision: 13417808474cacc064b90726705862a650c0b28a URL: https://github.com/llvm/llvm-project/commit/13417808474cacc064b90726705862a650c0b28a DIFF: https://github.com/llvm/llvm-project/commit/13417808474cacc064b90726705862a650c0b28a.diff L

[PATCH] D136848: [clang][AST] Compare UnresolvedLookupExpr in structural equivalence.

This revision was automatically updated to reflect the committed changes. Closed by commit rG13417808474c: [clang][AST] Compare UnresolvedLookupExpr in structural equivalence. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1368

[clang] 1118ee0 - [Clang][CGDebugInfo][ObjC] Mark objc bitfields with the DIFlagBitfield flag

Author: Juan Manuel MARTINEZ CAAMAÑO Date: 2022-12-21T04:00:40-05:00 New Revision: 1118ee04fc7c09bb54128bcaef4bd82835dcbafd URL: https://github.com/llvm/llvm-project/commit/1118ee04fc7c09bb54128bcaef4bd82835dcbafd DIFF: https://github.com/llvm/llvm-project/commit/1118ee04fc7c09bb54128bcaef4bd82

[PATCH] D140195: [Clang][CGDebugInfo][ObjC] Mark objc bitfields with the DIFlagBitfield flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG1118ee04fc7c: [Clang][CGDebugInfo][ObjC] Mark objc bitfields with the DIFlagBitfield flag (authored by jmmartinez). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D140432: [AArch64] Guard {vmull_p64, vmull_high_p64} with 'aes' target guard.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks for putting together the patch. It may be worth mentioning in the commit message that aes currently includes both FEAT_AES and FEAT_PMULL. Otherwise LGTM. Repository: rG LLVM Githu

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

pengfei created this revision. pengfei added reviewers: RKSimon, arsenm. Herald added a project: All. pengfei requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. @arsenm raised a good question that we should use a flag guard. But I found i

[PATCH] D140086: [analyzer][solver] Improve reasoning for not equal to operator

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. >>> Bitwidth was important because we should ideally cast smaller bitwidth type >>> to bigger bitwidth type. >>> Consider if we have LHS(u8), RHS(i32), then without checking for b

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14742 Builder.getFastMathFlags().setAllowReassoc(); -return Builder.CreateCall(F, {Ops[0], Ops[1]}); +Value *FAdd = Builder.CreateCall(F, {Ops[0], Ops[1]}); +Builder.getFastMathFlags(

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14742 Builder.getFastMathFlags().setAllowReassoc(); -return Builder.CreateCall(F, {Ops[0], Ops[1]}); +Value *FAdd = Builder.CreateCall(F, {Ops[0], Ops[1]}); +Builder.getFastMathFlags(

[PATCH] D140361: [RISCV] Merge Masked and unMasked RVV manual codegen

BeMg updated this revision to Diff 484498. BeMg added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140361/new/ https://reviews.llvm.org/D140361 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder marked 4 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:835 IsTemporary = true; Ty = E->getType(); } shafik wrote: > tbaeder wrote: > > shafik wrote: > > > Do we really want to the

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder updated this revision to Diff 484499. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135750/new/ https://reviews.llvm.org/D135750 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/

[PATCH] D136815: [clang][Interp] Unify visiting variable declarations

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1218 +auto GlobalIndex = P.getGlobal(VD); +assert(GlobalIndex); // visitVarDecl() didn't return false. +if (!this->emitGetPtrGlobal(*GlobalIndex, VD)) shafik wrote: >

[PATCH] D137070: [clang][Interp] Support destructors

tbaeder marked 2 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:30 /// Scope used to handle temporaries in toplevel variable declarations. -template class DeclScope final : public LocalScope { +template class DeclSc

[PATCH] D137070: [clang][Interp] Support destructors

tbaeder updated this revision to Diff 484500. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137070/new/ https://reviews.llvm.org/D137070 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/test/AST/

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

foad added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14740 CGM.getIntrinsic(Intrinsic::vector_reduce_fadd, Ops[1]->getType()); +FastMathFlags FMF = Builder.getFastMathFlags(); Builder.getFastMathFlags().setAllowReassoc(); We h

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

arsenm added a comment. Needs tests. I couldn’t find any for the base builtins either Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140467/new/ https://reviews.llvm.org/D140467 ___ cfe-commits mailing li

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

pengfei updated this revision to Diff 484521. pengfei marked an inline comment as done. pengfei added a comment. Use FastMathFlagGuard instead, thanks @foad! In D140467#4010296 , @arsenm wrote: > Needs tests. I couldn’t find any for the base builtins eit

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

pengfei added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14742 Builder.getFastMathFlags().setAllowReassoc(); -return Builder.CreateCall(F, {Ops[0], Ops[1]}); +Value *FAdd = Builder.CreateCall(F, {Ops[0], Ops[1]}); +Builder.getFastMathFlags() &=

[clang] b2638a7 - [clang] Do not extend i8 return values to i16 on AVR.

Author: Ben Shi Date: 2022-12-21T20:33:49+08:00 New Revision: b2638a7a34d97066caa234999055bf580cbab02f URL: https://github.com/llvm/llvm-project/commit/b2638a7a34d97066caa234999055bf580cbab02f DIFF: https://github.com/llvm/llvm-project/commit/b2638a7a34d97066caa234999055bf580cbab02f.diff LOG:

[PATCH] D139908: [clang] Do not extend i8 return values to i16 on AVR.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2638a7a34d9: [clang] Do not extend i8 return values to i16 on AVR. (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139908/new/ https

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

arsenm requested changes to this revision. arsenm added a comment. This revision now requires changes to proceed. In D140467#4010378 , @pengfei wrote: > Use FastMathFlagGuard instead, thanks @foad! > > In D140467#4010296

[clang] 016785d - [clang/xray] Convert tests to check 'target=...'

Author: Paul Robinson Date: 2022-12-21T05:19:27-08:00 New Revision: 016785d9316d8c5abc5fdf3cdb86479095bbb677 URL: https://github.com/llvm/llvm-project/commit/016785d9316d8c5abc5fdf3cdb86479095bbb677 DIFF: https://github.com/llvm/llvm-project/commit/016785d9316d8c5abc5fdf3cdb86479095bbb677.diff

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

arsenm added a comment. In D140467#4010507 , @arsenm wrote: > In D140467#4010378 , @pengfei wrote: > >> Use FastMathFlagGuard instead, thanks @foad! >> >> In D140467#4010296

[clang] 947905a - clang: Use correct address space for redeclared functions

Author: Matt Arsenault Date: 2022-12-21T08:27:24-05:00 New Revision: 947905a1c5843b677849c3c4fadb524b6405c139 URL: https://github.com/llvm/llvm-project/commit/947905a1c5843b677849c3c4fadb524b6405c139 DIFF: https://github.com/llvm/llvm-project/commit/947905a1c5843b677849c3c4fadb524b6405c139.diff

[clang] 7191232 - clang: Fix another assert from not respecting function address spaces

Author: Matt Arsenault Date: 2022-12-21T08:27:24-05:00 New Revision: 719123230577ebfb689b53ed09f4d06ddc1664ef URL: https://github.com/llvm/llvm-project/commit/719123230577ebfb689b53ed09f4d06ddc1664ef DIFF: https://github.com/llvm/llvm-project/commit/719123230577ebfb689b53ed09f4d06ddc1664ef.diff

[clang] 2bb5954 - clang: Respect function address space for __builtin_function_start

Author: Matt Arsenault Date: 2022-12-21T08:27:24-05:00 New Revision: 2bb59549e11fdb1d6b6c4e68f4572783f414d67f URL: https://github.com/llvm/llvm-project/commit/2bb59549e11fdb1d6b6c4e68f4572783f414d67f DIFF: https://github.com/llvm/llvm-project/commit/2bb59549e11fdb1d6b6c4e68f4572783f414d67f.diff

[PATCH] D138253: [-Wunsafe-buffer-usage] NFC: Implement fix-strategies and variable-use-claiming.

uabelho added a comment. It crashes on this as well: void f(int a[]) { int b = {a[1]}; } with clang -cc1 foo.c -Weverything I get clang: ../../clang/lib/Analysis/UnsafeBufferUsage.cpp:233: void (anonymous namespace)::DeclUseTracker::claimUse(const clang::DeclRefExpr *): Asser

[PATCH] D140475: BEGIN_PUBLIC test phabricator

merrymeerkat created this revision. Herald added a reviewer: NoQ. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. END_PUBLIC Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D140475

[PATCH] D140475: BEGIN_PUBLIC test phabricator

merrymeerkat updated this revision to Diff 484554. merrymeerkat added a comment. ?: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140475/new/ https://reviews.llvm.org/D140475 Files: clang/include/clang/Analysis/AnalysisDiagnostic.h Index: clan

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli updated this revision to Diff 484561. fpetrogalli added a comment. There is no need to use `target_include_directories(LLVMRISCVDesc PRIVATE ${LLVM_LIBRARY_DIR}/TargetParser/)` for components that are not related to the RISC-V target. Thank you @lenary for the suggestion! Repositor

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli updated this revision to Diff 484563. fpetrogalli added a comment. NFC - I just restored an empty line to prevent modifying a file that is not being touched by the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137517/new/ https:

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli updated this revision to Diff 484564. fpetrogalli added a comment. Same NFC - restore an empty line change... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137517/new/ https://reviews.llvm.org/D137517 Files: clang/lib/Basic/Targets/R

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

pengfei added a comment. > If it exists it must be tested. > Every piece of code generation needs to be tested. Let me show you the number: $ grep -rho '__builtin_ia32\w\+' clang/test/CodeGen | sort|uniq |wc -l 337 $ grep -rho '_mm512_\w\+' clang/test/CodeGen | sort|uniq |wc -l 2304 Not

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

lebedev.ri requested changes to this revision. lebedev.ri added a comment. In D140467#4010675 , @pengfei wrote: >> If it exists it must be tested. >> Every piece of code generation needs to be tested. > > Let me show you the number: > > $ grep -rho '__b

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

thakis added a comment. We think this is incorrect, see comments here: https://boringssl-review.googlesource.com/c/boringssl/+/55845/3/crypto/refcount_c11.c#18 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139266/new/ https://reviews.llvm.org/D139

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

thakis added a comment. (and https://bugs.chromium.org/p/chromium/issues/detail?id=1402885#c3) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139266/new/ https://reviews.llvm.org/D139266 ___ cfe-commits m

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam marked 3 inline comments as done. zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5006 +if (NeedsGlobalCtor || NeedsGlobalDtor) + DelayedCXXInitPosition[D] = ~0U; + } else { efriedma wrote: > zahiraam wrote: > >

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

arsenm added a comment. In D140467#4010675 , @pengfei wrote: > As I have explained, users are not suggested to use these builtins given we > have provided the more stable, well documented corresponding intrinsics. The > only case user has to use it is t

[PATCH] D140483: Remove empty header file.

merrymeerkat created this revision. Herald added a reviewer: NoQ. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D140483 Files: cl

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

compnerd added a comment. @thakis and https://github.com/llvm/llvm-project/issues/59640 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139266/new/ https://reviews.llvm.org/D139266 ___ cfe-commits mailing

[PATCH] D140433: [Clang] Add `nvptx-arch` tool to query installed NVIDIA GPUs

tianshilei1992 added inline comments. Comment at: clang/tools/nvptx-arch/NVPTXArch.cpp:63 + +printf("sm_%d%d\n", Major, Minor); + } Do we want to include device number here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D140433: [Clang] Add `nvptx-arch` tool to query installed NVIDIA GPUs

jhuber6 added inline comments. Comment at: clang/tools/nvptx-arch/NVPTXArch.cpp:63 + +printf("sm_%d%d\n", Major, Minor); + } tianshilei1992 wrote: > Do we want to include device number here? For `amdgpu-arch` and here we just have it implicitly in the order,

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

barannikov88 added inline comments. Comment at: llvm/lib/TargetParser/CMakeLists.txt:29 +# LLVMTargetParser. See https://stackoverflow.com/a/25681179 +target_include_directories(LLVMTargetParser PUBLIC $) Will it work if RISC-V target is not compiled-in? This do

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

ilinpv added a comment. In D127812#4009577 , @hctim wrote: > In D127812#4009447 , @hctim wrote: > >> Hi, this looks like a candidate for breaking the MSan bot: >> https://lab.llvm.org/buildbot/#/builders/5/buil

[PATCH] D140327: [clang] Remove overly restrictive aggregate paren init logic

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140327/new/ https://reviews.llvm.org/D140327 _

[clang] c77a91b - [clang] Remove overly restrictive aggregate paren init logic

Author: Alan Zhao Date: 2022-12-21T08:21:05-08:00 New Revision: c77a91bb7ba793ec3a6a5da3743ed55056291658 URL: https://github.com/llvm/llvm-project/commit/c77a91bb7ba793ec3a6a5da3743ed55056291658 DIFF: https://github.com/llvm/llvm-project/commit/c77a91bb7ba793ec3a6a5da3743ed55056291658.diff LOG

[PATCH] D140327: [clang] Remove overly restrictive aggregate paren init logic

This revision was automatically updated to reflect the committed changes. Closed by commit rGc77a91bb7ba7: [clang] Remove overly restrictive aggregate paren init logic (authored by ayzhao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140327/new/ h

[PATCH] D140433: [Clang] Add `nvptx-arch` tool to query installed NVIDIA GPUs

jhuber6 updated this revision to Diff 484594. jhuber6 added a comment. Change header I copied from the AMD implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140433/new/ https://reviews.llvm.org/D140433 Files: clang/tools/CMakeLists.t

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo marked 5 inline comments as done. abidmalikwaterloo added inline comments. Comment at: mlir/test/Dialect/OpenMP/ops.mlir:124 +// CHECK-LABEL: omp_DistributeOp +func.func @omp_DistributeOp(%lb : index, %ub : index, %step : index, %data_var : memref, %chunk_var

[PATCH] D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals

v1nh1shungry abandoned this revision. v1nh1shungry added a comment. Abandon because of the terrible implementation. - The cost seems to be higher than the value. - The place to insert isn't good enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D139534: [analyzer] Don't escape local static memregions on bind

steakhal added a comment. Finally, I had some time to come back to this. Thanks for taking the time for such a detailed response, kudos! @NoQ In D139534#3999455 , @NoQ wrote: > Ok screw it, my static example is still broken. There's technically still a

[PATCH] D139534: [analyzer] Don't escape local static memregions on bind

steakhal updated this revision to Diff 484600. steakhal added a comment. - Add two test cases demonstrating the false-positives this patch will introduce. These are semantically equivalent to the one mentioned in the comments by @NoQ. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] d4959b5 - [Driver] Fix tests not to fail randomly on Windows

Author: Paul Robinson Date: 2022-12-21T09:37:12-08:00 New Revision: d4959b5a4bb888789f99a952a1304ce915dfee2f URL: https://github.com/llvm/llvm-project/commit/d4959b5a4bb888789f99a952a1304ce915dfee2f DIFF: https://github.com/llvm/llvm-project/commit/d4959b5a4bb888789f99a952a1304ce915dfee2f.diff

[PATCH] D137838: [Support] Move TargetParsers to new component

dblaikie added a comment. This has introduced a circular dependency due to the forwarding header (forwarding header depends on new lib, new lib depends on support, where the forwarding header is). Generally this wouldn't be acceptable (& I'd suggest the patch be reverted on that basis) though I

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

hctim added a comment. In D127812#4010856 , @ilinpv wrote: > It would be great to have more details how to setup up your bot, using > buildbot_fast.sh on x86_64 Ubuntu 22.04 LTS leads to error ( pthreads > installed ): > > CMake Error at > /usr/share

[PATCH] D140432: [AArch64] Guard {vmull_p64, vmull_high_p64} with 'aes' target guard.

mingmingl updated this revision to Diff 484608. mingmingl added a comment. update commit message to mention target guard 'aes' includes both FEAT_AES and FEAT_PMULL currently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140432/new/ https://revie

[PATCH] D140432: [AArch64] Guard {vmull_p64, vmull_high_p64} with 'aes' target guard.

mingmingl added a comment. In D140432#4010143 , @dmgreen wrote: > Thanks for putting together the patch. It may be worth mentioning in the > commit message that aes currently includes both FEAT_AES and FEAT_PMULL. > Otherwise LGTM. Thanks for reviews! M

[PATCH] D115232: [clangd] Indexing of standard library

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:1008-1010 + // TUScheduler is the only thing that starts background indexing work. + if (IndexTasks && !IndexTasks->wait(timeoutSeconds(TimeoutSeconds))) +return false; b

[PATCH] D140486: [clangd] Fix crashing race in ClangdServer shutdown with stdlib indexing

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. In princip

[PATCH] D139701: [Clang] Emit "min-legal-vector-width" attribute for X86 only

arsenm added inline comments. Comment at: llvm/docs/LangRef.rst:2235-2241 -``"min-legal-vector-width"=""`` -This attribute indicates the minimum legal vector width required by the -calling convension. It is the maximum width of vector arguments and -returnings in the

[PATCH] D139261: [Clang] Modify sanity check assert in AggExprEmitter::VisitInitListExpr to cover anonymous struct in a union GNU extension

shafik updated this revision to Diff 484613. shafik added a comment. - Add Release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139261/new/ https://reviews.llvm.org/D139261 Files: clang/docs/ReleaseNotes.rst clang/lib/CodeGen/CGExprAgg.cpp clang/test/SemaCXX/anonymous-struc

[PATCH] D139261: [Clang] Modify sanity check assert in AggExprEmitter::VisitInitListExpr to cover anonymous struct in a union GNU extension

shafik added inline comments. Comment at: clang/lib/CodeGen/CGExprAgg.cpp:1688 for (const auto *Field : record->fields()) -assert(Field->isUnnamedBitfield() && "Only unnamed bitfields allowed"); +assert((Field->isUnnamedBitfield() || Field->isAnonymousStru

[PATCH] D115232: [clangd] Indexing of standard library

bnbarham added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:1008-1010 + // TUScheduler is the only thing that starts background indexing work. + if (IndexTasks && !IndexTasks->wait(timeoutSeconds(TimeoutSeconds))) +return false; sa

[clang] 475cc44 - [Clang] Modify sanity check assert in AggExprEmitter::VisitInitListExpr to cover anonymous struct in a union GNU extension

Author: Shafik Yaghmour Date: 2022-12-21T10:50:05-08:00 New Revision: 475cc44a2cba45c5449a323c6b331ddc593bd8de URL: https://github.com/llvm/llvm-project/commit/475cc44a2cba45c5449a323c6b331ddc593bd8de DIFF: https://github.com/llvm/llvm-project/commit/475cc44a2cba45c5449a323c6b331ddc593bd8de.dif

[PATCH] D139261: [Clang] Modify sanity check assert in AggExprEmitter::VisitInitListExpr to cover anonymous struct in a union GNU extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG475cc44a2cba: [Clang] Modify sanity check assert in AggExprEmitter::VisitInitListExpr to… (authored by shafik). Herald added a project: clang. Repos

[PATCH] D140433: [Clang] Add `nvptx-arch` tool to query installed NVIDIA GPUs

arsenm added inline comments. Comment at: clang/tools/nvptx-arch/NVPTXArch.cpp:37 +return 1; + printf("CUDA error: %s\n", ErrStr); + return 1; stderr? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140433/new/

[PATCH] D115232: [clangd] Indexing of standard library

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:1008-1010 + // TUScheduler is the only thing that starts background indexing work. + if (IndexTasks && !IndexTasks->wait(timeoutSeconds(TimeoutSeconds))) +return false; b

[clang] c847e22 - [AArch64] Guard {vmull_p64, vmull_high_p64} with 'aes' target guard.

Author: Mingming Liu Date: 2022-12-21T11:02:27-08:00 New Revision: c847e22db33e4625b1ad58b631f57d7d1e1944ca URL: https://github.com/llvm/llvm-project/commit/c847e22db33e4625b1ad58b631f57d7d1e1944ca DIFF: https://github.com/llvm/llvm-project/commit/c847e22db33e4625b1ad58b631f57d7d1e1944ca.diff

[PATCH] D140432: [AArch64] Guard {vmull_p64, vmull_high_p64} with 'aes' target guard.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc847e22db33e: [AArch64] Guard {vmull_p64, vmull_high_p64} with 'aes' target guard. (authored by mingmingl). Repository: rG LLVM Github Monorepo C

[PATCH] D115232: [clangd] Indexing of standard library

bnbarham added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:1008-1010 + // TUScheduler is the only thing that starts background indexing work. + if (IndexTasks && !IndexTasks->wait(timeoutSeconds(TimeoutSeconds))) +return false; sa

[clang] 6c3a290 - Headers: further refine the `stdatomic.h` MSVC inclusion

Author: Saleem Abdulrasool Date: 2022-12-21T19:09:10Z New Revision: 6c3a2902f1f8d102aa5b3cd37def4f1420ac0c80 URL: https://github.com/llvm/llvm-project/commit/6c3a2902f1f8d102aa5b3cd37def4f1420ac0c80 DIFF: https://github.com/llvm/llvm-project/commit/6c3a2902f1f8d102aa5b3cd37def4f1420ac0c80.diff

[PATCH] D140489: Add builtin_elementwise_log

bob80905 created this revision. bob80905 added reviewers: python3kgae, beanz. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add codegen for llvm log elementwise b

[PATCH] D140489: Add builtin_elementwise_log

bob80905 updated this revision to Diff 484633. bob80905 added a comment. Herald added subscribers: pcwang-thead, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook,

[PATCH] D140433: [Clang] Add `nvptx-arch` tool to query installed NVIDIA GPUs

jhuber6 updated this revision to Diff 484637. jhuber6 added a comment. Print to `stderr` and only return `1` if thre was an actual error. A lack of devices is considered a success and we print nothing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

efriedma added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5006 +if (NeedsGlobalCtor || NeedsGlobalDtor) + DelayedCXXInitPosition[D] = ~0U; + } else { zahiraam wrote: > efriedma wrote: > > zahiraam wrote: > > > Do you agree this sho

[PATCH] D137838: [Support] Move TargetParsers to new component

fpetrogalli added a comment. In D137838#4010987 , @dblaikie wrote: > This has introduced a circular dependency due to the forwarding header > (forwarding header depends on new lib, new lib depends on support, where the > forwarding header is). Generally

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

ilinpv added a comment. In D127812#4010993 , @hctim wrote: > Hmm, not exactly sure what's going on with the `could NOT find Threads` > there. A quick googling seems to point to pthreads.so not being in the right > places, but I don't think the buildbot

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

njames93 added a comment. In D138655#4007822 , @carlosgalvezp wrote: > Now that I think a bit better about this I wonder - does it really make sense > that we increase the complexity of the check to cover for cases where code > does not compile? If it

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli updated this revision to Diff 484649. fpetrogalli marked 5 inline comments as done. fpetrogalli added a comment. I submitted some of the cleanup suggested by @barannikov88 - thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137517

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli added inline comments. Comment at: llvm/utils/TableGen/RISCVTargetDefEmitter.cpp:15 +#include "llvm/TableGen/Record.h" +#include +namespace llvm { barannikov88 wrote: > [[ > https://llvm.org/docs/CodingStandards.html#include-iostream-is-forbidden |

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

hctim added a comment. In D127812#4011372 , @ilinpv wrote: > Regular builds works fine for me, pthreads located here > "/lib/x86_64-linux-gnu/libpthread.so" > "/usr/lib/x86_64-linux-gnu/libpthread.so". Enabling > "-DLLVM_USE_SANITIZER=Memory" resulted

[PATCH] D140315: [AMDGCN] Update search path for device libraries

yaxunl added a comment. files under clang/test/Driver/Inputs/rocm_resource_dir/lib/amdgcn/bitcode-no-abi-ver seem not used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140315/new/ https://reviews.llvm.org/D140315 __

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

barannikov88 added inline comments. Comment at: llvm/utils/TableGen/RISCVTargetDefEmitter.cpp:16 +#include +namespace llvm { + fpetrogalli wrote: > barannikov88 wrote: > > This [[ > > https://llvm.org/docs/CodingStandards.html#use-namespace-qualifiers-to-implem

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli marked an inline comment as done. fpetrogalli added inline comments. Comment at: llvm/lib/TargetParser/CMakeLists.txt:29 +# LLVMTargetParser. See https://stackoverflow.com/a/25681179 +target_include_directories(LLVMTargetParser PUBLIC $) barannikov88

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

shafik accepted this revision. shafik added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137232/new/ https://reviews.llvm.org/D137232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli marked an inline comment as done. fpetrogalli added inline comments. Comment at: llvm/utils/TableGen/RISCVTargetDefEmitter.cpp:52 + for (auto &Def : Map) { +const auto &Record = Def.second; +if (Record->isSubClassOf("RISCVProcessorModelTUNE_PROC")) --

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli updated this revision to Diff 484654. fpetrogalli marked an inline comment as done. fpetrogalli added a comment. ops - this was wrong: /Users/fpetrogalli/projects/cpu-defs/upstream/llvm-project/llvm/utils/TableGen/RISCVTargetDefEmitter.cpp:38:17: error: variable 'Record' with type

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli updated this revision to Diff 484655. fpetrogalli added a comment. Restore the following... -const auto *Record = Def.second; +const auto &Record = Def.second; ... to prevent this error: /<...>/llvm-project/llvm/utils/TableGen/RISCVTargetDefEmitter.cpp:38:17: error: v

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

shafik added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:918 return false; + if (!Ptr.isRoot()) +Ptr.initialize(); tbaeder wrote: > shafik wrote: > > Can you explain what is going on here? Why do we need to initialize if it > > is not ro

[PATCH] D137070: [clang][Interp] Support destructors

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137070/new/ https://reviews.llvm.org/D137070 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D138392: clang/HIP: Fix broken implementations of __make_mantissa* functions

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. It seems gcc assumes the argument to nan is nonnull (https://godbolt.org/z/xzb8T6Gon), so we can assume that too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138392/n

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli updated this revision to Diff 484658. fpetrogalli marked an inline comment as done. fpetrogalli added a comment. Remove `RISCVTargetParser.def` from the module map. Follow the guidelines on using namespace llvm

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

barannikov88 added inline comments. Comment at: llvm/utils/TableGen/RISCVTargetDefEmitter.cpp:52 + for (auto &Def : Map) { +const auto &Record = Def.second; +if (Record->isSubClassOf("RISCVProcessorModelTUNE_PROC")) fpetrogalli wrote: > barannikov88 wrot

  1   2   >