tbaeder marked 2 inline comments as done.
tbaeder added inline comments.
================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:30
/// Scope used to handle temporaries in toplevel variable declarations.
-template <class Emitter> class DeclScope final : public LocalScope<Emitter> {
+template <class Emitter> class DeclScope final : public VariableScope<Emitter>
{
public:
----------------
shafik wrote:
> Why the change from `LocalScope` to `VariableScope`?
I changed `VariableScope` to do the destructor handling, bu that's not needed
for "temporaries in toplevel variable desclarations" (also, but unrelated,
inherting from something called "local scope" but then explaining in a comment
that it's only used for toplevel declarations is kinda weird).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137070/new/
https://reviews.llvm.org/D137070
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
