[PATCH] D139281: [clang-format] Fix an assertion failure in block parsing

owenpan added a comment. In D139281#3969880 , @HazardyKnusperkeks wrote: > We should rename, remove, or re add the functionality for this function. Or > else someone new will come along and be confused. +1 Repository: rG LLVM Github Monorepo CHANG

[PATCH] D138489: [tsan] Add tsan support for loongarch64

dvyukov accepted this revision. dvyukov added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp:1526 + + /* if ($a0 != 0) + * return $a0; Please use C-style one-line comments // Repository: rG LLVM Github Monorepo

[PATCH] D139302: [RISCV] Add Syntacore SCR1 CPU model

dnpetrov-sc created this revision. dnpetrov-sc added reviewers: craig.topper, anton-afanasyev, asi-sc. Herald added subscribers: sunshaoce, VincentWu, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, Mart

[clang] 64428c0 - [NFC][clang] Strengthen checks in matrix-type-operators.cpp

Author: John McIver Date: 2022-12-05T10:12:25Z New Revision: 64428c0ddf55295c270569db7f581ac7bedeff87 URL: https://github.com/llvm/llvm-project/commit/64428c0ddf55295c270569db7f581ac7bedeff87 DIFF: https://github.com/llvm/llvm-project/commit/64428c0ddf55295c270569db7f581ac7bedeff87.diff LOG: [

[clang] 553bdf4 - [NFC][clang] Strengthen checks in matrix-type-operators.c

Author: John McIver Date: 2022-12-05T10:13:35Z New Revision: 553bdf4fde5a4638f3a7764a4f6c209b9cd36a09 URL: https://github.com/llvm/llvm-project/commit/553bdf4fde5a4638f3a7764a4f6c209b9cd36a09 DIFF: https://github.com/llvm/llvm-project/commit/553bdf4fde5a4638f3a7764a4f6c209b9cd36a09.diff LOG: [

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/ https://reviews.llvm.org/D136594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D136809: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice updated this revision to Diff 480025. paperchalice added reviewers: tstellar, MaskRay. paperchalice added a comment. Herald added a subscriber: StephenFan. Use genex `$` due to `CMAKE_CFG_INTDIR` is deprecated since cmake 3.21. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D139274: Store OptTable::Info::Name as a StringRef

nikic added a comment. Build failure in pre-merge checks: FAILED: lib/Option/CMakeFiles/LLVMOption.dir/OptTable.cpp.o CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++ -DBUILD_EXAMPLES -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACRO

[clang-tools-extra] fceec8d - Fix MSVC "not all control paths return a value" warning. NFC.

Author: Simon Pilgrim Date: 2022-12-05T10:39:54Z New Revision: fceec8dcd8da66fa611e7fd104052fa37b65aecb URL: https://github.com/llvm/llvm-project/commit/fceec8dcd8da66fa611e7fd104052fa37b65aecb DIFF: https://github.com/llvm/llvm-project/commit/fceec8dcd8da66fa611e7fd104052fa37b65aecb.diff LOG:

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

hokein added a comment. sorry for the delay, just realize it is sitting in the review list, left some comments. Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:25 +// Gets all the providers for a symbol by tarversing each location. +llvm::SmallVector findAllHead

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

TIFitis updated this revision to Diff 480029. TIFitis added a comment. Herald added a subscriber: Moerafaat. Changed map_operands to VariadicOfVariadic type. Variadic Enums are not supported, hence I've changed the map type to VariadicOfVariadic which allows to store the entire map clause includ

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

Michael137 added a comment. In D127284#3969975 , @v.g.vassilev wrote: > In D127284#3969593 , @Michael137 > wrote: > >> In D127284#3969458 , @v.g.vassilev >> wrote: >> >

[PATCH] D139107: [clangd] Allow to build Clangd without decision forest

ilya-biryukov updated this revision to Diff 480034. ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. - Merge DecisionForest.cpp and *_disabled.cpp, change #ifndef to #if - Add decision_forest to the feature string - Set Heuristics as the default code completion model

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

TIFitis marked an inline comment as done. TIFitis added a comment. If people are happy with this structure then I'll work on adding a pretty printer for the map clause. Please suggest any other changes that are required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D139107: [clangd] Allow to build Clangd without decision forest

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Features.inc.in:7 #define CLANGD_TIDY_CHECKS @CLANGD_TIDY_CHECKS@ +#define CLANGD_DECISION_FOREST @CLANGD_DECISION_FOREST@ sammccall wrote: > we **could** include this in the feature-strin

[clang] 541a137 - Revert "[AArch64] Improve TargetParser API"

Author: Tomas Matheson Date: 2022-12-05T11:09:03Z New Revision: 541a1371c05d77bb70a6173127d6544b9571dbab URL: https://github.com/llvm/llvm-project/commit/541a1371c05d77bb70a6173127d6544b9571dbab DIFF: https://github.com/llvm/llvm-project/commit/541a1371c05d77bb70a6173127d6544b9571dbab.diff LOG

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added subscribers: luismarques, s.egerton, Jim, PkmX, simoncook, kristof.beyls, arichardson. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, pcwan

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR

benshi001 added inline comments. Comment at: clang/test/Driver/avr-mmcu.c:48 -// RUN: %clang -### --target=avr -mmcu=atmega16a -save-temps %s 2>&1 | FileCheck -check-prefix=CHECKb %s -// CHECKb: "-cc1" {{.*}} "-target-cpu" "atmega16a" -// CHECKb: "-cc1as" {{.*}} "-target-cpu" "a

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a comment. > Latest test run: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/48911/execution/node/74/log/ > I modified the expected string slightly to make it work: > https://reviews.llvm.org/rG811ad246ac7b > Should be all good now. Thanks for looking into this!

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR

arichardson added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:387 return A->getValue(); +if (const Arg *A = Args.getLastArg(options::OPT_mcpu_EQ)) + return A->getValue(); It looks to me that -mcpu will always take prece

[clang-tools-extra] 14af1ad - [include-cleaner] Add two command-line flags to the include-cleaner

Author: Haojian Wu Date: 2022-12-05T12:20:34+01:00 New Revision: 14af1ad4ee0ab0c453af75e43cf469bd530536cf URL: https://github.com/llvm/llvm-project/commit/14af1ad4ee0ab0c453af75e43cf469bd530536cf DIFF: https://github.com/llvm/llvm-project/commit/14af1ad4ee0ab0c453af75e43cf469bd530536cf.diff LO

[PATCH] D139305: [clang][driver] Make option '-mmcu' as an alias of option '-mcpu'

benshi001 updated this revision to Diff 480040. benshi001 retitled this revision from "[clang][driver] Support option '-mcpu' on target AVR" to "[clang][driver] Make option '-mmcu' as an alias of option '-mcpu'". Herald added a subscriber: jeroen.dobbelaere. CHANGES SINCE LAST ACTION https://r

[PATCH] D139305: [clang][driver] Make option '-mmcu' as an alias of option '-mcpu'

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:387 return A->getValue(); +if (const Arg *A = Args.getLastArg(options::OPT_mcpu_EQ)) + return A->getValue(); aricha

[PATCH] D138792: [AArch64] Improve TargetParser API

tmatheson added a comment. @MaskRay I reverted that commit because it broke important functionality (comparison by address) to fix an issue in an unsupported C++ version, it wasn't reviewed, and it was not clear from the commit message what it was fixing. I explained this in a comment on the or

[PATCH] D138489: [tsan] Add tsan support for loongarch64

tangyouling updated this revision to Diff 480044. tangyouling added a comment. Use C-style one-line comments //. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138489/new/ https://reviews.llvm.org/D138489 Files: clang/lib/Driver/ToolChains/Linux.

[PATCH] D139107: [clangd] Allow to build Clangd without decision forest

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Looks great, thanks! Comment at: clang-tools-extra/clangd/CMakeLists.txt:21 +option(CLANGD_DECISION_FOREST "Enable decision forest model for ranking code completion

[PATCH] D136078: Use-after-return sanitizer binary metadata

dvyukov updated this revision to Diff 480051. dvyukov added a comment. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Moved tests to compiler-rt and rebased to HEAD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136078/ne

[PATCH] D136078: Use-after-return sanitizer binary metadata

dvyukov added a comment. PTAL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136078/new/ https://reviews.llvm.org/D136078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

ben.boeckel added inline comments. Comment at: clang/test/ClangScanDeps/P1689.cppm:155 +// CHECK-MAKE: [[PREFIX]]/impl_part.o: +// CHECK-MAKE: [[PREFIX]]/impl_part.cppm ChuanqiXu wrote: > ben.boeckel wrote: > > ChuanqiXu wrote: > > > ben.boeckel wrote: > > >

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

ben.boeckel added inline comments. Comment at: clang/test/ClangScanDeps/P1689.cppm:155 +// CHECK-MAKE: [[PREFIX]]/impl_part.o: +// CHECK-MAKE: [[PREFIX]]/impl_part.cppm ben.boeckel wrote: > ChuanqiXu wrote: > > ben.boeckel wrote: > > > ChuanqiXu wrote: > > >

[PATCH] D136809: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice updated this revision to Diff 480054. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136809/new/ https://reviews.llvm.org/D136809 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Tooling/CMakeLists.txt clang/runtime/CMakeLists.txt

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin updated this revision to Diff 480062. cor3ntin added a comment. Add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://reviews.llvm.org/D138861 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/Lexer.cpp clang/

[clang] a446827 - [NFC][Clang][Driver][AMDGPU] Avoid temporary copies of std::string by using Twine and StringRef

Author: Juan Manuel MARTINEZ CAAMAÑO Date: 2022-12-05T07:27:10-06:00 New Revision: a446827249bdeb2f27e55a9f4942bd7425ecb0ff URL: https://github.com/llvm/llvm-project/commit/a446827249bdeb2f27e55a9f4942bd7425ecb0ff DIFF: https://github.com/llvm/llvm-project/commit/a446827249bdeb2f27e55a9f4942bd7

[PATCH] D139023: [NFC][Clang][Driver][AMDGPU] Avoid temporary copies of std::string by using Twine and StringRef

This revision was automatically updated to reflect the committed changes. Closed by commit rGa446827249bd: [NFC][Clang][Driver][AMDGPU] Avoid temporary copies of std::string by using… (authored by jmmartinez). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D139023: [NFC][Clang][Driver][AMDGPU] Avoid temporary copies of std::string by using Twine and StringRef

jmmartinez added a comment. @tra Thanks for the review! I double checked with ASAN and there were no issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139023/new/ https://reviews.llvm.org/D139023 ___

[clang] dbe8c2c - Use-after-return sanitizer binary metadata

Author: Dmitry Vyukov Date: 2022-12-05T14:40:31+01:00 New Revision: dbe8c2c316c40b25a0a37b91f1a1a02a55182378 URL: https://github.com/llvm/llvm-project/commit/dbe8c2c316c40b25a0a37b91f1a1a02a55182378 DIFF: https://github.com/llvm/llvm-project/commit/dbe8c2c316c40b25a0a37b91f1a1a02a55182378.diff

[PATCH] D136078: Use-after-return sanitizer binary metadata

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdbe8c2c316c4: Use-after-return sanitizer binary metadata (authored by dvyukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri added inline comments. Comment at: clang/test/CodeGen/windows-seh-EHa-CppCondiTemps.cpp:3 +// FIXME: this check appears to be miscompiled? +// XFAIL: * tentzen wrote: > lebedev.ri wrote: > > This test broke once we always started adding (outermost) U

[clang] df41577 - [LinkerWrapper] Fix use-after-free when using JIT

Author: Joseph Huber Date: 2022-12-05T07:51:20-06:00 New Revision: df415774d2a584fb6a62bedf9a4ee936396a0e41 URL: https://github.com/llvm/llvm-project/commit/df415774d2a584fb6a62bedf9a4ee936396a0e41 DIFF: https://github.com/llvm/llvm-project/commit/df415774d2a584fb6a62bedf9a4ee936396a0e41.diff

[clang] 0b01e3d - clang: Convert builtins test to opaque pointers

Author: Matt Arsenault Date: 2022-12-05T09:01:52-05:00 New Revision: 0b01e3d0ae1f81b7e823397ed5a452025e8a751b URL: https://github.com/llvm/llvm-project/commit/0b01e3d0ae1f81b7e823397ed5a452025e8a751b DIFF: https://github.com/llvm/llvm-project/commit/0b01e3d0ae1f81b7e823397ed5a452025e8a751b.diff

[PATCH] D136078: Use-after-return sanitizer binary metadata

thakis added a comment. This seems to break tests: http://45.33.8.238/linux/93224/step_12.txt Can you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136078/new/ https://reviews.llvm.org/D136078

[PATCH] D136078: Use-after-return sanitizer binary metadata

dvyukov added a comment. In D136078#3970792 , @thakis wrote: > This seems to break tests: http://45.33.8.238/linux/93224/step_12.txt > > Can you take a look? Looking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D124351: [Clang][WIP] Implement Change scope of lambda trailing-return-type - Take 2

erichkeane added a comment. In D124351#3950805 , @cor3ntin wrote: > Rebase. This is still a bit rough, I have a few tests to fix > and some dead code to remove. > > --- > > @erichkeane I wouldn't mind picking your brain on this. > Consider: > > templat

[PATCH] D136078: Use-after-return sanitizer binary metadata

dvyukov added a comment. Fix for: -- Supported architectures for crt: aarch64 CMake Error at compiler-rt/cmake/config-ix.cmake:244 (message): Unsupported architecture: x86_64 Call Stack (most recent call first): compiler-rt/cmake/config-ix.cmake:280 (get_target_flags_for_arch) c

[PATCH] D136078: Use-after-return sanitizer binary metadata

dvyukov added a comment. In D136078#3970792 , @thakis wrote: > This seems to break tests: http://45.33.8.238/linux/93224/step_12.txt > > Can you take a look? Sent a fix: https://reviews.llvm.org/D139325 Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

erichkeane added inline comments. Comment at: clang/test/Frontend/sarif-reason.cpp:15 +void g() { + f1<0>(); // expected-error{{no matching function for call to 'f1'}} + f1(); // expected-error{{no matching function for call to 'f1'}} cjdb wrote: > erichkeane w

[PATCH] D136078: Use-after-return sanitizer binary metadata

dvyukov added a comment. FTR 2 breakage fixes merged: https://github.com/llvm/llvm-project/commit/2a05bd212e3e8aaed818ee23464f4d1fe0b0596d https://github.com/llvm/llvm-project/commit/08742e72a34e835e6fc3c696eabe6045c78d6289 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D139326: [clang] Add test for CWG952

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : // CWG952 is r

[PATCH] D139173: [clang] Add test for CWG600

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139173/new/ https://reviews.llvm.org/D139173 ___ cfe-commits mailing lis

[PATCH] D139086: [AArch64] Implement __arm_rsr128/__arm_wsr128

pratlucas accepted this revision. pratlucas added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139086/new/ https://reviews.llvm.org/D139086 _

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:13156 getSema().buildLambdaInitCaptureInitialization( - C->getLocation(), OldVD->getType()->isReferenceType(), + C->getLocation(), isReferenceType, Ellip

[PATCH] D139326: [clang] Add test for CWG952

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This appears right to me! I'd like others to take a look though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139326/new/ https://revi

[PATCH] D139095: [clang] Add test for CWG405

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CXX/drs/dr4xx.cpp:99 +void test3(A::S as) { using A::f; f(as); } // ok +void test4(A::S as) { using B::f; f(as); } // ok +

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

jhuber6 added a comment. Why do we have the JIT in the nextgen plugins? I figured that JIT would be handled by `libomptarget` proper rather than the plugins. I guess this is needed for per-kernel specialization? My idea of the rough pseudocode would be like this and we wouldn't need a complex c

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

ahatanak updated this revision to Diff 480101. ahatanak marked an inline comment as done. ahatanak added a comment. Add another environment variable `CC_PRINT_HEADERS_FILTERING`, which can be used to specify whether header information should be filtered or not. Currently, `CC_PRINT_HEADERS_FORMA

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 added a comment. In D139287#3970996 , @jhuber6 wrote: > Why do we have the JIT in the nextgen plugins? I figured that JIT would be > handled by `libomptarget` proper rather than the plugins. I guess this is > needed for per-kernel special

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

tahonermann added a comment. > I am bit afraid about release builds: > > if (!Initializer) > > return; > > Is this semantically incorrect? I think so. And now I think I see a path where the proposed `assert` is incorrect as well. The `else` branches at lines 5919, 5921, and 5923 appear to han

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

jhuber6 added a comment. In D139287#3971024 , @tianshilei1992 wrote: > In D139287#3970996 , @jhuber6 wrote: > >> Why do we have the JIT in the nextgen plugins? I figured that JIT would be >> handled by `libompta

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 added a comment. In D139287#3971062 , @jhuber6 wrote: > In D139287#3971024 , > @tianshilei1992 wrote: > >> In D139287#3970996 , @jhuber6 >> wrote: >> >>>

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp:184 + + auto AddStream = + [&](size_t Task, jhuber6 wrote: > tianshilei1992 wrote: > > jhuber6 wrote: > > > tianshilei1992 wrote: > > > > I

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

jhuber6 added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp:184 + + auto AddStream = + [&](size_t Task, tianshilei1992 wrote: > jhuber6 wrote: > > tianshilei1992 wrote: > > > jhuber6 wrote: > > > > tianshil

[clang] d4f1f35 - [clang][Interp][NFC] Move to std::optional

Author: Timm Bäder Date: 2022-12-05T17:31:49+01:00 New Revision: d4f1f35978c2593f7c52452d699a96899725452e URL: https://github.com/llvm/llvm-project/commit/d4f1f35978c2593f7c52452d699a96899725452e DIFF: https://github.com/llvm/llvm-project/commit/d4f1f35978c2593f7c52452d699a96899725452e.diff LO

[PATCH] D137756: [z/OS][p][pg] Throw Error When Using -p or -pg on z/OS

francii updated this revision to Diff 480130. francii marked an inline comment as not done. francii added a comment. Remove -p references Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137756/new/ https://reviews.llvm.org/D137756 Files: clang/lib

[PATCH] D138862: [Clang] Do not set offload kind in a freestanding build

jhuber6 added a comment. In D138862#3955581 , @tra wrote: > OK. So, we do need a flag, at least for now. I think we'll need a new one, > because `-freestanding` will likely do a lot of things we don't actually want > on the host side. > How about `--off

[PATCH] D138788: [SVE] Change some bfloat lane intrinsics to use i32 immediates

paulwalker-arm added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:2527 -def int_aarch64_sve_bfdot_lane : SVE_4Vec_BF16_Indexed; -def int_aarch64_sve_bfmlalb_lane : SVE_4Vec_BF16_Indexed; -def int_aarch64_sve_bfmlalt_lane : SVE_4Vec_BF16_Indexed; +def

[PATCH] D138511: [CodeGen][AArch64] Fix AArch64ABIInfo::EmitAAPCSVAArg crash with empty record type in variadic arg

yronglin added a comment. pin~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138511/new/ https://reviews.llvm.org/D138511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ilya-biryukov added a comment. Thanks! I have two major comments and also inline NITs. Not sure if we should block on those, just wanted to hear your opinions: - `InitListExpr` and `CXXParenInitListExpr` have some code in common. Code duplication is substantial and I think sharing the common i

[PATCH] D139343: [Driver][PPC] Support -mtune=auto

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, nemanjai, MaskRay. qiongsiwu1 added projects: clang, PowerPC. Herald added subscribers: StephenFan, shchenz, kbarton. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added a subscriber: cfe-comm

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

efriedma added inline comments. Comment at: clang/test/CodeGen/windows-seh-EHa-CppCondiTemps.cpp:3 +// FIXME: this check appears to be miscompiled? +// XFAIL: * lebedev.ri wrote: > tentzen wrote: > > lebedev.ri wrote: > > > This test broke once we always starte

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo updated this revision to Diff 480159. abidmalikwaterloo marked 3 inline comments as done. abidmalikwaterloo added a comment. Update the patch based on the feedback and comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105584/

[PATCH] D139343: [Driver][PPC] Support -mtune=auto

qiongsiwu1 abandoned this revision. qiongsiwu1 added a comment. It is decided that we no longer need this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139343/new/ https://reviews.llvm.org/D139343 ___

[PATCH] D139172: [clang] Mark CWG554 as N/A

shafik accepted this revision. shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139172/new/ https://reviews.llvm.org/D139172 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D139326: [clang] Add test for CWG952

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, though I would appreciate another test (that I expect to pass). Comment at: clang/test/CXX/drs/dr9xx.cpp:76 +namespace dr952 { // dr952: yes +struct A { + typedef int I; // #dr952-typedef-decl -

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri marked 2 inline comments as done. lebedev.ri added inline comments. Comment at: clang/test/CodeGen/windows-seh-EHa-CppCondiTemps.cpp:3 +// FIXME: this check appears to be miscompiled? +// XFAIL: * efriedma wrote: > lebedev.ri wrote: > > tentzen wrote

[PATCH] D137020: [clang][AST] Handle variable declaration with unknown typedef in C

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:177-178 + case tok::kw___attribute: + case tok::kw_const: + case tok::kw_volatile: + case tok::star: urazoff wrote: > aaron.ballman wrote: > > What about other qualifiers? `_Nullab

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao marked 4 inline comments as done. ayzhao added a comment. In D129531#3971392 , @ilya-biryukov wrote: > Thanks! > > I have two major comments and also inline NITs. Not sure if we should block > on those, just wanted to hear your opinions: > > - `I

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 480184. ayzhao added a comment. use NumUserSpecifiedExprs instead of syntatic/semantic forms, also address some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D12953

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri added a comment. (ping, maybe) In D138958#3968118 , @lebedev.ri wrote: > I've been thinking, and it seems to me that explicitly opting into > `__attribute__((nounwind))`-provided semantics should override > the `__attribute__((nothrow))`/`noe

[PATCH] D139261: [Clang] Modify sanity check assert in AggExprEmitter::VisitInitListExpr to cover anonymous struct in a union GNU extension

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a formatting nit fixed, but you should add a release note for the fix when landing. Comment at: clang/lib/CodeGen/CGExprAgg.cpp:1688 for (cons

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/CodeGen/CGExprAgg.cpp:581 + Expr *filler = nullptr; + if (auto *ILE = dyn_cast(ExprToVisit)) +filler = ILE->getArrayFiller(); ayzhao wrote: > ilya-biryukov wrote: > > ilya-biryukov wrote: > > > ayzhao wrot

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 480189. ayzhao marked 2 inline comments as done. ayzhao added a comment. add missing EOF newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/Re

[PATCH] D137756: [z/OS][p][pg] Throw Error When Using -p or -pg on z/OS

MaskRay added a comment. See `clang/lib/Driver/ToolChains/Clang.cpp:6191` `if (TC.SupportsProfiling()) {`. You can define `SupportsProfiling` as false for zos. It's a `-Wunused-command-line-argument` warning, not an error, but may be good enough. `-p` has already been handled. Repository:

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam updated this revision to Diff 480198. zahiraam edited the summary of this revision. Herald added subscribers: pcwang-thead, nlopes, abrachet, sstefan1, phosek, s.egerton, ormris, mstorsjo, simoncook, fedor.sergeev, aheejin, dschuff. Herald added a reviewer: jdoerfert. Herald added a revie

[PATCH] D138511: [CodeGen][AArch64] Fix AArch64ABIInfo::EmitAAPCSVAArg crash with empty record type in variadic arg

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Please don't ping every day. We haven't lost track of your patch, we're just busy reviewing other things. This seems reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D139360: [clang][dataflow] Support (in)equality operators in `optional` model.

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This patch adds interpretation of the overloa

[PATCH] D138337: Add support for kcfi-seal optimization with LTO

pcc added a comment. Can't this be implicit if LTO is being used? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138337/new/ https://reviews.llvm.org/D138337 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D139038: [Clang] Don't consider default constructors ineligible if the more constrained constructor is a template

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d58c95635cc: [Clang] Don't consider default constructors ineligible if the more constrained… (authored by royjacobson). Repository: rG LLVM Githu

[clang] 7d58c95 - [Clang] Don't consider default constructors ineligible if the more constrained constructor is a template

Author: Roy Jacobson Date: 2022-12-05T23:02:37+02:00 New Revision: 7d58c95635cce63ce6acd43c953b57f10bf5c686 URL: https://github.com/llvm/llvm-project/commit/7d58c95635cce63ce6acd43c953b57f10bf5c686 DIFF: https://github.com/llvm/llvm-project/commit/7d58c95635cce63ce6acd43c953b57f10bf5c686.diff

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir updated this revision to Diff 480217. schittir added a comment. Move the assert to after the branches that handle the cases where Initializer may be null CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139148/new/ https://reviews.llvm.org/D139148 Files: clang/lib/Sema/SemaIni

[PATCH] D139360: [clang][dataflow] Support (in)equality operators in `optional` model.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139360/new/ https://reviews.llvm.org/D139360

[PATCH] D139137: add floor library function

bob80905 updated this revision to Diff 480218. bob80905 added a comment. - update with clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139137/new/ https://reviews.llvm.org/D139137 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h clan

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir added a comment. > Perhaps the` assert` should be added after line 5926 above. Done. > I think the checks for `Initializer` being non-null following the addition of > an `assert` should be removed. I don't see any after this point. CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir added a comment. In D139148#3969383 , @tahonermann wrote: > When committing changes to address Coverity reported issues, I think it would > be useful to include the Coverity analysis in the commit message. A textual > representation can be obt

[PATCH] D138337: Add support for kcfi-seal optimization with LTO

samitolvanen added a comment. In D138337#3972009 , @pcc wrote: > Can't this be implicit if LTO is being used? I would prefer to keep this behind a flag (similarly to `-mibt-seal`), so we can better control when and where the optimization enabled. For ex

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

kda added a comment. Is there a risk of this being too strict for standard C? Should there be a test case for our specific problem? (C calling C++) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139296/new/ https://reviews.llvm.org/D139296 __

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

jansvoboda11 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5660 +"-header-include-filtering=" + +std::string(D.CCPrintHeadersFiltering ? "on" : "off"))); } Let's change "on" to something that won't interfere with pote

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

efriedma added a comment. (-Wglobal-constructors warning is still not implemented.) Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:572 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); + } else if (D->hasConstantInitialization() && !(D->hasAttr())) { +OrderG

[libunwind] 96d6399 - Revert "[CMake] Use LLVM_TARGET_TRIPLE in runtimes"

Author: Leonard Chan Date: 2022-12-05T22:20:51Z New Revision: 96d63993dd3698bbf2d6a83c035cd05faed7317b URL: https://github.com/llvm/llvm-project/commit/96d63993dd3698bbf2d6a83c035cd05faed7317b DIFF: https://github.com/llvm/llvm-project/commit/96d63993dd3698bbf2d6a83c035cd05faed7317b.diff LOG:

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

vitalybuka added a comment. In D139296#3972142 , @kda wrote: > Is there a risk of this being too strict for standard C? > > Should there be a test case for our specific problem? (C calling C++) Probably not. It's cross module mismatch. To reproduce we n

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

tahonermann added a comment. > I don't see any after this point. You're right! I thought I had seen some, but upon checking, I agree. That is a good sign we're on the right path! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139148/new/ https://reviews.llvm.org/D139148 __

  1   2   >