[PATCH] D137520: [AVR][Clang] Move family names into MCU list

benshi001 accepted this revision. benshi001 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137520/new/ https://reviews.llvm.org/D137520 _

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 474676. tbaeder added a comment. Added the int-to-float conversion tests from https://reviews.llvm.org/D137719 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 Files: clang/lib/AST/CMakeLists.txt clang/

[PATCH] D137521: [AVR][Clang] Implement __AVR_ARCH__ macro

benshi001 accepted this revision. benshi001 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137521/new/ https://reviews.llvm.org/D137521 _

[PATCH] D137770: [docs] Introduce clangd part in StandardCPlusPlusModules

nridge added a comment. In D137770#3919327 , @ChuanqiXu wrote: > And we need the compiler (clang) to parse the module file from different > versions. I think it's more likely that we'll need to get clangd to build the modules itself (or by using a clan

[PATCH] D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals

v1nh1shungry created this revision. v1nh1shungry added reviewers: tom-anders, kadircet. Herald added subscribers: arphaman, mgrang. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: cla

[PATCH] D137818: Add support for querying SubstTemplateTypeParm types

anderslanglands created this revision. anderslanglands added reviewers: tbaeder, aaron.ballman. Herald added subscribers: arphaman, kristof.beyls. Herald added a project: All. anderslanglands requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D137320: [include-cleaner] Initial version for the "Location=>Header" step

hokein updated this revision to Diff 474685. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137320/new/ https://reviews.llvm.org/D137320 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysi

[PATCH] D137320: [include-cleaner] Initial version for the "Location=>Header" step

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG779554804813: [include-cleaner] Initial version for the "Location=>Header" step (authored by hokein). Changed prior to commit: https://reviews.llv

[clang-tools-extra] 7795548 - [include-cleaner] Initial version for the "Location=>Header" step

Author: Haojian Wu Date: 2022-11-11T10:34:22+01:00 New Revision: 77955480481396c0e92aa1b4b99821eb21a66c0e URL: https://github.com/llvm/llvm-project/commit/77955480481396c0e92aa1b4b99821eb21a66c0e DIFF: https://github.com/llvm/llvm-project/commit/77955480481396c0e92aa1b4b99821eb21a66c0e.diff LO

[PATCH] D137572: [AVR][Clang] Implement __AVR_HAVE_*__ macros

benshi001 added inline comments. Comment at: clang/lib/Basic/Targets/AVR.cpp:355 +.Cases("31", "51", "6", true) +.Cases("104", "105", "106", "107", true) +.Default(false); ATxmega16a4 with family code 102 also supports ELPM. Could you please make a c

[PATCH] D137320: [include-cleaner] Initial version for the "Location=>Header" step

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h:63 +// FIXME: use a real Class! +using SymbolLocation = std::variant; + hokein wrote: > kadircet wrote: > > let's move this to `AnalysisInternal.

[PATCH] D137572: [AVR][Clang] Implement __AVR_HAVE_*__ macros

benshi001 added inline comments. Comment at: clang/lib/Basic/Targets/AVR.cpp:355 +.Cases("31", "51", "6", true) +.Cases("104", "105", "106", "107", true) +.Default(false); benshi001 wrote: > ATxmega16a4 with family code 102 also supports ELPM. Could y

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

hokein updated this revision to Diff 474707. hokein marked 3 inline comments as done. hokein added a comment. address comments: - mention #import case - rename file name - API: FileEntry => FileID Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13769

[PATCH] D134445: [PR57881][OpenCL] Fix incorrect diagnostics with templated types in kernel arguments

Anastasia added a comment. In D134445#3920448 , @rjmccall wrote: > In D134445#3920257 , @Anastasia > wrote: > >> In D134445#3920188 , @rjmccall >> wrote: >> >>> You real

[clang-tools-extra] 61c2276 - [include-cleaner] verbatimSpelling->verbatim, clean up some silly init-lists. NFC

Author: Sam McCall Date: 2022-11-11T12:10:12+01:00 New Revision: 61c2276cb231f5cc5698c0bdd2e92d9ecfdefa16 URL: https://github.com/llvm/llvm-project/commit/61c2276cb231f5cc5698c0bdd2e92d9ecfdefa16 DIFF: https://github.com/llvm/llvm-project/commit/61c2276cb231f5cc5698c0bdd2e92d9ecfdefa16.diff LO

[PATCH] D137320: [include-cleaner] Initial version for the "Location=>Header" step

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/AnalysisTest.cpp:33 TEST(WalkUsed, Basic) { // FIXME: Have a fixture for setting up tests. llvm::Annotations Code(R"cpp( sammccall wrote: > @kadircet gentle reminder -

[PATCH] D137825: [clang-include-cleaner] make SymbolLocation a real class, move FindHeaders

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. - replace SymbolLocation std::variant with enum-exposing version simil

[PATCH] D137826: [clang] Allow comparing pointers to string literals

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, jwakely. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes https://github.com/llvm/llvm-project/issues/58754 Repository:

[PATCH] D137712: Correctly handle Substitution failure in concept specialization.

usaxena95 updated this revision to Diff 474716. usaxena95 added a comment. Moving closer to show diagnostic of entity for which SFNIAE occurred. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137712/new/ https://reviews.llvm.org/D137712 Files: cl

[PATCH] D136809: [CMake] Make sure all headers are installed into `CLANG_RESOURCE_DIR`

paperchalice updated this revision to Diff 474715. paperchalice added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add cmake module to handle clang resource dir. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1368

[PATCH] D136936: [clang][Interp] Handle undefined functions better

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:24-31 + bool HasBody = true; + + // Function is not defined at all or not yet. We will + // create a Function instance but not compile the body. That +

[PATCH] D136809: [CMake] Make sure all headers are installed into `CLANG_RESOURCE_DIR`

paperchalice added inline comments. Herald added subscribers: Michael137, JDevlieghere. Comment at: clang/lib/Headers/CMakeLists.txt:285 +include(GetClangResourceDir) +get_clang_resource_dir(output_dir PREFIX ${LLVM_BINARY_DIR}/$ SUBDIR include) set(out_files)

Re: How can Autoconf help with the transition to stricter compilation defaults?

> On 10 Nov 2022, at 17:16, Zack Weinberg wrote: > > I’m the closest thing Autoconf has to a lead maintainer at present. > > It’s come to my attention (via https://lwn.net/Articles/913505/ and > https://fedoraproject.org/wiki/Changes/PortingToModernC) that GCC and > Clang both plan to disable

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

tbaeder updated this revision to Diff 474724. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137232/new/ https://reviews.llvm.org/D137232 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/Opco

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

tbaeder added inline comments. Comment at: clang/test/AST/Interp/arrays.cpp:216 - static_assert(getNextElem(E, 1) == 3); -#endif + static_assert(getNextElem(E, 1) == 3, ""); + aaron.ballman wrote: > aaron.ballman wrote: > > I'd like test cases where the point

[PATCH] D136815: [clang][Interp] Unify visiting variable declarations

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136815/new/ https://reviews.llvm.org/D136815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

sammccall added inline comments. Comment at: clang/lib/Tooling/Inclusions/Header.cpp:64 + // particular preprocessor state, usually set up by another header. + return !isDontIncludeMeHeader(SM.getBufferData(SM.translateFile(FE))); +} kadircet wrote: > `translat

[clang-tools-extra] 8dfaf99 - [include-cleaner] Provide public to_string of RefType (for HTMLReport), clean up includes. NFC

Author: Sam McCall Date: 2022-11-11T13:25:22+01:00 New Revision: 8dfaf9940abe029e4fd35c63e3d7f2df66306a06 URL: https://github.com/llvm/llvm-project/commit/8dfaf9940abe029e4fd35c63e3d7f2df66306a06 DIFF: https://github.com/llvm/llvm-project/commit/8dfaf9940abe029e4fd35c63e3d7f2df66306a06.diff LO

[PATCH] D136457: [clang][Interp] Fix discarding non-primitive function call return values

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136457/new/ https://reviews.llvm.org/D136457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D136694: [clang][Interp] Check that constructor calls initialize all record fields

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136694/new/ https://reviews.llvm.org/D136694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D136751: [clang][Interp] This pointers are writable in constructors

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136751/new/ https://reviews.llvm.org/D136751 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D137070: [clang][Interp] Support destructors

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137070/new/ https://reviews.llvm.org/D137070 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137235: [clang][Interp] Fix ImplicitValueInitExprs for pointer types

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137235/new/ https://reviews.llvm.org/D137235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D137386: [clang][Interp] Reject invalid declarations and expressions

tbaeder updated this revision to Diff 474726. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137386/new/ https://reviews.llvm.org/D137386 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/functions.cpp Index: clang/test/A

[PATCH] D137386: [clang][Interp] Reject invalid declarations and expressions

tbaeder updated this revision to Diff 474727. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137386/new/ https://reviews.llvm.org/D137386 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/functions.cpp Index: clang/test/A

[PATCH] D137825: [clang-include-cleaner] make SymbolLocation a real class, move FindHeaders

tschuett added a comment. You could: static_assert(std::variant_size_v<> == 2); Kind kind() const { if (std::holds_alternative(Storage)) return Kind::Physical; return Kind::Standard; } and Kind could become `enum class Kind`. => You would get rid of the order on the variant and the

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

kadircet added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/Header.h:21 +/// +/// A header is considered self-contained if either it has a proper header guard +/// or it doesn't has dont-include-me-similar pattern. kadircet wrote: > let's

[PATCH] D137825: [clang-include-cleaner] make SymbolLocation a real class, move FindHeaders

sammccall added a comment. In D137825#3921273 , @tschuett wrote: > You could: > > static_assert(std::variant_size_v<> == 2); > > Kind kind() const { if (std::holds_alternative(Storage)) > return Kind::Physical; return Kind::Standard; } > > an

[clang] 1da74ee - [Clang][LoongArch] Remove duplicate declaration. NFC

Author: wanglei Date: 2022-11-11T20:36:18+08:00 New Revision: 1da74eeb0e1b6cb0d427148d9ed05afb3a1e01bc URL: https://github.com/llvm/llvm-project/commit/1da74eeb0e1b6cb0d427148d9ed05afb3a1e01bc DIFF: https://github.com/llvm/llvm-project/commit/1da74eeb0e1b6cb0d427148d9ed05afb3a1e01bc.diff LOG:

[PATCH] D137825: [clang-include-cleaner] make SymbolLocation a real class, move FindHeaders

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137825/new/ https://reviews.llvm.org/D137825

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

sammccall added inline comments. Comment at: clang/lib/Tooling/Inclusions/Header.cpp:64 + // particular preprocessor state, usually set up by another header. + return !isDontIncludeMeHeader(SM.getBufferData(SM.translateFile(FE))); +} kadircet wrote: > sammccall

[clang-tools-extra] 7943169 - [clang-include-cleaner] make SymbolLocation a real class, move FindHeaders

Author: Sam McCall Date: 2022-11-11T13:41:54+01:00 New Revision: 7943169273b22f61a0322cb2d38ff75845e52628 URL: https://github.com/llvm/llvm-project/commit/7943169273b22f61a0322cb2d38ff75845e52628 DIFF: https://github.com/llvm/llvm-project/commit/7943169273b22f61a0322cb2d38ff75845e52628.diff LO

[PATCH] D137825: [clang-include-cleaner] make SymbolLocation a real class, move FindHeaders

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7943169273b2: [clang-include-cleaner] make SymbolLocation a real class, move FindHeaders (authored by sammccall). Repository: rG LLVM Github Monor

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

kadircet added inline comments. Comment at: clang/lib/Tooling/Inclusions/Header.cpp:64 + // particular preprocessor state, usually set up by another header. + return !isDontIncludeMeHeader(SM.getBufferData(SM.translateFile(FE))); +} sammccall wrote: > kadircet

[PATCH] D137531: [clang] Add the check of decltype in derived templates for issue #58674

lime updated this revision to Diff 474731. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137531/new/ https://reviews.llvm.org/D137531 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/decltype.cpp Index: clang/test/SemaCXX/decltype.cpp =

[PATCH] D137823: [clang-format][NFC] Moved configuration parsing tests in own file

rymiel added inline comments. Comment at: clang/unittests/Format/ConfigParseTest.cpp:1 +//===- unittest/Format/ConfiParseTest.cpp - Config parsing unit tests -===// +// typo (Confi) :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. This seems reasonable to me, but I'll leave the final sign-off to Erich. Comment at: clang/lib/Sema/SemaStmtAttr.cpp:331-332 const LoopHintAttr *NumericAttr; - } HintAttrs[] = {{nullptr, nullptr},

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

hokein updated this revision to Diff 474735. hokein added a comment. getBufferData => getMemoryBufferForFileOrNone Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137697/new/ https://reviews.llvm.org/D137697 Files: clang-tools-extra/clangd/Headers

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

hokein added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/Header.h:21 +/// +/// A header is considered self-contained if either it has a proper header guard +/// or it doesn't has dont-include-me-similar pattern. kadircet wrote: > kadircet

[clang-tools-extra] 15b2702 - [include-cleaner] NFC, correct a comment in

Author: Haojian Wu Date: 2022-11-11T14:40:08+01:00 New Revision: 15b2702e83fa1e99e56b51a4254e8dc4f331ca9d URL: https://github.com/llvm/llvm-project/commit/15b2702e83fa1e99e56b51a4254e8dc4f331ca9d DIFF: https://github.com/llvm/llvm-project/commit/15b2702e83fa1e99e56b51a4254e8dc4f331ca9d.diff LO

[clang-tools-extra] e000c2b - [include-cleaner] NFC, move the macro location fixme to findHeaders.

Author: Haojian Wu Date: 2022-11-11T14:55:29+01:00 New Revision: e000c2bce75ec59782e1a2459c4db6d7a996590c URL: https://github.com/llvm/llvm-project/commit/e000c2bce75ec59782e1a2459c4db6d7a996590c DIFF: https://github.com/llvm/llvm-project/commit/e000c2bce75ec59782e1a2459c4db6d7a996590c.diff LO

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137697/new/ https://reviews.llvm.org/D137697 __

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

kadircet added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/HeaderAnalysis.h:28 +/// dont-include-me pattern heuristically. +bool isSelfContainedHeader(FileID FID, const SourceManager &SM, + HeaderSearch &HeaderInfo); -

[PATCH] D137677: [include-cleaner] add macro symbols and implicit refs to HTML report

sammccall updated this revision to Diff 474738. sammccall added a comment. - hover card follows the internal data model: symbol -> location -> header (->include, later) - don't use public API, so we can get at internal details Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

tbaeder marked an inline comment as done. tbaeder added a comment. Can't push this without https://reviews.llvm.org/D135750, since the variables in the test functions are used without being initialized. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137071/new/ https://reviews.llvm.org/

[PATCH] D137835: [ARM] Move ARM::parseBranchProtection into ARMTargetParser

lenary created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. lenary requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. This should live with the Arm targets, given th

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary created this revision. Herald added subscribers: kadircet, arphaman, hiraditya, krytarowski. Herald added a project: All. lenary requested review of this revision. Herald added projects: LLVM, clang-tools-extra. Herald added subscribers: cfe-commits, llvm-commits. This change is focussed on

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

hokein updated this revision to Diff 474751. hokein marked an inline comment as done. hokein added a comment. use FileEntry in the API. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137697/new/ https://reviews.llvm.org/D137697 Files: clang-tools

[PATCH] D137839: [Sema] check InitListExpr format strings like {"foo"}

inclyc created this revision. Herald added a project: All. inclyc added a reviewer: aaron.ballman. inclyc published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds InitListExpr case in format string checks. e.g. int sprintf(char *__restrict

[PATCH] D137838: [RFC][Support] Move TargetParsers to new component

lenary added a comment. Herald added a subscriber: Michael137. Apologies to everyone who has automatically been marked as a reviewer for this change. There is more context for it here: https://discourse.llvm.org/t/targetparser-auto-generation-of-riscv-cpu-definitions/66419/4?u=lenary Repositor

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137697/new/ https://reviews.llvm.org/D137697

Re: How can Autoconf help with the transition to stricter compilation defaults?

On Thu, Nov 10, 2022 at 4:05 PM Paul Eggert wrote: > > On 2022-11-10 10:19, Aaron Ballman wrote: > > In terms of the Clang side of things, I don't think we've formed any > > sort of official stance on how to handle that yet. It's UB (you can > > declare the C standard library interface without UB

[PATCH] D137516: [TargetSupport] Move TargetParser API in a separate LLVM component.

lenary added a comment. In D137516#3912900 , @fpetrogalli wrote: > In D137516#3912842 , @lenary wrote: > >> In D137516#3912751 , @fpetrogalli >> wrote: >> >>> @arsenm @f

[PATCH] D137578: Fix 'unsafe-math-optimizations' flag dependencies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91628f0616ca: The handling of 'funsafe-math-optimizations' doesn't update the 'MathErrno' (authored by zahiraam). Changed prior to commit: https:

[clang] 91628f0 - The handling of 'funsafe-math-optimizations' doesn't update the 'MathErrno'

Author: Zahira Ammarguellat Date: 2022-11-11T10:24:12-05:00 New Revision: 91628f0616ca5203945afb56b3d8a27522b99808 URL: https://github.com/llvm/llvm-project/commit/91628f0616ca5203945afb56b3d8a27522b99808 DIFF: https://github.com/llvm/llvm-project/commit/91628f0616ca5203945afb56b3d8a27522b99808

[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127855/new/ https://reviews.llvm.org/D127855 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D137787: [CodeGen] Relax assertion on generating destructor call

Hahnfeld added a comment. I've trimmed the failing code down to #include #include #include template struct SO { void a() { struct SI { std::vector v; }; SI s; SI m(std::move(s)); } void g() { std::vector v{"a"}; } }; in

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin updated this revision to Diff 474770. cor3ntin added a comment. Address Shafik's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137244/new/ https://reviews.llvm.org/D137244 Files: clang/include/clang/AST/Decl.h clang/include/cl

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

to268 accepted this revision. to268 added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137724/new/ https://reviews.llvm.org/D137724 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D137835: [ARM] Move ARM::parseBranchProtection into ARMTargetParser

tmatheson accepted this revision. tmatheson added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:47 #include "llvm/Option/ArgList.h" +#include "llvm/Support/ARMTargetParser.h" #include "llvm/Support/CodeGen.h"

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

tmatheson added a comment. Makes sense since it is so similar to `get_cpus()` and is only used in Threading. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137836/new/ https://reviews.llvm.org/D137836 __

[PATCH] D137350: [RISCV] Implement assembler support for XVentanaCondOps

reames updated this revision to Diff 474782. reames added a comment. Address comments from @craig.topper CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137350/new/ https://reviews.llvm.org/D137350 Files: clang/test/Preprocessor/riscv-target-features.c llvm/docs/RISCVUsage.rst llvm

[PATCH] D137154: Adding nvvm_reflect clang builtin

jhuber6 added a comment. In D137154#3918949 , @bader wrote: > Is binary size a concern here? NVIDIA, AMD and Intel GPUs are already have ~ > 20 different architectures each, so I want my app/library to run on any GPU > from these vendors (which is quite

[PATCH] D137823: [clang-format][NFC] Moved configuration parsing tests in own file

HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/ConfigParseTest.cpp:1 +//===- unittest/Format/ConfiParseTest.cpp - Config parsing unit tests -===// +// rymiel wrote: > typo (Co

[PATCH] D137838: [RFC][Support] Move TargetParsers to new component

thakis added a comment. This is a gigantic diff. I'd recommend keeping the .h files in the old place for v0 and make them just forwarding headers that include the header at the new location. That way, you don't have to update oodles of include lines in this patch, and it makes it a bit easier t

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 added a project: OpenMP. Herald added subscribers: arphaman, guansong, yaxunl. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Her

[PATCH] D135636: [clang][modules][deps] Serialize inputs into PCMs using the "as requested" name

benlangmuir added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:447 +SmallString<128> CanonicalPath = FE.getNameAsRequested(); +ModMapInfo.canonicalizeModuleMapPath(CanonicalPath); +MD.ModuleMapFileDeps.emplace_ba

[PATCH] D137838: [RFC][Support] Move TargetParsers to new component

lenary added a comment. In D137838#3921828 , @thakis wrote: > This is a gigantic diff. I'd recommend keeping the .h files in the old place > for v0 and make them just forwarding headers that include the header at the > new location. That way, you don't

[PATCH] D137851: [OPENMP]Initial support for at clause

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:1613-1615 + /// Sets the location of '('. + void setLParenLoc(SourceLocation Loc) { LParenLoc = Loc; } + Make it private Comment at: clang/include/clang/Parse/P

[PATCH] D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

shafik added inline comments. Comment at: clang/lib/Sema/SemaStmtAttr.cpp:319 + }; + // There are 7 categories of loop hints attributes: vectorize, interleave, + // unroll, unroll_and_jam, pipeline, distribute, and vectorize predicate. Can you break up this co

[PATCH] D137838: [RFC][Support] Move TargetParsers to new component

fpetrogalli added a comment. Hi @lenary - thank you for working on this! The patch is reasonable to me. I agree on the suggestion of using forwarding headers or the first iteration of the change, it will make it easier to review. I'll adapt the auto-get patch at D137517

[PATCH] D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

erichkeane added a comment. I haven't dealt much with the loop hint attributes, but two of my coworkers have done extensive work in our downstream (@jyu2 and @mikerice), and likely have feedback about how this affects downstream feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals

tom-anders added a comment. This looks really cool :) Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:133 + std::string Directives; + for (auto &Using : UsingToAdd) +Directives += llvm::formatv("using namespace {0};\n", Using); -

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

jansvoboda11 added a comment. @stella.stamenova Any updates? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135128/new/ https://reviews.llvm.org/D135128 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] 33d848b - Fix typo; NFC

Author: Aaron Ballman Date: 2022-11-11T13:02:41-05:00 New Revision: 33d848b992ee1d3a6b39b3b6f1a42b46d583bf72 URL: https://github.com/llvm/llvm-project/commit/33d848b992ee1d3a6b39b3b6f1a42b46d583bf72 DIFF: https://github.com/llvm/llvm-project/commit/33d848b992ee1d3a6b39b3b6f1a42b46d583bf72.diff

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

FabioLuporini added a comment. Hi, any chance this will be completed any time soon? We are very keen to resurrect our clang-based OpenMP offloading pipeline at https://github.com/devitocodes/devito :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jhuber6 added a comment. @dhruvachak Do you still need help updating the LLVM tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 ___ cfe-commits mailing lis

[PATCH] D137154: Adding nvvm_reflect clang builtin

tra added a comment. > Yes, this probably would become untenable with really large sizes. I think that horse had left the barn long ago. Vast majority of NVIDIA GPU cycles these days spent in libraries shipped by NVIDIA and those are huge (O(1GB)), numerous (cuDNN, TensorRT, cuBLAS, cuSPARSE, c

[PATCH] D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals

v1nh1shungry updated this revision to Diff 474808. v1nh1shungry added a comment. Apply the review suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137817/new/ https://reviews.llvm.org/D137817 Files: clang-tools-extra/clangd/refactor/twe

[PATCH] D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals

v1nh1shungry added a comment. @tom-anders Thank you for reviewing and giving suggestions! Hope I use the `llvm::StringSet` correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137817/new/ https://reviews.llvm.org/D137817 _

[PATCH] D137714: Do not merge traps in functions annotated optnone

hnrklssn updated this revision to Diff 474811. hnrklssn added a comment. No longer reorders annotations to occur before codegen. Instead EmitTrapCheck checks the function declaration for OptimizeNoneAttr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D137714: Do not merge traps in functions annotated optnone

hnrklssn marked 2 inline comments as done. hnrklssn added a comment. Made changes in line with what @fcloutier suggested. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5321 + SetLLVMFunctionAttributesForDefinition(D, Fn); CodeGenFunction(*this).GenerateCode(GD, Fn, FI);

[PATCH] D137838: [RFC][Support] Move TargetParsers to new component

MaskRay added a comment. Moving target-specific parsers outside LLVMSupport LGTM. I even objected a bit when more stuff of this kind was introduced into LLVMSupport. +1 for adding temporary forwarding headers for now to avoid update all `#include` users. Repository: rG LLVM Github Monorepo

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare updated this revision to Diff 474812. gedare added a comment. Run tests and fix bad breaks. Fix comment style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137762/new/ https://reviews.llvm.org/D137762 Files: clang/lib/Format/TokenAnnotat

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare updated this revision to Diff 474814. gedare added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137762/new/ https://reviews.llvm.org/D137762 Files: clang/lib/Format/ContinuationIndenter.cpp clang/lib/

[PATCH] D137517: [TargetSupport] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli updated this revision to Diff 474817. fpetrogalli added a comment. I have applied the chaged suggested by @jrtc27: 1. The classes `RISCVProcessorModelPROC` and `RISCVProcessorModelTUNE_PROC` now are derived from `ProcessorModel`; 2. The `Enum` field is removed from both classes. What

[PATCH] D137040: [clangd] Add heuristic for dropping snippet when completing member function pointer

tom-anders updated this revision to Diff 474818. tom-anders added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137040/new/ https://reviews.llvm.org/D137040 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra

[PATCH] D137712: Correctly handle Substitution failure in concept specialization.

erichkeane added a comment. I think this is a move in the right direction, and generally is probably pretty close. The new bool for `ArgsHasSubstitutionFailure` isn't something I get the need for yet though. we also need release notes. Comment at: clang/include/clang/AST/Ex

[clang] 28e0798 - Revert "[Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms."

Author: Alex Brachet Date: 2022-11-11T19:40:08Z New Revision: 28e07984c3427908c9b423c7ed0cf6ac3064c5d8 URL: https://github.com/llvm/llvm-project/commit/28e07984c3427908c9b423c7ed0cf6ac3064c5d8 DIFF: https://github.com/llvm/llvm-project/commit/28e07984c3427908c9b423c7ed0cf6ac3064c5d8.diff LOG:

[clang] 0f7e863 - [LinkerWrapper] Perform device linking steps in parallel

Author: Joseph Huber Date: 2022-11-11T13:46:33-06:00 New Revision: 0f7e8631547ad2cbbe5bcf1933e1353e58f58406 URL: https://github.com/llvm/llvm-project/commit/0f7e8631547ad2cbbe5bcf1933e1353e58f58406 DIFF: https://github.com/llvm/llvm-project/commit/0f7e8631547ad2cbbe5bcf1933e1353e58f58406.diff

  1   2   >