sammccall added inline comments.
================ Comment at: clang/lib/Tooling/Inclusions/Header.cpp:64 + // particular preprocessor state, usually set up by another header. + return !isDontIncludeMeHeader(SM.getBufferData(SM.translateFile(FE))); +} ---------------- kadircet wrote: > `translateFile` actually does a linear scan over all the slocentries, so i > think it's better for this API to be based on FileID. (later on we can easily > get fileentry from fileid in constant time) You can get content through the fileentry directly, no? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137697/new/ https://reviews.llvm.org/D137697 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
