[PATCH] D137693: [NFC] [C++20] [Modules] [clangd] Add test for code completion for C++20 Named Modules

ChuanqiXu created this revision. ChuanqiXu added reviewers: nridge, sammccall. ChuanqiXu added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-b

[PATCH] D137693: [NFC] [C++20] [Modules] [clangd] Add test for code completion for C++20 Named Modules

ChuanqiXu added inline comments. Comment at: clang-tools-extra/clangd/test/completion-modules2.test:13 +export module A; +void printA() {} + It looks redundant at the first sight. I know we can reduce the size by the following trick: ``` #ifdef USE_EXPORT expor

[PATCH] D137386: [clang][Interp] Reject invalid declarations and expressions

tbaeder updated this revision to Diff 474172. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137386/new/ https://reviews.llvm.org/D137386 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/functions.cpp Index: clang/test/AST/Interp/functions.cpp ==

[PATCH] D137386: [clang][Interp] Reject invalid declarations and expressions

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/test/AST/Interp/functions.cpp:88-97 +constexpr int invalid() { + // Invalid expression in visit(). + while(huh) {} +} + +constexpr void invalid2() { + int i = 0; aaron.b

[PATCH] D137669: clang/cmake: Require pre-built test dependencies for stand-alone builds

mstorsjo added a comment. Also FYI, OpenMP has a bit of prior art in this area - see e.g. https://github.com/llvm/llvm-project/blob/main/openmp/cmake/OpenMPTesting.cmake#L27-L36. There it prints a warning at cmake time, disabling tests, saying why, and giving hints about how to fix it. Reposi

[PATCH] D137488: [clang][Interp] Array initialization via string literal

tbaeder updated this revision to Diff 474177. tbaeder marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137488/new/ https://reviews.llvm.org/D137488 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/literals.cpp Index: clang/test/AS

[PATCH] D137488: [clang][Interp] Array initialization via string literal

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1133-1134 + } else if (const auto *SL = dyn_cast(Initializer)) { +const ArrayType *AT = SL->getType()->getAsArrayTypeUnsafe(); +const auto *CAT = cast(AT); +size_t NumElems = CAT->get

[PATCH] D137650: [clangd] Implement hover for string literals

v1nh1shungry updated this revision to Diff 474179. v1nh1shungry added a comment. Improve the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 Files: clang-tools-extra/clangd/Hover.cpp clang-tools

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

tbaeder updated this revision to Diff 474181. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137071/new/ https://reviews.llvm.org/D137071 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/literals.cpp Index: clang/test/AST

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

tbaeder updated this revision to Diff 474182. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137232/new/ https://reviews.llvm.org/D137232 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/Opco

[PATCH] D137153: [X86] Support -march=sierraforest, grandridge, graniterapids.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG84a18a260e46: [X86] Support -march=sierraforest, grandridge, graniterapids. (authored by FreddyYe). Changed prior to commit: https://reviews.llvm.

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

hokein created this revision. hokein added reviewers: kadircet, sammccall. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. We plan to reuse

[PATCH] D137698: [include-cleaner] Add self-contained file support for PragmaIncludes.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. Based on https://reviews.llvm.org/D137697 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D137698 Fi

[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

kadircet added a comment. Hi @kito-cheng, can you please let us know if you're working on a fix here (and whether it seems to be close)? otherwise i am planning to revert this and consequent changes, as it's clearly introducing data races. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Opcodes.td:502 + let Types = [AluTypeClass]; + let Args = [ArgFltSemantics]; + let HasGroup = 1; jcranmer-intel wrote: > tbaeder wrote: > > sepavloff wrote: > > > tbaeder wrote: > > > > jcranmer-i

[PATCH] D137677: [include-cleaner] add macro symbols and implicit refs to HTML report

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/include-cleaner/lib/HTMLReport.cpp:243 +for (Header H : T.Providers) { + OS << "Candidate: "; + escapeString(llvm::to_string(H

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

tbaeder added a comment. In D137071#3915565 , @aaron.ballman wrote: > Precommit CI looks to have potentially found something interesting here. There might be one of my local patches missing, but it looks like it's somehow not applying this patch, which

[clang] 4057998 - Fix D132221 rebase: Add flags to enable Assignment Tracking

Author: OCHyams Date: 2022-11-09T09:28:41Z New Revision: 40579983555c7ed510e47bf2a0354bc1c0ec4d47 URL: https://github.com/llvm/llvm-project/commit/40579983555c7ed510e47bf2a0354bc1c0ec4d47 DIFF: https://github.com/llvm/llvm-project/commit/40579983555c7ed510e47bf2a0354bc1c0ec4d47.diff LOG: Fix D

[clang] 4b6b2b1 - Reapply: [Assignment Tracking][7/*] Add assignment tracking functionality to clang

Author: OCHyams Date: 2022-11-09T09:28:41Z New Revision: 4b6b2b1a425a2eabb3a4b995bb05f4f53e313afa URL: https://github.com/llvm/llvm-project/commit/4b6b2b1a425a2eabb3a4b995bb05f4f53e313afa DIFF: https://github.com/llvm/llvm-project/commit/4b6b2b1a425a2eabb3a4b995bb05f4f53e313afa.diff LOG: Reapp

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

fhahn added a comment. It looks like GISel crashes when building `llvm-test-suite` with -O3 on ARM64. If it isn't trivial to fix we should probably revert the patch to bring things back to green. Reproducer: ; llc -global-isel -O3 target datalayout = "e-m:o-i64:64-i128:128-n32:64-S128"

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

nikic added a comment. I'd like to object to enabling this via the frontend. This means that non-clang frontends will now use a non-default configuration that is not extensively tested by upstream anymore. If you don't want to change tests, you can adjust the RUN lines to explicitly disable gl

[PATCH] D80392: [mips][mc][clang] Use pc-relative relocations in .eh_frame

wzssyqa added a comment. In D80392#3876782 , @wzssyqa wrote: > I don't think that we need that option: what we need to do is to update the > old tools. the ld.bfd support R_MIPS_PC32 here. I think that we can just switch the behavior without any condtion

[clang] 9d1ff78 - [AArch64] Add support for the Cortex-X3 CPU

Author: Victor Campos Date: 2022-11-09T11:33:48Z New Revision: 9d1ff787e5c2b19e19e5475b9c36f4e5c2a07d23 URL: https://github.com/llvm/llvm-project/commit/9d1ff787e5c2b19e19e5475b9c36f4e5c2a07d23 DIFF: https://github.com/llvm/llvm-project/commit/9d1ff787e5c2b19e19e5475b9c36f4e5c2a07d23.diff LOG:

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d1ff787e5c2: [AArch64] Add support for the Cortex-X3 CPU (authored by vhscampos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 103bbdd - [ARM] Move Triple::getARMCPUForArch into ARMTargetParser

Author: Tomas Matheson Date: 2022-11-09T11:52:35Z New Revision: 103bbddde66f4157b52c2b6d7532c1dd0dfcaf94 URL: https://github.com/llvm/llvm-project/commit/103bbddde66f4157b52c2b6d7532c1dd0dfcaf94 DIFF: https://github.com/llvm/llvm-project/commit/103bbddde66f4157b52c2b6d7532c1dd0dfcaf94.diff LOG

[PATCH] D137564: [ARM] Move Triple::getARMCPUForArch into ARMTargetParser

This revision was automatically updated to reflect the committed changes. Closed by commit rG103bbddde66f: [ARM] Move Triple::getARMCPUForArch into ARMTargetParser (authored by tmatheson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137564/new/ ht

[PATCH] D137563: [clang][Interp] Check declarations for constexpr-ness in Load() instructions

tbaeder added a comment. This is wrong if the (constant) initializer is for a legitimate non-constexpr variable declaration. We do a load in `visitDecl()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137563/new/ https://reviews.llvm.org/D137563

[PATCH] D137706: [clang][Interp] Implement IntegralToPointer casts

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a subscriber: inglorion. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The pointers

[PATCH] D137706: [clang][Interp] Implement IntegralToPointer casts

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:188-192 +// == in C +if (const auto *BOP = dyn_cast(SubExpr); +BOP && BOP->isEqualityOp()) + return this->visit(SubExpr); +[[fallthrough]]; This is a tiny

[clang] 0f4f246 - [OpenCL] Guard read_write image3d with cl_khr_3d_image_writes

Author: Sven van Haastregt Date: 2022-11-09T13:17:59Z New Revision: 0f4f246783fa5866f6fa5db4043e898060cdf98d URL: https://github.com/llvm/llvm-project/commit/0f4f246783fa5866f6fa5db4043e898060cdf98d DIFF: https://github.com/llvm/llvm-project/commit/0f4f246783fa5866f6fa5db4043e898060cdf98d.diff

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

serge-sans-paille added inline comments. Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32 SmallString<128> LibPath = llvm::sys::path::parent_path(Dir); - llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX); + llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR

[clang] 2fb3bec - [analyzer] Fix crash for array-delete of UnknownVal values.

Author: Tomasz Kamiński Date: 2022-11-09T15:06:46+01:00 New Revision: 2fb3bec932ede7704724abb71e8270e0b4c201f6 URL: https://github.com/llvm/llvm-project/commit/2fb3bec932ede7704724abb71e8270e0b4c201f6 DIFF: https://github.com/llvm/llvm-project/commit/2fb3bec932ede7704724abb71e8270e0b4c201f6.dif

[PATCH] D136671: [analyzer] Fix crash for array-delete of UnknownVal values.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2fb3bec932ed: [analyzer] Fix crash for array-delete of UnknownVal values. (authored by tomasz-kaminski-sonarsource). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

kiranchandramohan requested changes to this revision. kiranchandramohan added a comment. This revision now requires changes to proceed. Patch probably needs a rebase. A few more minor things to fix. Looks mostly ready. Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:

[clang] b710444 - Fix Clang sphinx build

Author: Aaron Ballman Date: 2022-11-09T09:19:24-05:00 New Revision: b7104442ddcc90dd9aa22e08a2113a463b1ef4be URL: https://github.com/llvm/llvm-project/commit/b7104442ddcc90dd9aa22e08a2113a463b1ef4be DIFF: https://github.com/llvm/llvm-project/commit/b7104442ddcc90dd9aa22e08a2113a463b1ef4be.diff

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe added a comment. In D137205#3915526 , @Skylion007 wrote: > Okay, now I am getting what I believe to be segfaults: > > #0 0x564383482be4 PrintStackTraceSignalHandler(void*) Signals.cpp:0:0 > #1 0x564383480464 SignalHandler(int) Signals.c

[PATCH] D137712: Correctly handle Substitution failure in concept specialization.

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D137712 Files: clang/include/clang/AST/ExprConcepts.h

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe updated this revision to Diff 474260. Febbe added a comment. Fixed segfaults due to asserts which were wrongly assumed to be always true Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137205/new/ https://reviews.llvm.org/D137205 Files: clan

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance/unnecessary-copy-on-last-use.rst:40 +.. option:: BlockedFunctions + A semicolon-separated list of names of functions who's parameters do not + participate in the resolution

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:591 + + static_assert(IntDiv(INT_MIN, -1) == 0, ""); + This one should fail for the same reason as `%` Comment at: clang/test/AST/Interp/literals.cpp:553 + st

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Skylion007 added a comment. Currently, this check also tries to move static values which is very undesirable and unlikely to be correct. static auto value = std::string("CONSTANT"); - return value; + return std::move(value); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D136603: [analyzer] Model cast after LValueToRValueBitCasts

steakhal added a comment. This 'new' approach with the type auto-detection behaves the same way as the originally proposed patch. Same results, still no crashes :) I'll update the summary and the title according to the new approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D137550: [clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry updated this revision to Diff 474262. v1nh1shungry added a comment. Format codes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137550/new/ https://reviews.llvm.org/D137550 Files: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingN

[PATCH] D137618: [Clang] Fix behavior of -ffp-model option when overriden

zahiraam added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3034 RoundingFPMath = false; + FPExceptionBehavior = ""; // If fast-math is set then set the fp-contract mode to fast. FPExceptionBehavior should be set here and

[PATCH] D122385: [clang][deps] Fix clang-cl output argument parsing

saudi added inline comments. Herald added a subscriber: ributzka. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:487 +if (!llvm::sys::path::has_extension(CurrentO)) + LastO = (CurrentO + ".obj").str(); +else

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Skylion007 added a comment. Hmm, I still had a crash on this latest code (although it is crashing much more rarely now. It crashes on scanning this file https://github.com/facebookresearch/habitat-sim/blob/5fb04078b0b8432dc4a88ec186a2b7af74163be1/src/esp/core/managedContainers/ManagedContainerB

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

tbaeder updated this revision to Diff 474273. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137071/new/ https://reviews.llvm.org/D137071 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/literals.cpp Index: clang/test/AST/Interp/literals.cpp =

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:591 + + static_assert(IntDiv(INT_MIN, -1) == 0, ""); + aaron.ballman wrote: > This one should fail for the same reason as `%` Works when repla

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Opcodes.td:421-425 +// [Pointer] -> [] +def IncPtr : Opcode { + let HasGroup = 0; +} +// [Pointer] -> [] aaron.ballman wrote: > Don't both of these result in a `Pointer`? And should they have a `Typ

[PATCH] D137650: [clangd] Implement hover for string literals

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:816 + if (llvm::isa(E)) { +HoverInfo::PrintedType PT; +PT.Type = E->getType().getAsString(PP); can you extract this into a function, similar to the cases below?

[PATCH] D137719: [clang] Missed rounding mode use in constant evaluation

sepavloff created this revision. sepavloff added reviewers: rjmccall, efriedma, aaron.ballman. Herald added a project: All. sepavloff requested review of this revision. Herald added a project: clang. Integer-to-float conversion was handled in constant evaluator with default rounding mode. This cha

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

sepavloff added a comment. Patch https://reviews.llvm.org/D137719 fixed int->float conversion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137719: [clang] Missed rounding mode use in constant evaluation

tbaeder added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2653 + APFloat::opStatus St = Result.convertFromAPInt(Value, Value.isSigned(), RM); + return checkFloatingPointResult(Info, E, St); } `SrcType` was already unused before, but not so is `

[PATCH] D137720: Migrate getOrCreateInternalVariable from Clang to OMPIRBuilder.

TIFitis created this revision. TIFitis added reviewers: jdoerfert, jsjodin. Herald added a subscriber: hiraditya. Herald added a project: All. TIFitis requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. This patch re

[PATCH] D137719: [clang] Missed rounding mode use in constant evaluation

tbaeder added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2653 + APFloat::opStatus St = Result.convertFromAPInt(Value, Value.isSigned(), RM); + return checkFloatingPointResult(Info, E, St); } tbaeder wrote: > `SrcType` was already unused before

[PATCH] D137720: Migrate getOrCreateInternalVariable from Clang to OMPIRBuilder.

TIFitis updated this revision to Diff 474284. TIFitis added a comment. Fix commit message indentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137720/new/ https://reviews.llvm.org/D137720 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clan

[PATCH] D135859: [Includecleaner] Introduce RefType to ast walking

maryammo added a comment. @kadircet, this commit causes failure on https://lab.llvm.org/buildbot/#/builders/121 which is possible to reproduce locally, can you please take a look? [ 35/111] Linking CXX executable tools/clang/tools/extra/include-cleaner/unittests/ClangIncludeCleanerTests F

[PATCH] D137722: [clang][analyzer] No new nodes when bug is detected in StdLibraryFunctionsChecker.

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a project:

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

Mordante created this revision. Herald added a reviewer: bollu. Herald added subscribers: Moerafaat, zero9178, Enna1, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiag

[PATCH] D137712: Correctly handle Substitution failure in concept specialization.

erichkeane added a comment. I dont have a good hold as to why this is the solution, can you better explain the issue and the solution that you made? I will take a look when I get a chance next week, as the ISO meeting is taking up my week. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

thieta accepted this revision as: thieta. thieta added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: sstefan1, JDevlieghere. I think this is fine as we have discussed before. But I really dislike the code duplication for the check. We could put it in a include() I guess

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

Mordante added a comment. In D137724#3917616 , @thieta wrote: > I think this is fine as we have discussed before. But I really dislike the > code duplication for the check. We could put it in a include() I guess - but > maybe it's not worth it. I wante

[clang-tools-extra] 453c287 - [include-cleaner] Add dependency to fix build with shared libraries

Author: Ilya Biryukov Date: 2022-11-09T18:31:14+01:00 New Revision: 453c2879cb2ad6c46267ef8f39f0274aed69d9ee URL: https://github.com/llvm/llvm-project/commit/453c2879cb2ad6c46267ef8f39f0274aed69d9ee DIFF: https://github.com/llvm/llvm-project/commit/453c2879cb2ad6c46267ef8f39f0274aed69d9ee.diff

[PATCH] D135859: [Includecleaner] Introduce RefType to ast walking

ilya-biryukov added a comment. Sent out rG453c2879cb2ad6c46267ef8f39f0274aed69d9ee to fix this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135859/new/ https://reviews.llvm.or

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

MyDeveloperDay added a comment. I think this is them.. https://twitter.com/xen_org/status/1397581514318225412 https://xenproject.org/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91950/new/ https://reviews.llvm.org/D91950 ___ cfe-commits m

[PATCH] D136146: [Clang][LoongArch] Handle -march/-m{single,double,soft}-float/-mfpu options

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. In D136146#3911137 , @SixWeining wrote: > Sorry for the late reply. > > Should we choose not to implement the `-mfpu=` option which is not mandatory

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

MaskRay accepted this revision as: MaskRay. MaskRay added a comment. I think `if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)` checks for standalone builds is not necessary. The check in `llvm/CMakeLists.txt` suffices. It's unlikely the users will use different cmake versions to configure

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

Mordante added a comment. In D137724#3917644 , @MaskRay wrote: > I think `if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)` checks for > standalone builds is not necessary. The check in `llvm/CMakeLists.txt` > suffices. > It's unlikely the users w

[PATCH] D137719: [clang] Missed rounding mode use in constant evaluation

sepavloff updated this revision to Diff 474303. sepavloff added a comment. Removed unused parateters from HandleIntToFloatCast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137719/new/ https://reviews.llvm.org/D137719 Files: clang/lib/AST/ExprCo

[PATCH] D137719: [clang] Missed rounding mode use in constant evaluation

sepavloff updated this revision to Diff 474304. sepavloff added a comment. Remove accidentally added file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137719/new/ https://reviews.llvm.org/D137719 Files: clang/lib/AST/ExprConstant.cpp clang/te

[PATCH] D137154: Adding nvvm_reflect clang builtin

hdelan added a comment. Thanks for feedback. Instead of adding `__nvvm_reflect` as a clang builtin, would it be acceptable if I modified the NVVMReflect pass so that it works with addrspace casting as well? This would allow us to use `__nvvm_reflect` in openCL Repository: rG LLVM Github Mono

[PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

aaron.ballman added a comment. > ...we expect template params to be fully qualified when comparing them for > simple template names So lldb is not inspecting the AST, they're doing reflection (of a sort) on the pretty printed names? Or am I misunderstanding something? Commen

[clang-tools-extra] 82ca918 - [clangd] Fix the code action `RemoveUsingNamespace`

Author: v1nh1shungry Date: 2022-11-09T21:04:21+01:00 New Revision: 82ca918b5755f3c442e247563dc011f7b310e446 URL: https://github.com/llvm/llvm-project/commit/82ca918b5755f3c442e247563dc011f7b310e446 DIFF: https://github.com/llvm/llvm-project/commit/82ca918b5755f3c442e247563dc011f7b310e446.diff

[PATCH] D137550: [clangd] Fix the code action `RemoveUsingNamespace`

This revision was automatically updated to reflect the committed changes. Closed by commit rG82ca918b5755: [clangd] Fix the code action `RemoveUsingNamespace` (authored by v1nh1shungry, committed by tom-anders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/arrays.cpp:216 - static_assert(getNextElem(E, 1) == 3); -#endif + static_assert(getNextElem(E, 1) == 3, ""); + aaron.ballman wrote: > I'd like test cases where the pointer arithmetic has r

[PATCH] D131919: Move googletest to the third-party directory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG59052468c3e3: Move googletest to the third-party directory (authored by tstellar). Changed prior to commit: https://reviews.llvm.org/D131919?vs=46

[PATCH] D137386: [clang][Interp] Reject invalid declarations and expressions

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1235-1236 bool ByteCodeExprGen::visitDecl(const VarDecl *VD) { - Optional VarT = classify(VD->getType()); + if (VD->isInvalidDecl()) +return false; Because we can't

[PATCH] D137372: [Test][[AIX][pg] Add 32-bit linker invocation tests

cebowleratibm accepted this revision. cebowleratibm added a comment. This revision is now accepted and ready to land. LGTM. Test only patch is safe to commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137372/new/ https://reviews.llvm.org/D1373

[PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

dblaikie added a comment. In D137583#3917706 , @aaron.ballman wrote: >> ...we expect template params to be fully qualified when comparing them for >> simple template names > > So lldb is not inspecting the AST, they're doing reflection (of a sort) on >

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks added a comment. In D91950#3917635 , @MyDeveloperDay wrote: > I think this is them.. > > https://twitter.com/xen_org/status/1397581514318225412 > https://xenproject.org/ > https://xenproject.org/2021/09/22/clang-format-for-xen-coding-st

[PATCH] D137154: Adding nvvm_reflect clang builtin

tra added a subscriber: jhuber6. tra added a comment. In D137154#3917692 , @hdelan wrote: > Thanks for feedback. Instead of adding `__nvvm_reflect` as a clang builtin, > would it be acceptable if I modified the NVVMReflect pass That would be less proble

[clang] 0453857 - [clang] Mention vector in the description for -mno-implict-float.

Author: Craig Topper Date: 2022-11-09T11:32:19-08:00 New Revision: 0453857d740248a8991ac28981784445dffa8dee URL: https://github.com/llvm/llvm-project/commit/0453857d740248a8991ac28981784445dffa8dee DIFF: https://github.com/llvm/llvm-project/commit/0453857d740248a8991ac28981784445dffa8dee.diff

[PATCH] D134089: [clang] Mention vector in the description for -mno-implict-float.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0453857d7402: [clang] Mention vector in the description for -mno-implict-float. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134

[clang] 8a084f6 - Revert "Move googletest to the third-party directory"

Author: Tom Stellard Date: 2022-11-09T11:34:59-08:00 New Revision: 8a084f68c8a1cac99d9fa0fbcf490b53ab3b6e0c URL: https://github.com/llvm/llvm-project/commit/8a084f68c8a1cac99d9fa0fbcf490b53ab3b6e0c DIFF: https://github.com/llvm/llvm-project/commit/8a084f68c8a1cac99d9fa0fbcf490b53ab3b6e0c.diff

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D137373: [Test][[AIX][p] Add 64-bit linker invocation tests

cebowleratibm accepted this revision. cebowleratibm added a comment. This revision is now accepted and ready to land. LGTM. Test only patch is safe to commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137373/new/ https://reviews.llvm.org/D1373

[clang] dc9846c - [Test][AIX][p] Add 64-bit linker invocation tests

Author: Michael Francis Date: 2022-11-09T14:51:40-05:00 New Revision: dc9846ce988b9ddfcbc42cd462d5d94b634b3161 URL: https://github.com/llvm/llvm-project/commit/dc9846ce988b9ddfcbc42cd462d5d94b634b3161 DIFF: https://github.com/llvm/llvm-project/commit/dc9846ce988b9ddfcbc42cd462d5d94b634b3161.dif

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137071/new/ https://reviews.llvm.org/D137071 ___ cfe-commits mailing list

[clang] e07a704 - [Test][AIX][pg] Add 32-bit linker invocation tests

Author: Michael Francis Date: 2022-11-09T15:02:45-05:00 New Revision: e07a7040d9c6dbdd71e55d1153bfe1357079e511 URL: https://github.com/llvm/llvm-project/commit/e07a7040d9c6dbdd71e55d1153bfe1357079e511 DIFF: https://github.com/llvm/llvm-project/commit/e07a7040d9c6dbdd71e55d1153bfe1357079e511.dif

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

ldionne added a comment. LGTM (sorry, it looks like I approved on behalf of all libc++ vendors but that wasn't my intention). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137724/new/ https://reviews.llvm.org/D137724 _

[PATCH] D136701: [LinkerWrapper] Perform device linking steps in parallel

jhuber6 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136701/new/ https://reviews.llvm.org/D136701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

dblaikie added a comment. > I'm not aware of anyone using this mode, but please wait for responses from > Google and Meta people to verify that. Best understanding on the Google side is we aren't using this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137609/new/ https://reviews.llv

[PATCH] D137154: Adding nvvm_reflect clang builtin

jhuber6 added a comment. In D137154#3917752 , @tra wrote: > As for the code specialization, why not build for individual GPUs? To me it > looks like this use case is a good match for the "new-driver" offloading > that's been recently implemented in clan

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

mgorny added inline comments. Comment at: clang/CMakeLists.txt:14 set(CLANG_BUILT_STANDALONE TRUE) + if ("${CMAKE_VERSION}" VERSION_LESS "3.20.0") +message(WARNING I wonder if we could move this to `CMakePolicy.cmake`, though admittedly you'd have to som

[PATCH] D137740: [clang-tidy] Fix namespace comments in AvoidThrowingObjCExceptionCheck.cpp 🧹

stephanemoore created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. stephanemoore published this revision for review. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This commit

[PATCH] D137738: [clang-tidy] Suppress google-objc-avoid-throwing-exception in system macros 🫢

stephanemoore created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. stephanemoore updated this revision to Diff 474350. stephanemoore added a comment. stephanemoore updated this revision to Diff 474356. stephanemoo

[PATCH] D137040: [clangd] Add heuristic for dropping snippet when completing member function pointer

tom-anders updated this revision to Diff 474358. tom-anders added a comment. Add test to sema Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137040/new/ https://reviews.llvm.org/D137040 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-too

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 474359. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line i

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3916605 , @owenpan wrote: > In D137181#3916558 , @goldstein.w.n > wrote: > >> In D137181#3916547 , @owenpan >> wrote: >> >>> Ye

[PATCH] D137040: [clangd] Add heuristic for dropping snippet when completing member function pointer

tom-anders added a comment. Hmm I added the test for the flag to Sema, but now we kinda have the same test case duplicated in sema and clangd tests - I guess for clangd we now actually only have to test that the SnippetSuffix is cleared when FunctionCanBeCall is true, but I don't see an easy wa

  1   2   >