tbaeder added a comment. In D137071#3915565 <https://reviews.llvm.org/D137071#3915565>, @aaron.ballman wrote:
> Precommit CI looks to have potentially found something interesting here. There might be one of my local patches missing, but it looks like it's somehow not applying this patch, which is weird. ================ Comment at: clang/test/AST/Interp/literals.cpp:553 + static_assert(IntRem(2, 1) == 0, ""); + static_assert(IntRem(9, 7) == 2, ""); + ---------------- aaron.ballman wrote: > aaron.ballman wrote: > > ``` > > static_assert(IntRem(9, 0) == 12, ""); // Not constexpr > > static_assert(IntRem(__INT_MIN__, -1) == 12, ""); // Not constexpr > > ``` > Missed the test for __INT_MIN__ and -1? for rem, clang doesn't diagnose anything: https://godbolt.org/z/rhe5ezc54 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137071/new/ https://reviews.llvm.org/D137071 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
