[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

ABataev added a comment. In D137313#3906527 , @jyu2 wrote: > In D137313#3906487 , @ABataev wrote: > >> Do we have a runtime test for this? Would be good to try to test it if the >> offloading fails and the host v

[PATCH] D136811: -Wunsafe-buffer-usage: WIP: RFC: NFC: User documentation.

NoQ added inline comments. Comment at: clang/docs/SafeBuffers.rst:31 +convert large amounts of old code to conform to the warning; + - Attribute ``[[unsafe_buffer_usage]]`` lets you annotate custom functions as +unsafe, while providing a safe alternative that can often b

[PATCH] D137059: [Driver] [Modules] Introduce -fsave-std-c++-module-file= to specify the path of the module file (2/2)

dblaikie added a subscriber: rsmith. dblaikie added a comment. In D137059#3899339 , @ben.boeckel wrote: > There is another motivating factor for 1-phase: the build graph is far > simpler. With 2-phase, CMake will have to write out rules to perform: > >

[PATCH] D137372: [AIX][pg] Add 32-bit test case

francii created this revision. Herald added a project: All. francii requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a 32-bit version of the already-existing pg test case for compiler-emitted linker flags. Repository: rG LLVM Github

[PATCH] D137373: [AIX][p] Add 64-bit Test Case

francii created this revision. Herald added a project: All. francii requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a 64-bit version of the already-existing `-p` test case for compiler-emitted linker flags. Repository: rG LLVM Githu

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

efriedma added inline comments. Comment at: clang/lib/Headers/stdarg.h:21 + +#ifdef __STDARG_H Maybe the following is a little more readable? ``` #ifndef __STDARG_H #ifndef __GNUC_VA_LIST #define __GNUC_VA_LIST 1 typedef __builtin_va_list __gnuc_va_list; #end

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

francii created this revision. Herald added a project: All. francii requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. On AIX, profiled system libraries are stored at `/lib/profiled` and `/usr/lib/profiled`. When compiling with `-pg`,

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

rnk added a comment. In D137107#3905443 , @zahiraam wrote: > extern int __declspec(dllimport) next(int n); > int main () { > extern int _declspec(dllimport) val; > constexpr int& val_ref = val; > int i = next(val_ref); > return i; >

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

MaskRay added a comment. This needs a clang/test/Driver test. And, does this work with --sysroot= ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137375/new/ https://reviews.llvm.org/D137375 ___ cfe-comm

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

akhuang added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3590-3593 + getTarget().getCXXABI().isMicrosoft() && + llvm::any_of(cast(FD)->parameters(), [&](ParmVarDecl *P) { +return isInAllocaArgument(getCXXABI(), P->getType()); +

[clang] c072586 - [clang][dataflow] Generalize custom comparison to return tri-value result.

Author: Yitzhak Mandelbaum Date: 2022-11-03T23:31:20Z New Revision: c0725865b188f71f904ecd4dac56ef37268b30d2 URL: https://github.com/llvm/llvm-project/commit/c0725865b188f71f904ecd4dac56ef37268b30d2 DIFF: https://github.com/llvm/llvm-project/commit/c0725865b188f71f904ecd4dac56ef37268b30d2.diff

[PATCH] D137334: [clang][dataflow] Generalize custom comparison to return tri-value result.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc0725865b188: [clang][dataflow] Generalize custom comparison to return tri-value result. (authored by ymandel). Repository: rG LLVM Github Monorep

[PATCH] D137058: [Driver] [Modules] Support -fsave-std-c++-module-file (1/2)

iains added a comment. In D137058#3906579 , @dblaikie wrote: > I realize I got this jumbled up and the thread about "why do we need to name > things" is meant to be over in D137059 > (sorry @ben.boeckel :/ I know this

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

akhuang updated this revision to Diff 473082. akhuang added a comment. moved some stuff around Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136998/new/ https://reviews.llvm.org/D136998 Files: clang/lib/CodeGen/CGClass.cpp clang/lib/CodeGen/Co

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

rnk added a subscriber: efriedma. rnk added a comment. +@efriedma, can you review this as a Clang CodeGen owner, according to the recently updated CodeOwners.rst file? https://github.com/llvm/llvm-project/blob/main/clang/CodeOwners.rst#clang-llvm-ir-generation Comment at: clan

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

MyDeveloperDay added a comment. The issue that caused this issue was fix by the fix in https://reviews.llvm.org/rGa92cf5a5a0cd01145f8db2ae09334a8b43a1271b , from the clang-format perspective I don't really feel we need to revisit bringing in these libraries. I think I proved that moving everyt

[PATCH] D131919: Move googletest to the third-party directory

tstellar added a comment. Herald added a subscriber: Moerafaat. @probinson Does this latest update look better? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131919/new/ https://reviews.llvm.org/D131919

[PATCH] D137287: [Test] Fix CHECK typo.

zequanwu added a comment. In D137287#3905474 , @probinson wrote: > Nice work! > have you verified that all the modified tests pass? naively it looks like > you'd need at least 3 different targets to run them all (windows, > webassembly, powerpc) Those

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

jyu2 updated this revision to Diff 473084. jyu2 added a comment. Herald added a subscriber: openmp-commits. Thanks Alexey. New runtime test is added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137313/new/ https://reviews.llvm.org/D137313 Files

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

akhuang added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3590-3593 + getTarget().getCXXABI().isMicrosoft() && + llvm::any_of(cast(FD)->parameters(), [&](ParmVarDecl *P) { +return isInAllocaArgument(getCXXABI(), P->getType()); +

[PATCH] D137058: [Driver] [Modules] Support -fsave-std-c++-module-file (1/2)

dblaikie added a comment. > What was the objection to "-fc++-module-filename[=]" ? I guess it reads a bit awkwardly when you aren't providing the filename/want the default filename? > GCC has "-fmodule-only" Hmm, I don't mind that too much (& as you say, '-fobject-only' - though that flag is

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

efriedma added a comment. Should we try to use this codepath for variadic lambdas as well? Do we want to try to unify our cloning code? CodeGenFunction::GenerateVarArgsThunk has code doing something similar. (It's at least worth comparing to see if you're doing something significantly differ

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

efriedma added a comment. Might also be worth considering if we can avoid cloning here. It should be possible to emit the lambda body into a separate function with a calling convention of your choice, and make both the call operator and the static invoker call it. Repository: rG LLVM Githu

[PATCH] D137379: -Wunsafe-buffer-usage: adding warnings for unsafe buffer accesses by array subscript operations

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, t-rasmud, malavikasamak, jkorous, xazax.hun, aaron.ballman, gribozavr2. Herald added a subscriber: rnkovacs. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald add

[PATCH] D131919: Move googletest to the third-party directory

probinson accepted this revision. probinson added a comment. Yes, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131919/new/ https://reviews.llvm.org/D131919 ___ cfe-commits mailing list cfe-commits@

[PATCH] D137287: [Test] Fix CHECK typo.

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. LGTM, but you'll want to be ready to jump on any bot failures. That's just the nature of these kinds of changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

MaskRay added inline comments. Comment at: clang/lib/Headers/stdarg.h:17 +#ifndef __GNUC_VA_LIST +#define __GNUC_VA_LIST 1 +typedef __builtin_va_list __gnuc_va_list; To match gcc stdarg.h, `#define __GNUC_VA_LIST` Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Comment at: clang/docs/UsersManual.rst:2246 + blocks. Profi (profile inference) algorithm can infer block and edge counts + to fix them. For applying this,

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri created this revision. lebedev.ri added reviewers: rjmccall, morehouse, aaron.ballman, dvyukov, MaskRay, vsk, Sanitizers. lebedev.ri added a project: LLVM. Herald added subscribers: Enna1, StephenFan, dberris. Herald added a project: All. lebedev.ri requested review of this revision. He

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri added a comment. (also, this needs a bit more work around irgen, will look in a bit.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137381/new/ https://reviews.llvm.org/D137381 ___ cfe-commits

[PATCH] D136811: -Wunsafe-buffer-usage: WIP: RFC: NFC: User documentation.

jkorous added inline comments. Comment at: clang/docs/SafeBuffers.rst:173 + #pragma unsafe_buffer_usage begin + +Such pragmas not only enable incremental adoption with much smaller granularity, aaron.ballman wrote: > jkorous wrote: > > aaron.ballman wrote: > >

[PATCH] D137379: -Wunsafe-buffer-usage: adding warnings for unsafe buffer accesses by array subscript operations

NoQ added a comment. Yes, so this is how you work with the abstraction introduced in D137348 . It's very easy to cover more and more patterns incrementally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137379/new

[clang] a806fc2 - [X86] Support -march=raptorlake, meteorlake

Author: Freddy Ye Date: 2022-11-04T09:32:17+08:00 New Revision: a806fc2767d74f2d052647e272dd4339bd747bf0 URL: https://github.com/llvm/llvm-project/commit/a806fc2767d74f2d052647e272dd4339bd747bf0 DIFF: https://github.com/llvm/llvm-project/commit/a806fc2767d74f2d052647e272dd4339bd747bf0.diff LOG

[PATCH] D135937: [X86] Support -march=raptorlake, meteorlake

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa806fc2767d7: [X86] Support -march=raptorlake, meteorlake (authored by FreddyYe). Changed prior to commit: https://reviews.llvm.org/D135937?vs=472

[PATCH] D137259: [clang][modules][deps] WIP: In-memory module transfer

jansvoboda11 updated this revision to Diff 473104. jansvoboda11 added a comment. Kinda rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137259/new/ https://reviews.llvm.org/D137259 Files: clang/include/clang/Frontend/CompilerInstance.h cla

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

pengfei planned changes to this revision. pengfei added a comment. In D136919#3906159 , @rjmccall wrote: > In D136919#3906133 , @rjmccall > wrote: > >> We talked about this on the Itanium list, and as currently s

[PATCH] D137058: [Driver] [Modules] Support -fsave-std-c++-module-file (1/2)

ChuanqiXu added a comment. > so I can appreciate the -fsave-std-c++-module-file name here, but it does > sound a bit verbose? My thought is the option is mainly used by build systems so that the users wouldn't type it frequently. In this case, I feel it might not be bad to make it a little bit

[PATCH] D137317: [X86][CET] Add Diags for targets pre to i686 for `-fcf-protection`

pengfei added a comment. Thanks @nickdesaulniers and @craig.topper! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137317/new/ https://reviews.llvm.org/D137317 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

MaskRay added a comment. In your example, `clang++ a.cc; ./a.out` gives a libstdc++ error: terminate called after throwing an instance of 'int' libc++'s is similar. footgun is nounwind (due to the GNU pure attribute), so Clang uses `call` instead of `invoke` and the function call does not ge

[clang] 5251678 - [X86][CET] Add Diags for targets pre to i686 for `-fcf-protection`

Author: Phoebe Wang Date: 2022-11-04T12:38:29+08:00 New Revision: 52516782972730ff065a34123a9d8876da08c254 URL: https://github.com/llvm/llvm-project/commit/52516782972730ff065a34123a9d8876da08c254 DIFF: https://github.com/llvm/llvm-project/commit/52516782972730ff065a34123a9d8876da08c254.diff L

[PATCH] D137317: [X86][CET] Add Diags for targets pre to i686 for `-fcf-protection`

This revision was automatically updated to reflect the committed changes. Closed by commit rG525167829727: [X86][CET] Add Diags for targets pre to i686 for `-fcf-protection` (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137317/

[PATCH] D136815: [clang][Interp] Unify visiting variable declarations

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:282 + bool isGlobalDecl(const VarDecl *VD) const { +return !VD->hasLocalStorage() || VD->isConstexpr(); + } shafik wrote: > tbaeder wrote: > > shafik wrote: > > > tbaeder wrot

[PATCH] D137386: [clang][Interp] Reject invalid declarations and expressions

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I'm not really sure if this is the right thing to d

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135750/new/ https://reviews.llvm.org/D135750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D136457: [clang][Interp] Fix discarding non-primitive function call return values

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136457/new/ https://reviews.llvm.org/D136457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D136694: [clang][Interp] Check that constructor calls initialize all record fields

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136694/new/ https://reviews.llvm.org/D136694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D136751: [clang][Interp] This pointers are writable in constructors

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136751/new/ https://reviews.llvm.org/D136751 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] 3cbf904 - [X86][test] Add -fcf-protection test for pre-pentiumpro

Author: Fangrui Song Date: 2022-11-03T22:21:44-07:00 New Revision: 3cbf90468aecce960887e680f813cbb1209b337f URL: https://github.com/llvm/llvm-project/commit/3cbf90468aecce960887e680f813cbb1209b337f DIFF: https://github.com/llvm/llvm-project/commit/3cbf90468aecce960887e680f813cbb1209b337f.diff

[clang] e604f88 - [X86][test] Change some CodeGen tests to use %clang_cc1

Author: Fangrui Song Date: 2022-11-03T22:54:44-07:00 New Revision: e604f88304e183d3ce46cea5ba6bfba2fe9fba36 URL: https://github.com/llvm/llvm-project/commit/e604f88304e183d3ce46cea5ba6bfba2fe9fba36 DIFF: https://github.com/llvm/llvm-project/commit/e604f88304e183d3ce46cea5ba6bfba2fe9fba36.diff

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

HaoyuZhang updated this revision to Diff 473122. HaoyuZhang added a comment. 1. modified the documentation. 2. omit '.' in HelpText. 3. fix format in test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136846/new/ https://reviews.llvm.org/D136

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

HaoyuZhang added a comment. Thank you for the updating and comments from @spupyrev and @MaskRay . Comment at: clang/docs/UsersManual.rst:2244 + [OPTIONAL] During the sampling, the profiles may have errors or missing + blocks. Profi (profile inference) algorithm can infer bl

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

michele.scandale added a comment. In D136786#3903646 , @zahiraam wrote: > The changes in this patch look good to me. > @michele.scandale please make sure not to drop the driver changes that we > agreed upon in this patch. Thanks. I started looking at t

[PATCH] D137392: [clang][Interp] Explicitly handle RVO Pointer

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The calling convention is: [RVO pointer] [

[PATCH] D137338: Fix dupe word typos

Rageking8 added a comment. I am ok with you guys taking the parts of this revision that you reviewed and directly commiting them to the repo, just like how the person above did it. This is to break the revision up to smaller parts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] bf1e235 - Implement CWG2631

Author: Corentin Jabot Date: 2022-11-04T07:58:57+01:00 New Revision: bf1e235695a7acdc3e868217e69d5b31ada06cb3 URL: https://github.com/llvm/llvm-project/commit/bf1e235695a7acdc3e868217e69d5b31ada06cb3 DIFF: https://github.com/llvm/llvm-project/commit/bf1e235695a7acdc3e868217e69d5b31ada06cb3.diff

[PATCH] D136554: Implement CWG2631

This revision was automatically updated to reflect the committed changes. cor3ntin marked an inline comment as not done. Closed by commit rGbf1e235695a7: Implement CWG2631 (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/ne

<    1   2   3