HaoyuZhang added a comment.
Thank you for the updating and comments from @spupyrev and @MaskRay .
================
Comment at: clang/docs/UsersManual.rst:2244
+ [OPTIONAL] During the sampling, the profiles may have errors or missing
+ blocks. Profi (profile inference) algorithm can infer block and edge counts
----------------
spupyrev wrote:
> [OPTIONAL] Sampling-based profiles can have inaccuracies or missing block/edge
> counters. The profile inference algorithm (profi) can be used to infer
> missing
> block and edge counts and improve the quality of profile data. To apply the
> optimization, add an extra flag ``-fsample-profile-use-profi`` to the command
> line.
thank you for the updating.
================
Comment at: clang/docs/UsersManual.rst:2246
+ blocks. Profi (profile inference) algorithm can infer block and edge counts
+ to fix them. For applying this, you can use an additional flag
+ ``-fsample-profile-use-profi`` to the command line.
----------------
MaskRay wrote:
> This sentence is unnecessarily long. Just say `Enable it with
> -fsample-profile-use-profi.` (with correct backquotes)
thank you for the comments.
================
Comment at: clang/include/clang/Driver/Options.td:1253
+ Flags<[NoXarchOption, CC1Option]>, Group<f_Group>,
+ HelpText<"Use profi to infer block and edge counts.">,
+ DocBrief<[{Infer block and edge counts. If the profiles have errors or
missing
----------------
MaskRay wrote:
> Omit trailing `.` in HelpText.
Modified.
================
Comment at: clang/test/Driver/pgo-sample-use-profi.c:1
+// Test if profi flat is enabled in frontend as user-facing feature.
+//
----------------
MaskRay wrote:
> Optional: `///`
>
> Make non-RUN non-CHECK comments stand out and help tools finding
> unused/incorrect prefixes.
thank you for the correction of format.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136846/new/
https://reviews.llvm.org/D136846
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
