[PATCH] D137036: [X86] Enable EVEX GFNI instructions without avx512bw.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM, thanks for the patch! Comment at: llvm/test/CodeGen/X86/avx512-gfni-intrinsics.ll:29 +; +; X86NOBW-LABEL: test_vgf2p8affineinvqb_128: +; X86NOBW: # %bb.0: -

[PATCH] D137056: [clangd] Fix a small inconsistency in system-include-extractor.test

nridge created this revision. nridge added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Also add an explana

[PATCH] D137056: [clangd] Fix a small inconsistency in system-include-extractor.test

nridge updated this revision to Diff 471908. nridge added a comment. format comment better Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137056/new/ https://reviews.llvm.org/D137056 Files: clang-tools-extra/clangd/test/system-include-extractor.t

[PATCH] D137056: [clangd] Fix a small inconsistency in system-include-extractor.test

nridge updated this revision to Diff 471909. nridge added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137056/new/ https://reviews.llvm.org/D137056 Files: clang-tools-extra/clangd/test/system-include-extractor.test Index:

[PATCH] D136545: [Clang] use non-instantiated function declaration for constraints partial ordering

chapuni added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:1310 +const auto *FD2 = dyn_cast(D2); +assert(IsExpectedEntity(FD1) && FD2 && IsExpectedEntity(FD2) && + "use non-instantiated function declaration for constraints partial " --

[PATCH] D137058: [Driver] [Modules] Support -fsave-std-c++-module-file (1/2)

ChuanqiXu created this revision. ChuanqiXu added reviewers: dblaikie, ben.boeckel, iains, tschuett. ChuanqiXu added a project: clang-modules. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Pat

[clang] 21bac59 - Fix unused-variable warning in release build, NFC

Author: Haojian Wu Date: 2022-10-31T08:53:30+01:00 New Revision: 21bac595041d46d9882fb930a4467055b99ffa0a URL: https://github.com/llvm/llvm-project/commit/21bac595041d46d9882fb930a4467055b99ffa0a DIFF: https://github.com/llvm/llvm-project/commit/21bac595041d46d9882fb930a4467055b99ffa0a.diff LO

[PATCH] D137059: [Driver] [Modules] Introduce -fsave-std-c++-module-file= to specify the path of the module file

ChuanqiXu created this revision. ChuanqiXu added reviewers: dblaikie, ben.boeckel, iains, tschuett. ChuanqiXu added a project: clang-modules. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Suc

[PATCH] D137036: [X86] Enable EVEX GFNI instructions without avx512bw.

craig.topper added inline comments. Comment at: llvm/test/CodeGen/X86/avx512-gfni-intrinsics.ll:29 +; +; X86NOBW-LABEL: test_vgf2p8affineinvqb_128: +; X86NOBW: # %bb.0: pengfei wrote: > Since we are able to lower the mask version intrinsics, we have 3 choic

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added a comment. In D134267#3892629 , @ben.boeckel wrote: > In D134267#3876071 , @dblaikie > wrote: > >> I'm getting a bit exhausted with all the words involved here & not sure how >> to simplify/clar

[clang] e12b627 - [docs] Add the description about mixing use of clang modules and c++

Author: Chuanqi Xu Date: 2022-10-31T16:02:43+08:00 New Revision: e12b627a35ee41e2bee069bf871c8b779f4d4e35 URL: https://github.com/llvm/llvm-project/commit/e12b627a35ee41e2bee069bf871c8b779f4d4e35 DIFF: https://github.com/llvm/llvm-project/commit/e12b627a35ee41e2bee069bf871c8b779f4d4e35.diff LO

[PATCH] D136221: [docs] Add the description about mixing use of clang modules and c++ modules

This revision was automatically updated to reflect the committed changes. Closed by commit rGe12b627a35ee: [docs] Add the description about mixing use of clang modules and c++ (authored by ChuanqiXu). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Git

[PATCH] D136554: Implement CWG2631

ChuanqiXu added a comment. The serialization part looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: clang/lib/Headers/avx512vlbf16intrin.h:164 +#define _mm_cvtneps_pbh(A) \ + ((__m128bh)__builtin_ia32_vcvtneps2bf16128((__v4sf)(A))) pengfei wrote: > pengfei wrote: > > RKSim

[clang] fd3d7a9 - Handle errors in expansion of response files

Author: Serge Pavlov Date: 2022-10-31T15:36:41+07:00 New Revision: fd3d7a9f8cbb5ad81fb96d92d5f7b1d51a4d4127 URL: https://github.com/llvm/llvm-project/commit/fd3d7a9f8cbb5ad81fb96d92d5f7b1d51a4d4127 DIFF: https://github.com/llvm/llvm-project/commit/fd3d7a9f8cbb5ad81fb96d92d5f7b1d51a4d4127.diff

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

Origami404 added a comment. After digging more deeply into tests, I found that if we decide to make clang include `stdc-predef.h` or other things, the behavior of many libtooling-related tools (e.g. clang-tidy, clangd, and python binding) will be affected. For example, `clang-tidy/checkers/cpp

[PATCH] D133757: [clangd] Turn QueryDriverDatabase into a CompileCommandsAdjuster

nridge updated this revision to Diff 471925. nridge added a comment. reformulate test as lit test address other review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133757/new/ https://reviews.llvm.org/D133757 Files: clang-tools-extra/c

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

nridge added a comment. I believe this addresses the remaining review comments. I will follow up with a patch to rename QueryDriverDatabase.{h,cpp} to SystemIncludeExtractor,{h,cpp}. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:318 /// compilation database. -c

[PATCH] D137063: [clangd] Run semantic highligting in clangd check.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Allowing us to test this feature

[PATCH] D133756: [clangd] Pass the entire tooling::CompileCommand to CommandMangler

nridge added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.h:165 +// process a file (possibly different from the one in the command). +class CompileCommandsAdjuster { +public: sammccall wrote: > nridge wrote: > > sammccall wrote:

[PATCH] D137064: [clangd] Fix a semantic-highlighting crash.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Mon

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

nridge added inline comments. Comment at: clang-tools-extra/clangd/test/system-include-extractor.test:82 + +# Skip past the lack of diagnostics in the workspace and user config files... +# CHECK2: "method": "textDocument/publishDiagnostics", Ugh, this doesn't q

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

pengfei added inline comments. Comment at: clang/lib/Headers/avx512vlbf16intrin.h:164 +#define _mm_cvtneps_pbh(A) \ + ((__m128bh)__builtin_ia32_vcvtneps2bf16128((__v4sf)(A))) FreddyYe wrote: > pengfei wrote: > > pengfei wrote: > > > RKSimon wrote: > > > > Is t

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

kadircet added inline comments. Comment at: clang/include/clang/Sema/CodeCompleteConsumer.h:755 - /// Describes the kind of result generated. - enum ResultKind { -/// Refers to a declaration. egorzhdan wrote: > kadircet wrote: > > i don't follow the reason

[PATCH] D136071: [include-cleaner] WIP: Add PragmaIncludes which handles include-mapping pragmas.

hokein updated this revision to Diff 471936. hokein marked 6 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136071/new/ https://reviews.llvm.org/D136071 Files: clang-tools-extra/in

[PATCH] D136071: [include-cleaner] WIP: Add PragmaIncludes which handles include-mapping pragmas.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:41 +// spelling header rather than the header directly defines the symbol. +class PragmaIncludes { +public: kadircet wrote: > i think this interfac

[PATCH] D135937: [WIP][X86] Support -march=raptorlake, meteorlake

FreddyYe updated this revision to Diff 471938. FreddyYe marked an inline comment as done. FreddyYe added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135937/new/ https://reviews.llvm.org/D135937 Files: clang/docs/ReleaseNotes

[PATCH] D137056: [clangd] Fix a small inconsistency in system-include-extractor.test

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/test/system-include-extractor.test:14-17 +# The purpose of the three lines below is to test that the -nostdinc etc. +# argume

[PATCH] D136951: [clangd] Populate ranges and symbol origin for paramname completions

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:2019 + // Point back to cursor location. + Offset += 2; + CompletionRange.start = offsetToPosition(ParseInput.Con

[PATCH] D137064: [clangd] Fix a semantic-highlighting crash.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:664 bool VisitCXXMemberCallExpr(CXXMemberCallExpr *CE) { -if (isa(CE->getMethodDecl())) { +

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

hans added inline comments. Comment at: clang/include/clang/Driver/Options.td:1254 +HelpText<"Use profi to infer block and edge counts.">, +DocBrief<[{Profi - a flow-based profile inference algorithm is an extended + and significantly re-engineered classic M

[PATCH] D136071: [include-cleaner] Add PragmaIncludes which handles include-mapping pragmas.

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:41 +// spelling header rather than the header directly defines the symbol. +class PragmaIncludes { +public: hokein wrote: > kadircet wrote: > >

[PATCH] D137067: [DebugInfo][Metadata] Make AllEnumTypes holding TrackingMDNodeRef

krisb created this revision. krisb added reviewers: ellis, aprantl, dblaikie. Herald added a subscriber: hiraditya. Herald added a project: All. krisb requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Having AllEnumtypes to

[clang-tools-extra] 1258747 - [clangd] Fix a semantic-highlighting crash.

Author: Haojian Wu Date: 2022-10-31T11:19:01+01:00 New Revision: 1258747a59db5200112fca7c6140d184f3b8748e URL: https://github.com/llvm/llvm-project/commit/1258747a59db5200112fca7c6140d184f3b8748e DIFF: https://github.com/llvm/llvm-project/commit/1258747a59db5200112fca7c6140d184f3b8748e.diff LO

[PATCH] D137064: [clangd] Fix a semantic-highlighting crash.

This revision was automatically updated to reflect the committed changes. hokein marked 2 inline comments as done. Closed by commit rG1258747a59db: [clangd] Fix a semantic-highlighting crash. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D137064?vs=471930&id=471947#toc

[PATCH] D137063: [clangd] Run semantic highligting in clangd check.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/tool/Check.cpp:212 +log("Building semantic highlighting"); +getSemanticHighlightings(*AST); + } can you also vlog the highlights, while limitting the output to ranges that intersect wi

[clang-tools-extra] da5ded4 - [clangd] Populate ranges and symbol origin for paramname completions

Author: Kadir Cetinkaya Date: 2022-10-31T11:34:06+01:00 New Revision: da5ded4fc9d8c8edfd4a79fa0e75c2ac9165fa7b URL: https://github.com/llvm/llvm-project/commit/da5ded4fc9d8c8edfd4a79fa0e75c2ac9165fa7b DIFF: https://github.com/llvm/llvm-project/commit/da5ded4fc9d8c8edfd4a79fa0e75c2ac9165fa7b.dif

[PATCH] D136951: [clangd] Populate ranges and symbol origin for paramname completions

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rGda5ded4fc9d8: [clangd] Populate ranges and symbol origin for paramname completions (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D137054: [X86][Driver] Remove stale FIXME. NFC

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137054/new/ https://reviews.llvm.org/D137054 _

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

MosheBerman abandoned this revision. MosheBerman added a comment. In the interest of not leaving detritus on the internet, I'm going to abandon this diff. I believe there's an alternate approach worth pursuing, with clang tidy. Thanks for your reviews and constructive feedback! Repository: r

[PATCH] D137063: [clangd] Run semantic highligting in clangd check.

hokein updated this revision to Diff 471951. hokein marked an inline comment as done. hokein added a comment. add line-range support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137063/new/ https://reviews.llvm.org/D137063 Files: clang-tools-ex

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName == "std" || ChuanqiXu wrote: > std

[PATCH] D136071: [include-cleaner] Add PragmaIncludes which handles include-mapping pragmas.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LG from my side as well, just some small tweaks for tests. Comment at: clang-tools-extra/include-cleaner/unittests/RecordTest.cpp:124 + TestAST Processed = build

[PATCH] D137063: [clangd] Run semantic highligting in clangd check.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/tool/Check.cpp:213 +auto Highlights = getSemanticHighlightings(*AST); +if (LineRange) { + for (const auto HL : H

[clang] da4b929 - [clang][Interp] Reorder field destruction to avoid use after dtor

Author: Benjamin Kramer Date: 2022-10-31T12:20:10+01:00 New Revision: da4b929da79f4ce886f5612e3c84d29c1d2632f7 URL: https://github.com/llvm/llvm-project/commit/da4b929da79f4ce886f5612e3c84d29c1d2632f7 DIFF: https://github.com/llvm/llvm-project/commit/da4b929da79f4ce886f5612e3c84d29c1d2632f7.dif

[PATCH] D137070: [clang][Interp] Support destructors

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Try to use the existing cleanup machinery to implem

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah updated this revision to Diff 471958. tblah added a comment. I've updated the patch with @awarzynski's nit and an up-to-date context. @kiranchandramohan please could you commit for me CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136080/new/ https://reviews.llvm.org/D136080 File

[clang] a784de7 - [flang] Add -ffp-contract option processing

Author: Tom Eccles Date: 2022-10-31T11:32:31Z New Revision: a784de783af5096e593c5e214c2c78215fe303f5 URL: https://github.com/llvm/llvm-project/commit/a784de783af5096e593c5e214c2c78215fe303f5 DIFF: https://github.com/llvm/llvm-project/commit/a784de783af5096e593c5e214c2c78215fe303f5.diff LOG: [f

[PATCH] D136080: [flang] Add -ffp-contract option processing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa784de783af5: [flang] Add -ffp-contract option processing (authored by tblah, committed by kiranchandramohan). Repository: rG LLVM Github Monorepo

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

tbaeder updated this revision to Diff 471965. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137071/new/ https://reviews.llvm.org/D137071 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/literals.cpp Index: clang/test/AST/Interp/literals.cpp =

[PATCH] D137073: [clang] Fix inline builtin functions of an __asm__ renamed function with symbol prefixes

mstorsjo created this revision. mstorsjo added reviewers: aaron.ballman, rnk. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang. If a function is renamed with `__asm__`, the name provided is the exact symbol name, without any extra implicit symb

[PATCH] D137070: [clang][Interp] Support destructors

tbaeder updated this revision to Diff 471971. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137070/new/ https://reviews.llvm.org/D137070 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/test/AST/

[PATCH] D137075: [clang-format] Fix document of AlignTrailingComments

yusuke-kadowaki created this revision. Herald added a project: All. yusuke-kadowaki edited the summary of this revision. yusuke-kadowaki added reviewers: MyDeveloperDay, HazardyKnusperkeks. yusuke-kadowaki published this revision for review. Herald added a project: clang. Herald added a subscriber:

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

aaron.ballman added inline comments. Comment at: clang/lib/Sema/Sema.cpp:452 + if (auto *ND = dyn_cast_or_null(Context.getVaListTagDecl())) { +if (auto *DC = ND->getLexicalDeclContext(); DC->isStdNamespace()) { The API changed names recently. ===

[PATCH] D137075: [clang-format] Fix document of AlignTrailingComments

yusuke-kadowaki updated this revision to Diff 471977. yusuke-kadowaki added a comment. Add a blankline after the endcode to deal with the Buildbot error. https://lab.llvm.org/buildbot/#/builders/92/builds/34906 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

mizvekov added inline comments. Comment at: clang/test/AST/ast-dump-overloaded-operators.cpp:27 // CHECK-NEXT: | `-ParmVarDecl {{.*}} col:19{{( imported)?}} 'E' -// CHECK-NEXT: `-FunctionDecl {{.*}} line:14:6{{( imported)?}} test 'void ()' +// CHECK-NEXT: -FunctionDecl {{.*}

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

mizvekov added inline comments. Comment at: clang/lib/Sema/Sema.cpp:460-462 +Scope S(TUScope, Scope::DeclScope, getDiagnostics()); +PushDeclContext(&S, DC); +PushOnScopeChains(ND, &S); aaron.ballman wrote: > Is it valid to use a local vari

[PATCH] D137077: [Diagnostic] Clarify -Winfinite-recursion message

merrymeerkat created this revision. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D137077 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/test/SemaCXX/wa

[PATCH] D136554: Implement CWG2631

aaron.ballman added a comment. Thank you for working on this! > Immediate calls in default arguments and defaults members are not evaluated. Er, I think this meant to say "are not evaluated immediately, unlike what the misnamed term of art would suggest." ;-) > As a result of this patch, unuse

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

aaron.ballman added inline comments. Comment at: clang/test/AST/ast-dump-overloaded-operators.cpp:27 // CHECK-NEXT: | `-ParmVarDecl {{.*}} col:19{{( imported)?}} 'E' -// CHECK-NEXT: `-FunctionDecl {{.*}} line:14:6{{( imported)?}} test 'void ()' +// CHECK-NEXT: -FunctionDecl

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

erichkeane added inline comments. Comment at: clang/docs/ReleaseNotes.rst:347 Fixes `Issue 57562 `_. +- Clang now diagnoses use of invalid or reserved module names. Both are + diagnosed as an error, but the diagnostic is supp

[clang] 22914a8 - [NFC] Use isa<...> to replace isa<>||isa<> in clang/Serialization

Author: Chuanqi Xu Date: 2022-10-31T21:17:03+08:00 New Revision: 22914a82299dc45d4e5a3ec6c50808c97e6e6a10 URL: https://github.com/llvm/llvm-project/commit/22914a82299dc45d4e5a3ec6c50808c97e6e6a10 DIFF: https://github.com/llvm/llvm-project/commit/22914a82299dc45d4e5a3ec6c50808c97e6e6a10.diff LO

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

erichkeane added inline comments. Comment at: clang/lib/Sema/Sema.cpp:460-462 +Scope S(TUScope, Scope::DeclScope, getDiagnostics()); +PushDeclContext(&S, DC); +PushOnScopeChains(ND, &S); mizvekov wrote: > aaron.ballman wrote: > > Is it val

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

mizvekov added inline comments. Comment at: clang/test/AST/ast-dump-overloaded-operators.cpp:27 // CHECK-NEXT: | `-ParmVarDecl {{.*}} col:19{{( imported)?}} 'E' -// CHECK-NEXT: `-FunctionDecl {{.*}} line:14:6{{( imported)?}} test 'void ()' +// CHECK-NEXT: -FunctionDecl {{.*}

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

aaron.ballman added inline comments. Comment at: clang/test/AST/ast-dump-overloaded-operators.cpp:27 // CHECK-NEXT: | `-ParmVarDecl {{.*}} col:19{{( imported)?}} 'E' -// CHECK-NEXT: `-FunctionDecl {{.*}} line:14:6{{( imported)?}} test 'void ()' +// CHECK-NEXT: -FunctionDecl

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName == "std" || cor3ntin wrote: > Chua

[PATCH] D136554: Implement CWG2631

cor3ntin added inline comments. Comment at: clang/docs/ReleaseNotes.rst:507-508 ``-std=gnu++14`` to their build settings to restore the previous behaviour. +- Implemented DR2631. Invalid ``consteval`` calls in default arguments and default + member initializers are diagnosed

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

aaron.ballman added inline comments. Comment at: clang/lib/Sema/Sema.cpp:460-462 +Scope S(TUScope, Scope::DeclScope, getDiagnostics()); +PushDeclContext(&S, DC); +PushOnScopeChains(ND, &S); erichkeane wrote: > mizvekov wrote: > > aaron.bal

[PATCH] D136554: Implement CWG2631

cor3ntin added inline comments. Comment at: clang/test/CXX/class/class.local/p1-0x.cpp:14 int& x2 = x; // expected-error{{reference to local variable 'x' declared in enclosing lambda expression}} -}; +}c; // expected-note {{required here}} }; c

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName == "std" || ChuanqiXu wrote: >

[PATCH] D136554: Implement CWG2631

cor3ntin added inline comments. Comment at: clang/docs/ReleaseNotes.rst:507-508 ``-std=gnu++14`` to their build settings to restore the previous behaviour. +- Implemented DR2631. Invalid ``consteval`` calls in default arguments and default + member initializers are diagnosed

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

mizvekov added inline comments. Comment at: clang/test/AST/ast-dump-overloaded-operators.cpp:27 // CHECK-NEXT: | `-ParmVarDecl {{.*}} col:19{{( imported)?}} 'E' -// CHECK-NEXT: `-FunctionDecl {{.*}} line:14:6{{( imported)?}} test 'void ()' +// CHECK-NEXT: -FunctionDecl {{.*}

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

mizvekov added inline comments. Comment at: clang/lib/Sema/Sema.cpp:460-462 +Scope S(TUScope, Scope::DeclScope, getDiagnostics()); +PushDeclContext(&S, DC); +PushOnScopeChains(ND, &S); aaron.ballman wrote: > erichkeane wrote: > > mizvekov

[PATCH] D136826: [clang][Interp] Make sure we free() allocated InitMaps

antondaubert added inline comments. Comment at: clang/lib/AST/Interp/Program.h:54-56 +for (Global *G : Globals) { + G->block()->invokeDtor(); +} Seems like this change generates a ``` use-of-uninitialized-value lib/AST/Interp/Descriptor.cpp:150:22 i

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. In D136953#3893039 , @tschuett wrote: > Are malformed imports an issue or are they already covered? There is limit > test coverage for import. Am I missing something? > > im

[PATCH] D136826: [clang][Interp] Make sure we free() allocated InitMaps

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Program.h:54-56 +for (Global *G : Globals) { + G->block()->invokeDtor(); +} antondaubert wrote: > Seems like this change generates a > > ``` > use-of-uninitialized-value lib/AST/Interp/

[PATCH] D137063: [clangd] Run semantic highligting in clangd check.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/tool/Check.cpp:213 +auto Highlights = getSemanticHighlightings(*AST); +if (LineRange) { + for (const auto HL : Highlights) { kadircet wrote: >

[clang-tools-extra] e3ec9dd - [clangd] Run semantic highligting in clangd check.

Author: Haojian Wu Date: 2022-10-31T14:46:36+01:00 New Revision: e3ec9dd0ba42a6022b37d8a61e20fe338b8dc51f URL: https://github.com/llvm/llvm-project/commit/e3ec9dd0ba42a6022b37d8a61e20fe338b8dc51f DIFF: https://github.com/llvm/llvm-project/commit/e3ec9dd0ba42a6022b37d8a61e20fe338b8dc51f.diff LO

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

aaron.ballman updated this revision to Diff 471988. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Updated based on review feedback: - Fixed a typo - Clarified the release note - Added a test case for `std.foo` being reserved CHANGES SINCE LAST ACTION https://r

[PATCH] D137063: [clangd] Run semantic highligting in clangd check.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rGe3ec9dd0ba42: [clangd] Run semantic highligting in clangd check. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D137063?vs=471951&id=471

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

ldionne added a comment. In D136533#3894958 , @thakis wrote: > In D136533#3893032 , @ldionne wrote: > >> In D136533#3892949 , @ldionne >> wrote: >> >>> 2. Shipping this c

[PATCH] D136957: [AArch64] Add support for the Cortex-A715 CPU

simpal01 updated this revision to Diff 471991. simpal01 added a comment. Comments Addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136957/new/ https://reviews.llvm.org/D136957 Files: clang/docs/ReleaseNotes.rst clang/test/Driver/aarch6

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName == "std" || aaron.ballman wrote: >

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: clang/lib/Headers/avx512vlbf16intrin.h:164 +#define _mm_cvtneps_pbh(A) \ + ((__m128bh)__builtin_ia32_vcvtneps2bf16128((__v4sf)(A))) pengfei wrote: > FreddyYe wrote: > > peng

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

ChuanqiXu added inline comments. Comment at: clang/test/Modules/reserved-names-1.cpp:25 + expected-error {{module declaration must occur at the start of the translation unit}} +export module std.foo;// expected-error {{'std' is a reserved name for a modu

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/test/Modules/reserved-names-1.cpp:25 + expected-error {{module declaration must occur at the start of the translation unit}} +export module std.foo;// e

[PATCH] D136701: [LinkerWrapper] Perform device linking steps in parallel

jhuber6 updated this revision to Diff 471994. jhuber6 added a comment. Ping and fix test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136701/new/ https://reviews.llvm.org/D136701 Files: clang/test/Driver/linker-wrapper.c clang/tools/clang-li

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

ChuanqiXu added inline comments. Comment at: clang/test/Modules/reserved-names-1.cpp:25 + expected-error {{module declaration must occur at the start of the translation unit}} +export module std.foo;// expected-error {{'std' is a reserved name for a modu

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

zahiraam added a comment. In D136786#3893485 , @andrew.w.kaylor wrote: > In D136786#3892177 , @zahiraam > wrote: > I'm not following entirely, but -funsafe-math-optimizations is just a subset of -ffas

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName == "std" || ChuanqiXu wrote: > aa

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

aaron.ballman added inline comments. Comment at: clang/lib/Sema/Sema.cpp:460-462 +Scope S(TUScope, Scope::DeclScope, getDiagnostics()); +PushDeclContext(&S, DC); +PushOnScopeChains(ND, &S); mizvekov wrote: > aaron.ballman wrote: > > erichk

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName

[PATCH] D136701: [LinkerWrapper] Perform device linking steps in parallel

yaxunl added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:1211-1212 +llvm::sort(Input, [](OffloadingImage &A, OffloadingImage &B) { + return A.StringData["triple"].compare(B.StringData["triple"]) == 1 || + A.StringData[

[PATCH] D136071: [include-cleaner] Add PragmaIncludes which handles include-mapping pragmas.

hokein updated this revision to Diff 471995. hokein marked 2 inline comments as done. hokein added a comment. address comments around tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136071/new/ https://reviews.llvm.org/D136071 Files: clang-

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

mizvekov added inline comments. Comment at: clang/test/AST/ast-dump-overloaded-operators.cpp:27 // CHECK-NEXT: | `-ParmVarDecl {{.*}} col:19{{( imported)?}} 'E' -// CHECK-NEXT: `-FunctionDecl {{.*}} line:14:6{{( imported)?}} test 'void ()' +// CHECK-NEXT: -FunctionDecl {{.*}

[PATCH] D137077: [Diagnostic] Clarify -Winfinite-recursion message

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Thank you for the patch! However, I think this isn't an improvement to the diagnostic -- it's a cute phrase, but it doesn't help the programmer to understand what about

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

mizvekov added inline comments. Comment at: clang/test/AST/ast-dump-overloaded-operators.cpp:27 // CHECK-NEXT: | `-ParmVarDecl {{.*}} col:19{{( imported)?}} 'E' -// CHECK-NEXT: `-FunctionDecl {{.*}} line:14:6{{( imported)?}} test 'void ()' +// CHECK-NEXT: -FunctionDecl {{.*}

[clang-tools-extra] 9ab0827 - [include-cleaner] Add a data-structure to capture IWYU pragmas.

Author: Haojian Wu Date: 2022-10-31T15:21:24+01:00 New Revision: 9ab0827f70a524aa9f94995662d37675cd042f30 URL: https://github.com/llvm/llvm-project/commit/9ab0827f70a524aa9f94995662d37675cd042f30 DIFF: https://github.com/llvm/llvm-project/commit/9ab0827f70a524aa9f94995662d37675cd042f30.diff LO

[PATCH] D136071: [include-cleaner] Add PragmaIncludes which handles include-mapping pragmas.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ab0827f70a5: [include-cleaner] Add a data-structure to capture IWYU pragmas. (authored by hokein). Changed prior to commit: https://reviews.llvm.

  1   2   3   >