cor3ntin added inline comments.
================ Comment at: clang/docs/ReleaseNotes.rst:507-508 ``-std=gnu++14`` to their build settings to restore the previous behaviour. +- Implemented DR2631. Invalid ``consteval`` calls in default arguments and default + member initializers are diagnosed when and if the default is used. ---------------- cor3ntin wrote: > aaron.ballman wrote: > > Should this be listed as a potentially breaking change as this now 1) > > potentially changes the value people were getting for > > `source_location::current()` as a default argument, and 2) potentially > > causes instantiation differences due to the change in ODR use? > No because the current value of `source_location::current()` is invalid per > library wording ( i should reference the issue though) and 2/ i don't think > there are any difference in odr use except the point of diagnostic. Or at > least i don't think you could observe it? The wording for source location http://eel.is/c++draft/support.srcloc#cons-2 Without that issue resolution this calls for magic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
