[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 471338. ayzhao added a comment. we don't need CHECK-DAG here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/ReleaseNotes.rst clang/include/clang

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin created this revision. gonglingqin added reviewers: xen0n, xry111, SixWeining, wangleiat, MaskRay. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. gonglingqin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: l

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

eopXD updated this revision to Diff 471344. eopXD added a comment. Update code to handle when IdentifierInfo is null. The .Case syntax seems to evaulate expression in other non-trigger cases. The "loop" case was triggered for test case in loop unroll and jam, resulting in segmentation fault. Anywa

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

FreddyYe updated this revision to Diff 471350. FreddyYe added a comment. Rebase. THX for all of the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135932/new/ https://reviews.llvm.org/D135932 Files: clang/docs/ReleaseNotes.rst clang/inc

[PATCH] D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

jsjodin added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:3031 +OrderedEntries[E.getOrder()] = +std::make_tuple(&E, Loc, EntryInfo.ParentName); +ParentFunctions[E.getOrder()] = EntryInfo.ParentName; mikerice wrot

[PATCH] D136888: Move getenv for AS_SECURE_LOG_FILE to clang

benlangmuir updated this revision to Diff 471351. benlangmuir added a comment. Herald added a subscriber: ormris. - Updated to use cc1 option in clang - Moved the llvm-mc option to a central location so it can be used when initialized MCTargetOptions - Added tests to cover cc1 and cc1as since eac

[PATCH] D134128: [P0857R0 Part B] Resubmit an implemention for constrained template template parameters

h-vetinari added a comment. Congratulations for landing this! How far do you (both) think we're away from completing concepts? Are the issues (aside from CWG1496 & CWG1734) mentioned on https://clang.llvm.org/cxx_status.html tracked anywhere else? I see that https://github.com/orgs/llvm/projec

[clang] 0e720e6 - [X86] Add AVX-IFMA instructions.

Author: Freddy Ye Date: 2022-10-28T09:42:30+08:00 New Revision: 0e720e6adad13d9a3d29dc41e5c62240047acf55 URL: https://github.com/llvm/llvm-project/commit/0e720e6adad13d9a3d29dc41e5c62240047acf55 DIFF: https://github.com/llvm/llvm-project/commit/0e720e6adad13d9a3d29dc41e5c62240047acf55.diff LOG

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e720e6adad1: [X86] Add AVX-IFMA instructions. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D136888: Move getenv for AS_SECURE_LOG_FILE to clang

MaskRay added inline comments. Comment at: clang/test/Driver/AS_SECURE_LOG_FILE.s:1 +// RUN: env AS_SECURE_LOG_FILE=%t %clang -target x86_64-apple-darwin -c %s -o %t.o -### 2>&1 | FileCheck %s -DLOG_FILE=%t +// CHECK: "-cc1as" `--target=` for new tests remove u

[PATCH] D136839: [clang][Interp] Handle non-primitive locals without initializer

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136839/new/ https://reviews.llvm.org/D136839 ___

[PATCH] D136532: [clang][Interp] Implement left and right shifts

shafik accepted this revision. shafik added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136532/new/ https://reviews.llvm.org/D136532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D116735: [RISCV] Adjust RV64I data layout by using n32:64 in layout string

craig.topper updated this revision to Diff 471385. craig.topper added a comment. Refine ReleaseNotes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116735/new/ https://reviews.llvm.org/D116735 Files: clang/lib/Basic/Targets/RISCV.h llvm/docs/Re

[PATCH] D136817: [RISCV] Add H extension

kito-cheng updated this revision to Diff 471386. kito-cheng added a comment. Update instructions which are belong H extension now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136817/new/ https://reviews.llvm.org/D136817 Files: clang/test/Prepr

[PATCH] D136817: [RISCV] Add H extension

kito-cheng added inline comments. Comment at: llvm/test/MC/RISCV/rvi-aliases-valid.s:270 -# CHECK-S-OBJ: hfence.vvma a0 -hfence.vvma a0 Note: Those testcase are moved to `rv32ih-aliases-valid.s`, not just removed. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D136913: [HLSL] support RWByteAddressBuffer.

python3kgae created this revision. python3kgae added reviewers: pow2clk, beanz, bogner. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Only RWByteAddressBuffer:

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

rtrieu added a comment. I noticed some build failures after your commit. I'm trying to get a standalone reproducer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136564/new/ https://reviews.llvm.org/D136564 __

[PATCH] D136831: [clang][Interp] Protect Record creation against infinite recusion

shafik accepted this revision. shafik added a comment. LGTM Comment at: clang/test/AST/Interp/records.cpp:144 + // ref-error {{has incomplete type 'const Bar'}} +}; +constexpr Bar B; // expected-error {{must be initialized by a constant expression}} \ ---

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

HaoyuZhang added a comment. Thank you for the comments. The subject has been modified. For wenlei's comment, I am working on a Chromium patch for enabling profi algorithm in Chrome OS. The reviewer Hans hope an user-facing fl

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

wenlei added a comment. Did you see measurable perf boost with profi on autofdo? Or what motivated you to turn on profi? In most cases, profi helps when csspgo is used (instead of traditional autofdo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

SixWeining added a comment. In D136436#3881382 , @MaskRay wrote: > In D136436#3876684 , @SixWeining > wrote: > >> In D136436#3873987 , @xen0n wrote: >> >>> In D136436#387

[clang-tools-extra] 29e4606 - [clang-tidy] Skip template ctors in modernize-use-equals-default

Author: Alexander Shaposhnikov Date: 2022-10-28T05:30:19Z New Revision: 29e4606ced7284c87a88fdcd34a6d179a1350fe9 URL: https://github.com/llvm/llvm-project/commit/29e4606ced7284c87a88fdcd34a6d179a1350fe9 DIFF: https://github.com/llvm/llvm-project/commit/29e4606ced7284c87a88fdcd34a6d179a1350fe9.d

[PATCH] D136797: [clang-tidy] Skip template ctors in modernize-use-equals-default

This revision was automatically updated to reflect the committed changes. Closed by commit rG29e4606ced72: [clang-tidy] Skip template ctors in modernize-use-equals-default (authored by alexander-shaposhnikov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

HaoyuZhang added a comment. Sorry for not providing the enough information about our investigation. We have opened an issue to show that there are some perf boost with profi on autofdo base on Intel Alder Lake platform by experimen

[PATCH] D136154: [clang-format] Fix the continuation indenter

owenpan added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:803-804 CurrentState.LastSpace = State.Column; - } else if ((Previous.isOneOf(TT_BinaryOperator, TT_ConditionalExpr, - TT_CtorInitializerColon)) &&

[PATCH] D136154: [clang-format] Fix the continuation indenter

owenpan added a comment. In D136154#3882163 , @hel-ableton wrote: > I hope we can somewhat start from square 1 again with this. See https://reviews.llvm.org/D136154#3890747. It doesn't "fix" the last example in https://github.com/llvm/llvm-project/issu

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/PrimType.h:39 PT_Bool, + PT_Float, PT_Ptr, sepavloff wrote: > tbaeder wrote: > > sepavloff wrote: > > > In contrast to other members of this enumeration, `PT_Float` does not > > > designate a

[PATCH] D136828: [clang][Interp] Diagnose uninitialized array record fields

tbaeder updated this revision to Diff 471404. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136828/new/ https://reviews.llvm.org/D136828 Files: clang/lib/AST/Interp/Interp.cpp clang/lib/AST/Interp/Pointer.h clang/test/AST/Interp/cxx20.cpp Index: clang/test/AST/Interp/cxx20.cpp ===

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

xen0n added a comment. In D136436#3890737 , @SixWeining wrote: > In D136436#3881382 , @MaskRay wrote: > >> In D136436#3876684 , @SixWeining >> wrote: >> >>> In D136436#3

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny added a comment. In D136572#3889317 , @mstorsjo wrote: > Also for the record, I'd love to get rid of this symlink based setup, if I > could make cmake produce project files where caching works in the same way. > The main requirement for that woul

[clang] 9dd01a5 - Harmonize cmake_policy() across standalone builds of all projects

Author: Michał Górny Date: 2022-10-28T08:46:48+02:00 New Revision: 9dd01a5241dc5b46e92485e05bc345221df8938c URL: https://github.com/llvm/llvm-project/commit/9dd01a5241dc5b46e92485e05bc345221df8938c DIFF: https://github.com/llvm/llvm-project/commit/9dd01a5241dc5b46e92485e05bc345221df8938c.diff

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9dd01a5241dc: Harmonize cmake_policy() across standalone builds of all projects (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D135858: [clang][Interp] Support pointer arithmetic in binary operators

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:241 + // Pointer arithmethic special case. This is supported for one of + // LHS and RHS being a pointer type and the other being an integer type. + if

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

tangyouling added a comment. In D136436#3890737 , @SixWeining wrote: > In D136436#3881382 , @MaskRay wrote: > >> In D136436#3876684 , @SixWeining >> wrote: >> >>> In D13

<    1   2   3