[PATCH] D129443: [clang-format] Add option for aligning requires clause body

owenpan added a comment. In D129443#3857608 , @rymiel wrote: > Changing the default LLVM style would change the output of all the > requires-related test cases in `FormatTest.Concepts`. Should I change these > test cases to use the new indentation or pa

[PATCH] D135518: [clangAST] support TypeLoc in TextNodeDumper

upsj updated this revision to Diff 467698. upsj marked 6 inline comments as done. upsj added a comment. I incorporated the `cast`, `ASTContext` and `StringRef` suggestions. About JSONDumper, I was surprised to see that it doesn't seem to use `AddChild` for the AST hierarchy at all, so I'm not qu

[PATCH] D135518: [clangAST] support TypeLoc in TextNodeDumper

upsj added inline comments. Comment at: clang/include/clang/AST/TextNodeDumper.h:337 + void VisitConstantArrayTypeLoc(ConstantArrayTypeLoc TL); + void VisitVariableArrayTypeLoc(VariableArrayTypeLoc TL); + void VisitDependentSizedArrayTypeLoc(DependentSizedArrayTypeLoc TL); ---

[PATCH] D135859: [Includecleaner] Introduce RefType to ast walking

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/AnalysisInternal.h:33 +/// Indicates the relation between the reference and the target. +enum class RefType { + /// Target is explicit from the reference, e.g. function call. I'm won

[PATCH] D135025: [clang][Interp] Support base class constructors

tbaeder updated this revision to Diff 467699. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135025/new/ https://reviews.llvm.org/D135025 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/In

[PATCH] D135025: [clang][Interp] Support base class constructors

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/test/AST/Interp/records.cpp:209 + static_assert(d.getA() == 20); + static_assert(d.getB() == 30); +}; aaron.ballman wrote: > I'd appreciate some more failure test cases,

[PATCH] D135858: [clang][Interp] Support pointer arithmethic in binary operators

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:241 + // Pointer arithmethic special case. This is supported for one of + // LHS and RHS being a pointer type and the other being an integer type. + if (BO->getType()->isPointerType()) { --

[PATCH] D135518: [clangAST] support TypeLoc in TextNodeDumper

upsj added a comment. Let me backtrack my previous question: I misremembered where AddChild is actually being called in the traversal (ASTNodeTraverser, not TextNodeDumper), so I'll see if adding this to the JSON output is feasible CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135518/n

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

RKSimon added inline comments. Comment at: clang/test/CodeGen/avxifma-builtins.c:1 +// RUN: %clang_cc1 -ffreestanding %s -triple=x86_64-apple-darwin -target-feature +avxifma -emit-llvm -o - -Wall -Werror | FileCheck %s + 32-bit test coverage?

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

RKSimon added inline comments. Comment at: clang/test/CodeGen/X86/cmpccxadd-builtins-error.c:2 +// RUN: %clang_cc1 %s -ffreestanding -triple=x86_64-unknown-unknown \ +// RUN: -target-feature +cmpccxadd -emit-llvm -fsyntax-only -verify + Add 32-bit test coverage

[clang] 0e93b6b - [clang][Interp][NFC] Add more tests for if expressions

Author: Timm Bäder Date: 2022-10-14T10:21:53+02:00 New Revision: 0e93b6bd51a0f002e37e76d6efa8e71dde6d3e5f URL: https://github.com/llvm/llvm-project/commit/0e93b6bd51a0f002e37e76d6efa8e71dde6d3e5f DIFF: https://github.com/llvm/llvm-project/commit/0e93b6bd51a0f002e37e76d6efa8e71dde6d3e5f.diff LO

[clang] 1928da1 - [clang][Interp] Don't run functions immediately after compiling them

Author: Timm Bäder Date: 2022-10-14T10:21:53+02:00 New Revision: 1928da1ef73c383ea4daeffb41691882bdb074c2 URL: https://github.com/llvm/llvm-project/commit/1928da1ef73c383ea4daeffb41691882bdb074c2 DIFF: https://github.com/llvm/llvm-project/commit/1928da1ef73c383ea4daeffb41691882bdb074c2.diff LO

[clang] 773b468 - [clang][Interp][NFC] Add a TODO comment

Author: Timm Bäder Date: 2022-10-14T10:21:52+02:00 New Revision: 773b468543c8c5f0a226c0757a503cb9a40650a5 URL: https://github.com/llvm/llvm-project/commit/773b468543c8c5f0a226c0757a503cb9a40650a5 DIFF: https://github.com/llvm/llvm-project/commit/773b468543c8c5f0a226c0757a503cb9a40650a5.diff LO

[clang] 1942a25 - [clang][Interp] Start implementing record types

Author: Timm Bäder Date: 2022-10-14T10:21:53+02:00 New Revision: 1942a2538b86fe55b9723800db950391cc05402b URL: https://github.com/llvm/llvm-project/commit/1942a2538b86fe55b9723800db950391cc05402b DIFF: https://github.com/llvm/llvm-project/commit/1942a2538b86fe55b9723800db950391cc05402b.diff LO

[clang] 0ddd13a - [clang][Interp] Implement This pointer passing to methods

Author: Timm Bäder Date: 2022-10-14T10:21:53+02:00 New Revision: 0ddd13acc9e9b820c8f610c9006ef59aef8e5320 URL: https://github.com/llvm/llvm-project/commit/0ddd13acc9e9b820c8f610c9006ef59aef8e5320 DIFF: https://github.com/llvm/llvm-project/commit/0ddd13acc9e9b820c8f610c9006ef59aef8e5320.diff LO

[clang] cb5f205 - [clang][Interp] Implement nested struct initialization

Author: Timm Bäder Date: 2022-10-14T10:21:53+02:00 New Revision: cb5f205828e696fb23cfe3de57af83d151ffad38 URL: https://github.com/llvm/llvm-project/commit/cb5f205828e696fb23cfe3de57af83d151ffad38 DIFF: https://github.com/llvm/llvm-project/commit/cb5f205828e696fb23cfe3de57af83d151ffad38.diff LO

[clang] 33b5283 - [clang][Interp] Fix using default copy constructors

Author: Timm Bäder Date: 2022-10-14T10:21:53+02:00 New Revision: 33b52836de6e093acea15f24b6ae633f969d194a URL: https://github.com/llvm/llvm-project/commit/33b52836de6e093acea15f24b6ae633f969d194a DIFF: https://github.com/llvm/llvm-project/commit/33b52836de6e093acea15f24b6ae633f969d194a.diff LO

[PATCH] D135569: [clang][Interp] Don't run functions immediately after compiling them

This revision was automatically updated to reflect the committed changes. Closed by commit rG1928da1ef73c: [clang][Interp] Don't run functions immediately after compiling them (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D135569?vs=466462&id=467706#toc Repository:

[PATCH] D134057: [clang][Interp] Start implementing record types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tbaeder marked an inline comment as done. Closed by commit rG1942a2538b86: [clang][Interp] Start implementing record types (authored by tbaeder). Changed prior to comm

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tbaeder marked an inline comment as done. Closed by commit rG0ddd13acc9e9: [clang][Interp] Implement This pointer passing to methods (authored by tbaeder). Changed pri

[PATCH] D134175: [clang][Interp] Implement record instance functions and returning struct types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb5f205828e6: [clang][Interp] Implement nested struct initialization (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D134361: [clang][Interp] Fix copy constructors of structs with array members

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33b52836de6e: [clang][Interp] Fix using default copy constructors (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D134361

[PATCH] D135936: [X86] Support -march=raptorlake

RKSimon added inline comments. Comment at: llvm/lib/Support/Host.cpp:828 + *Subtype = X86::INTEL_COREI7_RAPTORLAKE; + break; // Icelake Xeon: newline to separate the defs Comment at: llvm/lib/Target/X86/X86.td:1423

[PATCH] D135937: [X86] Support -march=meteorlake

RKSimon added inline comments. Comment at: llvm/lib/Target/X86/X86.td:1424 +def : ProcModel<"meteorlake", SLMModel, ProcessorFeatures.ADLFeatures, +ProcessorFeatures.TRMTuning>; This should be with the alderlake/raptorlake defs below (and use AD

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

RKSimon added inline comments. Comment at: clang/test/CodeGen/avxvnniint8-builtins.c:1 +// RUN: %clang_cc1 -flax-vector-conversions=none -ffreestanding %s -triple=x86_64-unknown-unknown -target-feature +avxvnniint8 -emit-llvm -o - -Wall -Werror | FileCheck %s +

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

RKSimon added inline comments. Comment at: clang/test/CodeGen/X86/avxneconvert-builtins.c:2 +// RUN: %clang_cc1 %s -ffreestanding -triple=x86_64-unknown-unknown -target-feature +avx2 -target-feature +avxneconvert \ +// RUN: -target-feature +avx512fp16 -emit-llvm -o - -Wall -Werr

[PATCH] D135951: [X86][WIP] SUPPORT RAO-INT

pengfei created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. pengfei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. For more details about these instructions, please refer to the lates

[clang] 2f35705 - [Interp] Silence warning in release builds. NFC.

Author: Benjamin Kramer Date: 2022-10-14T10:38:32+02:00 New Revision: 2f357054d705459c534a74781e4dc24debe78fcb URL: https://github.com/llvm/llvm-project/commit/2f357054d705459c534a74781e4dc24debe78fcb DIFF: https://github.com/llvm/llvm-project/commit/2f357054d705459c534a74781e4dc24debe78fcb.dif

[clang] c004d75 - [clang][Interp] Disable some RVO tests

Author: Timm Bäder Date: 2022-10-14T10:45:23+02:00 New Revision: c004d7534dcefcfebc3e07a7fa12f5492be80279 URL: https://github.com/llvm/llvm-project/commit/c004d7534dcefcfebc3e07a7fa12f5492be80279 DIFF: https://github.com/llvm/llvm-project/commit/c004d7534dcefcfebc3e07a7fa12f5492be80279.diff LO

[PATCH] D135953: [IncludeCleaner] Introduce decl to location mapping

kadircet created this revision. kadircet added reviewers: hokein, sammccall. Herald added a subscriber: mgrang. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Creates a one to many mapping,

[PATCH] D135937: [X86] Support -march=meteorlake

RKSimon added a comment. Please add this to llvm-project\llvm\test\CodeGen\X86\cpus-intel.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135937/new/ https://reviews.llvm.org/D135937 ___ cfe-commits mai

[clang] ae27323 - [clang][Interp] Classify ArrayInitIndexExpr type

Author: Timm Bäder Date: 2022-10-14T11:10:28+02:00 New Revision: ae27323428ff9666b1c4cf32e0ea928681ce778e URL: https://github.com/llvm/llvm-project/commit/ae27323428ff9666b1c4cf32e0ea928681ce778e DIFF: https://github.com/llvm/llvm-project/commit/ae27323428ff9666b1c4cf32e0ea928681ce778e.diff LO

[clang] 7229227 - [clang][Interp][NFC] Run record tests on i686 as well

Author: Timm Bäder Date: 2022-10-14T11:19:24+02:00 New Revision: 72292271f6635a812bef42814808f60070297268 URL: https://github.com/llvm/llvm-project/commit/72292271f6635a812bef42814808f60070297268 DIFF: https://github.com/llvm/llvm-project/commit/72292271f6635a812bef42814808f60070297268.diff LO

[clang] b3d495e - [clang][Interp][NFC] Explain why tests are disabled

Author: Timm Bäder Date: 2022-10-14T11:47:25+02:00 New Revision: b3d495e7e082c3a3c77bfcf2ed928f6f18f69fc4 URL: https://github.com/llvm/llvm-project/commit/b3d495e7e082c3a3c77bfcf2ed928f6f18f69fc4 DIFF: https://github.com/llvm/llvm-project/commit/b3d495e7e082c3a3c77bfcf2ed928f6f18f69fc4.diff LO

[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

MyDeveloperDay added a comment. Thanks @rymiel its great to have another active contributor, especially one who seems so focused on github issues. Really appreciate your recent contributions. Can we start including you as one of the default reviewers that we use to review our stuff? Repositor

[PATCH] D135953: [IncludeCleaner] Introduce decl to location mapping

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/AnalysisInternal.h:64 +using SymbolLocation = std::variant; +/// A set of locations that provides the declaration, while indicating if This is an important public API concept ==>

[PATCH] D134523: [clang][Interp] Fix copy constructors with record array members

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e83209f623e: [clang][Interp] Fix copy constructors with record array members (authored by tbaeder). Changed prior to commit: https://reviews.llvm

[clang] 6e83209 - [clang][Interp] Fix copy constructors with record array members

Author: Timm Bäder Date: 2022-10-14T11:57:26+02:00 New Revision: 6e83209f623e00b16f5858efbfa0fd6409abf1fe URL: https://github.com/llvm/llvm-project/commit/6e83209f623e00b16f5858efbfa0fd6409abf1fe DIFF: https://github.com/llvm/llvm-project/commit/6e83209f623e00b16f5858efbfa0fd6409abf1fe.diff LO

[clang] 55c7ad3 - [clang][Interp][NFC] Pass Function* pointers around as const

Author: Timm Bäder Date: 2022-10-14T12:31:24+02:00 New Revision: 55c7ad31aacb6cdef19a7296fda56cc8b177e2b4 URL: https://github.com/llvm/llvm-project/commit/55c7ad31aacb6cdef19a7296fda56cc8b177e2b4 DIFF: https://github.com/llvm/llvm-project/commit/55c7ad31aacb6cdef19a7296fda56cc8b177e2b4.diff LO

[clang] 4d2d426 - [clang][Interp] Fix Pointer::toAPValue() LValuePath order

Author: Timm Bäder Date: 2022-10-14T12:31:24+02:00 New Revision: 4d2d426a51e122231443d89b196b0c6e91a5b147 URL: https://github.com/llvm/llvm-project/commit/4d2d426a51e122231443d89b196b0c6e91a5b147 DIFF: https://github.com/llvm/llvm-project/commit/4d2d426a51e122231443d89b196b0c6e91a5b147.diff LO

[clang] 699449d - [clang][Interp][NFC] Use a SourceRange for errors

Author: Timm Bäder Date: 2022-10-14T12:46:51+02:00 New Revision: 699449d71eadb1499bf6a98999c2abdaa6b1294a URL: https://github.com/llvm/llvm-project/commit/699449d71eadb1499bf6a98999c2abdaa6b1294a DIFF: https://github.com/llvm/llvm-project/commit/699449d71eadb1499bf6a98999c2abdaa6b1294a.diff LO

[clang] 81c5b5d - [clang][Interp][NFC] Simplify Integral using constexpr if

Author: Timm Bäder Date: 2022-10-14T12:47:07+02:00 New Revision: 81c5b5d80efab9de616d6f8e42cd007f9c16e36b URL: https://github.com/llvm/llvm-project/commit/81c5b5d80efab9de616d6f8e42cd007f9c16e36b DIFF: https://github.com/llvm/llvm-project/commit/81c5b5d80efab9de616d6f8e42cd007f9c16e36b.diff LO

[PATCH] D135956: [include-cleaner] Add include-cleaner tool, with initial HTML report

sammccall created this revision. Herald added a subscriber: mgrang. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The immediate goal is to start producing an HTML report to debug and expl

[clang] 5421234 - [clang][Interp] Implement bitwise not operations

Author: Timm Bäder Date: 2022-10-14T12:57:57+02:00 New Revision: 542123465f9e523ccd82bd91ee17f407ea4b0cd1 URL: https://github.com/llvm/llvm-project/commit/542123465f9e523ccd82bd91ee17f407ea4b0cd1 DIFF: https://github.com/llvm/llvm-project/commit/542123465f9e523ccd82bd91ee17f407ea4b0cd1.diff LO

[clang] c9ad877 - [clang][Interp] Implement rem opcode

Author: Timm Bäder Date: 2022-10-14T12:57:57+02:00 New Revision: c9ad877844a7fd52726ed3f11bb6e7fb90e9358e URL: https://github.com/llvm/llvm-project/commit/c9ad877844a7fd52726ed3f11bb6e7fb90e9358e DIFF: https://github.com/llvm/llvm-project/commit/c9ad877844a7fd52726ed3f11bb6e7fb90e9358e.diff LO

[clang] d704ba2 - [clang][Interp] Implement div opcode

Author: Timm Bäder Date: 2022-10-14T12:57:57+02:00 New Revision: d704ba26b9144829f1c4905c168f6b6278c7a3e6 URL: https://github.com/llvm/llvm-project/commit/d704ba26b9144829f1c4905c168f6b6278c7a3e6 DIFF: https://github.com/llvm/llvm-project/commit/d704ba26b9144829f1c4905c168f6b6278c7a3e6.diff LO

[PATCH] D134804: [clang][Interp] Implement bitwise Not operations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG542123465f9e: [clang][Interp] Implement bitwise not operations (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D134804?vs

[PATCH] D134744: [clang][Interp] Implement rem opcode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9ad877844a7: [clang][Interp] Implement rem opcode (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D134744?vs=463543&id=4

[PATCH] D134749: [clang][Interp] Implement Div opcode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd704ba26b914: [clang][Interp] Implement div opcode (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D134629: [clang][Interp] Fix Pointer::toAPValue() LValuePath order

tbaeder closed this revision. tbaeder added a comment. Meh, looks like I forgot to fix up the commit message for https://github.com/llvm/llvm-project/commit/4d2d426a51e122231443d89b196b0c6e91a5b147. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134629/new/ https://reviews.llvm.org/D134

[PATCH] D135956: [include-cleaner] Add include-cleaner tool, with initial HTML report

sammccall added reviewers: kadircet, hokein. sammccall added a comment. Demo: https://htmlpreview.github.io/?https://gist.githubusercontent.com/sam-mccall/0cc7dd1f6c5605837966cb113babe591/raw/7c9a29142eca1fc1f486540f255586a0f72a9c9e/AST.html This is missing tests, my plan is: - add some basic s

[PATCH] D134801: [clang][Interp] Implement ConditionalOperators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77aaf469a7ae: [clang][Interp] Implement ConditionalOperators (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D134801?vs=4

[clang] 77aaf46 - [clang][Interp] Implement ConditionalOperators

Author: Timm Bäder Date: 2022-10-14T13:16:10+02:00 New Revision: 77aaf469a7ae5af26a8fe92ed9d548404831d3ed URL: https://github.com/llvm/llvm-project/commit/77aaf469a7ae5af26a8fe92ed9d548404831d3ed DIFF: https://github.com/llvm/llvm-project/commit/77aaf469a7ae5af26a8fe92ed9d548404831d3ed.diff LO

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/SolverTest.cpp:69 -TEST(SolverTest, UnitConflict) { - ConstraintContext Ctx; Why delete this test? Repository: rG LLVM Github Monorepo

[clang] 0e69014 - [clang][Interp][NFC] Add a failing test case

Author: Timm Bäder Date: 2022-10-14T13:31:52+02:00 New Revision: 0e6901421247b1c7ce0a2e925666d5314a34fffa URL: https://github.com/llvm/llvm-project/commit/0e6901421247b1c7ce0a2e925666d5314a34fffa DIFF: https://github.com/llvm/llvm-project/commit/0e6901421247b1c7ce0a2e925666d5314a34fffa.diff LO

[clang] 9b2f2d8 - [clang][Interp][NFC] Remove unused function

Author: Timm Bäder Date: 2022-10-14T13:32:00+02:00 New Revision: 9b2f2d846345dfbc4256db1ebf2b6176553fa157 URL: https://github.com/llvm/llvm-project/commit/9b2f2d846345dfbc4256db1ebf2b6176553fa157 DIFF: https://github.com/llvm/llvm-project/commit/9b2f2d846345dfbc4256db1ebf2b6176553fa157.diff LO

[clang] 7fbfe55 - [clang][Interp][NFC] Rename a parameter to be more descriptive

Author: Timm Bäder Date: 2022-10-14T13:32:31+02:00 New Revision: 7fbfe5518c363da8ee7eb60352948f0e904f283b URL: https://github.com/llvm/llvm-project/commit/7fbfe5518c363da8ee7eb60352948f0e904f283b DIFF: https://github.com/llvm/llvm-project/commit/7fbfe5518c363da8ee7eb60352948f0e904f283b.diff LO

[clang] 1b731bd - [clang][Interp][NFC] Zero-initialize Function::FrameSize

Author: Timm Bäder Date: 2022-10-14T13:32:55+02:00 New Revision: 1b731bd8724c2f56550f87d3c4f0fa820b8b4527 URL: https://github.com/llvm/llvm-project/commit/1b731bd8724c2f56550f87d3c4f0fa820b8b4527 DIFF: https://github.com/llvm/llvm-project/commit/1b731bd8724c2f56550f87d3c4f0fa820b8b4527.diff LO

[clang] 11f3604 - [clang][Interp][NFC] Remove an unnecessary local variable

Author: Timm Bäder Date: 2022-10-14T13:33:04+02:00 New Revision: 11f360469599e5c7c470b2071692fc6647cf3280 URL: https://github.com/llvm/llvm-project/commit/11f360469599e5c7c470b2071692fc6647cf3280 DIFF: https://github.com/llvm/llvm-project/commit/11f360469599e5c7c470b2071692fc6647cf3280.diff LO

[PATCH] D135012: [clang][Interp] Implement bitwise and operations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62a58050ba0a: [clang][Interp] Implement bitwise and operations (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D135012?vs

[clang] 62a5805 - [clang][Interp] Implement bitwise and operations

Author: Timm Bäder Date: 2022-10-14T14:00:07+02:00 New Revision: 62a58050ba0afad5c1ca59195f10c6fdc0e0feaa URL: https://github.com/llvm/llvm-project/commit/62a58050ba0afad5c1ca59195f10c6fdc0e0feaa DIFF: https://github.com/llvm/llvm-project/commit/62a58050ba0afad5c1ca59195f10c6fdc0e0feaa.diff LO

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

ymandel updated this revision to Diff 467746. ymandel marked an inline comment as done. ymandel added a comment. Adding back accidentally deleted test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135397/new/ https://reviews.llvm.org/D135397 Files

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/SolverTest.cpp:69 -TEST(SolverTest, UnitConflict) { - ConstraintContext Ctx; gribozavr2 wrote: > Why delete this test? That was a mistak

[clang] ce4d5ae - [clang][Interp] Implement bitwise Or operations

Author: Timm Bäder Date: 2022-10-14T14:15:08+02:00 New Revision: ce4d5ae9dcf64deade70f305b8d7ab8d0dc80102 URL: https://github.com/llvm/llvm-project/commit/ce4d5ae9dcf64deade70f305b8d7ab8d0dc80102 DIFF: https://github.com/llvm/llvm-project/commit/ce4d5ae9dcf64deade70f305b8d7ab8d0dc80102.diff LO

[PATCH] D135361: [clang][Interp] Implement bitwise Or operations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce4d5ae9dcf6: [clang][Interp] Implement bitwise Or operations (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D135361?vs=

[clang] 19e984e - Properly print unnamed TagDecl objects in diagnostics

Author: Aaron Ballman Date: 2022-10-14T08:18:28-04:00 New Revision: 19e984ef8f49bc3ccced15621989fa9703b2cd5b URL: https://github.com/llvm/llvm-project/commit/19e984ef8f49bc3ccced15621989fa9703b2cd5b DIFF: https://github.com/llvm/llvm-project/commit/19e984ef8f49bc3ccced15621989fa9703b2cd5b.diff

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19e984ef8f49: Properly print unnamed TagDecl objects in diagnostics (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam updated this revision to Diff 467749. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135097/new/ https://reviews.llvm.org/D135097 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Driver/Options.td clang/lib/CodeGen/CGCall.cpp clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam marked an inline comment as done. zahiraam added inline comments. Comment at: clang/docs/ReleaseNotes.rst:410-412 +- The driver option ``-menable-unsafe-fp-math`` has been removed. Passing it, will +result in a hard error. To enable unsafe floating-point optimizations,

[clang] e83bea4 - [clang][Interp][NFC] Add some tests for invalid array access

Author: Timm Bäder Date: 2022-10-14T14:41:05+02:00 New Revision: e83bea40b6c45bf2a8d4983238da32b5d2be80fc URL: https://github.com/llvm/llvm-project/commit/e83bea40b6c45bf2a8d4983238da32b5d2be80fc DIFF: https://github.com/llvm/llvm-project/commit/e83bea40b6c45bf2a8d4983238da32b5d2be80fc.diff LO

[clang] 6fad712 - [clang][Interp][NFC] Remove unused parameter from emitConst()

Author: Timm Bäder Date: 2022-10-14T14:41:05+02:00 New Revision: 6fad7127cb990894cc2392c89152a36af7808736 URL: https://github.com/llvm/llvm-project/commit/6fad7127cb990894cc2392c89152a36af7808736 DIFF: https://github.com/llvm/llvm-project/commit/6fad7127cb990894cc2392c89152a36af7808736.diff LO

[clang] 5a85943 - [clang][Interp] Implement while and do-while loops

Author: Timm Bäder Date: 2022-10-14T14:41:05+02:00 New Revision: 5a859432f31716f780cd662741864ef1a77fc28a URL: https://github.com/llvm/llvm-project/commit/5a859432f31716f780cd662741864ef1a77fc28a DIFF: https://github.com/llvm/llvm-project/commit/5a859432f31716f780cd662741864ef1a77fc28a.diff LO

[PATCH] D135433: [clang][Interp] Implement while and do-while loops

This revision was automatically updated to reflect the committed changes. tbaeder marked an inline comment as done. Closed by commit rG5a859432f317: [clang][Interp] Implement while and do-while loops (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D135433?vs=466259&id=4

[PATCH] D132855: [OpenMP] Extend the lit test for uses_allocators in target region

animeshk-amd updated this revision to Diff 467757. animeshk-amd added a comment. Another patch that landed after this patch introduced merge conflicts in the target_map_codegen_10.cpp with regards to the use of the `-no-opaque-pointers`. Those merge conflicts are fixed in the revision. Reposit

[clang] dcee874 - Fix the ExtractAPI tests

Author: Aaron Ballman Date: 2022-10-14T08:58:16-04:00 New Revision: dcee874ee3900fe1617c7562c774e5405439f5c9 URL: https://github.com/llvm/llvm-project/commit/dcee874ee3900fe1617c7562c774e5405439f5c9 DIFF: https://github.com/llvm/llvm-project/commit/dcee874ee3900fe1617c7562c774e5405439f5c9.diff

[PATCH] D134928: [Sema] Don't treat a non-null template argument as if it were null.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134928/new/ https://reviews.llvm.org/D134928 _

[PATCH] D135772: Stop evaluating trailing requires clause after overload resolution

erichkeane updated this revision to Diff 467762. erichkeane marked an inline comment as done. erichkeane added a comment. Thanks for the review @shafik CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135772/new/ https://reviews.llvm.org/D135772 Files: clang/include/clang/Sema/Sema.h

[PATCH] D120862: Sema: Allow scoped enums as source type for integral conversion.

aaron.ballman added a comment. In D120862#3857372 , @shafik wrote: > In D120862#3857340 , @pcc wrote: > >> Does that DR apply retroactively to C++17? I get the impression that >> "Status: C++20" means that the is

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/docs/ReleaseNotes.rst:410-412 +- The driver option ``-menable-unsafe-fp-math`` has been removed. Passing it, will +result in a hard err

[PATCH] D134928: [Sema] Don't treat a non-null template argument as if it were null.

erichkeane accepted this revision. erichkeane added a comment. I would love it if the diagnostic had a little more info why it isn't, but this is probably good enough for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134928/new/ https://revie

[PATCH] D135919: [Clang] Set thread_local Itanium ABI guard variables before calling constructors.

erichkeane added a comment. So this logically looks/sounds right to me (and I have no code concerns)... But I'm also notoriously bad at anything threading related. I'd love it if one of the other reviewers could sanity check this for me. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D135931: [Attributes] Improve writing `ExprArgument` value.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135931/new/ https://reviews.llvm.org/D135931

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe added a comment. I'm out of machines next two days. Sorry for late address in advance... I'll update next Monday. Thanks for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135938/new/ https://reviews.llvm.org/D135938 _

[PATCH] D135472: [ODRHash] Hash attributes on declarations.

aaron.ballman added a comment. In D135472#3856596 , @vsapsai wrote: > Given all the discussion about which attributes should be added to ODR hash, > I think it is useful at this point to have TableGen infrastructure to get > this information from Attr.t

[clang] 06da9b9 - [OpenMP] Extend the lit test for uses_allocators in target region

Author: Animesh Kumar Date: 2022-10-14T19:12:33+05:30 New Revision: 06da9b94ae374f81a0898b01608c1c3529dfa29a URL: https://github.com/llvm/llvm-project/commit/06da9b94ae374f81a0898b01608c1c3529dfa29a DIFF: https://github.com/llvm/llvm-project/commit/06da9b94ae374f81a0898b01608c1c3529dfa29a.diff

[PATCH] D132855: [OpenMP] Extend the lit test for uses_allocators in target region

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG06da9b94ae37: [OpenMP] Extend the lit test for uses_allocators in target region (authored by animeshk-amd). Repository: rG LLVM Github Monorepo C

[PATCH] D135834: [PowerPC] Fix parameters for __builtin_crypto_vsbox

amyk accepted this revision as: amyk. amyk added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135834/new/ https://reviews.llvm.org/D135834 _

[clang] 3a31970 - [C2x] Implement support for nullptr and nullptr_t

Author: Aaron Ballman Date: 2022-10-14T10:06:02-04:00 New Revision: 3a31970ee2af24ffcfd4b6fc11ac9bdf4d4ef2e8 URL: https://github.com/llvm/llvm-project/commit/3a31970ee2af24ffcfd4b6fc11ac9bdf4d4ef2e8 DIFF: https://github.com/llvm/llvm-project/commit/3a31970ee2af24ffcfd4b6fc11ac9bdf4d4ef2e8.diff

[PATCH] D135099: [C2x] Implement support for nullptr and nullptr_t

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a31970ee2af: [C2x] Implement support for nullptr and nullptr_t (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D101526: [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg constraints

martong updated this revision to Diff 467772. martong marked 3 inline comments as done. martong added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101526/new/ https://reviews.llvm.org/D101526 Files: clang/lib/StaticAnalyzer/

[PATCH] D101526: [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg constraints

martong updated this revision to Diff 467773. martong added a comment. - Changed to be more verbose: "arg" -> "argument" - Fixed "less than" to "greater than" - Added new tests - Fixed typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101526/new/

[PATCH] D101526: [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg constraints

martong added a comment. In D101526#3804623 , @NoQ wrote: > Hi, looks great! I found a couple of typos and the amount of changes in tests > is suspiciously low. And I want to make sure that the promise to change "arg" > -> "argument" isn't lost (but I'l

[clang] 6ce8727 - [cmake] Remove LLVM_INCLUDE_GO_TESTS variable

Author: Nikita Popov Date: 2022-10-14T16:34:36+02:00 New Revision: 6ce87272487711c9f0ff408a037f5ca2e1ff5c5d URL: https://github.com/llvm/llvm-project/commit/6ce87272487711c9f0ff408a037f5ca2e1ff5c5d DIFF: https://github.com/llvm/llvm-project/commit/6ce87272487711c9f0ff408a037f5ca2e1ff5c5d.diff

[PATCH] D135919: [Clang] Set thread_local Itanium ABI guard variables before calling constructors.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135919/new/ https://reviews.llvm.org/D135919

[PATCH] D135690: [ASTMatchers] Add matcher for functions that are effectively inline

aaron.ballman added a comment. In D135690#3856863 , @Trass3r wrote: > In D135690#3852362 , @aaron.ballman > wrote: > >> what's the need for adding this matcher? Do you plan to use it for some >> in-tree needs? W

[clang] 84a9ec2 - Remove redundant option -menable-unsafe-fp-math.

Author: Zahira Ammarguellat Date: 2022-10-14T10:55:29-04:00 New Revision: 84a9ec2ff1ee97fd7e8ed988f5e7b197aab84a7b URL: https://github.com/llvm/llvm-project/commit/84a9ec2ff1ee97fd7e8ed988f5e7b197aab84a7b DIFF: https://github.com/llvm/llvm-project/commit/84a9ec2ff1ee97fd7e8ed988f5e7b197aab84a7b

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. zahiraam marked an inline comment as done. Closed by commit rG84a9ec2ff1ee: Remove redundant option -menable-unsafe-fp-math. (authored by zahiraam). Repository: rG L

[PATCH] D131944: [analyzer] Remove pattern matching of lambda capture initializers

steakhal added inline comments. Comment at: clang/test/Analysis/lambdas.cpp:226 + [uniquePtr = MakeUniquePtr()] {}(); + clang_analyzer_warnIfReached(); // expected-warning{{TRUE}} +} It should have said `REACHABLE`. How does this pass? @isuckatcs Repository:

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

aaron.ballman added subscribers: rjmccall, echristo, dblaikie, rsmith. aaron.ballman added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ re

[clang] 30b67c6 - [AArch64] Make ACLE intrinsics always available part1

Author: Daniel Kiss Date: 2022-10-14T17:23:11+02:00 New Revision: 30b67c677c6baf0d6ef6c3051cf270133c43e4d2 URL: https://github.com/llvm/llvm-project/commit/30b67c677c6baf0d6ef6c3051cf270133c43e4d2 DIFF: https://github.com/llvm/llvm-project/commit/30b67c677c6baf0d6ef6c3051cf270133c43e4d2.diff L

  1   2   3   >