[PATCH] D134339: [clang][llvm] generate accessibility metadata for type aliases

J-Camilleri updated this revision to Diff 462092. J-Camilleri added a comment. Addressing reviewer comments: Comply to offical style, Simplify test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134339/new/ https://reviews.llvm.org/D134339 Fi

[PATCH] D134339: [clang][llvm] generate accessibility metadata for type aliases

J-Camilleri marked 3 inline comments as done. J-Camilleri added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-access.cpp:23-27 + + // CHECK-DAG: !DIDerivedType(tag: DW_TAG_typedef, name: "pub_typedef",{{.*}} line: [[@LINE+1]],{{.*}} flags: DIFlagPublic) + typed

[PATCH] D134362: [clang] Fix interaction between asm labels and inline builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4420402927e: [clang] Fix interaction between asm labels and inline builtins (authored by serge-sans-paille). Changed prior to commit: https://rev

[clang] d442040 - [clang] Fix interaction between asm labels and inline builtins

Author: serge-sans-paille Date: 2022-09-22T09:24:47+02:00 New Revision: d4420402927eed63d21eab5f71f5dbdaf6244a66 URL: https://github.com/llvm/llvm-project/commit/d4420402927eed63d21eab5f71f5dbdaf6244a66 DIFF: https://github.com/llvm/llvm-project/commit/d4420402927eed63d21eab5f71f5dbdaf6244a66.d

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

dmgreen added a comment. Thanks. Should RNG be added? And Why is Crypto no longer enabled? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134352/new/ https://reviews.llvm.org/D134352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D133711: [Sema] Reject array element types whose sizes aren't a multiple of their alignments

DavidSpickett added a comment. This has caused 2 test suite failures across our bots, for example: https://lab.llvm.org/buildbot/#/builders/174/builds/13518 `GCC-C-execute-pr36093.test` / `GCC-C-execute-pr43783.test` Pretty likely the tests are doing something strange, I will look into it. Re

[PATCH] D134416: Allow getting template args for ClassTemplateSpecializations

anderslanglands created this revision. Herald added a project: All. anderslanglands requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Modifies clang_Cursor_getNumTemplateArguments() and friends to work on Struct, Class and ClassTemplateParti

[PATCH] D134416: Allow getting template args for ClassTemplateSpecializations

anderslanglands added reviewers: tbaeder, aaron.ballman. anderslanglands added a comment. Hello again, this generalizes the template argument functionality to operate on cursor kinds other than functions. I could use some help creating a test for this. On my previous path I was able to just cop

[PATCH] D134416: Allow getting template args for ClassTemplateSpecializations

anderslanglands updated this revision to Diff 462103. anderslanglands added a comment. Herald added a subscriber: arphaman. Updating doc comments to reflect new functionality Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134416/new/ https://reviews

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

dmgreen added a comment. Oh, A release note would be good to add too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134352/new/ https://reviews.llvm.org/D134352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D133711: [Sema] Reject array element types whose sizes aren't a multiple of their alignments

DavidSpickett added a comment. GCC also rejects those tests so https://reviews.llvm.org/D134417 to disable them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133711/new/ https://reviews.llvm.org/D133711 __

[PATCH] D130460: [pseudo] Add recovery for declarations

hokein updated this revision to Diff 462107. hokein added a comment. - rebase, fixed a few conflicts - address comments - fix some bugs - restructure the code, moving the implementation to a separate file - add unittests for recoveryNextDeclaration - keep the left-recursive declaration-seq grammar

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang updated this revision to Diff 462113. tingwang added a comment. Add TODO comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18/new/ https://reviews.llvm.org/D18 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/P

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang added a comment. In D18#3786406 , @nemanjai wrote: > I am not crazy about adding the Boolean parameter here or about the name. > Seems somewhat unclear when a caller wants to pass `true` there. > > What I think would be a more robust solutio

[PATCH] D134303: [AST] Preserve more structure in UsingEnumDecl node.

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:4866 auto ToUsingLoc = importChecked(Err, D->getUsingLoc()); - auto ToEnumLoc = importChecked(Err, D->getEnumLoc()); + auto ToEnumLoc = importChecked(Err, D->getEnumType()); auto ToEnumDecl = importC

[PATCH] D130460: [pseudo] Add recovery for declarations

hokein added a comment. I think the current version should be good to review, some bits need to take care of: - left-recursive vs right-recursive of declaration-seq rule, see my other comments about it. Currently I keep it as-is to avoid the performance regression on large files (I still don't

[clang-tools-extra] 983cb53 - [pseudo] NFC, Remove an extral blank line.

Author: Haojian Wu Date: 2022-09-22T11:07:25+02:00 New Revision: 983cb53845efde4b2a142a3e520ebe30c6673515 URL: https://github.com/llvm/llvm-project/commit/983cb53845efde4b2a142a3e520ebe30c6673515 DIFF: https://github.com/llvm/llvm-project/commit/983cb53845efde4b2a142a3e520ebe30c6673515.diff LO

[PATCH] D134379: [clangd] IncludeCleaner: handle using namespace

kadircet added a comment. In D134379#3807770 , @ArcsinX wrote: > Anyway if this is the only concern, we can handle namespace declaration as a > special case inside `ReferencedLocationCrawler::add()`. something like this: > > diff > -for (const De

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson added a comment. Thanks everyone! So if no one else has comments I'm planning to merge this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D133659 _

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

david-arm updated this revision to Diff 462124. david-arm added a comment. - Added FEAT_RNG to the neoverse-v2 CPU. - Added message to release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134352/new/ https://reviews.llvm.org/D134352 Files: clang/docs/ReleaseNotes.rst clang/

[clang] 677da09 - AArch64: add support for newer Apple CPUs

Author: Tim Northover Date: 2022-09-22T11:58:51+01:00 New Revision: 677da09d0259d7530d32e85cb561bee15f0066e2 URL: https://github.com/llvm/llvm-project/commit/677da09d0259d7530d32e85cb561bee15f0066e2 DIFF: https://github.com/llvm/llvm-project/commit/677da09d0259d7530d32e85cb561bee15f0066e2.diff

[PATCH] D134351: AArch64: add definitions for recent Apple CPUs

t.p.northover closed this revision. t.p.northover added a comment. Thanks, committed as 677da09d0259 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134351/new/ https://reviews.llvm.org/D134351 __

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

david-arm added a comment. In D134352#3806896 , @tschuett wrote: > `VScaleForTuning` is 1 for N2 and V2. It is 2 for V1. I though the V2 is more > like the V1 than the N2? > Sorry. This is throughput right? Hi @tschuett, Neoverse V2 will have 128-bit SV

[PATCH] D134425: Create a AllocLikeOpInterface and make memref::AllocLikeOp and gpu::AllocOp implement it.

arnab-oss created this revision. Herald added subscribers: zero9178, bzcheeseman, ThomasRaoux, sdasgup3, wenzhicui, wrengr, cota, mravishankar, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rridd

[PATCH] D121599: [AST] Better recovery on an expression refers to an invalid decl.

hokein updated this revision to Diff 462131. hokein marked 3 inline comments as done. hokein added a comment. rebase and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121599/new/ https://reviews.llvm.org/D121599 Files: clang/li

[PATCH] D121599: [AST] Better recovery on an expression refers to an invalid decl.

hokein added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:1230 LookupResult Result(*this, Name, NameLoc, LookupOrdinaryName); return BuildDeclarationNameExpr(SS, Result, /*ADL=*/true); } sammccall wrote: > wonder if if the results of setting Ac

[PATCH] D134425: Create a AllocLikeOpInterface and make memref::AllocLikeOp and gpu::AllocOp implement it.

arnab-oss updated this revision to Diff 462132. arnab-oss added a comment. Herald added a subscriber: csigg. Herald added a reviewer: herhut. Herald added a reviewer: ThomasRaoux. Make gpu.alloc op implement AllocLikeOpInterface Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115169: Create a generic ABI document for _BitInt

aaron.ballman added a comment. In D115169#3805964 , @gustedt wrote: > It seems that this has already shipped on some platforms. Since this > basically binds others to use the same ABI, it would perhaps be nice if the > document could have a table that l

[PATCH] D115169: Create a generic ABI document for _BitInt

gustedt added a comment. >> Also discussing consequences for `va_arg` functions such as `printf` would >> be nice. > > Does the information in the `Passing and Returning an Object` section > suffice, or are there more details you're looking for there? Ah, sorry must have overlooked this. Thanks

[PATCH] D134425: Create a AllocLikeOpInterface and make memref::AllocLikeOp and gpu::AllocOp implement it.

arnab-oss updated this revision to Diff 462137. arnab-oss added a comment. Refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134425/new/ https://reviews.llvm.org/D134425 Files: clang/docs/tools/clang-formatted-files.txt mlir/include/ml

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:81-83 +auto *GV = Const.first; +Const.second = EltTys.size(); +auto *Ty = GV->getValueType(); Please spell out these types. Comment at: clang/lib/C

[PATCH] D134157: [LoongArch] Add inline asm support for constraints f/l/I/K

SixWeining updated this revision to Diff 462139. SixWeining added a comment. Use double dashes for --mtriple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134157/new/ https://reviews.llvm.org/D134157 Files: clang/lib/Basic/Targets/LoongArch.cpp

[PATCH] D133108: [clang] Rework IsTailPaddedMemberArray into isFlexibleArrayMemberExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rGdad36245a5c2: [clang] Rework IsTailPaddedMemberArray into isFlexibleArrayMemberExpr (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D133108?vs=460899&id=462140#toc Re

[clang] dad3624 - [clang] Rework IsTailPaddedMemberArray into isFlexibleArrayMemberExpr

Author: serge-sans-paille Date: 2022-09-22T14:04:35+02:00 New Revision: dad36245a5c2e3779b4eede6fcbbddad19a2f01d URL: https://github.com/llvm/llvm-project/commit/dad36245a5c2e3779b4eede6fcbbddad19a2f01d DIFF: https://github.com/llvm/llvm-project/commit/dad36245a5c2e3779b4eede6fcbbddad19a2f01d.d

[PATCH] D134157: [LoongArch] Add inline asm support for constraints f/l/I/K

SixWeining added a comment. In D134157#3805855 , @xen0n wrote: > I don't know if the clang changes should be split into its own commit (or the > title of this commit amended to mention `[Clang]` but I don't know if this is > appropriate), but the rest l

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

aaron.ballman added a comment. In D133983#3807284 , @python3kgae wrote: > In D133983#3805761 , @aaron.ballman > wrote: > >> There are no tests for applying this to a global variable, so those should >> be added

[clang] e0cdafe - [AST] Better recovery on an expression refers to an invalid decl.

Author: Haojian Wu Date: 2022-09-22T14:23:47+02:00 New Revision: e0cdafe8d4b2f1585f4756447b677fec37954ec4 URL: https://github.com/llvm/llvm-project/commit/e0cdafe8d4b2f1585f4756447b677fec37954ec4 DIFF: https://github.com/llvm/llvm-project/commit/e0cdafe8d4b2f1585f4756447b677fec37954ec4.diff LO

[PATCH] D121599: [AST] Better recovery on an expression refers to an invalid decl.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe0cdafe8d4b2: [AST] Better recovery on an expression refers to an invalid decl. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121599/ne

[PATCH] D134432: [clang][dataflow] Add support for nested method calls.

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Extend the context-sensitive analysis to hand

[PATCH] D134432: [clang][dataflow] Add support for nested method calls.

ymandel updated this revision to Diff 462153. ymandel added a comment. formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134432/new/ https://reviews.llvm.org/D134432 Files: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp clang/

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

aaron.ballman added subscribers: hans, majnemer, rnk. aaron.ballman added a comment. In D131465#3806709 , @MaskRay wrote: > In D131465#3804893 , @glandium > wrote: > >> This didn't change the default for msvc tar

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3807707 , @wlei wrote: > Tested this and confirmed the issue I reported is gone, thanks! Thank you all for the quick responses! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126907/new/ https://reviews.ll

[PATCH] D134394: Update docs about [[likely]] vs. PGO

serge-sans-paille added a comment. While running this small experiment: https://sergesanspaille.fedorapeople.org/proftest.sh I get the following output: clang version 16.0.0 (...) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: ... - instrumentation + likely: pu

[PATCH] D134394: Update docs about [[likely]] vs. PGO

aaron.ballman added a comment. In D134394#3808397 , @serge-sans-paille wrote: > While running this small experiment: > https://sergesanspaille.fedorapeople.org/proftest.sh Thank you for the help with testing the assumptions here! Repository: rG LLV

[PATCH] D115169: Create a generic ABI document for _BitInt

gustedt added a comment. >> Also discussing consequences for `va_arg` functions such as `printf` would >> be nice. > > Does the information in the `Passing and Returning an Object` section > suffice, or are there more details you're looking for there? The narrow `_BitInt` types are not promoted

[PATCH] D134157: [Clang][LoongArch] Add inline asm support for constraints f/l/I/K

rengolin added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:1958 + // constraints while the official register name is prefixed with a '$'. + // So we manually select general purpose registers here. + // For now, no need to support ABI names

[PATCH] D108211: Emit sizeof/alignof values as notes when a static_assert fails

arichardson abandoned this revision. arichardson added a comment. Would require significant work to still be useful now that we print the value of expressions (e.g. only print for more complex expressions). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D108212: Emit offsetof values as notes when a static_assert fails

arichardson abandoned this revision. arichardson added a comment. Herald added a project: All. No longer needed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108212/new/ https://reviews.llvm.org/D108212

[clang] cf77333 - [clang][docs] Fix supported element types for __builtin_reduce_(add|mul)

Author: Joe Loser Date: 2022-09-22T07:52:22-06:00 New Revision: cf77333da986720e9aded4301d81a581e2be9611 URL: https://github.com/llvm/llvm-project/commit/cf77333da986720e9aded4301d81a581e2be9611 DIFF: https://github.com/llvm/llvm-project/commit/cf77333da986720e9aded4301d81a581e2be9611.diff LOG

[PATCH] D134316: [clang][docs] Fix supported element types for `__builtin_reduce_(add|mul)`

jloser closed this revision. jloser added a comment. This landed with https://github.com/llvm/llvm-project/commit/cf77333da986720e9aded4301d81a581e2be9611. The revision didn't auto-close for some reason. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D133659: [Clang] P1169R4: static operator()

aaron.ballman added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin, lichray. aaron.ballman added a comment. In D133659#3808095 , @royjacobson wrote: > Thanks everyone! So if no one else has comments I'm planning to merge this > tomorrow. FWIW,

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1037-1041 +def err_static_mutable_lambda : Error< + "lambda cannot be both mutable and static">; +def err_static_lambda_captures : Error< + "a static lambda cannot have any captures

[PATCH] D134316: [clang][docs] Fix supported element types for `__builtin_reduce_(add|mul)`

fhahn added a comment. In D134316#3808544 , @jloser wrote: > This landed with > https://github.com/llvm/llvm-project/commit/cf77333da986720e9aded4301d81a581e2be9611. > The revision didn't auto-close for some reason. You need to make sure the commit me

[PATCH] D133659: [Clang] P1169R4: static operator()

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1037-1041 +def err_static_mutable_lambda : Error< + "lambda cannot be both mutable and static">; +def err_static_lambda_captures : Error< + "a static lambda cannot have any captur

[PATCH] D134441: [ObjC][ARC] Don't use operand bundle "clang.arc.attachedcall" in codegen for Windows

sgraenitz created this revision. sgraenitz added reviewers: ahatanak, rjmccall, theraven, rnk. Herald added a subscriber: pengfei. Herald added a project: All. sgraenitz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is an attem

[PATCH] D134441: [ObjC][ARC] Don't use operand bundle "clang.arc.attachedcall" in codegen for Windows

sgraenitz added a comment. I assume is that this can only be a temporary fix as it probably has an impact on performance of compiled output. I am eager to fix this properly. The FIXME comment says that we need specific support in the target backend. Any ideas what the x86_64 backend for Windows

[PATCH] D134441: [ObjC][ARC] Don't use operand bundle "clang.arc.attachedcall" in codegen for Windows

sgraenitz added a comment. Bisectioning showed that the regression started with this patch: https://reviews.llvm.org/D111331 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134441/new/ https://reviews.llvm.org/D134441 __

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1037-1041 +def err_static_mutable_lambda : Error< + "lambda cannot be both mutable and static">; +def err_static_lambda_captures : Error< + "a static lambda cannot have any captures

[PATCH] D134441: [ObjC][ARC] Don't use operand bundle "clang.arc.attachedcall" in codegen for Windows

sgraenitz added a comment. The symptom is that Clang emits `movq %rax, %rdi` instead of `movq %rax, %rcx` while `objc_retainAutoreleasedReturnValue()` still expects the value in `%rcx`. It appears related to D94597 . Is this a calling convention issue? Reposito

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

RIscRIpt added a comment. In D133853#3799344 , @aaron.ballman wrote: > It's a conforming extension in older language modes like C++98, where we > couldn't steal the `constexpr` keyword because it's not reserved, which is > one benefit to it. Does MSVC

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

aaron.ballman added a comment. In D133853#3808669 , @RIscRIpt wrote: > In D133853#3799344 , @aaron.ballman > wrote: > >> It's a conforming extension in older language modes like C++98, where we >> couldn't steal

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added subscribers: joanahalili, alexfh. mizvekov added a comment. FYI, I fixed all known points made, I think this review can progress. Another thing, which I noticed only after we improved and merged D128113 , is that it does have an impact similar to

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

jmciver created this revision. Herald added subscribers: mattd, asavonic, jdoerfert, pengfei. Herald added a project: All. jmciver retitled this revision from "[clang][CodeGen] Add noundef metadata to scalar load instructions" to "[clang][CodeGen] Add noundef metadata to scalar load instructions

[PATCH] D134445: [PR57881][OpenCL] Fix incorrect diagnostics with templated types in kernel arguments

Anastasia created this revision. Anastasia added reviewers: svenvh, olestrohm, rjmccall. Herald added subscribers: Naghasan, ebevhan, yaxunl. Herald added a project: All. Anastasia requested review of this revision. It seems relying on `isStandardLayoutType` helpers is fragile when kernel argumen

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo added a comment. In D131469#3798409 , @Maetveis wrote: > As discussed with @jamieschmeiser on D133662 > , I have left suggestions regarding the > approach I took for handling `-o` and passing the option to th

[PATCH] D133659: [Clang] P1169R4: static operator()

aaron.ballman added a reviewer: hubert.reinterpretcast. aaron.ballman added a subscriber: hubert.reinterpretcast. aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1037-1041 +def err_static_mutable_lambda : Error< + "lambda cannot

[PATCH] D134445: [PR57881][OpenCL] Fix incorrect diagnostics with templated types in kernel arguments

Anastasia added inline comments. Comment at: clang/test/SemaOpenCLCXX/invalid-kernel.clcpp:110 + +// FIXME: Use of templates doesn't work due to lazy instantiation of reference types. +//template I think here should be something like - `the use of templated typ

[PATCH] D133705: [HIP] Fix unbundling archive

yaxunl updated this revision to Diff 462189. yaxunl added a comment. allow archive files to have unknown extension CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133705/new/ https://reviews.llvm.org/D133705 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/CommonArgs.cp

[PATCH] D134441: [ObjC][ARC] Don't use operand bundle "clang.arc.attachedcall" in codegen for Windows

fhahn added a comment. In D134441#3808655 , @sgraenitz wrote: > The symptom is that Clang emits `movq %rax, %rdi` instead of `movq %rax, > %rcx` while `objc_retainAutoreleasedReturnValue()` still expects the value in > `%rcx`. > It appears related to D9

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

shafik added a subscriber: aaron.ballman. shafik added a comment. I made mostly small comments but I think @aaron.ballman and/or @erichkeane should take a look as well. Comment at: clang/lib/Parse/ParseDecl.cpp:3434-3435 &SS) && -

[PATCH] D134416: Allow getting template args for ClassTemplateSpecializations

aaron.ballman added a comment. Mostly nits from me (FWIW, we use `auto` when the type is explicitly spelled out in the initialization and we don't usually use `else` after an unconditional `return` as a matter of coding style.) In terms of the test coverage, I would probably make a new test mod

[PATCH] D134445: [PR57881][OpenCL] Fix incorrect diagnostics with templated types in kernel arguments

svenvh added a comment. > I have attempted to workaround this issue for the reported test cases, > however it still doesn't quite work when the type is created from the > template parameter (see FIXME test case in the patch). I presume we want to > allow this? If so we might need to disable laz

[PATCH] D134339: [clang][llvm] generate accessibility metadata for type aliases

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. I'll commit this shortly. Comment at: llvm/lib/IR/DIBuilder.cpp:351 DIScope *Context, uint32_t AlignInBits, +

[clang] db664a6 - [Doc][OpenCL] Fixed typos in code examples

Author: Anastasia Stulova Date: 2022-09-22T17:46:47+01:00 New Revision: db664a666c2c0cc144c7827dbdad1b893a63408c URL: https://github.com/llvm/llvm-project/commit/db664a666c2c0cc144c7827dbdad1b893a63408c DIFF: https://github.com/llvm/llvm-project/commit/db664a666c2c0cc144c7827dbdad1b893a63408c.d

[PATCH] D134453: Introduce the `AlwaysIncludeTypeForNonTypeTemplateArgument` into printing policy

DoDoENT created this revision. Herald added a project: All. DoDoENT requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If enabled, it will ensure that full type name is always printed. This should fix issue reported here: https://github.com/l

[PATCH] D134453: Introduce the `AlwaysIncludeTypeForNonTypeTemplateArgument` into printing policy

dblaikie added inline comments. Comment at: clang/include/clang/AST/PrettyPrinter.h:307 + /// decltype(s) will be printed as "S" if enabled and as "S<{1,2}>" if disabled, + /// regardless if PrintCanonicalTypes is enabled. + unsigned AlwaysIncludeTypeForNonTypeTemplateArgumen

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

erichkeane added a comment. I think this is on the right track, but would like to see more work done on that fixme before we commit (or at least better understand what is causing this). I'm afraid of what else can get us into that situation besides the export-decl. Comment

[PATCH] D134453: Introduce the `AlwaysIncludeTypeForNonTypeTemplateArgument` into printing policy

DoDoENT added inline comments. Comment at: clang/include/clang/AST/PrettyPrinter.h:307 + /// decltype(s) will be printed as "S" if enabled and as "S<{1,2}>" if disabled, + /// regardless if PrintCanonicalTypes is enabled. + unsigned AlwaysIncludeTypeForNonTypeTemplateArgument

[PATCH] D134454: [Driver][Distro] Fix ArchLinux triplet and sysroot detection

10ne1 created this revision. 10ne1 added reviewers: nickdesaulniers, nathanchance, manojgupta. Herald added a subscriber: kristof.beyls. Herald added a project: All. 10ne1 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. While cross-

[clang] 9018fa1 - Update the C status page for WG14 N2359

Author: Aaron Ballman Date: 2022-09-22T13:05:49-04:00 New Revision: 9018fa174598ab53567ef36b4bd171f47daf14f5 URL: https://github.com/llvm/llvm-project/commit/9018fa174598ab53567ef36b4bd171f47daf14f5 DIFF: https://github.com/llvm/llvm-project/commit/9018fa174598ab53567ef36b4bd171f47daf14f5.diff

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao updated this revision to Diff 46. ayzhao marked 2 inline comments as done. ayzhao added a comment. address some review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847 Files: clang/incl

[PATCH] D134339: [clang][llvm] generate accessibility metadata for type aliases

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08288052aef2: [DebugInfo] Emit access specifiers for typedefs (authored by J-Camilleri, committed by dblaikie). Changed prior to commit: https://r

[clang] 4cd7529 - [clang][DebugInfo] Emit access specifiers for typedefs

Author: Jonathan Camilleri Date: 2022-09-22T17:08:41Z New Revision: 4cd7529e4caa00fa7ba27d9de18adea3c702ad8f URL: https://github.com/llvm/llvm-project/commit/4cd7529e4caa00fa7ba27d9de18adea3c702ad8f DIFF: https://github.com/llvm/llvm-project/commit/4cd7529e4caa00fa7ba27d9de18adea3c702ad8f.diff

[clang-tools-extra] 0ca5993 - [clang-tidy] Add option WarnOnSizeOfPointerToAggregate.

Author: Michael Benfield Date: 2022-09-22T17:09:43Z New Revision: 0ca5993741877ab7fd27a251cbc1895bd092d5ee URL: https://github.com/llvm/llvm-project/commit/0ca5993741877ab7fd27a251cbc1895bd092d5ee DIFF: https://github.com/llvm/llvm-project/commit/0ca5993741877ab7fd27a251cbc1895bd092d5ee.diff L

[PATCH] D134381: [clang-tidy] Add option WarnOnSizeOfPointerToAggregate.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0ca599374187: [clang-tidy] Add option WarnOnSizeOfPointerToAggregate. (authored by mbenfield). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

h-vetinari added a comment. > Now I'm wondering why the attribute exists at all. If it's functionally > equivalent to `constexpr` as a keyword, what are the use cases for the > attribute? I'm guessing something to do with ABI-compatibility with artefacts produced by their older compilers (thou

[PATCH] D134454: [Driver][Distro] Fix ArchLinux triplet and sysroot detection

manojgupta added a comment. Thanks for the patch. Can you please post a full diff (git diff -U). Adding @MaskRay as a reviewer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134454/new/ https://reviews.llvm.org/D134454 ___

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

AntonBikineev created this revision. AntonBikineev added a reviewer: hans. Herald added a subscriber: wenlei. Herald added a project: All. AntonBikineev requested review of this revision. Herald added a project: clang. Generally, with PGO enabled the C++20 likelyhood attributes shall be dropped as

[PATCH] D134457: Document WarnOnSizeOfPointerToAggregate.

mbenfield created this revision. mbenfield added a reviewer: mizvekov. Herald added a project: All. mbenfield requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This option was just landed in D134381

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

akhuang updated this revision to Diff 462230. akhuang marked an inline comment as done. akhuang added a comment. Fix flag name in test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133959/new/ https://reviews.llvm.org/D133959 Files: clang/i

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

aaron.ballman added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2343 + static ImplicitTypenameContext + isImplicitTypenameContext(DeclSpecContext DSC) { +switch (DSC) { Starting with `is` implies contextual conversion to bool (generally)

[PATCH] D134458: [AST] Add msvc-specific C++11 attribute 'msvc::no_unique_address'

RIscRIpt created this revision. Herald added a reviewer: aaron.ballman. Herald added a project: All. RIscRIpt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D134458 Files:

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

RIscRIpt added a comment. I am new to `arc`, I tried `arc diff --edit --verbatim` as it's said in the docs, but it still created a new revision: https://reviews.llvm.org/D134458 Comment at: clang/lib/Sema/SemaStmtAttr.cpp:296 + // Validation is in Sema::ActOnAttributedStmt().

[PATCH] D134458: [AST] Add msvc-specific C++11 attributes

RIscRIpt updated this revision to Diff 462234. RIscRIpt retitled this revision from "[AST] Add msvc-specific C++11 attribute 'msvc::no_unique_address'" to "[AST] Add msvc-specific C++11 attributes". RIscRIpt edited the summary of this revision. RIscRIpt added a comment. Add msvc::constexpr commit

[clang-tools-extra] 33bc9c3 - Document WarnOnSizeOfPointerToAggregate.

Author: Michael Benfield Date: 2022-09-22T17:38:04Z New Revision: 33bc9c3bf2e09f15ea7be7bc090492fad8226b34 URL: https://github.com/llvm/llvm-project/commit/33bc9c3bf2e09f15ea7be7bc090492fad8226b34 DIFF: https://github.com/llvm/llvm-project/commit/33bc9c3bf2e09f15ea7be7bc090492fad8226b34.diff L

[PATCH] D134457: Document WarnOnSizeOfPointerToAggregate.

This revision was automatically updated to reflect the committed changes. Closed by commit rG33bc9c3bf2e0: Document WarnOnSizeOfPointerToAggregate. (authored by mbenfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134457/new/ https://reviews.ll

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

hans added reviewers: Mordante, aaron.ballman. hans added a comment. Looks reasonable to me. +the folks from D85091 fyi or if they want to take a look. Comment at: clang/test/Profile/cxx-never-executed-branch.cpp:1 +// Test the clang doesn't

[PATCH] D134394: Update docs about [[likely]] vs. PGO

hans added a comment. See also D134456 which affects the behavior here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134394/new/ https://reviews.llvm.org/D134394 ___

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

erichkeane added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:5592 +bool Parser::isConstructorDeclarator(bool IsUnqualified, bool DeductionGuide, + bool IsFriend) { TentativeParsingAction TPA(*this); aaron.ball

[PATCH] D134453: Introduce the `AlwaysIncludeTypeForNonTypeTemplateArgument` into printing policy

dblaikie added a subscriber: aaron.ballman. dblaikie added inline comments. Comment at: clang/include/clang/AST/PrettyPrinter.h:307 + /// decltype(s) will be printed as "S" if enabled and as "S<{1,2}>" if disabled, + /// regardless if PrintCanonicalTypes is enabled. + unsigne

  1   2   3   >