mizvekov added subscribers: joanahalili, alexfh. mizvekov added a comment. FYI, I fixed all known points made, I think this review can progress.
Another thing, which I noticed only after we improved and merged D128113 <https://reviews.llvm.org/D128113>, is that it does have an impact similar to what D128113 <https://reviews.llvm.org/D128113> had before we inverted the indexing order. Specifically regarding the repro contained in this comment: https://reviews.llvm.org/D128113#3742779 On more real-world like code such as the tests in llvm-compile-time-tracker, there is no discernible impact from this patch: http://llvm-compile-time-tracker.com/compare.php?from=a5a9b896fe0645f1060b33b19693786146f83375&to=f2e03cd6d07901c4848242368a0b0c29c88331f6&stat=instructions Both @alexfh and @joanahalili first reported this problem on D128113 <https://reviews.llvm.org/D128113>, although it seems they managed to refactor the original code so it would not be a problem anymore for them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/ https://reviews.llvm.org/D131858 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
