[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

ye-luo added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ doru1004 wrote: > ye-luo wrote: > > doru1004 wrote: > > > ye-luo wrote: > > > > doru10

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

mwyman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2251-2256 +def ObjCDirectVisible : Attr { + let Spellings = [Clang<"objc_direct_visible">]; + let Subjects = SubjectList<[ObjCMethod], ErrorDiag>; + let LangOpts = [ObjC]; + let Documentation = [ObjCD

[PATCH] D133732: [clang-doc] Support default args for functions.

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Adds support for default arguments in the internal representation and reads t

[PATCH] D133266: [MinGW] Reject explicit hidden visibility applied to dllexport and hidden/protected applied to dllimport

bd1976llvm added a comment. In D133266#3776164 , @MaskRay wrote: > In D133266#3776051 , @bd1976llvm > wrote: > >> In D133266#3775832 , @MaskRay >> wrote: >> >>> In D1332

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

JonChesterfield added a comment. We can do this but should expect an increase in code size from having multiple internalised copies of the same function. There may be an incidental benefit if we can specialise some functions to the call site without additional cloning. Address of the same funct

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.h:58 + llvm::SmallVector + getHIPDeviceLibs(const llvm::opt::ArgList &Args) const override; + Why hip device libs? There's a common set, plus a hip.bc plus a opencl.bc.

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.h:58 + llvm::SmallVector + getHIPDeviceLibs(const llvm::opt::ArgList &Args) const override; + JonChesterfield wrote: > Why hip device libs? There's a common set, plus a hip.bc p

[PATCH] D133266: [MinGW] Reject explicit hidden visibility applied to dllexport and hidden/protected applied to dllimport

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1116 +if (GV->hasDLLExportStorageClass()) { + // Reject explicit hidden visibility on dllexport. + if (LV.getVisibility() == HiddenVisibility) --

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

akhuang updated this revision to Diff 459577. akhuang marked 2 inline comments as done. akhuang added a comment. Clean up test, add doc brief to new flag, try to put the flag logic in a separate function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

akhuang added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6480 + // Process Windows runtime flags (equivalent to cl flags /MD, /MDd, /MT, /MTd) + if (Triple.isOSWindows()) { hans wrote: > Could we somehow re-use the logic in Clang::Add

[PATCH] D133266: [MinGW] Reject explicit hidden visibility applied to dllexport and hidden/protected applied to dllimport

This revision was automatically updated to reflect the committed changes. MaskRay marked an inline comment as done. Closed by commit rG6f9c4851ab7c: [MinGW] Reject explicit hidden visibility applied to dllexport and… (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D1332

[clang] 6f9c485 - [MinGW] Reject explicit hidden visibility applied to dllexport and hidden/protected applied to dllimport

Author: Fangrui Song Date: 2022-09-12T15:56:36-07:00 New Revision: 6f9c4851ab7c729812bc8f48b19de3f84a64f6f0 URL: https://github.com/llvm/llvm-project/commit/6f9c4851ab7c729812bc8f48b19de3f84a64f6f0 DIFF: https://github.com/llvm/llvm-project/commit/6f9c4851ab7c729812bc8f48b19de3f84a64f6f0.diff

[PATCH] D133737: [HLSL] [clang] Add vector version of abs for HLSL

python3kgae created this revision. python3kgae added reviewers: beanz, pow2clk, bogner, fhahn, RKSimon. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add vecto

[PATCH] D132991: [Clang] Give error message for invalid profile path when compiling IR

aidengrossman added a comment. @xur Gentle reminder. Just want to make sure I'm not missing anything obvious since I've made some somewhat substantial changes since your sign off. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132991/new/ https://r

[clang-tools-extra] 651ceb1 - [test][clangd] Another try to fix bots after 72142fbac4

Author: Vitaly Buka Date: 2022-09-12T16:14:07-07:00 New Revision: 651ceb1ee7a257225bed1dc78693ff99fae9e571 URL: https://github.com/llvm/llvm-project/commit/651ceb1ee7a257225bed1dc78693ff99fae9e571 DIFF: https://github.com/llvm/llvm-project/commit/651ceb1ee7a257225bed1dc78693ff99fae9e571.diff L

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

jhuber6 added a comment. In D133726#3785040 , @JonChesterfield wrote: > We can do this but should expect an increase in code size from having > multiple internalised copies of the same function. There may be an incidental > benefit if we can specialise

[PATCH] D132975: [CMake] Add clang-bolt target

Amir updated this revision to Diff 459588. Amir added a comment. Add an ability to pass extra cmake flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975 Files: clang/CMakeLists.txt clang/cmake/caches

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

Amir updated this revision to Diff 459589. Amir added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133633/new/ https://reviews.llvm.org/D133633 Files: clang/CMakeLists.txt clang/cmake/modules/ClangBootstrap.cmake Index: cla

[PATCH] D132975: [CMake] Add clang-bolt target

Amir marked an inline comment as done. Amir added inline comments. Comment at: clang/CMakeLists.txt:930-937 +-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX} +-DCMAKE_C_COMPILER=${CLANG_INSTRUMENTED} +-DCMAKE_CXX_COMPILER=${CLANGXX_IN

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

doru1004 added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ ye-luo wrote: > doru1004 wrote: > > ye-luo wrote: > > > doru1004 wrote: > > > > ye-l

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

ye-luo added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ doru1004 wrote: > doru1004 wrote: > > ye-luo wrote: > > > doru1004 wrote: > > > > ye-l

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

alexfh added a comment. In D111283#3783627 , @alexfh wrote: > Hi Matheus, an early heads up: this commit is causing clang crashes on some > of our code. I'll post more details a bit later. The stack trace of the failure looks like this: #0 0x564

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

alexfh added a comment. In D111283#3785240 , @alexfh wrote: > In D111283#3783627 , @alexfh wrote: > >> Hi Matheus, an early heads up: this commit is causing clang crashes on some >> of our code. I'll post more de

[PATCH] D133659: [Clang] P1169R4: static operator()

shafik added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:15934 + // or a reference to an enumeration. + // Note: Before C++23, a member function also has to not be static. if (CXXMethodDecl *MethodDecl = dyn_cast(FnDecl)) { =

[PATCH] D133741: [IR] Add alignment for llvm.threadlocal.address

alexander-shaposhnikov created this revision. alexander-shaposhnikov added reviewers: ChuanqiXu, nikic, aeubanks. alexander-shaposhnikov created this object with visibility "All Users". Herald added a subscriber: hiraditya. Herald added a project: All. alexander-shaposhnikov requested review of thi

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 459617. VincentWu edited the summary of this revision. VincentWu added a reviewer: asb. VincentWu added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.ll

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 459620. VincentWu added a comment. add newline at end of file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Files: clang/test/Preprocessor/riscv-target-features

[PATCH] D133341: [C++] [Coroutines] Prefer aligned (de)allocation for coroutines - implement the option2 of P2014R0

ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. @ychen @rjmccall ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133341/new/ https://reviews.llvm.org/D133341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D132352: Introduce noread_thread_id to address the thread identification problem in coroutines

ChuanqiXu added a comment. @nhaehnle @jyknight @nikic @efriedma @fhahn ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132352/new/ https://reviews.llvm.org/D132352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

dreachem added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ ye-luo wrote: > doru1004 wrote: > > doru1004 wrote: > > > ye-luo wrote: > > > > doru

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc updated this revision to Diff 459633. inclyc added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133574/new/ https://reviews.llvm.org/D133574 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagn

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc updated this revision to Diff 459634. inclyc added a comment. git-clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133574/new/ https://reviews.llvm.org/D133574 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagn

[PATCH] D133705: [HIP] Fix unbundling archive

yaxunl added a comment. In D133705#3784605 , @tra wrote: >> Archives passed by -l: should not be prefixed with >> prefix lib and appended with '.a', but still need to be prefixed with >> paths in -L options. >> Archives passed as input files should not

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

ye-luo added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ dreachem wrote: > ye-luo wrote: > > doru1004 wrote: > > > doru1004 wrote: > > > > ye-l

[PATCH] D133648: Clang, increase upper bound of partially initialized array sizes

OfekShochat updated this revision to Diff 459642. OfekShochat added a comment. Clang, increase upper bound of partially initialized array sizes fixes issue with emitting partially initialized constant arrays larger than 2^32. issue #57353 on github. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.h:58 + llvm::SmallVector + getHIPDeviceLibs(const llvm::opt::ArgList &Args) const override; + jhuber6 wrote: > JonChesterfield wrote: > > Why hip device libs? There's a

[clang] 79fa0ec - [C++20] [Modules] Make member functions with a in-class definition in HU implicitly inline

Author: Chuanqi Xu Date: 2022-09-13T13:11:56+08:00 New Revision: 79fa0ec8c4bfeeb21f7b44ebd9a66e7ec9781798 URL: https://github.com/llvm/llvm-project/commit/79fa0ec8c4bfeeb21f7b44ebd9a66e7ec9781798 DIFF: https://github.com/llvm/llvm-project/commit/79fa0ec8c4bfeeb21f7b44ebd9a66e7ec9781798.diff LO

[PATCH] D133749: [clang][NFC] Update test case struct-union-BE.c for opaque-pointers

tingwang created this revision. tingwang added reviewers: dsanders, rjmccall, spetrovic, vkalintiris, john.brawn, petarj. tingwang added a project: clang. Herald added a project: All. tingwang requested review of this revision. Herald added a subscriber: cfe-commits. Update patterns in this test

[PATCH] D133589: [clang-format] JSON formatting add new option for controlling newlines in json arrays

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:2190 Matching->is(TT_ArrayInitializerLSquare)) && -!(FormatTok->is(tok::r_brace) && Matching->is(TT_DictLiteral))) { +

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang added a comment. (Inviting reviewers from D21611 to look into the change here.) The expected pattern `test8va()` added in this patch was broken by D21611 . Now as suggested by Ulrich, we are planning to create a flag f

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos marked 10 inline comments as done. pmatos added inline comments. Comment at: clang/include/clang/AST/Type.h:1972-1973 + /// Check if this is a WebAssembly Reference Type. + bool isWebAssemblyReferenceType() const; + bool isWebAssemblyExternrefType() const; /// Determ

[clang] f8643a9 - [analyzer] Prefer wrapping SymbolicRegions by ElementRegions

Author: Balazs Benics Date: 2022-09-13T08:58:46+02:00 New Revision: f8643a9b31c4029942f67d4534c9139b45173504 URL: https://github.com/llvm/llvm-project/commit/f8643a9b31c4029942f67d4534c9139b45173504 DIFF: https://github.com/llvm/llvm-project/commit/f8643a9b31c4029942f67d4534c9139b45173504.diff

[clang] afcd862 - [analyzer] LazyCompoundVals should be always bound as default bindings

Author: Balazs Benics Date: 2022-09-13T08:58:46+02:00 New Revision: afcd862b2e0a561bf03b1e7b83e6eec8e7143098 URL: https://github.com/llvm/llvm-project/commit/afcd862b2e0a561bf03b1e7b83e6eec8e7143098 DIFF: https://github.com/llvm/llvm-project/commit/afcd862b2e0a561bf03b1e7b83e6eec8e7143098.diff

[PATCH] D132142: [analyzer] Prefer wrapping SymbolicRegions by ElementRegions

This revision was automatically updated to reflect the committed changes. steakhal marked 3 inline comments as done. Closed by commit rGf8643a9b31c4: [analyzer] Prefer wrapping SymbolicRegions by ElementRegions (authored by steakhal). Changed prior to commit: https://reviews.llvm.org/D132142?vs

[PATCH] D132143: [analyzer] LazyCompoundVals should be always bound as default bindings

This revision was automatically updated to reflect the committed changes. Closed by commit rGafcd862b2e0a: [analyzer] LazyCompoundVals should be always bound as default bindings (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

<    1   2