akhuang added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6480 + // Process Windows runtime flags (equivalent to cl flags /MD, /MDd, /MT, /MTd) + if (Triple.isOSWindows()) { ---------------- hans wrote: > Could we somehow re-use the logic in Clang::AddClangCLArgs()? Perhaps the > main switch from that could be extracted to a function that could be called > from here? Put it in a separate function; I guess it's a bit messy as some clang-cl flags aren't implemented for clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133457/new/ https://reviews.llvm.org/D133457 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits