[PATCH] D133160: [cmake] Append CLANG_LIBDIR_SUFFIX to scan-build-py installation destination.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133160/new/ https://reviews.llvm.org/D133160 ___

[PATCH] D132810: [clang][MinGW] Add `-mguard=cf` and `-mguard=cf-nochecks`

alvinhochun updated this revision to Diff 457523. alvinhochun added a comment. Applied suggestions. Thanks for the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132810/new/ https://reviews.llvm.org/D132810 Files: clang/docs/ReleaseNotes

[clang] 66f332b - [X86] Add missing key feature for core2

Author: Freddy Ye Date: 2022-09-02T16:06:07+08:00 New Revision: 66f332bc1ac04430580a8498ab5537b392f3ea1e URL: https://github.com/llvm/llvm-project/commit/66f332bc1ac04430580a8498ab5537b392f3ea1e DIFF: https://github.com/llvm/llvm-project/commit/66f332bc1ac04430580a8498ab5537b392f3ea1e.diff LOG

[PATCH] D133094: [X86] Add missing key feature for core2

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66f332bc1ac0: [X86] Add missing key feature for core2 (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D133170: [Driver] Unsupport --print-multiarch

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133170/new/ https://reviews.llvm.org/D133170 ___

[clang] 1334e12 - [cmake] Append CLANG_LIBDIR_SUFFIX to scan-build-py installation destination

Author: Sinan Lin Date: 2022-09-02T16:18:15+08:00 New Revision: 1334e129a39cb427e7b855e9a711a3e7604e50e5 URL: https://github.com/llvm/llvm-project/commit/1334e129a39cb427e7b855e9a711a3e7604e50e5 DIFF: https://github.com/llvm/llvm-project/commit/1334e129a39cb427e7b855e9a711a3e7604e50e5.diff LOG

[PATCH] D133160: [cmake] Append CLANG_LIBDIR_SUFFIX to scan-build-py installation destination.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1334e129a39c: [cmake] Append CLANG_LIBDIR_SUFFIX to scan-build-py installation destination (authored by sinan, committed by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

mstorsjo added a comment. FYI, this change broke Wine (at least on arm and aarch64). Not saying that it is legit breakage of code that actually was UB to begin with though - it's going to take some time to figure out what's broken though. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] 085e8cd - [NFC] Cleanup lookup for coroutine allocation/deallocation

Author: Chuanqi Xu Date: 2022-09-02T17:24:52+08:00 New Revision: 085e8cd8d32c9104abbc2c1345a1483f19d25d36 URL: https://github.com/llvm/llvm-project/commit/085e8cd8d32c9104abbc2c1345a1483f19d25d36 DIFF: https://github.com/llvm/llvm-project/commit/085e8cd8d32c9104abbc2c1345a1483f19d25d36.diff LO

[PATCH] D133191: Driver test: remove `REQUIRES: x86-registered-target` and set `--sysroot=""` to support clang with `DEFAULT_SYSROOT`.

MaggieYi created this revision. MaggieYi added reviewers: probinson, wristow, dyung. Herald added a subscriber: pengfei. Herald added a project: All. MaggieYi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When testing clang that has been

[PATCH] D130888: [Clang] Introduce -fexperimental-sanitize-metadata=

melver updated this revision to Diff 457543. melver added a comment. Add CodeGen test. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130888/new/ https://reviews.llvm.org/D130888 Files: clang/include/clang/Basic/CodeGenOptions.def clang/

[PATCH] D132945: [clang] Skip re-building lambda expressions in parameters to consteval fns.

usaxena95 updated this revision to Diff 457546. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments and added more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132945/new/ https://reviews.llvm.org/D1329

[PATCH] D133194: rewording note note_constexpr_invalid_cast

Codesbyusman created this revision. Codesbyusman added reviewers: aaron.ballman, erichkeane, xgupta. Herald added a project: All. Codesbyusman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The diagnostics here are correct, but the note is

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added a comment. Is there a technical reason for reusing the struct rather than introducing a new one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132131/new/ https://reviews.llvm.org/D132131 _

[clang] e7eec38 - [clang] Skip re-building lambda expressions in parameters to consteval fns.

Author: Utkarsh Saxena Date: 2022-09-02T12:30:52+02:00 New Revision: e7eec38246560781e0a4020b19c7eb038a8c5655 URL: https://github.com/llvm/llvm-project/commit/e7eec38246560781e0a4020b19c7eb038a8c5655 DIFF: https://github.com/llvm/llvm-project/commit/e7eec38246560781e0a4020b19c7eb038a8c5655.diff

[PATCH] D132945: [clang] Skip re-building lambda expressions in parameters to consteval fns.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7eec3824656: [clang] Skip re-building lambda expressions in parameters to consteval fns. (authored by usaxena95). Changed prior to commit: https:

[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2429 + This determines the number of empty lines to use when + SeparateDefinitionBlocks == SeparateDefinitionStyle::SDS_Always. + Can you write this not in terms of the cod

[PATCH] D67949: [clang-format] [PR36858] Add missing .hh and .cs extensions from python support utilities

MyDeveloperDay added a comment. Herald added a project: All. We are also missing json Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67949/new/ https://reviews.llvm.org/D67949 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D133109: [LLVM][ARM] Remove options for armv2, 2A, 3 and 3M

DavidSpickett added a comment. This is probably overkill but I posted an RFC just in case https://discourse.llvm.org/t/rfc-removal-of-armv2-2a-3-3m-target-options/65040. Like I said, no rush to land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D133109: [LLVM][ARM] Remove options for armv2, 2A, 3 and 3M

rengolin accepted this revision. rengolin added a comment. Agree. Even 10 years ago we made the concerted effort not to care about pre-v4, so I'd be a little surprised if people are actually using modern clang to target those platforms. Projects that rely on it can work in the same way as gcc a

[PATCH] D132056: [HLSL] Restrict to supported targets

Anastasia accepted this revision. Anastasia added a comment. This makes sense. I believe the same applies to some other languages i.e. OpenCL, as the way clang evolved currently not all targets are compatible with all languages. In the future we might want to generalize this diagnostics to use

[PATCH] D133195: Expose QualType::getNonReferenceType in libclang

diseraluca created this revision. diseraluca added a reviewer: aaron.ballman. Herald added a subscriber: arphaman. Herald added a project: All. diseraluca requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The method is now wrapped by clang_ge

[clang] 18de7c6 - Revert "[InstCombine] Treat passing undef to noundef params as UB"

Author: Muhammad Omair Javaid Date: 2022-09-02T16:09:50+05:00 New Revision: 18de7c6a3b3689bf69215429bde1fb2330a3e69d URL: https://github.com/llvm/llvm-project/commit/18de7c6a3b3689bf69215429bde1fb2330a3e69d DIFF: https://github.com/llvm/llvm-project/commit/18de7c6a3b3689bf69215429bde1fb2330a3e6

[PATCH] D132851: Further update -Wbitfield-constant-conversion for 1-bit bitfield

bjope added inline comments. Comment at: clang/test/Sema/constant-conversion.c:30 + s.b = 1; // one-bit-warning {{implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1}} + s.b = true; // no-warning (we suppress it manually to reduce false

[PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. This change has broken LLDB Arm/AArch64 Linux buildbots. I dont really understand the underlying reason. Reverting for now to make buildbot green. Repository: rG LLVM Github Monorepo C

[PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

omjavaid added a comment. Apparently some problem occuring due to trouble with ASAN exception https://lab.llvm.org/buildbot/#/builders/96/builds/28300 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133036/new/ https://reviews.llvm.org/D133036 _

[clang] 7c232b0 - [Clang][Comments] Fix `Index/comment-lots-of-unknown-commands.c`

Author: Egor Zhdan Date: 2022-09-02T12:34:38+01:00 New Revision: 7c232b0867209a8f487bbcabca9289e9ef313bef URL: https://github.com/llvm/llvm-project/commit/7c232b0867209a8f487bbcabca9289e9ef313bef DIFF: https://github.com/llvm/llvm-project/commit/7c232b0867209a8f487bbcabca9289e9ef313bef.diff LO

[PATCH] D133105: [Clang][Comments] Fix `Index/comment-lots-of-unknown-commands.c`

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c232b086720: [Clang][Comments] Fix `Index/comment-lots-of-unknown-commands.c` (authored by egorzhdan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133105/

[PATCH] D133197: [clang] Fix crash when parsing scanf format string with missing arguments

serge-sans-paille created this revision. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When parsing a format string with less argument than specified, one should check argument access because

[PATCH] D132918: [clang] Fix a crash in constant evaluation

kadircet updated this revision to Diff 457566. kadircet added a comment. Add reproducer. I think the issue is about keeping constexpr functions valid even when their bodies contain invalid decls under certain instantiations, which I believe is the right behaviour. As the function body might be in

[PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

TimNN added a comment. This also broke Rust when compiled at LLVM head: https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/13166#0182fb4a-0f2d-4f2e-830f-f62b463b8d48. (I don't know whether this was some existing UB that got only exposed by this patch or not, but wanted to m

[PATCH] D133155: Update the docs about IRC

This revision was automatically updated to reflect the committed changes. Closed by commit rG3da23970ed75: Update the docs about IRC (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133155/new/ https://reviews.llvm.org/D133

[PATCH] D132851: Further update -Wbitfield-constant-conversion for 1-bit bitfield

aaron.ballman added inline comments. Comment at: clang/test/Sema/constant-conversion.c:30 + s.b = 1; // one-bit-warning {{implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1}} + s.b = true; // no-warning (we suppress it manually to reduce

[PATCH] D133194: rewording note note_constexpr_invalid_cast

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Thanks for the cleanup here! Precommit CI pointed out places where test coverage found issues, and you're missing new test coverage for the change. If you run the faili

[PATCH] D132550: Changes to code ownership in clang and clang-tidy

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. +1 to the rst format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132550/new/ https://reviews.llvm.org/D132550 ___ cfe-co

[PATCH] D133197: [clang] Fix crash when parsing scanf format string with missing arguments

inclyc added a reviewer: aaron.ballman. inclyc accepted this revision. inclyc added a subscriber: aaron.ballman. inclyc added a comment. This revision is now accepted and ready to land. Thanks @serge-sans-paille! Basically LGTM. Maybe we need to backport this patch though? @aaron.ballman Reposi

[PATCH] D133202: [Clang][CodeGen] Fix __builtin_assume_aligned crash

yronglin created this revision. yronglin added a reviewer: rjmccall. Herald added a project: All. yronglin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang will crash when __builtin_assume_aligned's 1st arg is array type(or string lit

[PATCH] D133202: [Clang][CodeGen] Fix __builtin_assume_aligned crash

yronglin added a comment. Hi John, I just have a new account, we continue here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133202/new/ https://reviews.llvm.org/D133202 ___ cfe-commits mailing list cfe

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

luken-google updated this revision to Diff 457579. luken-google marked an inline comment as done. luken-google added a comment. Rebase and lazily check condition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133052/new/ https://reviews.llvm.org/D1

[PATCH] D133197: [clang] Fix crash when parsing scanf format string with missing arguments

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! In D133197#3766797 , @inclyc wrote: > Thanks @serge-sans-paille! Basically LGTM. Maybe we need to backport this > patch though? @aaron.ballman Clang 15 is closed for backports t

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

luken-google added a comment. In D133052#3765753 , @ychen wrote: > Oh, one more thing, we probably need to handle nested levels too, for > example, `foo(a);` might be triggered by a template which may be in turn > triggered by the concept check. So only

[PATCH] D133202: [Clang][CodeGen] Fix __builtin_assume_aligned crash

yronglin updated this revision to Diff 457580. yronglin added a comment. Format code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133202/new/ https://reviews.llvm.org/D133202 Files: clang/include/clang/Basic/Builtins.def clang/lib/CodeGen/CGB

[PATCH] D133195: Expose QualType::getNonReferenceType in libclang

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! The precommit CI failure on Debian looks to be unrelated, so I will land this on your behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[clang] e7d9917 - Expose QualType::getNonReferenceType in libclang

Author: Luca Di Sera Date: 2022-09-02T09:54:10-04:00 New Revision: e7d9917a60dca60da05d0114de9858ed7acb015c URL: https://github.com/llvm/llvm-project/commit/e7d9917a60dca60da05d0114de9858ed7acb015c DIFF: https://github.com/llvm/llvm-project/commit/e7d9917a60dca60da05d0114de9858ed7acb015c.diff

[PATCH] D133195: Expose QualType::getNonReferenceType in libclang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7d9917a60dc: Expose QualType::getNonReferenceType in libclang (authored by diseraluca, committed by aaron.ballman). Repository: rG LLVM Github Mo

[PATCH] D132918: [clang] Fix a crash in constant evaluation

ilya-biryukov added a comment. I was just passing by, but wanted to add more context from our investigation with @kadircet. If variables with incomplete types appear inside non-template `constexpr` function this gets detected by a call to `CheckConstexprFunctionDefinition` inside `ActOnFinishFu

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo added a comment. @jamieschmeiser @Whitney For now, the time-trace file's name is corresponding to the output file's name ([demo].o => [demo].json). The only fly in the ointment is that when the user hasn't given the object file's name by "-o", the object file may be stored in `/tmp

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

aaron.ballman added a comment. In D132136#3766140 , @tbaeder wrote: > @aaron.ballman Can you comment on my last question? I'd like to land this > patch since the others depend on it. Sorry for the delay! In D132136#3760738

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat added a comment. @Orlando thanks for taking a look! > When constructing the compiler command line (here in Clang.cpp) there's a > special case for SCE debugger tuning: Yeah, but it seems that it is not possible to use `lld` for PS4 (only `orbis-ld`), according to https://github.com/llvm/

[PATCH] D133209: [clang] Document environment variables used by the driver

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We also mention limitations with regards to character encoding support. Signed-off-by: Matheus Izvekov Repository: r

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

aaron.ballman added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2646 +.. option:: -fstrict-flex-arrays=, -fno-strict-flex-arrays + From the top of this file: ``` --- N

[PATCH] D133209: [clang] Document environment variables used by the driver

aaron.ballman added subscribers: jansvoboda11, aaron.ballman. aaron.ballman added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2-5 --- NOTE: This file is automatically generated by runn

[PATCH] D133209: [clang] Document environment variables used by the driver

mizvekov added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2-5 --- NOTE: This file is automatically generated by running clang-tblgen -gen-opt-docs. Do not edit this file by hand!!

[PATCH] D133209: [clang] Document environment variables used by the driver

aaron.ballman added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2-5 --- NOTE: This file is automatically generated by running clang-tblgen -gen-opt-docs. Do not edit this file by ha

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

aaron.ballman added a comment. In D133066#3765503 , @zhouyizhou wrote: > In D133066#3764384 , @aaron.ballman > wrote: > >> The existing comment is correct according to my copy of the C++11 standard, >> but the

[PATCH] D133158: [NFC] Make MultiplexExternalSemaSource own sources

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from some minor nits (also, please run clang-format over the patch before landing). Comment at: clang/lib/Sema/MultiplexExternalSemaSource.cpp:32 +MultiplexExternalSemaSource::~MultiplexExternalSem

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

peixin added a comment. Mostly LGTM. Have several more comments. Comment at: flang/lib/Lower/Bridge.cpp:279 +// are compiled separately. +if (hasMainProgram) { + createGlobalOutsideOfFunctionLowering([&]() { Nit Comment at: flang

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

roberteg16 added a comment. In D126172#3754221 , @mizvekov wrote: > Hello, @roberteg16, are you still interested in working on this patch? > > I might need a fix for this myself, and also it happened recently that > someone else attempted a fix for the s

[PATCH] D131701: [CodeGen][ObjC] Call synthesized copy constructor/assignment operator functions in getter/setter functions of non-trivial C struct properties

ahatanak updated this revision to Diff 457620. ahatanak added a comment. Call the move assignment operator in the setter instead of calling the copy assignment operator and the destructor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131701/new/

[clang] e05edb1 - [Driver] Unsupport --print-multiarch

Author: Fangrui Song Date: 2022-09-02T09:51:02-07:00 New Revision: e05edb19adbfd1b24f58d583e4b5b4d742f982ee URL: https://github.com/llvm/llvm-project/commit/e05edb19adbfd1b24f58d583e4b5b4d742f982ee DIFF: https://github.com/llvm/llvm-project/commit/e05edb19adbfd1b24f58d583e4b5b4d742f982ee.diff

[PATCH] D133170: [Driver] Unsupport --print-multiarch

This revision was automatically updated to reflect the committed changes. Closed by commit rGe05edb19adbf: [Driver] Unsupport --print-multiarch (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133170/new/ https://reviews.llvm.org

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

aaron.ballman added a comment. > The patch conceptually models the possible "top-level" statements between two > top-level declarations into a block which is emitted as part of the global > init function. > Currently we model this "statement block" as a function body to a void > function taking

[PATCH] D133180: [MinGW] Ignore -fvisibility/-fvisibility-inlines-hidden for dllexport

MaskRay updated this revision to Diff 457625. MaskRay marked an inline comment as done. MaskRay added a comment. rename test to dllstorage-visibility.cpp use -fdeclspec instead of -fms-extensions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133180/

[PATCH] D130888: [Clang] Introduce -fexperimental-sanitize-metadata=

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/fsanitize-metadata.c:24 + +// RUN: %clang --target=x86_64-linux-gnu \ +// RUN: -fexperimental-sanitize-metadata=covered,atomics %s

[clang] 1a4d851 - [MinGW] Ignore -fvisibility/-fvisibility-inlines-hidden for dllexport

Author: Fangrui Song Date: 2022-09-02T09:59:16-07:00 New Revision: 1a4d851d272d141fb39ff9a0b2572dfa4411c5c5 URL: https://github.com/llvm/llvm-project/commit/1a4d851d272d141fb39ff9a0b2572dfa4411c5c5 DIFF: https://github.com/llvm/llvm-project/commit/1a4d851d272d141fb39ff9a0b2572dfa4411c5c5.diff

[PATCH] D133180: [MinGW] Ignore -fvisibility/-fvisibility-inlines-hidden for dllexport

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a4d851d272d: [MinGW] Ignore -fvisibility/-fvisibility-inlines-hidden for dllexport (authored by MaskRay). Repository: rG LLVM Github Monorepo CH

[PATCH] D132550: Changes to code ownership in clang and clang-tidy

njames93 added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132550/new/ https://reviews.llvm.org/D132550 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

rjmccall added a comment. Other than the one thing, this looks good. Comment at: clang/lib/Sema/SemaChecking.cpp:7697 // The alignment must be a constant integer. - Expr *Arg = TheCall->getArg(1); + Expr *SecondArg = TheCall->getArg(1); This should be:

[PATCH] D131268: [HLSL] Generate buffer subscript operators

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit that was missed. Thanks for switching to static_cast, that makes me happier. :-) Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:10

[clang] a931edd - [docs] Regenerate clang/docs/ClangCommandLineReference.rst

Author: Fangrui Song Date: 2022-09-02T10:29:38-07:00 New Revision: a931eddd09145c340966db0561159a8e7cdb212e URL: https://github.com/llvm/llvm-project/commit/a931eddd09145c340966db0561159a8e7cdb212e DIFF: https://github.com/llvm/llvm-project/commit/a931eddd09145c340966db0561159a8e7cdb212e.diff

[clang] 8899c3c - [docs] -fivisibility= allows protected and internal

Author: Fangrui Song Date: 2022-09-02T10:49:10-07:00 New Revision: 8899c3c4e15ea3681b0c423b44313163f5370abd URL: https://github.com/llvm/llvm-project/commit/8899c3c4e15ea3681b0c423b44313163f5370abd DIFF: https://github.com/llvm/llvm-project/commit/8899c3c4e15ea3681b0c423b44313163f5370abd.diff

[PATCH] D133194: rewording note note_constexpr_invalid_cast

shafik added a comment. I can't find any C tests that exercise this diagnostic. We should add a C test as well to confirm that we obtain the diagnostic we expect in a C context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133194/new/ https://rev

[PATCH] D130888: [Clang] Introduce -fexperimental-sanitize-metadata=

melver updated this revision to Diff 457637. melver added a comment. Don't split RUN lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130888/new/ https://reviews.llvm.org/D130888 Files: clang/include/clang/Basic/CodeGenOptions.def clang/in

[PATCH] D131701: [CodeGen][ObjC] Call synthesized copy constructor/assignment operator functions in getter/setter functions of non-trivial C struct properties

rjmccall added a comment. Can we check for the right conditions when emitting the setter body and just deactivate the cleanup? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131701/new/ https://reviews.llvm.org/D131701

[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

yronglin updated this revision to Diff 457643. yronglin added a comment. Update patch with john's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133202/new/ https://reviews.llvm.org/D133202 Files: clang/include/clang/Basic/Builtins.def

[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

yronglin added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7697 // The alignment must be a constant integer. - Expr *Arg = TheCall->getArg(1); + Expr *SecondArg = TheCall->getArg(1); rjmccall wrote: > This should be: > > ``` > Expr *Secon

[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133202/new/ https://reviews.llvm.org/D133202 ___

[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

yronglin added a comment. In D133202#3767414 , @rjmccall wrote: > Thanks, LGTM Thanks for your review John, but I don’t have commit access, can you land this patch for me? Please use "yronglin " to commit the change. Repository: rG LLVM Github Mono

[PATCH] D125419: [Arm64EC 7/?] clang side of Arm64EC varargs ABI.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2457 +/*IsVectorCall=*/false, /*IsRegCall=*/false); + } + Hmm. Doesn't EC ABI lowering need to preserve this same state, or else you'll get incompatibilities when

[PATCH] D133158: [NFC] Make MultiplexExternalSemaSource own sources

beanz updated this revision to Diff 457651. beanz added a comment. Herald added a project: clang-tools-extra. Updating with changes based on review feedback, and fixups for clang-tools-extra Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133158/new/

[PATCH] D132975: [clang][BOLT] Add clang-bolt target

phosek added a comment. In D132975#3765541 , @Amir wrote: > Hi Petr, thank you for your comments! > > In D132975#3763264 , @phosek wrote: > >> This was already on my list of build system features I'd like to imple

[PATCH] D132829: [clang][Interp] Handle ImplictValueInitExprs

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang/test/AST/Interp/arrays.cpp:13 +/// currently evaluate other parts of it. +#if 0 +struct fred { I wish we could find some solution that didn't require this so that the

[PATCH] D133158: [NFC] Make MultiplexExternalSemaSource own sources

beanz added a comment. I built LLDB and ran its tests. I see no additional failures after applying my change, but LLDB's tests do not execute successfully on my local system (22 failures). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133158/new/

[clang] 10194a5 - [HLSL] Restrict to supported targets

Author: Chris Bieneman Date: 2022-09-02T13:36:23-05:00 New Revision: 10194a51a9d304ab9f68432f244749c672f9012a URL: https://github.com/llvm/llvm-project/commit/10194a51a9d304ab9f68432f244749c672f9012a DIFF: https://github.com/llvm/llvm-project/commit/10194a51a9d304ab9f68432f244749c672f9012a.diff

[PATCH] D132056: [HLSL] Restrict to supported targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG10194a51a9d3: [HLSL] Restrict to supported targets (authored by beanz). Changed prior to commit: https://reviews.llvm.org/D132056?vs=456746&id=457

[PATCH] D133191: Driver test: remove `REQUIRES: x86-registered-target` and set `--sysroot=""` to support clang with `DEFAULT_SYSROOT`.

wristow accepted this revision. wristow added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133191/new/ https://reviews.llvm.org/D133191 _

[clang] 1491282 - [clang] Change cc1 -fvisibility's canonical spelling to -fvisibility=

Author: Fangrui Song Date: 2022-09-02T11:49:38-07:00 New Revision: 1491282165bfb87b15bd806ab53b3e9910ee7b29 URL: https://github.com/llvm/llvm-project/commit/1491282165bfb87b15bd806ab53b3e9910ee7b29 DIFF: https://github.com/llvm/llvm-project/commit/1491282165bfb87b15bd806ab53b3e9910ee7b29.diff

[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:277 +template +bool ByteCodeExprGen::VisitConstantExpr (const ConstantExpr *E) { + // TODO: Check if the ConstantExpr already has a value set and if so, ===

[PATCH] D133087: [clang-format][NFC][Docs] fix wrong example of warping class definitions

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133087/new/ https://reviews.llvm.org/D133087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] 5b5329b - [NFC] Make MultiplexExternalSemaSource own sources

Author: Chris Bieneman Date: 2022-09-02T13:57:39-05:00 New Revision: 5b5329bd41ba977459fcd7abb7cf438fd98c98e0 URL: https://github.com/llvm/llvm-project/commit/5b5329bd41ba977459fcd7abb7cf438fd98c98e0 DIFF: https://github.com/llvm/llvm-project/commit/5b5329bd41ba977459fcd7abb7cf438fd98c98e0.diff

[PATCH] D133158: [NFC] Make MultiplexExternalSemaSource own sources

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b5329bd41ba: [NFC] Make MultiplexExternalSemaSource own sources (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D132975: [clang][BOLT] Add clang-bolt target

phosek added inline comments. Comment at: clang/CMakeLists.txt:930-937 +-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX} +-DCMAKE_C_COMPILER=${CLANG_INSTRUMENTED} +-DCMAKE_CXX_COMPILER=${CLANGXX_INSTRUMENTED} +-DCMAKE_

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

jpenix-quic added inline comments. Comment at: flang/test/Driver/emit-mlir.f90:16 ! CHECK-NEXT: } +! CHECK-NEXT: fir.global @_QQEnvironmentDefaults constant : !fir.ref, !fir.ref> { +! CHECK-NEXT: %[[VAL_0:.*]] = fir.zero_bits !fir.ref, !fir.ref> peixi

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks added a comment. In D132131#3766590 , @MyDeveloperDay wrote: > Is there a technical reason for reusing the struct rather than introducing a > new one? I see, good point. Really only if one would port the implementation to `AlignToke

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

mizvekov added a comment. In D126172#3767188 , @roberteg16 wrote: > Hey @mizvekov! Sorry for the late response. > > Yes, I am still interested and I am working on this. I'll let you know ASAP > if I find something that resembles a valid fix. > > I would

[PATCH] D132990: [Clang] Fix compat diagnostic to detect a nontype template parameter has a placeholder type using getContainedAutoType()

aaron.ballman added a comment. Can you also add a release note for the changes? Comment at: clang/lib/Sema/SemaTemplate.cpp:1534-1538 + if (const auto *T = TInfo->getType()->getContainedDeducedType()) +if (isa(T)) + Diag(D.getIdentifierLoc(), + diag::warn_cx

[PATCH] D132831: [clang][Interp] Handle SubstNonTypeTemplateParmExprs

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM on the assumption that the extra test coverage doesn't find anything. Comment at: clang/test/AST/Interp/functions.cpp:68-69 static_assert(recursion(10) == 0, ""); + + +template ==

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

jamieschmeiser accepted this revision. jamieschmeiser added a comment. If the source is specified with a partial path, I would expect the .json file to be in the same directory as the source, so dir1/f.C and dir2/f.C would result in dir1/f.json and dir2/f.json. But this can be a later improveme

[PATCH] D132779: Enforce module decl-use restrictions and private header restrictions in textual headers

aaron.ballman added a comment. The changes look reasonable to me, though if you think the flag is a temporary one, we might want to consider changes to document that explicitly. Comment at: clang/docs/ReleaseNotes.rst:126 +

[clang] 7474214 - [test] Change cc1 -fvisibility to -fvisibility=

Author: Fangrui Song Date: 2022-09-02T12:36:44-07:00 New Revision: 74742147ee27659dc3b0bc713d61ea9218bf29d0 URL: https://github.com/llvm/llvm-project/commit/74742147ee27659dc3b0bc713d61ea9218bf29d0 DIFF: https://github.com/llvm/llvm-project/commit/74742147ee27659dc3b0bc713d61ea9218bf29d0.diff

  1   2   >