aaron.ballman added a comment.

In D133066#3765503 <https://reviews.llvm.org/D133066#3765503>, @zhouyizhou 
wrote:

> In D133066#3764384 <https://reviews.llvm.org/D133066#3764384>, @aaron.ballman 
> wrote:
>
>> The existing comment is correct according to my copy of the C++11 standard, 
>> but the standard has changed since C++11 and those words no longer appear in 
>> http://eel.is/c++draft/dcl.init.ref#5. Some more investigation is needed, 
>> but I suspect the correct action to take here is to update the comment based 
>> on the current standards wording or to see if there's a bug because the code 
>> does not match the comment.
>
> thank Aaron for review my patch, 
> I am a passionate beginner,

Welcome to the community, we're glad to have you here!

> this is a very good learning experience for me ;-)  I am looking forward to 
> seeing the final change.

Happy to help, but to be clear on the next steps: are you planning to do the 
investigation work, or were you hoping someone else would do it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133066/new/

https://reviews.llvm.org/D133066

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to