[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

mstorsjo added a comment. This triggers failed asserts for me: $ cat repro.c static float strtof(char *, char *) {} void a() { strtof(a, 0); } $ clang -target x86_64-w64-mingw32 -w -c repro.c -O3 clang: ../lib/Analysis/CGSCCPassManager.cpp:958: updateCGAndAnalysisManagerForPass(llvm::

[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

corona10 marked an inline comment as done. corona10 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/use-emplace.cpp:1059 priority_queue.emplace(Foo(13)); // CHECK-MESSAGES: :[[@LINE-1]]:26: warning: unnecessary temporary object cr

[PATCH] D132600: [llvm-profdata] Handle internal linkage functions in profile supplementation

xur added inline comments. Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:589 + +if (SampleProfileHasFUnique) { + // If profile also uses funqiue, nothing to do here. tmsriram wrote: > Maybe rewrite this slightly as: > > // If Sample Profile an

[PATCH] D127973: [analyzer] Eval construction of non POD type arrays.

steakhal added a comment. In D127973#3749153 , @isuckatcs wrote: > @steakhal > > Can you send me a snippet please, which reproduces this issue? For me the > egraph rewriter works fine. I had the time for reducing it. Luckily it wasn't that bad. digra

[PATCH] D132600: [llvm-profdata] Handle internal linkage functions in profile supplementation

xur updated this revision to Diff 455816. xur added a comment. Integrated Sriraman's suggestion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132600/new/ https://reviews.llvm.org/D132600 Files: clang/lib/CodeGen/CodeGenModule.cpp llvm/include/llvm/ProfileData/SampleProf.h llvm/t

[PATCH] D130207: [HLSL] Move DXIL validation version out of ModuleFlags

python3kgae updated this revision to Diff 455817. python3kgae marked 3 inline comments as done. python3kgae added a comment. Remove empty function and replace auto with correct type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130207/new/ https:/

[PATCH] D127973: [analyzer] Eval construction of non POD type arrays.

isuckatcs added a comment. > I had the time for reducing it. Luckily it wasn't that bad. This egraph doesn't contain an entry with key "index_of_element", which is strange. I still feel like I need a code snippet, which generates such egraph. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D132503: [clang] Add cxx scope if needed for requires clause.

ilya-biryukov added a comment. I will commit this on behalf of Luke. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132503/new/ https://reviews.llvm.org/D132503 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

corona10 updated this revision to Diff 455819. corona10 marked an inline comment as done. corona10 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132640/new/ https://reviews.llvm.org/D132640 Files: clang-tools-extra/clang-

[PATCH] D132661: [clang] Make guard(nocf) attribute available only for Windows

alvinhochun updated this revision to Diff 455820. alvinhochun added a comment. Applied suggestions and added test coverage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132661/new/ https://reviews.llvm.org/D132661 Files: clang/docs/ReleaseNotes

[clang] 7aa3270 - [clang] Add cxx scope if needed for requires clause.

Author: Luke Nihlen Date: 2022-08-26T10:15:54+02:00 New Revision: 7aa3270622f495ce1209aeca83a3b216889ccab4 URL: https://github.com/llvm/llvm-project/commit/7aa3270622f495ce1209aeca83a3b216889ccab4 DIFF: https://github.com/llvm/llvm-project/commit/7aa3270622f495ce1209aeca83a3b216889ccab4.diff L

[PATCH] D132503: [clang] Add cxx scope if needed for requires clause.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7aa3270622f4: [clang] Add cxx scope if needed for requires clause. (authored by luken-google, committed by ilya-biryukov). Changed prior to commit: https://reviews.llvm.org/D132503?vs=455622&id=455822#t

[clang] 5fef4c6 - [clang] NFC. Small tweak to release notes

Author: Ilya Biryukov Date: 2022-08-26T10:17:44+02:00 New Revision: 5fef4c6d397cbf9d6a41d42299b55b0cfddc7d12 URL: https://github.com/llvm/llvm-project/commit/5fef4c6d397cbf9d6a41d42299b55b0cfddc7d12 DIFF: https://github.com/llvm/llvm-project/commit/5fef4c6d397cbf9d6a41d42299b55b0cfddc7d12.diff

[PATCH] D132723: [Clang] Fix crash in coverage of if consteval.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang crashes when encountering an `if consteval` statement. This is the minimum fix not to crash. The fix is consistent w

[PATCH] D132723: [Clang] Fix crash in coverage of if consteval.

cor3ntin added a comment. @aaron.ballman I did a minimal fix, both because It's unclear to me how coverage work and because I think we should try to land this is 15. I hope that's okay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132723/new/ ht

[clang] 4a043c6 - PotentiallyEvaluatedContext in a ImmediateFunctionContext.

Author: Utkarsh Saxena Date: 2022-08-26T10:30:10+02:00 New Revision: 4a043c6376468f1883bbfcdac1a160e5bc97f640 URL: https://github.com/llvm/llvm-project/commit/4a043c6376468f1883bbfcdac1a160e5bc97f640 DIFF: https://github.com/llvm/llvm-project/commit/4a043c6376468f1883bbfcdac1a160e5bc97f640.diff

[PATCH] D132659: PotentiallyEvaluatedContext in a ImmediateFunctionContext.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a043c637646: PotentiallyEvaluatedContext in a ImmediateFunctionContext. (authored by usaxena95). Changed prior to commit: https://reviews.llvm.or

[PATCH] D132719: [clang-format] Rework removeBraces() in Format.cpp

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132719/new/ https://reviews.llvm.org/D132719 ___

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay accepted this revision. MyDeveloperDay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/Format.cpp:649 IO.mapOptional("AlignOperands", Style.AlignOperands); -IO.mapOptional("AlignTrailingComments", Style.

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:797 +AlignConsecutiveMacros: + Enabled: true + AcrossEmptyLines: true why do we need Enabled? isn't it just ``` false: AcrossEmptyLines: false AcrossComments:

[PATCH] D127973: [analyzer] Eval construction of non POD type arrays.

steakhal added a comment. In D127973#3751119 , @isuckatcs wrote: >> I had the time for reducing it. Luckily it wasn't that bad. > > This egraph doesn't contain an entry with key "index_of_element", which is > strange. > > I still feel like I need a code

[PATCH] D131683: Diagnosing the Future Keywords

Codesbyusman updated this revision to Diff 455841. Codesbyusman added a comment. updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131683/new/ https://reviews.llvm.org/D131683 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/D

[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, shafik, erichkeane, tahonermann. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It took me a pretty long time to get the patch this

[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:553 +if (!visitArrayInitializer(Init)) + return false; +if (!this->emitPopPtr(Init)) I've been wondering about a macro to simplify code like this, e.g. `d

[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:43 protected: - // Emitters for opcodes of various arities. - using NullaryFn = bool (ByteCodeExprGen::*)(const SourceInfo &); - using UnaryFn = bool (ByteCodeExprGen::*)(PrimType, const SourceI

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

psamolysov added a comment. @mstorsjo Thank you very much for the information. Unfortunately, our tests didn't catch this problem. I've reproduced this on Windows even w/o mingw. Some time is required for triaging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

dyung added a comment. We also saw this assert on our Windows build, and it also can be reproduced in Linux: $ cat test2.c static char *getenv(char *) {} void foo() { getenv(""); } $ ~/src/upstream/879f5118fc74657e4a5c4eff6810098e1eed75ac-linux/bin/clang -c -O3 test2.c

[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

tbaeder updated this revision to Diff 455849. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132727/new/ https://reviews.llvm.org/D132727 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/I

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

dyung added a comment. In D128830#3751368 , @dyung wrote: > We also saw this assert on our Windows build, and it also can be reproduced > in Linux: > > $ cat test2.c > static char *getenv(char *) {} > void foo() { getenv(""); } > $ ~/src/upstream

[clang] f964417 - Revert "[Pipelines] Introduce DAE after ArgumentPromotion"

Author: Pavel Samolysov Date: 2022-08-26T13:43:09+03:00 New Revision: f964417c32d05a88c80db315e97ada639d97eda1 URL: https://github.com/llvm/llvm-project/commit/f964417c32d05a88c80db315e97ada639d97eda1 DIFF: https://github.com/llvm/llvm-project/commit/f964417c32d05a88c80db315e97ada639d97eda1.dif

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

psamolysov added a comment. No problem, I've reverted the commit while I need some time to build `clang` with the reverted commit even for make it clear the commit is guilty. I'm sorry. It's very interesting, in @mstorsjo case, a function from the standard `C` library is used: `strtof`. When I

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

Michael137 added a comment. Noted, thanks for the heads up AFAIK, the only test that'd now fail on the debug-info side is: https://reviews.llvm.org/D132664 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128830/new/ https://reviews.llvm.org/D128830

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

joanahalili added a comment. We have some compilation failures on our end because of function template parameter deduction when passing the function template to a function pointer. typedef void (*f)(const int&); template void F(T value) {} template void F(const T& value){}

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov added a comment. In D128113#3747946 , @alexfh wrote: > For now we've added a workaround for the most problematic use case and got us > unblocked. Thus there is no need now in introducing additional flags. > However, I'm rather concerned about t

[PATCH] D132487: [pseudo] Placeholder disambiguation strategy: always choose second

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/pseudo/tool/ClangPseudo.cpp:231 + +if (Disambiguate && PrintForest) { + ForestNode *DisambigRoot = &Root; hokein wrote: > nit: we're going to print

[PATCH] D132712: [Clang] Fix assert in Sema::LookupTemplateName so that it does not attempt an unconditional cast to TagType

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Good catch! LGTM, but please add a release note for the fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132712/new/ https://reviews.llvm.org/D132712

[clang] 4a56470 - Revert "Clang: fix AST representation of expanded template arguments."

Author: Matheus Izvekov Date: 2022-08-26T13:09:55+02:00 New Revision: 4a56470d0dcd2b6183e7aaf929995b01d986c216 URL: https://github.com/llvm/llvm-project/commit/4a56470d0dcd2b6183e7aaf929995b01d986c216 DIFF: https://github.com/llvm/llvm-project/commit/4a56470d0dcd2b6183e7aaf929995b01d986c216.dif

[PATCH] D132470: [pseudo] add the spurious left-and-upwads recovery case to unittest.

sammccall added inline comments. Comment at: clang-tools-extra/pseudo/unittests/GLRTest.cpp:711 +TEST_F(GLRTest, SpuriousRecoveryLeftAndUpwardsCase) { + build(R"bnf( it's not clear to me what this is testing, can you add some documentation? (also I think "lef

[clang-tools-extra] 56c54cf - [pseudo] Placeholder disambiguation strategy: always choose second

Author: Sam McCall Date: 2022-08-26T13:16:09+02:00 New Revision: 56c54cf66bcd6c2266cd96ab4da45c766fbad540 URL: https://github.com/llvm/llvm-project/commit/56c54cf66bcd6c2266cd96ab4da45c766fbad540 DIFF: https://github.com/llvm/llvm-project/commit/56c54cf66bcd6c2266cd96ab4da45c766fbad540.diff LO

[PATCH] D132487: [pseudo] Placeholder disambiguation strategy: always choose second

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG56c54cf66bcd: [pseudo] Placeholder disambiguation strategy: always choose second (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

inclyc updated this revision to Diff 455871. inclyc added a comment. Add LangOpts so we keep the Obj-C behavior of clang just as-is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132568/new/ https://reviews.llvm.org/D132568 Files: clang/docs/Rel

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

inclyc added inline comments. Comment at: clang/lib/AST/FormatString.cpp:367 +case BuiltinType::Char_U: +case BuiltinType::Bool: + return Match; aaron.ballman wrote: > inclyc wrote: > > aaron.ballman wrote: > > > Isn't this a match promot

[PATCH] D131388: [docs] Add "Standard C++ Modules"

ruoso accepted this revision. ruoso added a comment. Thanks for taking my last minute suggestions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131388/new/ https://reviews.llvm.org/D131388 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang/include/clang/Frontend/SARIFDiagnostic.h:45-47 + void emitCodeContext(FullSourceLoc Loc, DiagnosticsEngine::Level Level, + SmallVectorImpl &Ranges, +

[PATCH] D132147: [clang][dataflow] Refactor `TestingSupport.h`

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:60 +/// Arguments for building the dataflow analysis. +template struct AnalysisInputs { + /// Input code that is analyzed. Could you

[PATCH] D132695: [Clang] Avoid crashes when parsing using enum declarations

aaron.ballman accepted this revision. aaron.ballman added a comment. Thanks, this looks like it cleans up some needlessly chatty diagnostics! Just had a question that you can fix when landing if you agree, otherwise LGTM as well. Comment at: clang/lib/Parse/ParseDecl.cpp:4651

[PATCH] D132661: [clang] Make guard(nocf) attribute available only for Windows

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Comment at: clang/include/clang/Basic/Attr.td:373-375 // Specifies Operating Systems for which the target applies, based off the // OSTyp

[PATCH] D132377: [clang][dataflow] Add `SetupTest` parameter for `AnalysisInputs`.

sgatev added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:88 +/// Arguments for building the dataflow analysis. +template struct AnalysisInputs { + /// Input code that is analyzed. Why move this? It makes it hard to tell

[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

tbaeder updated this revision to Diff 455873. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132727/new/ https://reviews.llvm.org/D132727 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/I

[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

tbaeder added inline comments. Comment at: clang/test/AST/Interp/arrays.cpp:56 +// LValuePath correctly. +//static_assert(data[0] == 4); + tbaeder wrote: > This is quite unfortunate, but it only fails when evaluating `data[0]` by > itself, when printing the extr

[PATCH] D132592: [Clang] Implement function attribute nouwtable

aaron.ballman added a comment. In D132592#3749567 , @ychen wrote: > Thanks for taking a look! > > In D132592#3749261 , @aaron.ballman > wrote: > >> Do we have any evidence that users need this level of control or

[PATCH] D132732: [pseudo] Collect positions in TokenStream that trigger the error recovery.

hokein created this revision. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. Mainly for making it easier to debug broken code. No intend to land it. Repository: rG LLVM Githu

[PATCH] D132244: [docs] improve documentation for misc-const-correctness

JonasToth added a comment. @njames93 friendly ping, for https://reviews.llvm.org/D130793 as well :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132244/new/ https://reviews.llvm.org/D132244 ___ cfe-comm

[PATCH] D132723: [Clang] Fix crash in coverage of if consteval.

aaron.ballman added a comment. Can you also add a release note? Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1375 extendRegion(S); + if (S->getInit()) Spurious whitespace change. Comment at: clang/lib/CodeGen/CoverageMapping

[clang] 80e7dec - Typo fix in Release notes.

Author: Utkarsh Saxena Date: 2022-08-26T14:36:45+02:00 New Revision: 80e7dec561705386376bbfba0f7d5c290f2c04f6 URL: https://github.com/llvm/llvm-project/commit/80e7dec561705386376bbfba0f7d5c290f2c04f6 DIFF: https://github.com/llvm/llvm-project/commit/80e7dec561705386376bbfba0f7d5c290f2c04f6.diff

[PATCH] D132286: [clang][Interp] Implement function calls

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some small nits you can fix when landing. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:607-610 + if (auto R = + ByteCo

[PATCH] D132723: [Clang] Fix crash in coverage of if consteval.

cor3ntin updated this revision to Diff 455883. cor3ntin added a comment. Release notes + style issues (There was no shadowing though) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132723/new/ https://reviews.llvm.org/D132723 Files: clang/docs/Re

[PATCH] D132723: [Clang] Fix crash in coverage of if consteval.

cor3ntin marked an inline comment as done. cor3ntin added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1407 // The 'else' count applies to the area immediately after the 'then'. - Gap = findGapAreaBetween(getEnd(S->getThen()), getStart(Else));

[PATCH] D131388: [docs] Add "Standard C++ Modules"

bbrown105 added a comment. Nice writeup! I appreciate the work that went into this. Comment at: clang/docs/StandardCPlusPlusModules.rst:27 + +standard C++ Named modules +== Just matching the capitalization of the other sections and subse

[PATCH] D132712: [Clang] Fix assert in Sema::LookupTemplateName so that it does not attempt an unconditional cast to TagType

erichkeane accepted this revision. erichkeane added a comment. Looking through `isCompleteType` I note that arrays of an elements of incomplete types would have also hit this crash, as would member-pointers in MicrosoftABI (in some weird cases?), and some ObjC types. Anyway, other than the nit

[PATCH] D131683: Diagnosing the Future Keywords

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! There's a minor thing left to be fixed, but I'll handle it on commit. I wanted to drop the `|KEYC2X` for the Boolean keywords so it relies solely on `BOOLSUPPORT`, but then

[clang] 41667a8 - Diagnosing the Future Keywords

Author: Muhammad Usman Shahid Date: 2022-08-26T09:20:05-04:00 New Revision: 41667a8b9b624e282e7c08fadf7091223728d1c1 URL: https://github.com/llvm/llvm-project/commit/41667a8b9b624e282e7c08fadf7091223728d1c1 DIFF: https://github.com/llvm/llvm-project/commit/41667a8b9b624e282e7c08fadf7091223728d1

[PATCH] D131683: Diagnosing the Future Keywords

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41667a8b9b62: Diagnosing the Future Keywords (authored by Codesbyusman, committed by aaron.ballman). Changed prior to commit: https://reviews.llvm

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Would be great if we had a better test here... is there anything we can do to validate this is happening other than checking for that one note? CHANGES SINCE LAST ACTION https://rev

[PATCH] D132030: [analyzer] Pass correct bldrCtx to computeObjectUnderConstruction

tomasz-kaminski-sonarsource added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132030/new/ https://reviews.llvm.org/D132030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D132550: Changes to code ownership in clang and clang-tidy

rengolin accepted this revision. rengolin added a comment. W00t! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132550/new/ https://reviews.llvm.org/D132550 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

erichkeane added a comment. Nothing suspicious as far as I can tell, other than just punting on ArrayFillers. Don't understand enough of this code to just do a straight-up approval though, so hopefully one of the other reviewers can take a look and confirm with another uninformed opinion :)

[PATCH] D132739: [clang][Interp] Implement IntegralToBoolean casts

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, tahonermann. Herald added a subscriber: inglorion. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Redo how we d

[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:535 + + // TODO: Fillers? + if (const auto *InitList = dyn_cast(Initializer)) { erichkeane wrote: > Heh, THIS is a huge "TODO" here. The ArrayFillers go through a ton of > twi

[PATCH] D132739: [clang][Interp] Implement IntegralToBoolean casts

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/Interp/Opcodes.td:433 +def ToCastTypeClass : TypeClass { + let Types = [Sint32, Bool]; } Not sure how this works... b

[PATCH] D132739: [clang][Interp] Implement IntegralToBoolean casts

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Opcodes.td:433 +def ToCastTypeClass : TypeClass { + let Types = [Sint32, Bool]; } erichkeane wrote: > Not sure how this works... but is this ONLY int-32 to bool and vice versa? > The implementati

[PATCH] D132739: [clang][Interp] Implement IntegralToBoolean casts

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/Opcodes.td:433 +def ToCastTypeClass : TypeClass { + let Types = [Sint32, Bool]; } tbaeder wrote: > erichkeane wrote: > > Not sure how this works... but is this ONLY int-32 to bool and vice versa

[PATCH] D132739: [clang][Interp] Implement IntegralToBoolean casts

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Opcodes.td:433 +def ToCastTypeClass : TypeClass { + let Types = [Sint32, Bool]; } erichkeane wrote: > tbaeder wrote: > > erichkeane wrote: > > > Not sure how this works... but is this ONLY int-32 t

[PATCH] D132739: [clang][Interp] Implement IntegralToBoolean casts

tbaeder updated this revision to Diff 455897. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132739/new/ https://reviews.llvm.org/D132739 Files: clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Opcodes.td clang/test/AST/Interp/literals.c

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

inclyc updated this revision to Diff 455898. inclyc added a comment. Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132568/new/ https://reviews.llvm.org/D132568 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/FormatSt

[PATCH] D132739: [clang][Interp] Implement IntegralToBoolean casts

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/Opcodes.td:433 +def ToCastTypeClass : TypeClass { + let Types = [Sint32, Bool]; } tbaeder wrote: > erichkeane wrote: > > tbaeder wrote: > > > erichkeane wrote: > > > > Not sure how this works...

[clang] 01bebed - [Basic] Drop header-only dependency from Basic to Lex

Author: Benjamin Kramer Date: 2022-08-26T16:03:22+02:00 New Revision: 01bebedaf09bcb7b4f00b8d37a121e68316f9f59 URL: https://github.com/llvm/llvm-project/commit/01bebedaf09bcb7b4f00b8d37a121e68316f9f59 DIFF: https://github.com/llvm/llvm-project/commit/01bebedaf09bcb7b4f00b8d37a121e68316f9f59.dif

[clang] 8360174 - Fix the Sphinx build bot

Author: Aaron Ballman Date: 2022-08-26T10:04:57-04:00 New Revision: 8360174fb1a2d0ed759bb0a97708add44deddf92 URL: https://github.com/llvm/llvm-project/commit/8360174fb1a2d0ed759bb0a97708add44deddf92 DIFF: https://github.com/llvm/llvm-project/commit/8360174fb1a2d0ed759bb0a97708add44deddf92.diff

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

daltenty accepted this revision. daltenty added a comment. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119147/new/ https://reviews.llvm.org/D119147 ___ cfe-commits mailing list cfe-commits

[PATCH] D132607: [OffloadPackager] Add ability to extract mages from other file types

yaxunl added inline comments. Comment at: clang/tools/clang-offload-packager/ClangOffloadPackager.cpp:17-21 +#include "llvm/IR/Constants.h" +#include "llvm/IR/Module.h" +#include "llvm/IRReader/IRReader.h" +#include "llvm/Object/Archive.h" +#include "llvm/Object/ArchiveWriter.h"

[PATCH] D132607: [OffloadPackager] Add ability to extract mages from other file types

jhuber6 added inline comments. Comment at: clang/tools/clang-offload-packager/ClangOffloadPackager.cpp:17-21 +#include "llvm/IR/Constants.h" +#include "llvm/IR/Module.h" +#include "llvm/IRReader/IRReader.h" +#include "llvm/Object/Archive.h" +#include "llvm/Object/ArchiveWriter.h"

[PATCH] D132329: [X86][RFC] Using `__bf16` for AVX512_BF16 intrinsics

pengfei updated this revision to Diff 455906. pengfei added a comment. Address Yuanke's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132329/new/ https://reviews.llvm.org/D132329 Files: clang/include/clang/Basic/BuiltinsX86.def clang

[PATCH] D132329: [X86][RFC] Using `__bf16` for AVX512_BF16 intrinsics

pengfei added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2472 + case BuiltinType::BFloat16: +mangleArtificialTagType(TTK_Struct, "__bf16", {"__clang"}); LuoYuanke wrote: > This looks irrelative to the patch. The use of `__bf16` in intri

[PATCH] D132742: [X86][BF16] Add type mangling for Windows

pengfei created this revision. pengfei added reviewers: FreddyYe, LuoYuanke, craig.topper, RKSimon, skan. Herald added a subscriber: StephenFan. Herald added a project: All. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository

[clang] be19952 - Fix the lldb test bots

Author: Aaron Ballman Date: 2022-08-26T11:19:42-04:00 New Revision: be199527205dc8a8c7febc057ad6be90fac15547 URL: https://github.com/llvm/llvm-project/commit/be199527205dc8a8c7febc057ad6be90fac15547 DIFF: https://github.com/llvm/llvm-project/commit/be199527205dc8a8c7febc057ad6be90fac15547.diff

[PATCH] D132236: [analyzer] Fix liveness of LazyCompoundVals

steakhal added a comment. In D132236#3747652 , @NoQ wrote: > Nice catch but I don't think this is the right solution. > > Symbol liveness corresponds to a concrete runtime property of the program: > can the program obtain this value by executing further

[PATCH] D132723: [Clang] Fix crash in coverage of if consteval.

cor3ntin updated this revision to Diff 455917. cor3ntin added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132723/new/ https://reviews.llvm.org/D132723 Files: clang/docs/ReleaseNotes.rst clang/lib/CodeGen/CoverageMapping

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

usaxena95 updated this revision to Diff 455920. usaxena95 marked 11 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131154/new/ https://reviews.llvm.org/D131154 Files: clang-t

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticSelectionTests.cpp:391 +/* No folding for this comment. +*/ int b_token=0; + )cpp", kadircet wrote: > it'd be nice to have a test case like: > ``` > templ

[PATCH] D132723: [Clang] Fix crash in coverage of if consteval.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix! Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1407 // The 'else' count applies to the area immediately after the 'then'.

[PATCH] D132186: Clang: Add a new flag Wmisnoinline for printing hot noinline functions

tejohnson added a comment. In D132186#3750925 , @iamarchit123 wrote: > @paulkirth this change was done under the intuition that marking hot > functions noinline may hurt performance. This change till now hasn't been > tested for performance improvemen

[PATCH] D131979: [clang][UBSan] Fix __builtin_assume_aligned crash

yihanaa updated this revision to Diff 455918. yihanaa added a comment. Thanks John and Erich for your comments. In this update: Check args in Sema, and both in C and C++, emit an error if the 1st arg of __builtin_assume_aligned is volatile qualified or 1st arg not a pointer type. Remove getSubE

[PATCH] D132607: [OffloadPackager] Add ability to extract mages from other file types

jhuber6 updated this revision to Diff 455929. jhuber6 added a comment. Removing unused headers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132607/new/ https://reviews.llvm.org/D132607 Files: clang/test/Driver/offload-packager.c clang/tools/

[clang] 463e30f - [Clang] Fix crash in coverage of if consteval.

Author: Corentin Jabot Date: 2022-08-26T17:46:53+02:00 New Revision: 463e30f51fd07921f32c6630afb3f8dd18d6d2f5 URL: https://github.com/llvm/llvm-project/commit/463e30f51fd07921f32c6630afb3f8dd18d6d2f5 DIFF: https://github.com/llvm/llvm-project/commit/463e30f51fd07921f32c6630afb3f8dd18d6d2f5.diff

[PATCH] D132723: [Clang] Fix crash in coverage of if consteval.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG463e30f51fd0: [Clang] Fix crash in coverage of if consteval. (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D132723?vs=

[PATCH] D132745: [clang] Fix ambiguous use of `report_fatal_error`.

wyt created this revision. Herald added a project: All. wyt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `report_fatal_error` is overloaded on `StringRef` and `Twine &`, therefore passing a `std::string` argument leads to ambiguity as i

[PATCH] D132712: [Clang] Fix assert in Sema::LookupTemplateName so that it does not attempt an unconditional cast to TagType

shafik updated this revision to Diff 455935. shafik marked an inline comment as done. shafik added a comment. - Change to order of operations in assert to put off more costly check - Add release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132712/new/ https://reviews.llvm.org/D132

[clang] a0ecb4a - [HLSL] Move DXIL validation version out of ModuleFlags

Author: Xiang Li Date: 2022-08-26T09:20:45-07:00 New Revision: a0ecb4a2991d6163c16c29bee8cd63720ee7d3d7 URL: https://github.com/llvm/llvm-project/commit/a0ecb4a2991d6163c16c29bee8cd63720ee7d3d7 DIFF: https://github.com/llvm/llvm-project/commit/a0ecb4a2991d6163c16c29bee8cd63720ee7d3d7.diff LOG:

[PATCH] D130207: [HLSL] Move DXIL validation version out of ModuleFlags

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0ecb4a2991d: [HLSL] Move DXIL validation version out of ModuleFlags (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130207/new/ ht

[PATCH] D132712: [Clang] Fix assert in Sema::LookupTemplateName so that it does not attempt an unconditional cast to TagType

erichkeane accepted this revision. erichkeane added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132712/new/ https://reviews.llvm.org/D132712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

  1   2   >