[PATCH] D132030: [analyzer] Pass correct bldrCtx to computeObjectUnderConstruction

NoQ added a comment. Beautiful find, thanks! Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h:753 -SVal V = computeObjectUnderConstruction(E, State, LCtx, CC, CallOpts, Idx); +SVal V = computeObjectUnderConstruction(E, State, currBldrCtx

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

abrachet added a comment. While digging around failures we were seeing related to this I found some behavior that diverges from gcc. See https://godbolt.org/z/qe18Wh4jf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117616/new/ https://reviews.llvm

[PATCH] D132030: [analyzer] Pass correct bldrCtx to computeObjectUnderConstruction

tomasz-kaminski-sonarsource added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h:753 -SVal V = computeObjectUnderConstruction(E, State, LCtx, CC, CallOpts, Idx); +SVal V = computeObjectUnderConstruction(E, State, currBld

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

sunho added a comment. In D130788#3730533 , @sbc100 wrote: > I'm not totally sure but I think the change is responsible for the emscripten > integration bot failing `InterpreterTest.CatchException`: > https://logs.chromium.org/logs/emscripten-releases/b

[PATCH] D131618: [WIP][Do NOT review] LLD related changes for -ffat-lto-objects support

arda updated this revision to Diff 453550. arda added a comment. Use obj2yaml and yaml2obj to avoid unreadable object files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131618/new/ https://reviews.llvm.org/D131618 Files: clang/include/clang/Bas

[PATCH] D132031: Do not evaluate dependent immediate invocations

ilya-biryukov added a comment. A few NITS for the release notes, otherwise LG Comment at: clang/docs/ReleaseNotes.rst:162 (C++14 [dcl.constexpr]p6 (CWG DR647/CWG DR1358)) +- Correctly defer dependent immediate invocations until template instantiation. + This fixes `Issue 55

[PATCH] D132030: [analyzer] Pass correct bldrCtx to computeObjectUnderConstruction

tomasz-kaminski-sonarsource added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h:753 -SVal V = computeObjectUnderConstruction(E, State, LCtx, CC, CallOpts, Idx); +SVal V = computeObjectUnderConstruction(E, State, currBld

[PATCH] D132109: [analyzer] Dump the environment entry kind as well

steakhal created this revision. steakhal added a reviewer: NoQ. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All. steakhal reque

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

usaxena95 added a comment. I would like to see this land. This also fixes https://github.com/llvm/llvm-project/issues/57046. Are there any pending concerns of the reviewers which we need to address ? Happy to help in any way to move this patch forward. CC: @erichkeane @cor3ntin Repository:

[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

dmgreen added a comment. > Is there a formal requirement that LLVM must remain backward compatible with > older LLVM IR (beyond the target-independent parts)? We have always done it in the past, and I don't see a good reason to change. This change is essentially for llvm 16, so we are talking a

[PATCH] D126534: [analyzer] Deadstore static analysis: Fix false positive on C++17 assignments

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. It feels like there is no objection. I think it looks great and you did everything you could to address the review comments. I believe we should not postpone this any further. Consider comm

[clang] 6741f0f - Revert "[Driver] Support libc++ in MSVC"

Author: Petr Hosek Date: 2022-08-18T08:22:43Z New Revision: 6741f0f9124dd28e1a4bade173774fc47fb75912 URL: https://github.com/llvm/llvm-project/commit/6741f0f9124dd28e1a4bade173774fc47fb75912 DIFF: https://github.com/llvm/llvm-project/commit/6741f0f9124dd28e1a4bade173774fc47fb75912.diff LOG: Re

[PATCH] D132110: [IncludeCleaner] Handle more C++ constructs

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang-tools-extra. This brings IncludeCleaner's reference discovery from AST

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

cor3ntin added a comment. This looks good to me. I *think* landing things without doing silent sfinae for incomplete types is okay-ish, but I'd like to here from other folks. @royjacobson Have you looked into that? Do you know how involved would it be? Either way, we should make sure that if t

[PATCH] D132111: [clang][Interp] Implement pointer (de)ref operations and DeclRefExprs

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I wanted to do only pointers here, but they are impossible to test witho

[PATCH] D132031: Do not evaluate dependent immediate invocations

usaxena95 updated this revision to Diff 453562. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Updated release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132031/new/ https://reviews.llvm.org/D132031 Files: clang

[clang] 0e0e8b6 - Do not evaluate dependent immediate invocations

Author: Utkarsh Saxena Date: 2022-08-18T10:30:40+02:00 New Revision: 0e0e8b65765e32776a5188e96d1672baeb11b16c URL: https://github.com/llvm/llvm-project/commit/0e0e8b65765e32776a5188e96d1672baeb11b16c DIFF: https://github.com/llvm/llvm-project/commit/0e0e8b65765e32776a5188e96d1672baeb11b16c.diff

[PATCH] D132031: Do not evaluate dependent immediate invocations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e0e8b65765e: Do not evaluate dependent immediate invocations (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

sebastian-ne added a comment. In D130586#3731021 , @Ericson2314 wrote: > Anyone have any idea what this Debian test failure is about? I haven’t seen a passing debian pre-merge check for months now, so I usually ignore it (the failures seems to be relat

[PATCH] D131555: [Clang] Propagate const context info when emitting compound literal

stuij updated this revision to Diff 453579. stuij added a comment. addressed review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131555/new/ https://reviews.llvm.org/D131555 Files: clang/lib/CodeGen/CGExprConstant.cpp clang/lib/CodeGe

[PATCH] D132110: [IncludeCleaner] Handle more C++ constructs

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:55 + bool VisitMemberExpr(MemberExpr *E) { +auto *MD = E->getMemberDecl(); +report(E->getMemberLoc(), MD); nit: inline? Comment at: clang-to

[PATCH] D119651: [clang] Fix evaluation context type for consteval function calls in instantiations

usaxena95 added a comment. Herald added a project: All. Hi, I have been trying to get consteval in a better shape. In D119651#3327212 , @Izaron wrote: > After an investigation in GDB I can say that the assert seems to be wrong. > Since Clang instantiate

[PATCH] D131555: [Clang] Propagate const context info when emitting compound literal

stuij marked an inline comment as done. stuij added inline comments. Comment at: clang/test/CodeGen/const-init.c:2 +// setting strict FP behaviour in the run line below tests that the compiler +// does the right thing for global compound literals (compoundliteral test) +// RUN: %

[PATCH] D131175: [clangd] Use the "macro" semantic token for pre-defined identifiers

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Yeah, this seems reasonable to me. Wonder if we can support this in hover too! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131175/new/ h

[PATCH] D131555: [Clang] Propagate const context info when emitting compound literal

DavidSpickett accepted this revision. DavidSpickett added a comment. My comment was addressed, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131555/new/ https://reviews.llvm.org/D131555 ___ cfe-com

[PATCH] D130688: [Driver][Sparc] Default to -mcpu=v9 for SparcV8 on Linux

ro added a comment. It's almost three weeks since the last comments. Any suggestions on how to proceed with this patch? Given that the original issue (atomics not inlined with `-m32`) is now worked around by always linking with `--as-needed -latomic --no-as-needed`, the patch is no longer nee

[PATCH] D101156: [Clang] Support a user-defined __dso_handle

Tuxist added a comment. Herald added a project: All. i have a problem i'am implement a libc in c++ i can't export now __dso_handle as weak so I can't link other shared libs against my libc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101156/new/

[PATCH] D130688: [Driver][Sparc] Default to -mcpu=v9 for SparcV8 on Linux

glaubitz added a comment. In D130688#3731577 , @ro wrote: > It's almost three weeks since the last comments. Any suggestions on how to > proceed with this patch? Given that the original issue (atomics not inlined > with `-m32`) is now worked around by

[PATCH] D130688: [Driver][Sparc] Default to -mcpu=v9 for SparcV8 on Linux

ro added a comment. In D130688#3731611 , @glaubitz wrote: > > Yeah, someone from the LEON community should comment whether they would be OK > to default to V9 on all Linux targets. I don't really want to omit Gentoo > here which still support Linux

[PATCH] D130688: [Driver][Sparc] Default to -mcpu=v9 for SparcV8 on Linux

glaubitz added a comment. In D130688#3731619 , @ro wrote: > In D130688#3731611 , @glaubitz > wrote: > >> > > > >> Yeah, someone from the LEON community should comment whether they would be >> OK to default to V

[PATCH] D132111: [clang][Interp] Implement pointer (de)ref operations and DeclRefExprs

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:649 + return DiscardResult ? this->emitPop(T, E) : true; +}); case UO_Not:// ~x Handling the deref like this breaks assigning, e.g. `int m = 10; int *p = &

[clang] 27cbfa7 - [Clang] Propagate const context info when emitting compound literal

Author: Ties Stuij Date: 2022-08-18T11:25:20+01:00 New Revision: 27cbfa7cc8cdab121842adf4dd31f6811f523928 URL: https://github.com/llvm/llvm-project/commit/27cbfa7cc8cdab121842adf4dd31f6811f523928 DIFF: https://github.com/llvm/llvm-project/commit/27cbfa7cc8cdab121842adf4dd31f6811f523928.diff LO

[PATCH] D131555: [Clang] Propagate const context info when emitting compound literal

This revision was automatically updated to reflect the committed changes. stuij marked an inline comment as done. Closed by commit rG27cbfa7cc8cd: [Clang] Propagate const context info when emitting compound literal (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D130688: [Driver][Sparc] Default to -mcpu=v9 for SparcV8 on Linux

ro added a comment. In D130688#3731653 , @glaubitz wrote: > In D130688#3731619 , @ro wrote: > >> In D130688#3731611 , @glaubitz >> wrote: >> >>> >> >> >> >>> Yeah, someo

[PATCH] D132111: [clang][Interp] Implement pointer (de)ref operations and DeclRefExprs

tbaeder updated this revision to Diff 453610. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132111/new/ https://reviews.llvm.org/D132111 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/cxx20.cpp clang/test/AST/Interp/li

[PATCH] D131623: [clang-tidy] Improve modernize-use-emplace check

joeywatts added a comment. In D131623#3731106 , @njames93 wrote: > In D131623#3730833 , @joeywatts > wrote: > >> Thanks for the review @njames93! This is my first contribution so I don't >> think I have permissi

[PATCH] D132111: [clang][Interp] Implement pointer (de)ref operations and DeclRefExprs

tbaeder updated this revision to Diff 453617. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132111/new/ https://reviews.llvm.org/D132111 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/cxx20.cpp clang/test/AST/Interp/li

[PATCH] D132111: [clang][Interp] Implement pointer (de)ref operations and DeclRefExprs

tbaeder updated this revision to Diff 453618. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132111/new/ https://reviews.llvm.org/D132111 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/cxx20.cpp clang/test/AST/Interp/li

[PATCH] D132111: [clang][Interp] Implement pointer (de)ref operations and DeclRefExprs

tbaeder updated this revision to Diff 453619. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132111/new/ https://reviews.llvm.org/D132111 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/cxx20.cpp clang/test/AST/Interp/li

[PATCH] D131175: [clangd] Use the "macro" semantic token for pre-defined identifiers

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:546 + bool VisitPredefinedExpr(PredefinedExpr *E) { +H.addToken(E->getLocation(), HighlightingKind::Macro); +return true; actually, would HighlightingKind::Loc

[clang-tools-extra] 9ad0ace - [clang-tidy] Rename a local cmake variables to match the new tool name. NFC.

Author: Martin Storsjö Date: 2022-08-18T14:27:45+03:00 New Revision: 9ad0ace2ba52b2194090a0ec4dd980d604ea74b0 URL: https://github.com/llvm/llvm-project/commit/9ad0ace2ba52b2194090a0ec4dd980d604ea74b0 DIFF: https://github.com/llvm/llvm-project/commit/9ad0ace2ba52b2194090a0ec4dd980d604ea74b0.diff

[PATCH] D130701: [clang-tidy] Rename a local cmake variables to match the new tool name. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ad0ace2ba52: [clang-tidy] Rename a local cmake variables to match the new tool name. NFC. (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D131874: [Clang] Tighten restrictions on enum out of range diagnostic to avoid constant initialization

mstorsjo added a comment. Thanks! It seems like this now finally works as it should again, with the code I regularly build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131874/new/ https://reviews.llvm.org/D131874 ___

[PATCH] D132111: [clang][Interp] Implement pointer (de)ref operations and DeclRefExprs

tbaeder updated this revision to Diff 453624. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132111/new/ https://reviews.llvm.org/D132111 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/cxx20.cpp clang/test/AST/Interp/li

[PATCH] D131052: [CMake] Allow setting the location of host tools with LLVM_NATIVE_TOOL_DIR

mstorsjo added a comment. Ping - is there any interest in this - a single flag for pointing towards existing prebuilt native executables instead of having to name every one (llvm-tblgen, clang-tblgen, lldb-tblgen, clang-pseudo-gen, clang-tidy-confusable-chars-gen) individually? Repository:

[PATCH] D131052: [CMake] Allow setting the location of host tools with LLVM_NATIVE_TOOL_DIR

sammccall added a comment. FWIW I have no idea: in principle this makes sense, but I don't use such a configuration and don't have a clear idea of what people who do use it want. It also adds significant CMake complexity: e.g. clang-pseudo-gen now has 30 lines just to support the non-default "n

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 added a comment. OK I was worried the debuginfod one was unique to this PR; glad to hear it isn't. I'll give it a shot then, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/ https://reviews.llvm.org/D130586 __

[PATCH] D132110: [IncludeCleaner] Handle more C++ constructs

kadircet updated this revision to Diff 453638. kadircet marked 5 inline comments as done. kadircet added a comment. - Adress comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132110/new/ https://reviews.llvm.org/D132110 Files: clang-tools-e

[PATCH] D132110: [IncludeCleaner] Handle more C++ constructs

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:55 + bool VisitMemberExpr(MemberExpr *E) { +auto *MD = E->getMemberDecl(); +report(E->getMemberLoc(), MD); sammccall wrote: > sammccall wrote: > > nit: inline?

[PATCH] D131175: [clangd] Use the "macro" semantic token for pre-defined identifiers

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:546 + bool VisitPredefinedExpr(PredefinedExpr *E) { +H.addToken(E->getLocation(), HighlightingKind::Macro); +return true; sammccall wrote: > actually, would Hi

[PATCH] D132111: [clang][Interp] Implement pointer (de)ref operations and DeclRefExprs

erichkeane added subscribers: shafik, tahonermann. erichkeane added a comment. Just the 1 question for my info, Tests seem pretty complete for what is being looked at, but I'm hopeful someone else will take a look at this too. @shafik or @tahonermann want to take a pass so aaron doesn't have to

[PATCH] D132111: [clang][Interp] Implement pointer (de)ref operations and DeclRefExprs

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:215 +return false; + return DiscardResult ? this->emitPopPtr(BO) : true; default: erichkeane wrote: > Can you explain what this is doing for me? The `Store` oper

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

yusuke-kadowaki created this revision. Herald added a project: All. yusuke-kadowaki edited the summary of this revision. yusuke-kadowaki added reviewers: curdeius, MyDeveloperDay, HazardyKnusperkeks. yusuke-kadowaki published this revision for review. Herald added a project: clang. Herald added a s

[PATCH] D131175: [clangd] Use the "macro" semantic token for pre-defined identifiers

ckandeler updated this revision to Diff 453648. ckandeler added a comment. Use variable instead of macro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131175/new/ https://reviews.llvm.org/D131175 Files: clang-tools-extra/clangd/SemanticHighligh

[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

sdesmalen added a comment. Thanks for addressing the comments @CarolineConcatto! In D131547#3731310 , @dmgreen wrote: >> Is there a formal requirement that LLVM must remain backward compatible with >> older LLVM IR (beyond the target-independent parts)?

[PATCH] D131687: [AArch64] Replace aarch64_sve_ldN intrinsic by aarch64_sve_ldN.sret

sdesmalen added a comment. Can you also split this patch in two: - One for Clang where it will no longer use the legacy ld2/3/4 intrinsics - One for LLVM where it removes the old intrinsics and AutoUpgrades the old intrinsics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131175: [clangd] Use the "macro" semantic token for pre-defined identifiers

sammccall added a comment. (thanks, still LG) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131175/new/ https://reviews.llvm.org/D131175 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D132135: [clangd] Support hover on __func__ etc (PredefinedExpr)

sammccall created this revision. sammccall added a reviewer: ckandeler. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Expose th

[PATCH] D131175: [clangd] Use the "macro" semantic token for pre-defined identifiers

ckandeler marked an inline comment as not done. ckandeler added a comment. Thanks for the review. Can you please merge it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131175/new/ https://reviews.llvm.org/D131175 _

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

tbaeder created this revision. tbaeder added reviewers: erichkeane, aaron.ballman, shafik, tahonermann. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Extra bonus patch. The EvaluateAsRValue() document

[PATCH] D132135: [clangd] Support hover on __func__ etc (PredefinedExpr)

sammccall updated this revision to Diff 453652. sammccall added a comment. fix type to be const in both c & c++, not sure where I got that idea from... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132135/new/ https://reviews.llvm.org/D132135 File

[clang-tools-extra] 1c056f8 - [clangd] Use the "macro" semantic token for pre-defined identifiers

Author: Christian Kandeler Date: 2022-08-18T16:12:55+02:00 New Revision: 1c056f8df26b542b21b61a538203244215701113 URL: https://github.com/llvm/llvm-project/commit/1c056f8df26b542b21b61a538203244215701113 DIFF: https://github.com/llvm/llvm-project/commit/1c056f8df26b542b21b61a538203244215701113.

[PATCH] D131175: [clangd] Use the "macro" semantic token for pre-defined identifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c056f8df26b: [clangd] Use the "macro" semantic token for pre-defined identifiers (authored by ckandeler, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D131175: [clangd] Use the "macro" semantic token for pre-defined identifiers

sammccall added a comment. Sure thing! Also sent D132135 to support hover. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131175/new/ https://reviews.llvm.org/D131175 _

[PATCH] D131662: [clang] Try to improve diagnostics about uninitialized constexpr variables

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaFixItUtils.cpp:208-210 + if (T->isArrayType()) { +return " = {}"; + } tbaeder wrote: > aaron.ballman wrote: > > I don't think this is a good change, consider: > > ``` > > int array[] = {};

[PATCH] D132056: [HLSL] Restrict to supported targets

aaron.ballman added reviewers: ABataev, Anastasia. aaron.ballman added a comment. I don't have particular concerns FWIW, but I'm not certain if others have opinions so I'm holding off on accepting for a bit. Comment at: clang/test/Driver/hlsl-lang-targets.hlsl:14 + +// Maybe s

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131084/new/ https://reviews.llvm.org/D131084 ___ cfe-commits mailing list cfe-comm

[PATCH] D130510: Missing tautological compare warnings due to unary operators

aaron.ballman added a comment. In D130510#3729864 , @rtrieu wrote: > In D130510#3728719 , @aaron.ballman > wrote: > >> In D130510#3727096 , @rtrieu wrote: >> >>> This pat

[PATCH] D132135: [clangd] Support hover on __func__ etc (PredefinedExpr)

ckandeler accepted this revision. ckandeler added a comment. This revision is now accepted and ready to land. Works fine for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132135/new/ https://reviews.llvm.org/D132135 ___

[PATCH] D131175: [clangd] Use the "macro" semantic token for pre-defined identifiers

ckandeler added a comment. By the way: How do I change the commit message when using arc? It seems to ignore all subsequent changes other than in the code itself, and now the patch is in the repo with a misleading commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

vaibhav.y added a comment. Thank you! I don't have merge access, will need your help for that :) For the commit details, I'd like to use: - Name: Vaibhav Yenamandra - email address: vyenaman...@bloomberg.net Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D131662: [clang] Try to improve diagnostics about uninitialized constexpr variables

tbaeder updated this revision to Diff 453664. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131662/new/ https://reviews.llvm.org/D131662 Files: clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/SemaInit.cpp clang/test/CXX/dcl.dcl/dcl.spec/dcl.constexpr/p1.cpp clang/test/CXX/dcl.dcl/dcl.

[PATCH] D131662: [clang] Try to improve diagnostics about uninitialized constexpr variables

tbaeder added a comment. The new version also gets the new error message for `constexpr int foo[2];`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131662/new/ https://reviews.llvm.org/D131662 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

tstellar added a subscriber: thieta. tstellar added a comment. @dblaikie Is there anything we need to do in the release branch for this still? cc @thieta Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117616/new/ https://reviews.llvm.org/D117616 _

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

dblaikie added a comment. In D117616#3732173 , @tstellar wrote: > @dblaikie Is there anything we need to do in the release branch for this > still? cc @thieta Sorry, yeah, I'd tagged you over here: https://reviews.llvm.org/D118511#3717753 for part of t

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

tstellar added a comment. @dblaikie Can you file a bug and add the 15.0.0 Release Milestone, so we don't forget to fix this in the release branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118511/new/ https://reviews.llvm.org/D118511

[PATCH] D132140: [AMDGPU] Add builtin s_sendmsg_rtn_b{32|64}

yaxunl created this revision. yaxunl added reviewers: b-sumner, arsenm, foad, kzhuravl, bcahoon. Herald added subscribers: kosarev, kerbowa, t-tye, tpr, dstuttard, jvesely. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: wdng. https://reviews.llvm.

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

yubing created this revision. Herald added a subscriber: pengfei. Herald added a project: All. yubing requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D132141 Files: clang/li

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3042 + + if (!(Simdlen == nullptr && Safelen == nullptr)) { +// If both simdlen and safelen clauses ar

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

craig.topper added inline comments. Comment at: clang/lib/Headers/immintrin.h:301 + unsigned long long tmp; + if (__builtin_ia32_rdrand32_step((unsigned int *)&tmp) & + __builtin_ia32_rdrand32_step(((unsigned int *)&tmp) + 1)) { Should `&` be `&&`? =

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

dblaikie added a comment. In D117616#3731188 , @abrachet wrote: > While digging around failures we were seeing related to this I found some > behavior that diverges from gcc. See https://godbolt.org/z/qe18Wh4jf thanks for the bug report, yeah - looks li

[PATCH] D132140: [AMDGPU] Add builtin s_sendmsg_rtn_b{32|64}

b-sumner added a comment. Following existing naming, it might make sense to rename "rtn_b32" --> "rtn" and "rtn_b64" --> "rtnl". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132140/new/ https://reviews.llvm.org/D132140 ___ cfe-commits maili

[PATCH] D132142: [analyzer] Prefer wrapping SymbolicRegions by ElementRegions

steakhal created this revision. steakhal added reviewers: NoQ, martong, ASDenysPetrov, Szelethus, isuckatcs, vabridgers. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. steakhal requeste

[PATCH] D132143: [analyzer] LazyCompoundVals should be always bound as default bindings

steakhal created this revision. steakhal added reviewers: NoQ, xazax.hun, ASDenysPetrov, martong, isuckatcs, vabridgers, Szelethus. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: All. steakhal requeste

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

RKSimon added inline comments. Comment at: clang/lib/Headers/immintrin.h:301 + unsigned long long tmp; + if (__builtin_ia32_rdrand32_step((unsigned int *)&tmp) & + __builtin_ia32_rdrand32_step(((unsigned int *)&tmp) + 1)) { craig.topper wrote: > craig.topp

[PATCH] D132140: [AMDGPU] Add builtin s_sendmsg_rtn_b{32|64}

yaxunl added a comment. In D132140#3732262 , @b-sumner wrote: > Following existing naming, it might make sense to rename "rtn_b32" --> "rtn" > and "rtn_b64" --> "rtnl". will modify. thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132140/

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

sbc100 added a comment. In D130788#3731232 , @sunho wrote: > In D130788#3730533 , @sbc100 wrote: > >> I'm not totally sure but I think the change is responsible for the >> emscripten integration bot failing `Inte

[PATCH] D132140: [AMDGPU] Add builtin s_sendmsg_rtn_b{32|64}

yaxunl updated this revision to Diff 453681. yaxunl added a comment. revised by Brian's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132140/new/ https://reviews.llvm.org/D132140 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def clang/lib/CodeGen/CGBuiltin.cpp clang/te

[PATCH] D131175: [clangd] Use the "macro" semantic token for pre-defined identifiers

sammccall added a comment. In D131175#3732163 , @ckandeler wrote: > By the way: How do I change the commit message when using arc? It seems to > ignore all subsequent changes other than in the code itself, and now the > patch is in the repo with a misle

[clang-tools-extra] 7f2a079 - [clangd] Fix a tsan failure in PreambleThrottle tests

Author: Kadir Cetinkaya Date: 2022-08-18T18:36:01+02:00 New Revision: 7f2a079a122b5f3abd4afa6697e951616dca768b URL: https://github.com/llvm/llvm-project/commit/7f2a079a122b5f3abd4afa6697e951616dca768b DIFF: https://github.com/llvm/llvm-project/commit/7f2a079a122b5f3abd4afa6697e951616dca768b.dif

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaron.ballman added a comment. Thank you for your patience on the review! I've taken a cursory look through and I'm still thinking about the patch. I've not seen anything that's really worrying. But this is pretty dense stuff and @delesley has way more experience with TIL, so I'm hoping he migh

[PATCH] D132144: [Clang][BPF] Support record argument with direct values

yonghong-song created this revision. yonghong-song added a reviewer: ast. Herald added subscribers: pengfei, kristof.beyls. Herald added a project: All. yonghong-song requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, record argumen

[PATCH] D131662: [clang] Try to improve diagnostics about uninitialized constexpr variables

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though you should add a release note. Comment at: clang/lib/Sema/SemaInit.cpp:8057 +const Decl *D = Entity.getDecl(); +const VarDecl *VD = dyn_cas

[PATCH] D131203: [HLSL] Initial codegen for SV_GroupIndex

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:94 llvm::Function *F, const FunctionDecl *FD) { - if (HLSLShaderAttr *ShaderAttr = FD->getAttr()) { -const StringRef ShaderAttrKindStr = "dx.shader"; -F->addFnAttr(ShaderAttrKindStr

[PATCH] D131614: [clang][dataflow] Extend transfer functions for other `CFGElement`s

wyt updated this revision to Diff 453702. wyt marked 2 inline comments as done. wyt added a comment. Address comments. Unable to rename `check/runDataflowOnCFG` to `check/runDataflow` currently due to ambiguous use. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D131616: [clang][dataflow] Generalise match switch utility to other AST types and add a `CFGMatchSwitch` which currently handles `CFGStmt` and `CFGInitializer`.

wyt updated this revision to Diff 453704. wyt marked 5 inline comments as done. wyt added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131616/new/ https://reviews.llvm.org/D131616 Files: clang/include/clang/Analysis

[PATCH] D132147: [clang][dataflow] Refactor `TestingSupport.h`

wyt created this revision. Herald added subscribers: martong, xazax.hun. Herald added a project: All. wyt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Add `AnalysisArguments` struct for `checkDataflow`. - Remove compulsory binding fro

[PATCH] D130207: [HLSL] Move DXIL validation version out of ModuleFlags

beanz added a comment. A few nitpicks, otherwise this looks good. Comment at: llvm/lib/Target/DirectX/DXILTranslateMetadata.cpp:61 -static void cleanModuleFlags(Module &M) { - constexpr StringLiteral DeadKeys[] = {ValVerKey}; - // Collect DeadKeys in ModuleFlags. - StringS

[PATCH] D132147: [clang][dataflow] Refactor `TestingSupport.h`

wyt updated this revision to Diff 453708. wyt added a comment. Small fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132147/new/ https://reviews.llvm.org/D132147 Files: clang/unittests/Analysis/FlowSensitive/TestingSupport.cpp clang/unitt

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

steplong added a comment. @thakis @hans What do you both think of the latest version? I would like to get this merged Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127641/new/ https://reviews.llvm.org/D127641 _

  1   2   3   >