erichkeane added subscribers: shafik, tahonermann.
erichkeane added a comment.

Just the 1 question for my info, Tests seem pretty complete for what is being 
looked at, but I'm hopeful someone else will take a look at this too.  @shafik 
or @tahonermann want to take a pass so aaron doesn't have to?



================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:215
+        return false;
+      return DiscardResult ? this->emitPopPtr(BO) : true;
     default:
----------------
Can you explain what this is doing for me?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132111/new/

https://reviews.llvm.org/D132111

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to