[clang] ebe0674 - [clang] Try to fix builders

Author: Timm Bäder Date: 2022-08-11T09:07:44+02:00 New Revision: ebe0674acb8bb3404d0e2a6b689d5e3cd02bb0b6 URL: https://github.com/llvm/llvm-project/commit/ebe0674acb8bb3404d0e2a6b689d5e3cd02bb0b6 DIFF: https://github.com/llvm/llvm-project/commit/ebe0674acb8bb3404d0e2a6b689d5e3cd02bb0b6.diff LO

[PATCH] D130894: [clang] Print more information about failed static assertions

mstorsjo added a comment. This broke building with GCC (also noted by buildbot mails): ../tools/clang/lib/Sema/SemaDeclCXX.cpp: In member function ‘void clang::Sema::DiagnoseStaticAssertDetails(const clang::Expr*)’: ../tools/clang/lib/Sema/SemaDeclCXX.cpp:1:19: error: declaration of ‘co

[PATCH] D130894: [clang] Print more information about failed static assertions

xbolva00 added a comment. In D130894#3715124 , @mstorsjo wrote: > This broke building with GCC (also noted by buildbot mails): > > ../tools/clang/lib/Sema/SemaDeclCXX.cpp: In member function ‘void > clang::Sema::DiagnoseStaticAssertDetails(const clang:

[PATCH] D130969: [clang] [HLSL] Fix GCC warnings about virtual methods that are hidden

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d89f9044392: [clang] [HLSL] Fix GCC warnings about virtual methods that are hidden (authored by mstorsjo). Repository: rG LLVM Github Monorepo C

[clang] 5d89f90 - [clang] [HLSL] Fix GCC warnings about virtual methods that are hidden

Author: Martin Storsjö Date: 2022-08-11T10:15:13+03:00 New Revision: 5d89f9044392db3838348a3f44e2723e3436dd28 URL: https://github.com/llvm/llvm-project/commit/5d89f9044392db3838348a3f44e2723e3436dd28 DIFF: https://github.com/llvm/llvm-project/commit/5d89f9044392db3838348a3f44e2723e3436dd28.diff

[PATCH] D131388: [docs] Add "C++20 Modules"

ChuanqiXu updated this revision to Diff 451750. ChuanqiXu marked 2 inline comments as done. ChuanqiXu added a comment. Address comments: - Change `module file` to `BMI`. - Replace `rm -f` with `rm`. - Add a conclusion paragraph to the `How module speed up compilation` section. CHANGES SINCE LAS

[PATCH] D131388: [docs] Add "C++20 Modules"

ChuanqiXu added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:665 + # This is not allowed! + $ clang++ iostream.pcm -c -o iostream.o + dblaikie wrote: > could this use a strikethrough, perhaps? (not sure if you can strikethrough > inside a co

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

glandium added a comment. Having looked around in the Firefox codebase for cases that now fail to build because of this, and looking at the clarification in DR2338, I wonder if enums in `extern "C"` sections should be treated as if they had an explicit type of `int` as if it were e.g. `enum Foo

[PATCH] D131655: [analyzer] Nullability: Enable analysis of non-inlined nullable objc properties.

NoQ created this revision. NoQ added reviewers: t-rasmud, usama54321, ziqingluo-90, malavikasamak, xazax.hun. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project

[PATCH] D131065: [clang][dataflow] Store DeclContext of block being analysed in Environment if available.

wyt updated this revision to Diff 451754. wyt added a comment. Initialise DeclCtx field with nullptr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131065/new/ https://reviews.llvm.org/D131065 Files: clang/include/clang/Analysis/FlowSensitive/Da

[PATCH] D131528: [Clang] Restrict non fixed enum to a value outside the range of the enumeration values warning to context requiring a constant expression

mstorsjo added a comment. There are still some cases that were broken by D131307 , that aren't fixed by this patch. Building https://martin.st/temp/qt-enum.cpp with `clang -target i686-w64-mingw32 -c -std=c++17 qt-enum.cpp -Wno-ignored-attributes -Wno-user-defi

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

h-vetinari added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123967/new/ https://reviews.llvm.org/D123967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] 2cb5144 - [clang][dataflow] Store DeclContext of block being analysed in Environment if available.

Author: Wei Yi Tee Date: 2022-08-11T07:36:57Z New Revision: 2cb51449f0d9ed06de87b4a47b5074eb6eec2e23 URL: https://github.com/llvm/llvm-project/commit/2cb51449f0d9ed06de87b4a47b5074eb6eec2e23 DIFF: https://github.com/llvm/llvm-project/commit/2cb51449f0d9ed06de87b4a47b5074eb6eec2e23.diff LOG: [c

[PATCH] D131065: [clang][dataflow] Store DeclContext of block being analysed in Environment if available.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2cb51449f0d9: [clang][dataflow] Store DeclContext of block being analysed in Environment if… (authored by wyt). Repository: rG LLVM Github Monorep

[PATCH] D131134: [X86] Report error if the amx enabled on the non-64-bits target

pengfei added a comment. In D131134#3715079 , @craig.topper wrote: > In D131134#3715062 , @pengfei wrote: > >> In D131134#3715024 , @pengfei >> wrote: >> >>> In D131134#

[PATCH] D131448: Introduce iterator sentinel to make graph traversal implementation more efficient and cleaner

rusyaev-roman added a comment. First of all, thank you for your feedback! I've tried to address all your comments. Comment at: llvm/include/llvm/ADT/BreadthFirstIterator.h:128-131 + bool operator==(iterator_sentinel) const { return VisitQueue.empty(); } + + bool operator!=(i

[PATCH] D131657: Remove redundant condition check, NFC

junaire created this revision. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Jun Zhang Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D131657 Files: clang/lib/Pars

[PATCH] D131563: [WIP] [clang] Fix clang multiarch isssue with musl

listout updated this revision to Diff 451757. listout added a comment. Using `getEnvironmentTypeName()` instead of `isMusl()` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131563/new/ https://reviews.llvm.org/D131563 Files: clang/lib/Driver/ToolChains/Linux.cpp Index: clang/lib/Dri

[PATCH] D131563: [WIP] [clang] Fix clang multiarch isssue with musl

listout marked an inline comment as done. listout added a comment. @barannikov88 made some changes. What do you think? Comment at: clang/lib/Driver/ToolChains/Linux.cpp:49 + std::string EnvName = TargetTriple.isMusl() ? "musl" : "gnu"; + barannikov88 wrote:

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

carlosgalvezp updated this revision to Diff 451760. carlosgalvezp added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126880/new/ https://reviews.llvm.org/D126880 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCons

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

bigdavedev accepted this revision. bigdavedev added a comment. LGTM. All comments have been addressed. Any improvements to the diagnostics can be made down the line depending on how users feel about them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang-tools-extra] 9ae5896 - [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

Author: Carlos Galvez Date: 2022-08-11T07:46:04Z New Revision: 9ae5896d9673a54f4a6cf656624891bafc192857 URL: https://github.com/llvm/llvm-project/commit/9ae5896d9673a54f4a6cf656624891bafc192857 DIFF: https://github.com/llvm/llvm-project/commit/9ae5896d9673a54f4a6cf656624891bafc192857.diff LOG:

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ae5896d9673: [clang-tidy] Add cppcoreguidelines-avoid-const-or-re

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

ChuanqiXu added a comment. In D126907#3712363 , @erichkeane wrote: > In D126907#3711956 , @ChuanqiXu > wrote: > >> In D126907#3710656 , @erichkeane >> wrote: >> >>> Ok,

[PATCH] D131555: [Clang] Propagate const context info when emitting compound literal

stuij updated this revision to Diff 451781. stuij added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131555/new/ https://reviews.llvm.org/D131555 Files: clang/lib/CodeGen/CGExprConstant.cpp clang/lib/CodeG

[PATCH] D131555: [Clang] Propagate const context info when emitting compound literal

stuij updated this revision to Diff 451783. stuij marked an inline comment as done. stuij added a comment. also added a comment above the runline. Initially thought it wouldn't be necessary as we're now doing a check, but I do agree that it's more clear to be specific about the cmdline arg. Re

[PATCH] D131662: [clang] Try to improve diagnostics about uninitialized constexpr variables

tbaeder created this revision. tbaeder added a reviewer: aaron.ballman. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Consider: constexpr int a; the error message for this is currently: error: d

[PATCH] D131555: [Clang] Propagate const context info when emitting compound literal

vhscampos added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:2217 assert(E->isFileScope() && "not a file-scope compound literal expr"); - return tryEmitGlobalCompoundLiteral(*this, nullptr, E); + ConstantEmitter emitter(*this, nullptr); + return tryEmit

[PATCH] D131555: [Clang] Propagate const context info when emitting compound literal

vhscampos added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:2217 assert(E->isFileScope() && "not a file-scope compound literal expr"); - return tryEmitGlobalCompoundLiteral(*this, nullptr, E); + ConstantEmitter emitter(*this, nullptr); + return tryEmit

[PATCH] D130701: [clang-tidy] Rename a local cmake variables to match the new tool name. NFC.

mstorsjo added a comment. Ping @sammccall (although I guess I could just go ahead and commit this as it is quite trivial, but as I sent it out for review in the first place...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130701/new/ https://rev

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo updated this revision to Diff 451785. dongjunduo added a comment. [Clang] add -### for debug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131469/new/ https://reviews.llvm.org/D131469 Files: clang/lib/Driver/Driver.cpp clang/test/Dr

[PATCH] D131580: [clang][SVE] Undefine preprocessor macro defined in

mgabka updated this revision to Diff 451791. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131580/new/ https://reviews.llvm.org/D131580 Files: clang/utils/TableGen/SveEmitter.cpp Index: clang/utils/TableGen/SveEmitter.cpp ===

[PATCH] D131580: [clang][SVE] Undefine preprocessor macro defined in

mgabka marked an inline comment as done. mgabka added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:1285 OS << "#endif\n\n"; + OS << "#undef __ai\n\n"; OS << "#endif /*__ARM_FEATURE_SVE */\n\n"; paulwalker-arm wrote: > Can you also do th

[PATCH] D90275: [clang][IR] Add support for leaf attribute

xbolva00 added a comment. Was there any follow up? It seems that this hint (attribute) is currently not used by LLVM passes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90275/new/ https://reviews.llvm.org/D90275

[PATCH] D131555: [Clang] Propagate const context info when emitting compound literal

stuij updated this revision to Diff 451794. stuij added a comment. addressed review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131555/new/ https://reviews.llvm.org/D131555 Files: clang/lib/CodeGen/CGExprConstant.cpp clang/lib/CodeGe

[PATCH] D131555: [Clang] Propagate const context info when emitting compound literal

stuij marked 2 inline comments as done. stuij added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:2217 assert(E->isFileScope() && "not a file-scope compound literal expr"); - return tryEmitGlobalCompoundLiteral(*this, nullptr, E); + ConstantEmitter emitte

[PATCH] D130689: [LLVM] Update C++ standard to 17

xbolva00 added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:57 + +* GCC >= 7.1 +* Clang >= 5.0 Do we have bots which uses last supported compiler versions? GCC 7.1, Clang 5.0 and MSVC 16.7. It is bad to promise something and then breakages here and t

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo updated this revision to Diff 451796. dongjunduo added a comment. Add more debug info Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131469/new/ https://reviews.llvm.org/D131469 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/ch

[PATCH] D131665: [CMake] Support passing arguments to build tool (bootstrap).

CarlosAlbertoEnciso created this revision. CarlosAlbertoEnciso added reviewers: andrewng, phosek, beanz, russell.gallop. CarlosAlbertoEnciso added a project: LLVM. Herald added a subscriber: mgorny. Herald added a project: All. CarlosAlbertoEnciso requested review of this revision. Herald added a p

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:57 + +* GCC >= 7.1 +* Clang >= 5.0 xbolva00 wrote: > Do we have bots which uses last supported compiler versions? GCC 7.1, Clang > 5.0 and MSVC 16.7. > > It is bad to promise something and the

[PATCH] D131614: [clang][dataflow] Extend transfer functions for other `CFGElement`s

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:103 + virtual void transferCFGElement(const CFGElement *Element, Lattice &L, + Environment &Env) {} + Instead of adding v

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 451799. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang-tools-extra/clangd/unittests/ASTTests.cpp clang-

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added a comment. In D111283#3712348 , @erichkeane wrote: > This is a sizable patch, and it isn't really clear from context what I'm > looking at. Can you please improve the description/commit message to better > clarify what you are trying to

[clang-tools-extra] e935f7f - [pseudo] Fix a bug in checking the duplicated grammar rules.

Author: Haojian Wu Date: 2022-08-11T13:16:01+02:00 New Revision: e935f7fd0cbc698438bdabc3b836ab25baa9a174 URL: https://github.com/llvm/llvm-project/commit/e935f7fd0cbc698438bdabc3b836ab25baa9a174 DIFF: https://github.com/llvm/llvm-project/commit/e935f7fd0cbc698438bdabc3b836ab25baa9a174.diff LO

[PATCH] D130363: [clang] Give priority to Class context while parsing declarations

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! let me know if i should land this for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130363/new/ https://reviews.llvm.org/

[clang] ef110a4 - [Builtins] Do not claim most libfuncs are readnone with trapping math.

Author: Florian Hahn Date: 2022-08-11T12:29:01+01:00 New Revision: ef110a491f702e84d3f97e7cde6dacea99fd238d URL: https://github.com/llvm/llvm-project/commit/ef110a491f702e84d3f97e7cde6dacea99fd238d DIFF: https://github.com/llvm/llvm-project/commit/ef110a491f702e84d3f97e7cde6dacea99fd238d.diff

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

This revision was automatically updated to reflect the committed changes. Closed by commit rGef110a491f70: [Builtins] Do not claim most libfuncs are readnone with trapping math. (authored by fhahn). Changed prior to commit: https://reviews.llvm.org/D129231?vs=448628&id=451800#toc Repository:

[PATCH] D131657: Remove redundant condition check, NFC

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LTGM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131657/new/ https://reviews.llvm.org/D131657

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

fhahn added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1409 -LIBBUILTIN(round, "dd", "fnc", "math.h", ALL_LANGUAGES) -LIBBUILTIN(roundf, "ff", "fnc", "math.h", ALL_LANGUAGES) -LIBBUILTIN(roundl, "LdLd", "fnc", "math.h", ALL_LANGUAGES) +LIBBUILTIN(round,

[clang] 7309e8c - Do not use the same identifier for a data member as a type; NFC

Author: Aaron Ballman Date: 2022-08-11T07:32:32-04:00 New Revision: 7309e8cfbe59844b4e0128c3f48eb1a68d8bad68 URL: https://github.com/llvm/llvm-project/commit/7309e8cfbe59844b4e0128c3f48eb1a68d8bad68 DIFF: https://github.com/llvm/llvm-project/commit/7309e8cfbe59844b4e0128c3f48eb1a68d8bad68.diff

[PATCH] D130894: [clang] Print more information about failed static assertions

aaron.ballman added a comment. In D130894#3715143 , @xbolva00 wrote: > In D130894#3715124 , @mstorsjo > wrote: > >> This broke building with GCC (also noted by buildbot mails): >> >> ../tools/clang/lib/Sema/Sem

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo updated this revision to Diff 451804. dongjunduo added a comment. Add more debug info Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131469/new/ https://reviews.llvm.org/D131469 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/ch

[PATCH] D131194: [C++20] Fix crash-on-valid with consteval temporary construction through list initialization

aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131194/new/ https://reviews.llvm.org/D131194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D130894: [clang] Print more information about failed static assertions

mstorsjo added a comment. In D130894#3715709 , @aaron.ballman wrote: > In D130894#3715143 , @xbolva00 > wrote: > >> In D130894#3715124 , @mstorsjo >> wrote: >> >>> This

[PATCH] D130894: [clang] Print more information about failed static assertions

aaron.ballman added a comment. In D130894#3715725 , @mstorsjo wrote: > In D130894#3715709 , @aaron.ballman > wrote: > >> In D130894#3715143 , @xbolva00 >> wrote: >> >>>

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

aaron.ballman added a comment. In D130058#3714880 , @glandium wrote: > In D130058#3714672 , @glandium > wrote: > >> This catches >> https://searchfox.org/mozilla-central/rev/c77834ec635c523f2ba0092fcd1728c9b1c30

[PATCH] D131479: Handle explicitly defaulted consteval special members.

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:805 +void func() { + default_ctor fail0; // expected-error-re {{call to consteval function '{{.*::default_ctor<.*::foo>}}::default_ctor' is not a constant expression}} \ +

[PATCH] D131396: [pseudo] Use C++17 variant to simplify the DirectiveTree::Chunk class, NFC.

hokein updated this revision to Diff 451811. hokein marked 2 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131396/new/ https://reviews.llvm.org/D131396 Files: clang-tools-extra/p

[PATCH] D131569: [clangd] Allow updates to be canceled after compile flags retrieval

adamcz added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:898 +if (isCancelled()) { + log("ASTWorker skipping update {0} for file {1}", Inputs.Version, + FileName); I'd add something like "due to cancellation". I know yo

[clang-tools-extra] bf0e219 - [pseudo] Use C++17 variant to simplify the DirectiveTree::Chunk class, NFC.

Author: Haojian Wu Date: 2022-08-11T14:27:38+02:00 New Revision: bf0e219d0481212ad12667262ed0b27e5e69f5f2 URL: https://github.com/llvm/llvm-project/commit/bf0e219d0481212ad12667262ed0b27e5e69f5f2 DIFF: https://github.com/llvm/llvm-project/commit/bf0e219d0481212ad12667262ed0b27e5e69f5f2.diff LO

[PATCH] D131396: [pseudo] Use C++17 variant to simplify the DirectiveTree::Chunk class, NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rGbf0e219d0481: [pseudo] Use C++17 variant to simplify the DirectiveTree::Chunk class, NFC. (authored by hokei

[PATCH] D131091: [clang][index] Index unresolved member expression as reference

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131091/new/ https://reviews.llvm.org/D131091

[PATCH] D131528: [Clang] Restrict non fixed enum to a value outside the range of the enumeration values warning to context requiring a constant expression

thakis added a comment. We're also still seeing the diag fire after this: https://ci.chromium.org/p/chromium/builders/ci/ToTLinux (And we cleaned up our codebase back when it was still an error.) Our bots have been red since the change to turn this into a warning landed. Repository: rG LLVM

[PATCH] D131646: [clang][dataflow] Restructure loops to call widen on back edges

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Nice! Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:180 + assert(Block->pred_size() == 2); + BackEdge = Pred; +} ---

[PATCH] D131351: [C] Default implicit function pointer conversions diagnostic to be an error

aaron.ballman added a comment. In D131351#3714968 , @brooksmoses wrote: > For the record, so far we've seen this showing up in the following: > > - A case in a notoriously warning-heavy third-party library where we'd > backported a file from a newer ver

[PATCH] D131645: [clang][dataflow] Allow user-provided lattices to provide a widen operator

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:119 + std::unique_ptr AST = + tooling::buildASTFromCodeWithArgs("int x = 0;

[PATCH] D130894: [clang] Print more information about failed static assertions

xbolva00 added a comment. Btw, https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1697r0.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130894/new/ https://reviews.llvm.org/D130894 ___ cfe-co

[PATCH] D131580: [clang][SVE] Undefine preprocessor macro defined in

mgabka marked an inline comment as done. mgabka added a comment. It is a fix for https://github.com/llvm/llvm-project/issues/57083 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131580/new/ https://reviews.llvm.org/D131580 _

[PATCH] D130894: [clang] Print more information about failed static assertions

aaron.ballman added a comment. In D130894#3715884 , @xbolva00 wrote: > Btw, > > https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1697r0.html Yup, that paper is currently closed in the WG21 paper tracker FWIW. Repository: rG LLVM Github Monor

[PATCH] D130363: [clang] Give priority to Class context while parsing declarations

furkanusta marked an inline comment as not done. furkanusta added a comment. That would be great, thanks Comment at: clang/test/CodeCompletion/overrides.cpp:41 +// Runs completion at empty line on line 13. +// RUN: %clang_cc1 -fsyntax-only -code-completion-patterns -code-compl

[clang] eb91fd5 - [clang][dataflow] Analyze constructor bodies

Author: Sam Estep Date: 2022-08-11T12:46:20Z New Revision: eb91fd5cbc6995099bd38c04c839686cbdd18b92 URL: https://github.com/llvm/llvm-project/commit/eb91fd5cbc6995099bd38c04c839686cbdd18b92 DIFF: https://github.com/llvm/llvm-project/commit/eb91fd5cbc6995099bd38c04c839686cbdd18b92.diff LOG: [cl

[PATCH] D131675: [clang] SIGSEGV fix at clang::ASTContext::getRawCommentForDeclNoCacheImpl

ivanmurashko created this revision. ivanmurashko added reviewers: sammccall, aaron.ballman. Herald added subscribers: usaxena95, kadircet. Herald added a project: All. ivanmurashko requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang

[clang] d09d4bd - [clang][dataflow] Don't crash when caller args are missing storage locations

Author: Sam Estep Date: 2022-08-11T13:00:42Z New Revision: d09d4bd66c864d58b29d74918a4a164f3ad905de URL: https://github.com/llvm/llvm-project/commit/d09d4bd66c864d58b29d74918a4a164f3ad905de DIFF: https://github.com/llvm/llvm-project/commit/d09d4bd66c864d58b29d74918a4a164f3ad905de.diff LOG: [cl

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

jamieschmeiser added a comment. You should not have debugging information in code that is up for review. If this is debugging information that you plan to leave in for future purposes (which I doubt is the case here), you need to protect it so that it isn't active unless some option is set. F

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

erichkeane added a comment. > In D130058#3714882 , @glandium > wrote: > >> Also not caught: a cast of 0 when 0 is not a valid value in the enum. > > I don't think that situation will ever be UB. When the underlying type of the > enum is not fixed, the

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

aaron.ballman added a comment. In D119051#3714645 , @dblaikie wrote: > Realized maybe we don't need a separate driver flag for this at all, and rely > only on the abi-compat flag? That seems to be how (at least some) other ABI > compat changes have been

[PATCH] D131651: [AST] [Modules] Introduce Decl::getNonTransparentDeclContext to handle exported friends

erichkeane added a comment. I think this is fine. I vaguely remember doing something like this in the past, but I can't seem to figure out what it was... Comment at: clang/lib/AST/DeclBase.cpp:1037 + assert(getDeclContext()); + return getDeclContext()->getNonTransparentCont

[clang] bbb30bd - [clang][AArch64][SVE] Clarify documentation for sizeof operator on SVE

Author: David Truby Date: 2022-08-11T13:22:23Z New Revision: bbb30bd54a6447702f9f59a2ae4c478eb7133ae0 URL: https://github.com/llvm/llvm-project/commit/bbb30bd54a6447702f9f59a2ae4c478eb7133ae0 DIFF: https://github.com/llvm/llvm-project/commit/bbb30bd54a6447702f9f59a2ae4c478eb7133ae0.diff LOG: [

[PATCH] D131625: [HLSL] Entry functions require param annotation

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Attr.h:193 +class HLSLAnnotationAttr : public InheritableAttr { +protected: Is this intended to be used only for parameters (that's how I read the summary for the patch)? If so, why is th

[PATCH] D131651: [AST] [Modules] Introduce Decl::getNonTransparentDeclContext to handle exported friends

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/lib/AST/DeclBase.cpp:1037 + assert(getDeclContext()); + return getDeclContext()->getNonTransparentContext(); +} eri

[PATCH] D131657: Remove redundant condition check, NFC

erichkeane accepted this revision. erichkeane added a comment. LGTM! Let us know if you need this committed for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131657/new/ https://reviews.llvm.org/D131657 __

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3715436 , @ChuanqiXu wrote: > In D126907#3712363 , @erichkeane > wrote: > >> In D126907#3711956 , @ChuanqiXu >> wrote: >> >>> In D

[PATCH] D131528: [Clang] Restrict non fixed enum to a value outside the range of the enumeration values warning to context requiring a constant expression

erichkeane added a comment. In D131528#3715841 , @thakis wrote: > We're also still seeing the diag fire after this: > https://ci.chromium.org/p/chromium/builders/ci/ToTLinux > > (And we cleaned up our codebase back when it was still an error.) > > Our bo

[PATCH] D131573: [clang][AArch64][SVE] Change SVE_VECTOR_OPERATORS macro for VLA vectors

This revision was automatically updated to reflect the committed changes. DavidTruby marked an inline comment as done. Closed by commit rG13a784f368ef: [clang][AArch64][SVE] Change SVE_VECTOR_OPERATORS macro for VLA vectors (authored by DavidTruby). Repository: rG LLVM Github Monorepo CHANGES

[clang] 13a784f - [clang][AArch64][SVE] Change SVE_VECTOR_OPERATORS macro for VLA vectors

Author: David Truby Date: 2022-08-11T13:23:52Z New Revision: 13a784f368ef062a7bd652829bcf8bbdd94dc659 URL: https://github.com/llvm/llvm-project/commit/13a784f368ef062a7bd652829bcf8bbdd94dc659 DIFF: https://github.com/llvm/llvm-project/commit/13a784f368ef062a7bd652829bcf8bbdd94dc659.diff LOG: [

[PATCH] D131665: [CMake] Support passing arguments to build tool (bootstrap).

russell.gallop added a comment. Noting related review: https://reviews.llvm.org/D115815 which added this variable to support this for other "external projects". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131665/new/ https://reviews.llvm.org/D13

[PATCH] D131528: [Clang] Restrict non fixed enum to a value outside the range of the enumeration values warning to context requiring a constant expression

erichkeane added a comment. In D131528#3715217 , @mstorsjo wrote: > There are still some cases that were broken by D131307 > , that aren't fixed by this patch. Building > https://martin.st/temp/qt-enum.cpp with `clang -

[clang] efc75a2 - Remove redundant condition check, NFC

Author: Jun Zhang Date: 2022-08-11T21:47:19+08:00 New Revision: efc75a2baedc7405193e3e0f5ea9aaa881783cec URL: https://github.com/llvm/llvm-project/commit/efc75a2baedc7405193e3e0f5ea9aaa881783cec DIFF: https://github.com/llvm/llvm-project/commit/efc75a2baedc7405193e3e0f5ea9aaa881783cec.diff LOG

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

isuruf added a comment. As a downstream packager of libclang, I really like the SONAME not changing in libclang. It makes it possible for us to package things like qt that depend on libclang, but not have to rebuild qt for every major revision of LLVM. It's not clear to me what the reason for re

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo updated this revision to Diff 451838. dongjunduo added a comment. fix stringRef bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131469/new/ https://reviews.llvm.org/D131469 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/chec

[PATCH] D131479: Handle explicitly defaulted consteval special members.

usaxena95 updated this revision to Diff 451839. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Removed regex matching for diagnostics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131479/new/ https://reviews.llvm.org/D13147

[PATCH] D131657: Remove redundant condition check, NFC

junaire added a comment. In D131657#3715976 , @erichkeane wrote: > LGTM! Let us know if you need this committed for you. Thanks! But I already have commit access :^) Closed in efc75a2baedc7405193e3e0f5ea9aaa881783cec

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo added a comment. In D131469#3715929 , @jamieschmeiser wrote: > You should not have debugging information in code that is up for review. If > this is debugging information that you plan to leave in for future purposes > (which I doubt is the

[PATCH] D124434: [Clang][Test] Run tests in C++14 mode explicitly.

junaire abandoned this revision. junaire added a comment. Herald added a subscriber: bzcheeseman. Prefer https://reviews.llvm.org/D131464 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124434/new/ https://reviews.llvm.org/D124434 __

[PATCH] D131678: hicpp-signed-bitwise - Return location of the operand (and not of the operator beginning)

vladimir.plyashkun created this revision. vladimir.plyashkun added reviewers: JonasToth, steveire, njames93. vladimir.plyashkun added a project: clang-tools-extra. Herald added a subscriber: carlosgalvezp. Herald added a project: All. vladimir.plyashkun requested review of this revision. Herald add

[clang] 5e876c5 - [analyzer] exploded-graph-rewriter: Fix python3 string encoding issues

Author: Balazs Benics Date: 2022-08-11T16:07:52+02:00 New Revision: 5e876c54f2d70195dd1bde827e908825aab2f4fb URL: https://github.com/llvm/llvm-project/commit/5e876c54f2d70195dd1bde827e908825aab2f4fb DIFF: https://github.com/llvm/llvm-project/commit/5e876c54f2d70195dd1bde827e908825aab2f4fb.diff

[PATCH] D131553: [analyzer] exploded-graph-rewriter: Fix python3 string encoding issues

This revision was automatically updated to reflect the committed changes. steakhal marked an inline comment as done. Closed by commit rG5e876c54f2d7: [analyzer] exploded-graph-rewriter: Fix python3 string encoding issues (authored by steakhal). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D131623: [clang-tidy] Improve modernize-use-emplace check

joeywatts created this revision. Herald added a subscriber: carlosgalvezp. Herald added a project: All. joeywatts updated this revision to Diff 451689. joeywatts added a comment. Eugene.Zelenko retitled this revision from "(wip) improve modernize-use-emplace check" to "[clang-tidy][wip] improve mo

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

davrec added a comment. This part of the description is confusing: > We take two types, X and Y, which we wish to unify as input. > These types must have the same (qualified or unqualified) canonical > type. > > We dive down fast through top-level type sugar nodes, to the > underlying canonical n

[PATCH] D131623: [clang-tidy] Improve modernize-use-emplace check

joeywatts updated this revision to Diff 451850. joeywatts added a comment. Update commit title/message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131623/new/ https://reviews.llvm.org/D131623 Files: clang-tools-extra/clang-tidy/modernize/UseEm

  1   2   3   >