[clang] 6f867f9 - [X86] Support ``-mindirect-branch-cs-prefix`` for call and jmp to indirect thunk

Author: Phoebe Wang Date: 2022-08-04T15:12:15+08:00 New Revision: 6f867f9102838ebe314c1f3661fdf95700386e5a URL: https://github.com/llvm/llvm-project/commit/6f867f9102838ebe314c1f3661fdf95700386e5a DIFF: https://github.com/llvm/llvm-project/commit/6f867f9102838ebe314c1f3661fdf95700386e5a.diff L

[PATCH] D130754: [X86] Support ``-mindirect-branch-cs-prefix`` for call and jmp to indirect thunk

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. pengfei marked an inline comment as done. Closed by commit rG6f867f910283: [X86] Support ``-mindirect-branch-cs-prefix`` for call and jmp to indirect thunk (authored by

[PATCH] D130754: [X86] Support ``-mindirect-branch-cs-prefix`` for call and jmp to indirect thunk

pengfei added a comment. Thanks for review! Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6350 + if (Args.hasArg(options::OPT_mindirect_branch_cs_prefix)) +CmdArgs.push_back("-mindirect-branch-cs-prefix"); MaskRay wrote: > pengfei wrote: > > MaskRay

[PATCH] D130735: [Clang][LLD][cmake] Drop deprecated support for `llvm-config`-based build

tstellar accepted this revision. tstellar added a comment. LGTM. I just tested this patch in our build config and it works fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130735/new/ https://reviews.llvm.org/D130735 __

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

jpenix-quic updated this revision to Diff 449894. jpenix-quic added a comment. Hopefully fix Window's build errors by using the proper Windows-specific environment utilities (_putenv_s vs setenv). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130513/new/ https://reviews.llvm.org/D13051

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

asmok-g added a comment. This is also causing a compilation error in some google third-party code. Compiling with older clang doesn't give that error. Error: error: no matching function for call to object of type 'key_compare_adapter::IntervalLess>::checked_compare' comp(__trans_tmp_3,

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

sberg added a comment. I'm surprised that $ cat test.c struct S { int m1; int m2[1]; }; void f(struct S * s) { s->m2[1] = 0; } $ clang -fsyntax-only -fstrict-flex-arrays=1 test.c test.c:6:5: warning: array index 1 is past the end of the array (which contains 1

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

bgraur added a comment. @SimplyDanny given the reports from @joanahalili and @asmok-g are you considering a revert for this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129973/new/ https://reviews.llvm.org/D129973

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu updated this revision to Diff 449898. ChuanqiXu marked 15 inline comments as done. ChuanqiXu edited the summary of this revision. ChuanqiXu added a comment. - Address comments. - Tested with `make docs-clang-html`. - Add `Known Problems` section. CHANGES SINCE LAST ACTION https://rev

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:18 + +There is already a detailed document about clang modules Modules_, it +should be helpful to read Modules_ if you want to know more about the general Mordante wrote: > Is `Modules

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:377-393 + │ │ ││ + ├─ frontend ─┼─

[clang] 127bf44 - [Clang][C++20] Support capturing structured bindings in lambdas

Author: Corentin Jabot Date: 2022-08-04T10:12:53+02:00 New Revision: 127bf44385424891eb04cff8e52d3f157fc2cb7c URL: https://github.com/llvm/llvm-project/commit/127bf44385424891eb04cff8e52d3f157fc2cb7c DIFF: https://github.com/llvm/llvm-project/commit/127bf44385424891eb04cff8e52d3f157fc2cb7c.diff

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

This revision was automatically updated to reflect the committed changes. Closed by commit rG127bf4438542: [Clang][C++20] Support capturing structured bindings in lambdas (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/ne

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu added a comment. In D131062#3697193 , @Mordante wrote: > Thanks a lot for working on this! > > I wonder whether it would be better to have some of the more technical > information in a separate file and let this file mainly have an introduction

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

bgraur added a subscriber: tstellar. bgraur added a comment. @tstellar FYI the clang crash report from @joanahalili and the new compilation errors report from @asmok-g, both introduced by this patch. Is a revert warranted here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

ckandeler added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130015/new/ https://reviews.llvm.org/D130015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

peixin added inline comments. Comment at: flang/lib/Lower/Bridge.cpp:203 //them. for (Fortran::lower::pft::Program::Units &u : pft.getUnits()) { std::visit(Fortran::common::visitors{ Doing this can avoid add one variable to the bridge. CHAN

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

kadircet added a comment. Reverting for @bgraur as he's having some issues with his commit access ATM. To sum up the reproducer attached by @joanahalili triggers a crash https://reviews.llvm.org/rG4e94f6653150511de434fa7e29b684ae7f0e52b6 with stack trace and error: $ ~/repos/llvm/build/bin/c

[clang] c8b2f3f - [ObjC] type method metadata `_imp`, messenger routine at callsite with program address space

Author: Matt Jacobson Date: 2022-08-04T05:40:32-04:00 New Revision: c8b2f3f51bd923afbf9d3ebd0823bce895629630 URL: https://github.com/llvm/llvm-project/commit/c8b2f3f51bd923afbf9d3ebd0823bce895629630 DIFF: https://github.com/llvm/llvm-project/commit/c8b2f3f51bd923afbf9d3ebd0823bce895629630.diff

[PATCH] D112113: [ObjC] type method metadata `_imp`, messenger routine at callsite with program address space

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc8b2f3f51bd9: [ObjC] type method metadata `_imp`, messenger routine at callsite with program… (authored by mhjacobson). Herald added a project: All.

[PATCH] D131006: [analyzer] Use DisequalityMap while inferring constraints

martong added a comment. Awesome! Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1512-1516 +if (IsFirst) { + IsFirst = false; + RS = *RSPtr; +} else + RS = RangeFactory.unite(RS, *RSPtr); `unite`

[PATCH] D131153: AArch64: disable asynchronous unwind by default for MachO.

t.p.northover created this revision. Herald added subscribers: kristof.beyls, mcrosier. Herald added a project: All. t.p.northover requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: clang. AArch64 MachO has a compact unwind format where most functions' u

[PATCH] D130372: [analyzer] Add a new factory function RangeSet::Factory::invert

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Nice work! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130372/new/ https://reviews.llvm.org/D130372 ___ cfe-commits mailing list

[PATCH] D128248: [clang] Avoid an assertion in APValue::hasArrayFiller()

tbaeder abandoned this revision. tbaeder added a comment. Abandoning as per the discussion in https://discourse.llvm.org/t/apvalue-lifetime-problem-when-evaluating-constant-expressions/64002/5. This patch just hides a problem. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128248/new/

[PATCH] D131006: [analyzer] Use DisequalityMap while inferring constraints

martong added inline comments. Comment at: clang/test/Analysis/range-inferring-from-disequality-map.cpp:10-11 + clang_analyzer_value(x); // expected-warning {{32s:{ [0, 0] }}} + // TODO: TODO: Keep x range correct even if associated disequalities are + // already dead. +

[PATCH] D130470: [clang][analyzer] Add more wide-character functions to CStringChecker

martong accepted this revision. martong added a comment. I think there's only some very minor style nits which are remained, but that should not block this any further. Let's land it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130470/new/ https

[PATCH] D131067: [analyzer] Treat values passed as parameter as escaped

martong added a comment. Thanks, looks good with some nits. Comment at: clang/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp:556-558 +unsigned numParams = FD->getNumParams(); +for (unsigned i = 0; i < numParams; ++i) { + findReferenceParameter(FD->getParamDecl(i

[clang-tools-extra] df48e3f - Revert "[clang] Pass FoundDecl to DeclRefExpr creator for operator overloads"

Author: Kadir Cetinkaya Date: 2022-08-04T12:14:43+02:00 New Revision: df48e3fbcc8be1f4c04bd97517d12e662f54de75 URL: https://github.com/llvm/llvm-project/commit/df48e3fbcc8be1f4c04bd97517d12e662f54de75 DIFF: https://github.com/llvm/llvm-project/commit/df48e3fbcc8be1f4c04bd97517d12e662f54de75.dif

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

kadircet added a comment. Reverted in df48e3fbcc8be1f4c04bd97517d12e662f54de75 , @tstellar it needs to be cherry-picked into release branch as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D130705: [clang][ASTImporter] Improve import of functions with auto return type.

martong added a comment. Thank you, nice and assiduous work! The changes look good to me, but I think we should have some more tests where variable and function template specializations are used as return types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

usaxena95 created this revision. usaxena95 added a reviewer: hokein. Herald added subscribers: kadircet, arphaman. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Do not fold the endline wh

[PATCH] D131155: [clang] Expand array expressions if the filler expression's filler is element dependent

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is about the problem described in https://discourse.llvm.org/t/apv

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

usaxena95 updated this revision to Diff 449928. usaxena95 added a comment. Do same for multi-line comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131154/new/ https://reviews.llvm.org/D131154 Files: clang-tools-extra/clangd/ClangdLSPServe

[PATCH] D130894: [clang] Print more information about failed static assertions

aaron.ballman added a comment. In D130894#3698552 , @tbaeder wrote: >> +1 to the suggestion to use quotes for a bit of visual distinction between >> the diagnostic message and the code embedded within it. > > One problem is that both the integer value `0

[PATCH] D131070: [clang][sema] Fix collectConjunctionTerms()

tbaeder updated this revision to Diff 449930. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131070/new/ https://reviews.llvm.org/D131070 Files: clang/lib/Sema/SemaTemplate.cpp Index: clang/lib/Sema/SemaTemplate.cpp === -

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

usaxena95 updated this revision to Diff 449931. usaxena95 added a comment. More tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131154/new/ https://reviews.llvm.org/D131154 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-e

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

aaron.ballman added a comment. In D130058#3697949 , @smeenai wrote: > Given that we have a non-obvious (at least to me) issue in a widely used > third-party library, would we consider giving users some way to opt out of > this error, at least as a trans

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

omjavaid added a comment. This breaks clang causes it to crash in LLDB buildbot testsuite breaking the LLDB buildbot: https://lab.llvm.org/buildbot/#/builders/96/builds/27003 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131007/new/ https://review

[PATCH] D130894: [clang] Print more information about failed static assertions

tbaeder added a comment. IMO it's clear enough... test.cpp:24:1: error: static assertion failed due to requirement 'c != c' static_assert(c != c); ^ ~~ test.cpp:24:17: note: expression evaluates to 'a != a' static_assert(c != c); ~~^~~~ test.cpp:25:1: e

[PATCH] D131155: [clang] Expand array expressions if the filler expression's filler is element dependent

tbaeder updated this revision to Diff 449932. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131155/new/ https://reviews.llvm.org/D131155 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/constexpr-array-init.cpp Index: clang/test/SemaCXX/constexpr-array-init.cpp

[PATCH] D130894: [clang] Print more information about failed static assertions

xbolva00 added a comment. personally I dont see huge value to print “ left-hand side of operator '==' evaluates to …” I would like to see the full expression. +1 to just copy gcc’s approach CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130894/new/ https://reviews.llvm.org/D130894 __

[PATCH] D131156: [analyzer] Treat values passed as parameter as escaped

t-8ch created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. t-8ch requested review of this revision. Her

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

aaron.ballman added a comment. In D131007#3699142 , @omjavaid wrote: > This breaks clang causes it to crash in LLDB buildbot testsuite breaking the > LLDB buildbot: https://lab.llvm.org/buildbot/#/builders/96/builds/27003 I believe this was already reso

[PATCH] D131156: [analyzer] Treat values passed as parameter as escaped

t-8ch abandoned this revision. t-8ch added a comment. This is an accidental repost of #D131067 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131156/new/ https://reviews.llvm.org/D131156 ___ cfe-commits m

[PATCH] D131067: [analyzer] Treat values passed as parameter as escaped

t-8ch updated this revision to Diff 449934. t-8ch added a comment. Hoisted common code into common function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131067/new/ https://reviews.llvm.org/D131067 Files: clang/lib/StaticAnalyzer/Checkers/Dead

[PATCH] D131057: [Sema] -Wformat: support C23 format specifier %b %B

aaron.ballman accepted this revision. aaron.ballman added a comment. In D131057#3697392 , @MaskRay wrote: > ISTM adding the diagnostic (even if we do) is not so necessary in this patch. I tend to agree. I think we'll want such a diagnostic at some point,

[PATCH] D131067: [analyzer] Treat values passed as parameter as escaped

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131067/new/ https://reviews.llvm.org/D131067

[PATCH] D131070: [clang][sema] Fix collectConjunctionTerms()

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Oh shoot, I saw that precommit CI made it past patch application failing (last time) and I thought the precommit CI bug was fixed and so it was testing the whole stack for once.

[PATCH] D130553: [clang][lld][cmake] Simplify header dirs

Ericson2314 added a comment. @tstellar There wasn't a configuration necessitating these changes. The CMake config file currently distinguishes a main include dir and secondary include dir, which feels to me like it is leaking the implementation details of which headers are generated or not. I w

[PATCH] D130735: [Clang][LLD][cmake] Drop deprecated support for `llvm-config`-based build

Ericson2314 abandoned this revision. Ericson2314 added a comment. Abandoing based on @phosek's point in D128777 about it being nice to have it easy to revert them individually. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D130600: [clang][dataflow] Handle return statements

samestep added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:345 +// FIXME: Support reference-type returns. +assert(Val->getKind() != Value::Kind::Reference); + sgatev wrote: > Let's do `if (Val->getKind() == Value::Kind::Refe

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

aaron.ballman added a comment. In D131084#3697678 , @cjdb wrote: > It seems I got confused and conflated the two this morning. > > In D131084#3697525 , @vaibhav.y > wrote: > >>> Hmm, we can probably use "informat

[PATCH] D130600: [clang][dataflow] Handle return statements

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:348 +auto *Loc = Env.getReturnStorageLocation(); +assert(Loc != nullptr); +// FIXME: Model NRVO. samestep wrote: > sgatev wrote: > > Let's do `if (Loc == nullptr)

[PATCH] D131070: [clang][sema] Fix collectConjunctionTerms()

tbaeder added a comment. FWIW I switched it around so _this_ patch is now good as-is while https://reviews.llvm.org/D130894 now depends on this one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131070/new/ https://reviews.llvm.org/D131070 _

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some small corrections. Thank you for this! Do you need me to commit on your behalf? If so, what name and email address would you like me to use for patch attribu

[PATCH] D131134: [X86] Report error if the amx enabled on the non-64-bits target

pengfei accepted this revision. pengfei added a subscriber: aaron.ballman. pengfei added a comment. This revision is now accepted and ready to land. LGTM, but maybe wait one day or two for other FE folks' opinions. @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130894: [clang] Print more information about failed static assertions

tbaeder updated this revision to Diff 449942. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130894/new/ https://reviews.llvm.org/D130894 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDeclCXX.

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

erichkeane added a comment. In D131007#3699162 , @aaron.ballman wrote: > In D131007#3699142 , @omjavaid > wrote: > >> This breaks clang causes it to crash in LLDB buildbot testsuite breaking the >> LLDB buildbo

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

inclyc added a comment. Thank you! I already have the commit access, I can commit this myself ^_^ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130906/new/ https://reviews.llvm.org/D130906 ___ cfe-commi

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

inclyc updated this revision to Diff 449947. inclyc added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130906/new/ https://reviews.llvm.org/D130906 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaChecking.cpp clang/test/S

[clang] f417583 - [clang] format string checking for conpile-time evaluated str literal

Author: YingChi Long Date: 2022-08-04T21:07:30+08:00 New Revision: f417583f319bd60d1e32cdf9d0242e42f86101bf URL: https://github.com/llvm/llvm-project/commit/f417583f319bd60d1e32cdf9d0242e42f86101bf DIFF: https://github.com/llvm/llvm-project/commit/f417583f319bd60d1e32cdf9d0242e42f86101bf.diff

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf417583f319b: [clang] format string checking for conpile-time evaluated str literal (authored by inclyc). Repository: rG LLVM Github Monorepo CHA

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

aaron.ballman added a comment. In D130906#3699323 , @inclyc wrote: > Thank you! I already have the commit access, I can commit this myself ^_^ Excellent! Feel free to land when you're ready. :-) Comment at: clang/lib/Sema/SemaCheckin

[PATCH] D131062: [docs] Add "C++20 Modules"

h-vetinari added a comment. Aside from a couple typos, I was wondering if it would be welcome to do a pass w.r.t stylistic improvements (e.g. "Modules have a lot of meanings." --> "The term 'modules' has a lot of meanings"). I don't want to be too nit-picky - the sentences are all understandabl

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

inclyc added a comment. In D130906#3699335 , @aaron.ballman wrote: > In D130906#3699323 , @inclyc wrote: > >> Thank you! I already have the commit access, I can commit this myself ^_^ > > Excellent! Feel free to

[PATCH] D131134: [X86] Report error if the amx enabled on the non-64-bits target

aaron.ballman added a comment. I think the precommit CI failures might be relevant here -- can you double-check those? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131134/new/ https://reviews.llvm.org/D131134

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

aaron.ballman added a comment. In D130906#3699342 , @inclyc wrote: > In D130906#3699335 , @aaron.ballman > wrote: > >> In D130906#3699323 , @inclyc wrote: >> >>> Thank yo

[clang] 282d475 - [clang] change `auto` to `Expr` in last commit [NFC]

Author: YingChi Long Date: 2022-08-04T21:15:45+08:00 New Revision: 282d4755c37ced7c2b36526d79033c5c76a006a8 URL: https://github.com/llvm/llvm-project/commit/282d4755c37ced7c2b36526d79033c5c76a006a8 DIFF: https://github.com/llvm/llvm-project/commit/282d4755c37ced7c2b36526d79033c5c76a006a8.diff

[PATCH] D131155: [clang] Expand array expressions if the filler expression's filler is element dependent

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Your logic makes sense to me and these changes look correct; good catch! Please be sure to add a release note when landing. Thanks for the fix! CHANGES SINCE LAST ACTION https

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

inclyc added a comment. Last question, issue https://github.com/llvm/llvm-project/issues/55805 mentioned another case, some `initListExpr` evaulated as "StringLiteral"(`Array` in fact, but maybe able to consider as a literal), should we implement this? Repository: rG LLVM Github Monorepo C

[PATCH] D130600: [clang][dataflow] Handle return statements

samestep added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:348 +auto *Loc = Env.getReturnStorageLocation(); +assert(Loc != nullptr); +// FIXME: Model NRVO. sgatev wrote: > samestep wrote: > > sgatev wrote: > > > Let's do

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

aaron.ballman added a comment. In D130906#3699361 , @inclyc wrote: > Last question, issue https://github.com/llvm/llvm-project/issues/55805 > mentioned another case, some `initListExpr` evaulated as > "StringLiteral"(`Array` in fact, but maybe able to c

[PATCH] D130600: [clang][dataflow] Handle return statements

samestep updated this revision to Diff 449958. samestep added a comment. Don't assert returns to not be references Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130600/new/ https://reviews.llvm.org/D130600 Files: clang/include/clang/Analysis/Flo

[PATCH] D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

yurai007 updated this revision to Diff 449963. yurai007 edited the summary of this revision. yurai007 added a comment. Rebase and fix last comment. Remove dependency to https://reviews.llvm.org/D129781 by moving relevant part of change here. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D130984: [clang][AArch64][SVE] Add unary +/- operators for SVE types

c-rhodes accepted this revision. c-rhodes added a comment. This revision is now accepted and ready to land. LGTM, just one minor comment Comment at: clang/test/CodeGen/aarch64-sve-vector-arith-ops.c:1654 + +// UNARY PROMOTION + should we add FP tests as well?

[PATCH] D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

nikic accepted this revision. nikic added a comment. Still LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130268/new/ https://reviews.llvm.org/D130268 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

fhahn added a comment. Looks like a nice improvement, thanks! Comment at: llvm/unittests/ADT/SmallVectorTest.cpp:867 - template - static unsigned NumBuiltinElts(const SmallVector&) { return N; } }; This seems like an unrelated change unless I am missing som

[PATCH] D130600: [clang][dataflow] Handle return statements

samestep updated this revision to Diff 449975. samestep added a comment. Use CallExpr location for ReturnLoc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130600/new/ https://reviews.llvm.org/D130600 Files: clang/include/clang/Analysis/FlowSensi

[PATCH] D130600: [clang][dataflow] Handle return statements

samestep updated this revision to Diff 449976. samestep added a comment. Revert an unnecessary little change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130600/new/ https://reviews.llvm.org/D130600 Files: clang/include/clang/Analysis/FlowSensi

[PATCH] D131170: [clang][dataflow] Analyze method bodies

samestep created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. samestep requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https:/

[PATCH] D131155: [clang] Expand array expressions if the filler expression's filler is element dependent

erichkeane accepted this revision. erichkeane added a comment. This seems reasonable to me as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131155/new/ https://reviews.llvm.org/D131155 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D131172: [clang][llvm][doc] Add more information for the ABI change in FP16

pengfei created this revision. pengfei added reviewers: kparzysz, thieta, abdulras, tstellar. Herald added a project: All. pengfei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo http

[PATCH] D131172: [clang][llvm][doc] Add more information for the ABI change in FP16

pengfei added a comment. This is for LLVM 15.0 release per to #56854. Forgive me my bad English. Suggestions are welcome. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131172/new/ https://reviews.llvm.org/D131172 _

[PATCH] D131170: [clang][dataflow] Analyze method bodies

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:383 StorageLocation *ReturnLoc = nullptr; - // FIXME: Move `ThisPointeeLoc` here from `DataflowAnalysisContext`. + StorageLocation *ThisPointeeLoc = nullptr;

[PATCH] D131172: [clang][llvm][doc] Add more information for the ABI change in FP16

kparzysz accepted this revision. kparzysz added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131172/new/ https://reviews.llvm.org/D131172

[PATCH] D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

yurai007 marked an inline comment as done. yurai007 added inline comments. Comment at: llvm/unittests/ADT/SmallVectorTest.cpp:867 - template - static unsigned NumBuiltinElts(const SmallVector&) { return N; } }; fhahn wrote: > This seems like an unrelated chan

[PATCH] D131170: [clang][dataflow] Analyze method bodies

samestep added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:383 StorageLocation *ReturnLoc = nullptr; - // FIXME: Move `ThisPointeeLoc` here from `DataflowAnalysisContext`. + StorageLocation *ThisPointeeLoc = nullptr; --

[PATCH] D131170: [clang][dataflow] Analyze method bodies

samestep updated this revision to Diff 449986. samestep added a comment. Address Stanislav's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131170/new/ https://reviews.llvm.org/D131170 Files: clang/include/clang/Analysis/FlowSensitive/Da

[clang] 54d24ea - [clang][dataflow][NFC] Fix outdated comment on getStableStorageLocation

Author: Eric Li Date: 2022-08-04T11:15:14-04:00 New Revision: 54d24eae98726e37867bc3a683cd58af6ec128df URL: https://github.com/llvm/llvm-project/commit/54d24eae98726e37867bc3a683cd58af6ec128df DIFF: https://github.com/llvm/llvm-project/commit/54d24eae98726e37867bc3a683cd58af6ec128df.diff LOG:

[PATCH] D131109: [clang][dataflow][NFC] Fix outdated comment on getStableStorageLocation

This revision was automatically updated to reflect the committed changes. Closed by commit rG54d24eae9872: [clang][dataflow][NFC] Fix outdated comment on getStableStorageLocation (authored by li.zhe.hua). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D131134: [X86] Report error if the amx enabled on the non-64-bits target

craig.topper added a comment. How does this interact with `-march=native -m32`. Won't that pick up the amx flag from CPUID? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131134/new/ https://reviews.llvm.org/D131134 ___

[PATCH] D130808: [InstrProf] Add new format for -fprofile-list=

ellis updated this revision to Diff 449994. ellis added a comment. Fix case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130808/new/ https://reviews.llvm.org/D130808 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/ProfileList.h

[PATCH] D130807: [InstrProf] Add the skipprofile attribute

ellis updated this revision to Diff 449995. ellis added a comment. Rebase and update docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130807/new/ https://reviews.llvm.org/D130807 Files: clang/lib/CodeGen/CodeGenFunction.h clang/lib/CodeGen/C

[PATCH] D131170: [clang][dataflow] Analyze method bodies

sgatev accepted this revision. sgatev added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:217 +const Expr *Arg = MethodCall->getImplicitObjectArgument(); +Env.ThisPointeeLoc = Env.get

[clang] 12e78ff - [InstrProf] Add the skipprofile attribute

Author: Ellis Hoag Date: 2022-08-04T08:45:27-07:00 New Revision: 12e78ff88105f2dc6cb1449d6fcd5d8f69e0512f URL: https://github.com/llvm/llvm-project/commit/12e78ff88105f2dc6cb1449d6fcd5d8f69e0512f DIFF: https://github.com/llvm/llvm-project/commit/12e78ff88105f2dc6cb1449d6fcd5d8f69e0512f.diff LO

[PATCH] D130807: [InstrProf] Add the skipprofile attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12e78ff88105: [InstrProf] Add the skipprofile attribute (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[clang] bcf6ffb - Reland "[lldb/Fuzzer] Add fuzzer for expression evaluator"

Author: Chelsea Cassanova Date: 2022-08-04T11:47:06-04:00 New Revision: bcf6ffb87ec67ba41daeaab905b2c57a50568aa0 URL: https://github.com/llvm/llvm-project/commit/bcf6ffb87ec67ba41daeaab905b2c57a50568aa0 DIFF: https://github.com/llvm/llvm-project/commit/bcf6ffb87ec67ba41daeaab905b2c57a50568aa0.d

[PATCH] D131170: [clang][dataflow] Analyze method bodies

samestep added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:217 +const Expr *Arg = MethodCall->getImplicitObjectArgument(); +Env.ThisPointeeLoc = Env.getStorageLocation(*Arg, SkipPast::Reference); + } sgatev wrote

[clang] b692312 - [InstrProf] Add new format for -fprofile-list=

Author: Ellis Hoag Date: 2022-08-04T08:49:43-07:00 New Revision: b692312ca432d9a379f67a8d83177a6f1722baaa URL: https://github.com/llvm/llvm-project/commit/b692312ca432d9a379f67a8d83177a6f1722baaa DIFF: https://github.com/llvm/llvm-project/commit/b692312ca432d9a379f67a8d83177a6f1722baaa.diff LO

[PATCH] D130808: [InstrProf] Add new format for -fprofile-list=

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb692312ca432: [InstrProf] Add new format for -fprofile-list= (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   3   >