samestep added inline comments.
================ Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:383 StorageLocation *ReturnLoc = nullptr; - // FIXME: Move `ThisPointeeLoc` here from `DataflowAnalysisContext`. + StorageLocation *ThisPointeeLoc = nullptr; ---------------- sgatev wrote: > Let's add a brief comment explaining what this is and when it is expected to > be non-null. Will do, thanks. ================ Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:217 + const Expr *Arg = MethodCall->getImplicitObjectArgument(); + Env.ThisPointeeLoc = Env.getStorageLocation(*Arg, SkipPast::Reference); + } ---------------- sgatev wrote: > What if `Arg` is null? Good point, thanks; under what circumstances can that happen? In any case, I'm adding a guard for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131170/new/ https://reviews.llvm.org/D131170 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
