[PATCH] D130414: [pseudo] Reorganize CXX.h enums

sammccall created this revision. sammccall added reviewers: hokein, usaxena95. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. - Place rules under rule::lhs::rhs__rhs__rhs - Ch

[PATCH] D130337: [pseudo] Eliminate multiple-specified-types ambiguities using guards

sammccall added a comment. In D130337#3671614 , @hokein wrote: > If we look at the existing guard implementations, we have a few of these > usages: > > - in `isFunctionDeclarator`, we enumerate all rules of `noptr_declarator`, > `ptr_declarator`, `decla

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

StephenFan added a comment. In D129448#3669296 , @vitalybuka wrote: > I am not sure what to do with this patch. I really prefer to avoid it to > minimize the risk of regressions. > > We probably considered/prototyped to insert starts like in this soluti

[PATCH] D129174: [C++20][Modules] Update ADL to handle basic.lookup.argdep p4 [P1815R2 part 1]

iains updated this revision to Diff 447046. iains added a comment. rebased, addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129174/new/ https://reviews.llvm.org/D129174 Files: clang/include/clang/Sema/Overload.h clang/l

[PATCH] D129174: [C++20][Modules] Update ADL to handle basic.lookup.argdep p4 [P1815R2 part 1]

iains marked 2 inline comments as done. iains added a comment. it would be good to get this landed before llvm-15 branches.. Comment at: clang/lib/Sema/SemaLookup.cpp:3864-3878 + for (auto *E : AssociatedClasses) { +// and have the same innermost en

[PATCH] D130415: [Clang] Adjust extension warnings for #warning

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The #warning directive is standard in C++2b and C2x, this adjusts the pedantic and extensions warning accordingly. Repos

[PATCH] D130415: [Clang] Adjust extension warnings for #warning

cor3ntin updated this revision to Diff 447048. cor3ntin added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130415/new/ https://reviews.llvm.org/D130415 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/lib/Lex

[PATCH] D130415: [Clang] Adjust extension warnings for #warning

cor3ntin updated this revision to Diff 447049. cor3ntin added a comment. Update release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130415/new/ https://reviews.llvm.org/D130415 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Ba

[PATCH] D130416: [Clang] Add support for Unicode identifiers (UAX31) in C2x mode.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implements N2836 Identifier Syntax using Unicode Standard Annex 31. The feature was already implemented for C++, and

[PATCH] D130416: [Clang] Add support for Unicode identifiers (UAX31) in C2x mode.

cor3ntin updated this revision to Diff 447051. cor3ntin added a comment. Update a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130416/new/ https://reviews.llvm.org/D130416 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/Lexer.cpp c

[PATCH] D130299: [clang-format] FIX: Misannotation 'auto' as trailing return type in lambdas

denis-fatkulin updated this revision to Diff 447052. denis-fatkulin retitled this revision from "[clang-format] FIX: Misformatting lambdas with trailing return type 'auto' in braced lists" to "[clang-format] FIX: Misannotation 'auto' as trailing return type in lambdas". denis-fatkulin edited the

[PATCH] D130417: [clang-format] Missing space between trailing return type 'auto' and left brace

denis-fatkulin created this revision. denis-fatkulin added reviewers: HazardyKnusperkeks, curdeius. denis-fatkulin added a project: clang-format. Herald added a project: All. denis-fatkulin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Th

[PATCH] D130419: Use `` with MSVC and C++

fsb4000 created this revision. fsb4000 added a project: clang. Herald added a project: All. fsb4000 requested review of this revision. Herald added a subscriber: cfe-commits. and use fallback only for C. It fixes the isssue with clang-cl: #include #include #ifdef __cplusplus #include

[PATCH] D130416: [Clang] Add support for Unicode identifiers (UAX31) in C2x mode.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a typo fix in a comment. One thing worth thinking about is whether it would be worth it to have a diagnostic for valid C code in older modes that will change beha

[PATCH] D130419: Use `` with MSVC and C++

fsb4000 added a comment. F23880823: изображение.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130419/new/ https://reviews.llvm.org/D130419 ___ cfe-commits mailing

[PATCH] D130415: [Clang] Adjust extension warnings for #warning

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:393-398 +def warn_cxx2b_compat_warning_directive : Warning< + "#warning is incompatible with

[PATCH] D130416: [Clang] Add support for Unicode identifiers (UAX31) in C2x mode.

cor3ntin updated this revision to Diff 447056. cor3ntin added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130416/new/ https://reviews.llvm.org/D130416 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/Lexer.cpp clang/tes

[PATCH] D130415: [Clang] Adjust extension warnings for #warning

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:393-398 +def warn_cxx2b_compat_warning_directive : Warning< + "#warning is incompatible with C++ standards before C++2b">, + InGroup, DefaultIgnore; +def warn_c2x_compat_warning_directiv

[clang] aee76cb - [Clang] Add support for Unicode identifiers (UAX31) in C2x mode.

Author: Corentin Jabot Date: 2022-07-23T14:08:08+02:00 New Revision: aee76cb59ca273d46db20cd7d23a252a2683ed6a URL: https://github.com/llvm/llvm-project/commit/aee76cb59ca273d46db20cd7d23a252a2683ed6a DIFF: https://github.com/llvm/llvm-project/commit/aee76cb59ca273d46db20cd7d23a252a2683ed6a.diff

[PATCH] D130416: [Clang] Add support for Unicode identifiers (UAX31) in C2x mode.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaee76cb59ca2: [Clang] Add support for Unicode identifiers (UAX31) in C2x mode. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGE

[clang] 559f07b - [Clang] Adjust extension warnings for #warning

Author: Corentin Jabot Date: 2022-07-23T14:10:11+02:00 New Revision: 559f07b872116fb85ea7d493768a6eb450329fa0 URL: https://github.com/llvm/llvm-project/commit/559f07b872116fb85ea7d493768a6eb450329fa0 DIFF: https://github.com/llvm/llvm-project/commit/559f07b872116fb85ea7d493768a6eb450329fa0.diff

[PATCH] D130415: [Clang] Adjust extension warnings for #warning

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG559f07b87211: [Clang] Adjust extension warnings for #warning (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D130406: Use llvm::sort instead of std::sort where possible

nhaehnle accepted this revision. nhaehnle added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130406/new/ https://reviews.llvm.org/D130406 ___

[PATCH] D130420: [CodeGen] Consider MangleCtx when move lazy emission States

junaire created this revision. junaire added a reviewer: v.g.vassilev. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also move MangleCtx when moving some lazy emission states in CodeGenModule. Without

[PATCH] D130421: [Clang] De-deprecate volatile compound operations

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As per P2327R1, | =, &= and ^= are no longer deprecated in all languages mode. | Repository: rG LLVM Github Monorepo

[PATCH] D130421: [Clang] De-deprecate volatile compound operations

cor3ntin added a comment. @aaron.ballman I think getting that in 15 would avoid some churn, WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130421/new/ https://reviews.llvm.org/D130421 ___ cfe-commit

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

iains updated this revision to Diff 447062. iains added a comment. rebased, retested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128328/new/ https://reviews.llvm.org/D128328 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/incl

[clang-tools-extra] cd9a5cf - Use the range-based overload of llvm::sort where possible

Author: Dmitri Gribenko Date: 2022-07-23T15:13:25+02:00 New Revision: cd9a5cfd2e4e4d583c9bf5ef1100acaf5e96f29e URL: https://github.com/llvm/llvm-project/commit/cd9a5cfd2e4e4d583c9bf5ef1100acaf5e96f29e DIFF: https://github.com/llvm/llvm-project/commit/cd9a5cfd2e4e4d583c9bf5ef1100acaf5e96f29e.dif

[PATCH] D130403: Use the range-based overload of llvm::sort where possible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd9a5cfd2e4e: Use the range-based overload of llvm::sort where possible (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] cd9a5cf - Use the range-based overload of llvm::sort where possible

Author: Dmitri Gribenko Date: 2022-07-23T15:13:25+02:00 New Revision: cd9a5cfd2e4e4d583c9bf5ef1100acaf5e96f29e URL: https://github.com/llvm/llvm-project/commit/cd9a5cfd2e4e4d583c9bf5ef1100acaf5e96f29e DIFF: https://github.com/llvm/llvm-project/commit/cd9a5cfd2e4e4d583c9bf5ef1100acaf5e96f29e.dif

[clang] e82880e - [Clang] Update the status of N2393 in c_status.html

Author: Corentin Jabot Date: 2022-07-23T15:15:12+02:00 New Revision: e82880e6b8cd2f01ee18e99c4c7b6ec71b764e13 URL: https://github.com/llvm/llvm-project/commit/e82880e6b8cd2f01ee18e99c4c7b6ec71b764e13 DIFF: https://github.com/llvm/llvm-project/commit/e82880e6b8cd2f01ee18e99c4c7b6ec71b764e13.diff

[PATCH] D130406: Use llvm::sort instead of std::sort where possible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaba43035bdf8: Use llvm::sort instead of std::sort where possible (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D130422: [clang-repl] Fix incorrect return code

junaire created this revision. junaire added a reviewer: v.g.vassilev. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without this patch, clang-repl incorrectly pass some tests when there's error occure

[PATCH] D130423: [clang][dataflow] Rename iterators from IT to It

gribozavr created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. gribozavr requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The latter way to abbreviate is a

[PATCH] D130423: [clang][dataflow] Rename iterators from IT to It

gribozavr updated this revision to Diff 447067. gribozavr added a comment. Reverted an unintended edit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130423/new/ https://reviews.llvm.org/D130423 Files: clang/lib/Analysis/FlowSensitive/DataflowAna

[PATCH] D130419: Use `` with MSVC and C++

fsb4000 added a comment. Why did x64 debian tests fail? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130419/new/ https://reviews.llvm.org/D130419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D130419: Use `` with MSVC and C++

mizvekov added a comment. In D130419#3673877 , @fsb4000 wrote: > Why did x64 debian tests fail? openmp build is broken on linux pre-commit CI right now. Not related to your patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D130419: Use `` with MSVC and C++

fsb4000 added a comment. Good. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130419/new/ https://reviews.llvm.org/D130419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] 3256021 - Fix one stray `{LLVM -> CLANG}_TOOLS_INSTALL_DIR`

Author: John Ericson Date: 2022-07-23T16:26:32Z New Revision: 32560211c6206a7c63224a52200f41d17652fb0d URL: https://github.com/llvm/llvm-project/commit/32560211c6206a7c63224a52200f41d17652fb0d DIFF: https://github.com/llvm/llvm-project/commit/32560211c6206a7c63224a52200f41d17652fb0d.diff LOG:

[PATCH] D130362: Fix one stray `{LLVM -> CLANG}_TOOLS_INSTALL_DIR`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32560211c620: Fix one stray `{LLVM -> CLANG}_TOOLS_INSTALL_DIR` (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 447085. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 447086. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang-tools-extra/clangd/unittests/ASTTests.cpp clang-tools-extra/clangd/unittests/HoverTests.cpp

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 447087. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added a comment. In D111509#3168178 , @shafik wrote: > Changing how types are printed can effect LLDB expression parsing tests. I > ran the LLDB test suite with this change: > > ninja check-lldb > > and it changes to the results for `TestScala

[PATCH] D130420: [CodeGen] Consider MangleCtx when move lazy emission States

v.g.vassilev added reviewers: rsmith, rjmccall. v.g.vassilev added a comment. Let's add more reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130420/new/ https://reviews.llvm.org/D130420 ___ cfe-

[PATCH] D130422: [clang-repl] Fix incorrect return code

v.g.vassilev added inline comments. Comment at: clang/test/Interpreter/fail.cpp:6 +// UNSUPPORTED: system-aix +// XFAIL: * +// CHECK-DRIVER: i = 10 Why this is marked as XFAIL? If it is only for the return code we can add the `not` command in front to make the e

[PATCH] D127284: [WIP] [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:5247-5248 + // ObjC + case tok::at: +return getLangOpts().ObjC; + rsmith wrote: > In Objective-C, both declarations and expressions can start with `@`. In > general we'd need to

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov updated this revision to Diff 447091. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130308/new/ https://reviews.llvm.org/D130308 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp clang/lib/Sema/SemaTemplateDeduc

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

MaskRay added inline comments. Comment at: clang/lib/Basic/Targets/LoongArch.h:24 + +class LoongArchTargetInfo : public TargetInfo { +protected: LLVM_LIBRARY_VISIBILITY Comment at: clang/lib/Basic/Targets/LoongArch.h:35 +SuitableAlign = 128

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

iains updated this revision to Diff 447094. iains added a comment. rebase, update testcases for upstream changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126694/new/ https://reviews.llvm.org/D126694 Files: clang/include/clang/AST/DeclBase.

[clang-tools-extra] c730f9a - Convert for_each to range-based for loops (NFC)

Author: Kazu Hirata Date: 2022-07-23T12:17:27-07:00 New Revision: c730f9a164eacc30fdd0f6ae202211ef8a63b64a URL: https://github.com/llvm/llvm-project/commit/c730f9a164eacc30fdd0f6ae202211ef8a63b64a DIFF: https://github.com/llvm/llvm-project/commit/c730f9a164eacc30fdd0f6ae202211ef8a63b64a.diff L

[PATCH] D130299: [clang-format] FIX: Misannotation 'auto' as trailing return type in lambdas

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Thanks for the changes. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:752 +TEST_F(TokenAnnotatorTest, UnderstandsTrailingReturnTypeAutoI

[PATCH] D130417: [clang-format] Missing space between trailing return type 'auto' and left brace

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130417/new/ https://reviews.llvm.org/D130417

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

mstorsjo added a comment. In D129377#3673237 , @mib wrote: > In D129377#3673204 , @mstorsjo > wrote: > >> This broke building of Clang, when it's set up by symlinking >> `llvm-project/clang` into `llvm-project/l

[PATCH] D127284: [WIP] [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 447098. v.g.vassilev added a comment. Keep the patch minimal, exclude opencl, etc for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files: clang/include/clang/AST/ASTConsumer.h clang/includ

[PATCH] D127284: [WIP] [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added inline comments. Comment at: clang/lib/CodeGen/ModuleBuilder.cpp:179 +bool +HandleTopLevelStmts(const llvm::SmallVectorImpl &Stmts) override { + if (Diags.hasErrorOccurred()) Hi @rjmccall, this patch tries to add support for statem

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:17875 +return true; + if (!Context.hasSameType(M1->getParamDecl(0)->getType(), + M2->getParamDecl(0)->getType())) shafik wrote: > What happens if we have fur

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

augusto2112 added a comment. Hi @aaron.ballman, it looks like this broke 2 tests in the lldb test suite (https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/45560/). Can we revert this to keep CI green? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

augusto2112 added a comment. Actually, never mind, I think I can fix the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129881/new/ https://reviews.llvm.org/D129881 ___ cfe-commits mailing list cfe

[clang] 944cb96 - clang/include/clang/module.modulemap: Mark `Tooling/Inclusions/*.inc` as textual.

Author: NAKAMURA Takumi Date: 2022-07-24T09:32:34+09:00 New Revision: 944cb96429b874e5bf9c672e0013914573227fcd URL: https://github.com/llvm/llvm-project/commit/944cb96429b874e5bf9c672e0013914573227fcd DIFF: https://github.com/llvm/llvm-project/commit/944cb96429b874e5bf9c672e0013914573227fcd.dif

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

pscoro updated this revision to Diff 447102. pscoro added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129016/new/ https://reviews.llvm.org/D129016 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Basic/Targets/PPC

[PATCH] D130422: [clang-repl] Fix incorrect return code

junaire updated this revision to Diff 447103. junaire added a comment. Use `not` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130422/new/ https://reviews.llvm.org/D130422 Files: clang/test/Interpreter/fail.cpp clang/tools/clang-repl/ClangRepl

[PATCH] D125272: [clang] Add -fcheck-new support

heatd added a comment. In D125272#3531836 , @heatd wrote: > In D125272#3515874 , @heatd wrote: > >> In D125272#3504113 , @heatd wrote: >> >>> Adjusted the driver code to u

[PATCH] D130421: [Clang] De-deprecate volatile compound operations

shafik added a comment. LGTM but I will let Aaron accept it. Comment at: clang/docs/ReleaseNotes.rst:523 This feature is available as an extension in all C and C++ language modes. +- Implemented `P2327 De-deprecating volatile compound operations `

[PATCH] D130299: [clang-format] FIX: Misannotation 'auto' as trailing return type in lambdas

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:752 +TEST_F(TokenAnnotatorTest, UnderstandsTrailingReturnTypeAutoInLabmdas) { + auto Tokens = annotate("[]() -> auto {}"); HazardyKnusperke

[PATCH] D130417: [clang-format] Missing space between trailing return type 'auto' and left brace

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:23555-23556 + FormatStyle Style = getLLVMStyle(); + verifyFormat("[]() -> auto { return Val; }", Style); + verifyFormat("auto foo() -> auto { return Val; }", Style)

[PATCH] D101070: [llvm][cmake] Make `llvm_install_symlink` robust to absolute dirs.

Ericson2314 updated this revision to Diff 447107. Ericson2314 added a comment. Rebase, hopefully fix, and also fix stray GNUInstallDirs violation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101070/new/ https://reviews.llvm.org/D101070 Files: l

[PATCH] D101070: [llvm][cmake] Make `install_symlink` robust to absolute dirs.

Ericson2314 updated this revision to Diff 447108. Ericson2314 added a comment. Rebase to retrigger CI I think it tried to cherry-pick an already-landed patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101070/new/ https://reviews.llvm.org/D1010

[PATCH] D130411: [clang-format] Fix a hang when formatting C# $@ string literals

curdeius accepted this revision. curdeius added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:536 + // $"{x ?? "null"}" + // should not be split into $"{x ?? ", null, "}" but should treated as a + // single string-literal. Repository:

[PATCH] D130417: [clang-format] Missing space between trailing return type 'auto' and left brace

curdeius accepted this revision. curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:23555-23556 + FormatStyle Style = getLLVMStyle(); + verifyFormat("[]() -> auto { return Val; }", Style); + verifyFormat("auto foo() -> auto { return Val; }", Styl

[PATCH] D130299: [clang-format] FIX: Misannotation 'auto' as trailing return type in lambdas

curdeius accepted this revision. curdeius added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:752 +TEST_F(TokenAnnotatorTest, UnderstandsTrailingReturnTypeAutoInLabmdas) { + auto Tokens = annotate("[]() -> auto {}"); owenpan wrote:

[PATCH] D130421: [Clang] De-deprecate volatile compound operations

cor3ntin updated this revision to Diff 447109. cor3ntin added a comment. Fix paper number in release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130421/new/ https://reviews.llvm.org/D130421 Files: clang/docs/ReleaseNotes.rst clang/inc

[PATCH] D130421: [Clang] De-deprecate volatile compound operations

cor3ntin added a comment. @shafik Thanks for the review! Comment at: clang/docs/ReleaseNotes.rst:523 This feature is available as an extension in all C and C++ language modes. +- Implemented `P2327 De-deprecating volatile compound operations `_

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin marked 3 inline comments as done. cor3ntin added a comment. @shafik I just realized i forgot to submit a bunch of replies i had to your comments, sorry about that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.l

[PATCH] D130437: [clang] Fix incorrect constant folding of `if consteval`

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/55638. `if consteval` was evaluated incorrectly when in a non-constant