iains marked 2 inline comments as done.
iains added a comment.
it would be good to get this landed before llvm-15 branches..
================
Comment at: clang/lib/Sema/SemaLookup.cpp:3864-3878
+ for (auto *E : AssociatedClasses) {
+ // and have the same innermost enclosing non-inline namespace
+ // scope as a declaration of an associated entity attached to M
+ if (!E->hasOwningModule() || E->getOwningModule() != FM)
+ continue;
+ // TODO: maybe this could be cached when generating the
+ // associated namespaces / entities.
----------------
ChuanqiXu wrote:
> iains wrote:
> > ChuanqiXu wrote:
> > > nit: how do you think about the suggested style? (not required)
> > I guess it's a little shorter, and roughly the same in readability,
> >
> The current implementation skips a `break` of the outer loop.
I'm not sure exactly what you are referring to here (maybe I missed something)
-
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129174/new/
https://reviews.llvm.org/D129174
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
