[PATCH] D129797: [clang-tidy] Reduce the dependencies for the "make-confusable-table" tool

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. I'm fine with this too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129797/new/ https://reviews.llvm.org/D129797 __

[PATCH] D129798: [clang-tidy] Add a "clang-" namespace prefix to the make-confusable-target executable

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM, thanks for doing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129798/new/ https://reviews.llvm.org/D129798 _

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

zixuan-wu added inline comments. Comment at: clang/lib/Driver/Driver.cpp:660 + +if (RVArch == llvm::Triple::riscv64 && +ArchName.startswith_insensitive("rv32")) eopXD wrote: > Do we need to throw error (or warning) when these two (`RVArch` and > `Arc

[clang] 4983fdf - [C++20] [Modules] Handle reachability for deduction guide

Author: Chuanqi Xu Date: 2022-07-18T15:46:26+08:00 New Revision: 4983fdfec0443cf388adb87b816b7298a7bdf273 URL: https://github.com/llvm/llvm-project/commit/4983fdfec0443cf388adb87b816b7298a7bdf273 DIFF: https://github.com/llvm/llvm-project/commit/4983fdfec0443cf388adb87b816b7298a7bdf273.diff LO

[PATCH] D128621: [clangd] Do not try to use $0 as a placeholder in completion snippets

nridge updated this revision to Diff 445407. nridge added a comment. Revise patch to use $0 (no placeholder text) rather than ${n:placeholder} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128621/new/ https://reviews.llvm.org/D128621 Files: clan

[PATCH] D128621: [clangd] Do not try to use $0 as a placeholder in completion snippets

nridge added a comment. In D128621#3645271 , @sammccall wrote: > - Of the ideas we've heard, I like `${0:named}` => `$0` best, but can > certainly live with the one in this patch I like this approach as well. Revised the patch to do this. Repository:

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 445410. pmatos added a comment. Completely refactored the initial solution to funcref implementation and design. Now it works similarly to the __ptr32 attribute from -fms-extensions. We keep _both_ attribute and address space through the frontend, which is th

[PATCH] D121141: [Clang] Add `-fexperimental-library` flag to enable unstable and experimental features: follow-up fixes

phosek added a comment. In D121141#3656100 , @mstorsjo wrote: > In D121141#3655323 , @ldionne wrote: > >> The `experimental-library-flag` test is currently failing on Windows because >> on Windows, `-stdlib=libc+

[clang-tools-extra] b94ea8b - [pseudo] Add bracket recovery for function parameters.

Author: Haojian Wu Date: 2022-07-18T10:23:15+02:00 New Revision: b94ea8b3ebc16504b668fd7086de544637e0cd53 URL: https://github.com/llvm/llvm-project/commit/b94ea8b3ebc16504b668fd7086de544637e0cd53 DIFF: https://github.com/llvm/llvm-project/commit/b94ea8b3ebc16504b668fd7086de544637e0cd53.diff LO

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

Izaron added a comment. Hi! Unfortunately I don't have time to finish this pull request, so please feel free to take it and get it done =) (You may reuse the code from this PR or write a completely new implementation) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

StephenFan updated this revision to Diff 445420. StephenFan added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. 1. Rebase. 2. Add a test case of goto_bypass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129448/ne

[PATCH] D129648: Use pseudo parser for folding ranges

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, this looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129648/new/ https://reviews.llvm.org/D129648 ___

[PATCH] D128927: [libc++] Always build c++experimental.a

hans added a comment. In D128927#3648652 , @ldionne wrote: > In D128927#3648616 , @fhahn wrote: > >> It looks like this is causing macOS builds to fail on GreenDragon. Please >> take a look and refer the commit i

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

hokein updated this revision to Diff 445427. hokein marked 3 inline comments as done. hokein added a comment. rebase and add comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129222/new/ https://reviews.llvm.org/D129222 Files: clang-tools-

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

StephenFan added inline comments. Comment at: clang/test/CodeGen/lifetime2.c:78 break; case 2: bar(&x, 1); vitalybuka wrote: > vitalybuka wrote: > > StephenFan wrote: > > > vitalybuka wrote: > > > > vitalybuka wrote: > > > > > Please check for lifeti

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

hokein added a comment. All comments should be addressed now. As discussed offline, I'm going to land it now, happy to address any post comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129222/new/ https://reviews.llvm.org/D129222 _

[clang-tools-extra] 70914aa - Use pseudo parser for folding ranges

Author: Utkarsh Saxena Date: 2022-07-18T11:35:34+02:00 New Revision: 70914aa631561aa9a29681bfe5159b4ea6952060 URL: https://github.com/llvm/llvm-project/commit/70914aa631561aa9a29681bfe5159b4ea6952060 DIFF: https://github.com/llvm/llvm-project/commit/70914aa631561aa9a29681bfe5159b4ea6952060.diff

[PATCH] D129648: Use pseudo parser for folding ranges

This revision was automatically updated to reflect the committed changes. Closed by commit rG70914aa63156: Use pseudo parser for folding ranges (authored by usaxena95). Changed prior to commit: https://reviews.llvm.org/D129648?vs=445002&id=445432#toc Repository: rG LLVM Github Monorepo CHAN

[PATCH] D103313: [RISCV][Clang] Add support for Zmmul extension

asb added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:80 +{"zmmul", RISCVExtensionVersion{0, 1}}, + craig.topper wrote: > If it is ratified, is the version really 0.1? It looks like it should be 1.0 now https://github.com/riscv/riscv-isa

[PATCH] D129992: [clang][OpenMP] Add IRBuilder support for taskgroup

shraiysh created this revision. Herald added subscribers: guansong, yaxunl. Herald added a project: All. shraiysh requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch makes use of OMPIRBuil

[clang] f764dc9 - [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

Author: serge-sans-paille Date: 2022-07-18T12:45:52+02:00 New Revision: f764dc99b37e1e6428724a61f36bcb49c015dc70 URL: https://github.com/llvm/llvm-project/commit/f764dc99b37e1e6428724a61f36bcb49c015dc70 DIFF: https://github.com/llvm/llvm-project/commit/f764dc99b37e1e6428724a61f36bcb49c015dc70.d

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille closed this revision. serge-sans-paille added a comment. Forgot the commit tag: just landed it as f764dc99b37e1e6428724a61f36bcb49c015dc70 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: [clang] ee88c0c - [NFCI] Fix unused variable/function warnings in MacroCallReconstructorTest.cpp when asserts are disabled.

Ping :) On Wed, Jul 13, 2022 at 11:43 AM Manuel Klimek wrote: > This is a functional change, as it removes the debug output when the > tokens do not match, which is important for understanding test failures. > > On Wed, Jul 13, 2022 at 1:47 AM Jorge Gorbe Moya via cfe-commits < > cfe-commits@lis

[clang-tools-extra] 098488e - [pseduo] More precise on printing the error message, NFC

Author: Haojian Wu Date: 2022-07-18T13:23:18+02:00 New Revision: 098488e09a320a09bebcac2bac4c9c12bbe6db76 URL: https://github.com/llvm/llvm-project/commit/098488e09a320a09bebcac2bac4c9c12bbe6db76 DIFF: https://github.com/llvm/llvm-project/commit/098488e09a320a09bebcac2bac4c9c12bbe6db76.diff LO

[PATCH] D128697: [clang-tidy] Add new check `bugprone-unhandled-exception-at-sto`

Sockke added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128697/new/ https://reviews.llvm.org/D128697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke added a comment. Friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org/D127293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D129573: [Clang] add a diagnostic note 'while loop outside functions' at global scope

inclyc updated this revision to Diff 445455. inclyc edited the summary of this revision. inclyc added a comment. Now it only generates 1 error encountering token "while" ./local/while_loop_outside_func.cpp:1:1: error: while loop outside of function while (true) { ^ 1 error generated. CH

[PATCH] D129573: [Clang] add a diagnostic note 'while loop outside functions' at global scope

inclyc updated this revision to Diff 445458. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129573/new/ https://reviews.llvm.org/D129573 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/lib/Parse/ParseDecl.cpp clang/test/Parser/while-loop-outside-function.c clang/tes

[PATCH] D103313: [RISCV][Clang] Add support for Zmmul extension

ksyx updated this revision to Diff 445461. ksyx marked an inline comment as done. ksyx added a comment. Update zmmul version & rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ https://reviews.llvm.org/D103313 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Drive

[PATCH] D128927: [libc++] Always build c++experimental.a

hans added a comment. After some more digging, it seems we're hitting the same issue as we did back in https://reviews.llvm.org/D82702#2153130 and now the work-around of passing `-DLIBCXX_ENABLE_EXPERIMENTAL_LIBRARY=OFF` stopped working. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D129706: [NFCI][clang-tidy] Reimplement GlobList without relying on Regex.

njames93 updated this revision to Diff 445464. njames93 added a comment. Enable escaping the leading `-` at the start of a glob to match strings starting with a `-`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129706/new/ https://reviews.llvm.or

[clang] 4b03ad6 - [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

Author: Vaibhav Yenamandra Date: 2022-07-18T08:37:59-04:00 New Revision: 4b03ad650645e2f74a8824c8f69b095ca321fdfe URL: https://github.com/llvm/llvm-project/commit/4b03ad650645e2f74a8824c8f69b095ca321fdfe DIFF: https://github.com/llvm/llvm-project/commit/4b03ad650645e2f74a8824c8f69b095ca321fdfe.

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b03ad650645: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface (authored by vaibhav.y, committed by aaron.ballman). Re

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov marked an inline comment as done. mizvekov added a comment. @JDevlieghere @teemperor ping. Sorry for the urgency here, but I have a lot of work built on top of this patch. And this patch fixes a bunch of bugs that other people are unaware and duplicating effort, see github issues. Re

[PATCH] D130003: [clangd] Use empty string to represent None semantics in FoldingRange::kind

kadircet created this revision. kadircet added a reviewer: usaxena95. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository:

[PATCH] D129706: [NFCI][clang-tidy] Reimplement GlobList without relying on Regex.

njames93 updated this revision to Diff 445469. njames93 added a comment. Ensure escaped negatives are printed correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129706/new/ https://reviews.llvm.org/D129706 Files: clang-tools-extra/clang-ti

[clang-tools-extra] 0496cf2 - [clangd] Use empty string to represent None semantics in FoldingRange::kind

Author: Kadir Cetinkaya Date: 2022-07-18T15:01:48+02:00 New Revision: 0496cf2f6a2ef640ad6577b083068be59c3ea137 URL: https://github.com/llvm/llvm-project/commit/0496cf2f6a2ef640ad6577b083068be59c3ea137 DIFF: https://github.com/llvm/llvm-project/commit/0496cf2f6a2ef640ad6577b083068be59c3ea137.dif

[PATCH] D130003: [clangd] Use empty string to represent None semantics in FoldingRange::kind

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0496cf2f6a2e: [clangd] Use empty string to represent None semantics in FoldingRange::kind (authored by kadircet). Repository: rG LLVM Github Monor

[PATCH] D130004: [pseudo] Add `clang-pseudo -html-forest=`, an HTML forest browser

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a subscriber: mgorny. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. It generates a standalon

[PATCH] D130005: [clang-tidy] Prettify GlobList before serializing Options

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, LegalizeAdulthood. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: cl

[PATCH] D128621: [clangd] Do not try to use $0 as a placeholder in completion snippets

sammccall accepted this revision. sammccall added a comment. Thank you! Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:195 ++SnippetArg; - *Snippet += - "${" + - std::to_string(SnippetArg == CursorSnippetArg ? 0 : SnippetArg) + ':'

[PATCH] D128621: [clangd] Do not try to use $0 as a placeholder in completion snippets

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LG, just some extra precautions. Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:195 ++SnippetArg; - *Snippet += - "${" + -

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

njames93 added a comment. Can you add test cases where there is a struct with an anonymous union and another field that does need an initializer, just to verify warning and fixit behaviour. struct S3 { S3() {} int A; union { int B; int C = 0; // Possibly a case where t

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

nikic added a comment. Given that LLVM 15 branches off in one week, maybe it would be better to wait for that before relanding the change, as it seems to have significant impact on plugins? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/

[PATCH] D129953: [PATCH] [clang-tidy] NFC: add preposition "of" to code annotation of ElseAfterReturnCheck

zhouyizhou added a comment. Hi, I have no write access to LLVM, could you commit for me at your convenience ;-) Many thanks Zhouyi Zhou Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129953/new/ https://reviews.llvm.org/D129953

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3659597 , @nikic wrote: > Given that LLVM 15 branches off in one week, maybe it would be better to wait > for that before relanding the change, as it seems to have significant impact > on plugins? I think it would m

[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

martong added inline comments. Comment at: clang/test/Analysis/print-ranges.cpp:1 +// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection -analyzer-config eagerly-assume=false -verify %s +// REQUIRES: no-z3 ASDenysPetrov wrote: > martong wrote: >

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 445490. pmatos added a comment. Updated patch over current main. Fixed all failint tests. Ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: cl

[PATCH] D130011: Use pseudoparser-based folding ranges in ClangdServer.

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[clang] 313f8a2 - Don't include private gtest/gmock headers

Author: Benjamin Kramer Date: 2022-07-18T16:34:36+02:00 New Revision: 313f8a20fdf968501a79c7f9aaaf77ae0faaf907 URL: https://github.com/llvm/llvm-project/commit/313f8a20fdf968501a79c7f9aaaf77ae0faaf907 DIFF: https://github.com/llvm/llvm-project/commit/313f8a20fdf968501a79c7f9aaaf77ae0faaf907.dif

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 445493. pmatos added a comment. Remove some extraneous spaces I hadn't noticed before. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang/include/clang/AST

[libunwind] 24ec521 - [libunwind][SystemZ] Use process_vm_readv to avoid potential segfaults

Author: Ulrich Weigand Date: 2022-07-18T16:54:48+02:00 New Revision: 24ec521cd7bb51447f4ab03460d91c57378d49f7 URL: https://github.com/llvm/llvm-project/commit/24ec521cd7bb51447f4ab03460d91c57378d49f7 DIFF: https://github.com/llvm/llvm-project/commit/24ec521cd7bb51447f4ab03460d91c57378d49f7.diff

[clang] 09cebfb - Revert "[libc++] Always build c++experimental.a"

Author: Hans Wennborg Date: 2022-07-18T16:57:15+02:00 New Revision: 09cebfb978def7fa2a4460bca89690f8d3608216 URL: https://github.com/llvm/llvm-project/commit/09cebfb978def7fa2a4460bca89690f8d3608216 DIFF: https://github.com/llvm/llvm-project/commit/09cebfb978def7fa2a4460bca89690f8d3608216.diff

[PATCH] D128927: [libc++] Always build c++experimental.a

hans added a subscriber: thakis. hans added a comment. After discussing with @thakis a bit, I've reverted this in 09cebfb978def7fa2a4460bca89690f8d3608216 to bring builds back to a green state while we figure out what's going

[PATCH] D130011: Use pseudoparser-based folding ranges in ClangdServer.

kadircet added a comment. as discussed offline i don't see much value in having an extra flag to choose between ast-based and pseudo-based implementation, as the pseudo-based one is a super-set of the ast-based implementation. hence it shouldn't be regressing change in any way, therefore i am i

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

ckandeler created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Counterpart to "usedAsMutabl

[PATCH] D130016: [HLSL] Add __builtin_hlsl_create_handle

beanz created this revision. beanz added reviewers: aaron.ballman, Anastasia, kuhar, bogner, python3kgae. Herald added a project: All. beanz requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. This is pretty straightforward, it just adds

[PATCH] D130017: [HLSL] Add RWBuffer default constructor

beanz created this revision. beanz added reviewers: aaron.ballman, Anastasia, kuhar, bogner, python3kgae. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. This fills out the default constructor for RWBuffer to assign the handle with the result of

[PATCH] D130018: [HLSL] Add HLSLResource attribute

beanz created this revision. beanz added reviewers: aaron.ballman, Anastasia, kuhar, bogner, python3kgae. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. HLSL Resource objects will have restrictions on use and codegen requirements. This patch is

[PATCH] D130019: [HLSL] CodeGen HLSL Resource annotations

beanz created this revision. beanz added reviewers: aaron.ballman, Anastasia, kuhar, bogner, python3kgae. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. HLSL Resource types need special annotations that the backend will use to build out metadat

[PATCH] D56303: [clang-tidy] Recognize labelled statements when simplifying boolean exprs

kwk added subscribers: tstellar, serge-sans-paille, kwk. kwk added inline comments. Herald added a project: All. Comment at: clang-tools-extra/unittests/clang-tidy/ReadabilityModuleTest.cpp:1 +#include "../../clang/unittests/ASTMatchers/ASTMatchersTest.h" #include "ClangTidyTest

[PATCH] D109977: LLVM Driver Multicall tool

abrachet added a comment. In D109977#3652467 , @mgorny wrote: > In D109977#3652091 , @abrachet > wrote: > >> Could I have a cmake invocation or a bot link? > > The exact CMake invocation for clang is: > > cmake

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 445524. pmatos added a comment. Cleanedup the code. Ready to review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 Files: clang/include/clang/AST/Type.h clang/in

[PATCH] D129174: [C++20][Modules] Update ADL to handle basic.lookup.argdep p4 [P1815R2 part 1]

iains updated this revision to Diff 445530. iains marked 5 inline comments as done. iains added a comment. rebased, addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129174/new/ https://reviews.llvm.org/D129174 Files: clan

[PATCH] D129174: [C++20][Modules] Update ADL to handle basic.lookup.argdep p4 [P1815R2 part 1]

iains added a comment. sorry got a little delayed in responding to this (sorting out some testing problems) Comment at: clang/lib/Sema/SemaLookup.cpp:3859 +// C++20 [basic.lookup.argdep] p4.3 .. are exported +Module *FM = D->getOwningModule(); +

[PATCH] D129864: [Flang] Generate documentation for compiler flags

awarzynski added a comment. Makes sense, thanks for working on this! Some minor comments below and inline. From your summary: > This is done by using clang tablegen What do you mean by "clang tablegen"? Is it Clang's clang_tablegen

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

jyknight added a comment. Sorry if I was unclear -- I did intend that the remaining minor open comments be addressed before commit. I've quoted them again here for clarity. Please address in a follow-up, thanks! Comment at: clang/include/clang/Driver/Options.td:1143 Marsha

[clang] fbbabd4 - [Tooling/DependencyScanning] Enable passing a `vfs::FileSystem` object to `DependencyScanningTool`

Author: Argyrios Kyrtzidis Date: 2022-07-18T09:37:17-07:00 New Revision: fbbabd4ca06a030b714220f17b1c6e74a9ea3c4d URL: https://github.com/llvm/llvm-project/commit/fbbabd4ca06a030b714220f17b1c6e74a9ea3c4d DIFF: https://github.com/llvm/llvm-project/commit/fbbabd4ca06a030b714220f17b1c6e74a9ea3c4d.

[PATCH] D129912: [Tooling/DependencyScanning] Enable passing a `vfs::FileSystem` object to `DependencyScanningTool`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfbbabd4ca06a: [Tooling/DependencyScanning] Enable passing a `vfs::FileSystem` object to… (authored by akyrtzi). Repository: rG LLVM Github Monorep

[PATCH] D130011: Use pseudoparser-based folding ranges in ClangdServer.

usaxena95 updated this revision to Diff 445547. usaxena95 added a comment. Removed option to fallback to AST based implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130011/new/ https://reviews.llvm.org/D130011 Files: clang-tools-extr

[PATCH] D130011: Use pseudoparser-based folding ranges in ClangdServer.

usaxena95 added a comment. Let us land this after the branch cut then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130011/new/ https://reviews.llvm.org/D130011 ___ cfe-commits mailing list cfe-commits@

[PATCH] D130016: [HLSL] Add __builtin_hlsl_create_handle

python3kgae added inline comments. Comment at: clang/test/CodeGenHLSL/builtins/create_handle.hlsl:4 +void fn() { + (void)__builtin_hlsl_create_handle(0); +} What does the parameter 0 mean here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas updated this revision to Diff 445549. manas added a comment. Remove filling gaps and convert, use castTo, and add tests for short-ushort, char-uchar pairs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/ https://reviews.llvm.org/D112

[clang] 47b0aa5 - [LinkerWrapper] Rework passing args to the LLVM backend

Author: Joseph Huber Date: 2022-07-18T12:44:15-04:00 New Revision: 47b0aa5e4be7ba88bab60b9573407be1f6c387b1 URL: https://github.com/llvm/llvm-project/commit/47b0aa5e4be7ba88bab60b9573407be1f6c387b1 DIFF: https://github.com/llvm/llvm-project/commit/47b0aa5e4be7ba88bab60b9573407be1f6c387b1.diff

[PATCH] D56303: [clang-tidy] Recognize labelled statements when simplifying boolean exprs

njames93 added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/ReadabilityModuleTest.cpp:1 +#include "../../clang/unittests/ASTMatchers/ASTMatchersTest.h" #include "ClangTidyTest.h" kwk wrote: > @LegalizeAdulthood I'm doing standalone builds

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas marked 5 inline comments as done. manas added a comment. Considering @ASDenysPetrov 's example of `LHS = [1, 2] U [8, 9]` and `RHS = [5, 6]`, I constructed a test case as following: `(((u1 >= 1 && u1 <= 2) || (u1 >= 8 && u1 <= 9)) && u2 >= 5 && u2 <= 6)` but I can see that the analyzer is

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

abrahamcd updated this revision to Diff 445554. abrahamcd retitled this revision from "[clang] Add -fdiagnostics-format=sarif for SARIF diagnostics" to "[clang] Add -fdiagnostics-format=sarif option for future SARIF output". abrahamcd edited the summary of this revision. abrahamcd added a comment

[PATCH] D130026: [clang-tidy] Remove unnecessary code from ReadabilityModuleTest

njames93 created this revision. njames93 added reviewers: LegalizeAdulthood, aaron.ballman, kwk, serge-sans-paille. Herald added subscribers: xazax.hun, mgorny. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscr

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

abrahamcd added a comment. In D129886#3656221 , @vaibhav.y wrote: > Might be worth hiding it from `--help`, despite the instability warning. I already couldn't find any mention of `-fdiagnostics-format` or `sarif` when I ran `clang --help`. Is there so

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

abrahamcd added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:684 + "diagnostic formatting in SARIF mode is currently unstable">, + InGroup>; } Please let me know if there's a better warning group you think this should be in.

[PATCH] D130016: [HLSL] Add __builtin_hlsl_create_handle

beanz added inline comments. Comment at: clang/test/CodeGenHLSL/builtins/create_handle.hlsl:4 +void fn() { + (void)__builtin_hlsl_create_handle(0); +} python3kgae wrote: > What does the parameter 0 mean here? > For the purposes of this test, the value doesn't m

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

vaibhav.y added a comment. In D129886#3660299 , @abrahamcd wrote: > In D129886#3656221 , @vaibhav.y > wrote: > >> Might be worth hiding it from `--help`, despite the instability warning. > > I already couldn't fi

[PATCH] D130029: [analyzer][NFC] Use `SValVisitor` instead of explicit helper functions

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: martong, NoQ, steakhal. ASDenysPetrov added a project: clang. Herald added subscribers: manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All

[PATCH] D126534: [analyzer] Deadstore static analysis: Fix false positive on C++17 assignments

frederic-tingaud-sonarsource marked an inline comment as done. frederic-tingaud-sonarsource added a comment. Hi @NoQ , Do the changes correspond to what you had in mind? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126534/new/ https://reviews.llvm.org/D126534 _

[PATCH] D130029: [analyzer][NFC] Use `SValVisitor` instead of explicit helper functions

ASDenysPetrov added a comment. In D90157#2518118 , @steakhal wrote: > Why don't you use the `SValVisitor` instead? @steakhal Finally fulfilled you suggestion :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D130019: [HLSL] CodeGen HLSL Resource annotations

beanz updated this revision to Diff 445572. beanz added a comment. Updating based on feedback from @python3kgae provided via chat. Because of the odd nature of DXIL, the DirectX backend needs to filter the module flags, for that reason it is easier to use a named metadata entry which can just be

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

cjdb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:684 + "diagnostic formatting in SARIF mode is currently unstable">, + InGroup>; } abrahamcd wrote: > Please let me know if there's a better warning group you think this

[PATCH] D130026: [clang-tidy] Remove unnecessary code from ReadabilityModuleTest

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130026/new/ https://reviews.llvm.org/D130026

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

rusyaev-roman added a comment. In D119792#3658987 , @Izaron wrote: > Hi! > > Unfortunately I don't have time to finish this pull request, so please feel > free to take it and get it done =) > > (You may reuse the code from this PR or write a completely n

[PATCH] D129902: [AMDGPU] Support for gfx940 fp8 conversions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9fa5a6b7e8a2: [AMDGPU] Support for gfx940 fp8 conversions (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commi

[clang] 9fa5a6b - [AMDGPU] Support for gfx940 fp8 conversions

Author: Stanislav Mekhanoshin Date: 2022-07-18T11:48:43-07:00 New Revision: 9fa5a6b7e8a292ec91b844a622836d2990ef5796 URL: https://github.com/llvm/llvm-project/commit/9fa5a6b7e8a292ec91b844a622836d2990ef5796 DIFF: https://github.com/llvm/llvm-project/commit/9fa5a6b7e8a292ec91b844a622836d2990ef57

[PATCH] D130033: [HLSL] Add resource binding attribute for HLSL.

python3kgae created this revision. python3kgae added reviewers: svenvh, asavonic, beanz, pow2clk, Anastasia, aaron.ballman. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The resource binding attri

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

denik added a comment. Thanks for adding the flag! Comment at: clang/include/clang/Basic/DiagnosticGroups.td:1383 + +def SarifFormatUnstable : DiagGroup<"sarif-format-unstable">; cjdb wrote: > Please make sure that there's a newline at the end of each file. I g

[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules

tahonermann added a comment. Thank you for the detailed explanation, @ChuanqiXu, that was very helpful. It looks to me like the problem may be that the initial declaration of the `basic_string_view` class template is non-defining, but when serializing that declaration, we serialize a definition

[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules

tahonermann added a comment. I neglected to explicitly mention in conjunction with my last comment, but @ChuanqiXu, can you check to see if we are indeed serializing class template specializations "too early" and, if so, whether delaying such serialization until a defining point resolves the is

[clang] 2695f0a - [AMDGPU] Support for gfx940 fp8 mfma

Author: Stanislav Mekhanoshin Date: 2022-07-18T11:49:56-07:00 New Revision: 2695f0a688e9d26fcb0f3a4b686a2783f2eb145c URL: https://github.com/llvm/llvm-project/commit/2695f0a688e9d26fcb0f3a4b686a2783f2eb145c DIFF: https://github.com/llvm/llvm-project/commit/2695f0a688e9d26fcb0f3a4b686a2783f2eb14

[PATCH] D129906: [AMDGPU] Support for gfx940 fp8 mfma

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2695f0a688e9: [AMDGPU] Support for gfx940 fp8 mfma (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commits. Re

[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules

aaron.ballman added a comment. In D129748#3658657 , @ChuanqiXu wrote: > In D129748#3654918 , @aaron.ballman > wrote: > >> For example, I would be IBOutletCollection, OwnerAttr, PointerAttr, and >> TypeTagForData

[PATCH] D129573: [Clang] add a diagnostic note 'while loop outside functions' at global scope

mizvekov added a comment. In D129573#3659404 , @inclyc wrote: > Now it only generates 1 error encountering token "while" Yes thank you, that is what I meant! But now we just gotta make sure this stays true for more complex test cases. ===

[PATCH] D128465: [OLD] [llvm] add zstd to `llvm::compression` namespace

MaskRay added a comment. Instead of marking a differential `[OLD] ` (which may confuse readers whether this is to be abandoned), you can mark a differential `Request Reviews`/`Request Changes`. Then it will not be in the green state. I clicked "Reopen" to make it clear the patch hasn't relanded

  1   2   >