denik added a comment.
Thanks for adding the flag!
================
Comment at: clang/include/clang/Basic/DiagnosticGroups.td:1383
+
+def SarifFormatUnstable : DiagGroup<"sarif-format-unstable">;
----------------
cjdb wrote:
> Please make sure that there's a newline at the end of each file.
I guess you don't need a new entry here since you used
InGroup<DiagGroup<"sarif-format-unstable">>.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4009
CmdArgs.push_back(A->getValue());
+ if (std::string(A->getValue()) == "sarif") {
+ D.Diag(diag::warn_drv_sarif_format_unstable);
----------------
nit: I would replace it with StringRef.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129886/new/
https://reviews.llvm.org/D129886
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
