[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

domada added inline comments. Comment at: clang/test/OpenMP/irbuilder_simd.cpp:15 P pp; -#pragma omp simd +#pragma omp simd simdlen(3) for (int i = 3; i < 32; i += 5) { Could you add separate test case instead of modifying existing test case? Repository:

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. I have seen multiple reports that distributors found this behavior change surprising. I agree that having this more complex symbol versioning with libclang.so probably doesn't improve

[PATCH] D129174: [C++20][Modules] Invalidate internal-linkage functions in overload sets [P1815R2 part 1]

iains created this revision. Herald added a project: All. iains added reviewers: urnathan, ChuanqiXu. iains added a subscriber: clang-modules. iains published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is an implementation of the first par

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

shraiysh added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2596 // Check for unsupported clauses - if (!S.clauses().empty()) { -// Currently no clause is supported -return false; + for (OMPClause *C : S.clauses()) { +// Currently only simdlen

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

h-vetinari added a comment. Forgot to mention it before: would be good to note this in the release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129160/new/ https://reviews.llvm.org/D129160 ___ cfe

[PATCH] D129043: [RISCV][Clang] Teach RISCVEmitter to generate BitCast for pointer operands.

fakepaper56 added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:111 +if (I.value()->isPointer()) { + assert(RVVI->getIntrinsicTypes().front() == -1 && + "RVVI should be vector load intrinsic."); khchen wrote: > I feel th

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

iains added a comment. Perhaps we could be a little more bold about the completeness of the implementation (at least, w.r.t the base paper `P1103`) - we pass the relevant test cases. As for the follow-on papers, I think we have more that can be added notes below: There are some test cases to be

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable

ChuanqiXu added a reviewer: nikic. ChuanqiXu marked 2 inline comments as done. ChuanqiXu added a comment. In D125291#3629276 , @nikic wrote: > FWIW the bitcode patch has landed, so implementing the variant using a token > type should be possible now. I'm

[PATCH] D125693: [DebugInfo] Support types, imports and static locals declared in a lexical block (3/5)

krisb added inline comments. Comment at: llvm/test/Instrumentation/InstrProfiling/debug-info-correlate.ll:23 call void @llvm.instrprof.increment(i8* getelementptr inbounds ([3 x i8], [3 x i8]* @__profn_foo, i32 0, i32 0), i64 12345678, i32 2, i32 0) - ret void + ret void, !

[PATCH] D129174: [C++20][Modules] Invalidate internal-linkage functions in overload sets [P1815R2 part 1]

ChuanqiXu added inline comments. Comment at: clang/include/clang/Sema/Overload.h:800 +/// This candidate was not viable because it has internal linkage and is +/// from a different module than the use. +ovl_fail_module_mismatched,

[PATCH] D129064: [clang-format] Avoid crash in LevelIndentTracker.

curdeius updated this revision to Diff 442482. curdeius marked an inline comment as done. curdeius added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129064/new/ https://reviews.llvm.org/D129064 Files: clang/lib/For

[PATCH] D110114: [OMPIRBuilder] Generate aggregate argument for parallel region outlined functions

kiranchandramohan added subscribers: Meinersbur, kiranchandramohan. kiranchandramohan added a comment. Herald added a project: All. If I understand this correctly, filling the aggregate struct is only happening in the parallel case but not for the serialized parallel version. See example below,

[PATCH] D129100: [clangd] Support external throttler for preamble builds

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/ClangdServer.h:108 +/// This throttler controls which preambles may be built at a given time. +clangd::Preamble

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

wyt created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. wyt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https:/

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

ChuanqiXu updated this revision to Diff 442487. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129138/new/ https://reviews.llvm.org/D129138 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

ChuanqiXu added a comment. In D129138#3631912 , @iains wrote: > Perhaps we could be a little more bold about the completeness of the > implementation (at least, w.r.t the base paper `P1103`) - we pass the > relevant test cases. I added the wording like

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

iains added a comment. I would not expect to add all this information to the release notes, or any of the phab links - just single lines to say that paper numbers are implemented - the details are just to help us track the situation up to 26th July. CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch.

v.g.vassilev added a comment. In D126266#3629145 , @vsapsai wrote: > Hmm, I'm concerned with the pieces added purely for testing. Specifically, > `FileEntriesToReread` and TestHelper friend functions. Need to think how else > we can test it. I am not t

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

jeanPerier added a comment. Hi @pengfei, I am working on flang, and after this patch, we started to see some bugs in Fortran programs using REAL(2) (which is fp16 in flang). I am not an expert in LLVM codegen and the builtins, but I am wondering if there is not issue with how llvm codegen think

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:263-267 + Possible return values are: + /// - `Satisfiable` : There exists a satisfying assignment for `Constraints`, + ///the solutio

[PATCH] D129174: [C++20][Modules] Invalidate internal-linkage functions in overload sets [P1815R2 part 1]

iains marked 2 inline comments as done. iains added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:6406 +if (Function->getFormalLinkage() <= Linkage::InternalLinkage && +getLangOpts().CPlusPlus20 && MF != getCurrentModule()) { + Candidate.Viable = f

[PATCH] D129174: [C++20][Modules] Invalidate internal-linkage functions in overload sets [P1815R2 part 1]

iains updated this revision to Diff 442505. iains marked 4 inline comments as done. iains added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129174/new/ https://reviews.llvm.org/D129174 Files: clang/include/c

[PATCH] D129174: [C++20][Modules] Invalidate internal-linkage functions in overload sets [P1815R2 part 1]

iains added a comment. TODO: second test-case for cases that should succeed, split out basic-link / p10-ex2 test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129174/new/ https://reviews.llvm.org/D129174

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei added a comment. Hi @jeanPerier , yes, you are right. This patch changes the calling conversion of fp16 from GPRs to XMMs. So you need to update the runtime. If you are using compiler-rt, you could simply re-build it with trunk code, or at least after rGabeeae57

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

h-vetinari added inline comments. Comment at: clang/docs/ReleaseNotes.rst:472-476 +- Implemented `P1103R3: Merging Modules `_. +- Implemented `P1779R3: ABI isolation for member functions `_. +- Implemented `P1874R1: Dynamic I

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2596 // Check for unsupported clauses - if (!S.clauses().empty()) { -// Currently no clause is supported -return false; + for (OMPClause *C : S.clauses()) { +// Currently only simdlen

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

jeroen.dobbelaere accepted this revision. jeroen.dobbelaere added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126956/new/ https://reviews.llvm.org/D126956 _

[clang] 5b3247b - [tbaa] Handle base classes in struct tbaa

Author: Bruno De Fraine Date: 2022-07-06T14:37:59+02:00 New Revision: 5b3247bf9f715cc1b399af1e17540b3a3ce9cdec URL: https://github.com/llvm/llvm-project/commit/5b3247bf9f715cc1b399af1e17540b3a3ce9cdec DIFF: https://github.com/llvm/llvm-project/commit/5b3247bf9f715cc1b399af1e17540b3a3ce9cdec.dif

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b3247bf9f71: [tbaa] Handle base classes in struct tbaa (authored by brunodf, committed by jeroen.dobbelaere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D129100: [clangd] Support external throttler for preamble builds

sammccall marked 5 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:108 +/// This throttler controls which preambles may be built at a given time. +clangd::PreambleThrottler *PreambleThrottler = nullptr; + -

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Solver.h:45 +enum class Assignment : int8_t { + Unassigned = -1, + AssignedFalse = 0, A solution consists of true/false assignments for all variables. Having an `U

[PATCH] D128204: [clangd] Add fix-it for inserting IWYU pragma: keep

kadircet added a comment. > A specific example i encountered is clang/Tooling/DiagnosticsYaml.h Which > defines template specializations for inputting/outputting yaml io. That file > must be included if you ever want to emit diagnostics as YAML, but the > typical use case is to just use the ope

[clang-tools-extra] ed0e20d - [clangd] Support external throttler for preamble builds

Author: Sam McCall Date: 2022-07-06T14:58:24+02:00 New Revision: ed0e20d5e8c5d6c679d2cead674654541fa10e1b URL: https://github.com/llvm/llvm-project/commit/ed0e20d5e8c5d6c679d2cead674654541fa10e1b DIFF: https://github.com/llvm/llvm-project/commit/ed0e20d5e8c5d6c679d2cead674654541fa10e1b.diff LO

[PATCH] D129100: [clangd] Support external throttler for preamble builds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGed0e20d5e8c5: [clangd] Support external throttler for preamble builds (authored by sammccall). Changed p

[PATCH] D129158: [pseudo] Define recovery strategy as grammar extension.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/pseudo/lib/cxx/CXX.cpp:54 + return { + {(ExtensionID)Extension::Brackets, recoverBrackets}, + }; hokein wrote: > btw, it is annoying to write an expl

[clang-tools-extra] 7d8e274 - [pseudo] Define recovery strategy as grammar extension.

Author: Sam McCall Date: 2022-07-06T15:03:38+02:00 New Revision: 7d8e2742d958468b900532f1e44610b9b0b29f5e URL: https://github.com/llvm/llvm-project/commit/7d8e2742d958468b900532f1e44610b9b0b29f5e DIFF: https://github.com/llvm/llvm-project/commit/7d8e2742d958468b900532f1e44610b9b0b29f5e.diff LO

[PATCH] D129158: [pseudo] Define recovery strategy as grammar extension.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d8e2742d958: [pseudo] Define recovery strategy as grammar extension. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

erichkeane added subscribers: aaron.ballman, erichkeane. erichkeane added inline comments. Comment at: clang/docs/ReleaseNotes.rst:305 +- Some type traits builtins like ``__has_trivial_assign`` have been documented + as deprecated for a while, because their semantics don't mix

[PATCH] D129198: [clang] Correct the macOS version that supports aligned allocation

ldionne created this revision. ldionne added a reviewer: ahatanak. Herald added a project: All. ldionne requested review of this revision. Herald added projects: clang, libc++. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. After checking the libc++abi.dyli

[clang] 923b56e - [NFC] Add a TODO comment to apply nounwind attribute in all GPU modes.

Author: Alexey Bader Date: 2022-07-06T06:20:09-07:00 New Revision: 923b56e7ca96e03cedcb0e3a5df5c05e8e975a38 URL: https://github.com/llvm/llvm-project/commit/923b56e7ca96e03cedcb0e3a5df5c05e8e975a38 DIFF: https://github.com/llvm/llvm-project/commit/923b56e7ca96e03cedcb0e3a5df5c05e8e975a38.diff

[clang-tools-extra] 511a7ee - [clangd] Fix tests after ed0e20d5e8c5d6c679d2c

Author: Sam McCall Date: 2022-07-06T15:22:05+02:00 New Revision: 511a7eef937ebc1e25efc90bf41f12b52ad1dff3 URL: https://github.com/llvm/llvm-project/commit/511a7eef937ebc1e25efc90bf41f12b52ad1dff3 DIFF: https://github.com/llvm/llvm-project/commit/511a7eef937ebc1e25efc90bf41f12b52ad1dff3.diff LO

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

ldionne updated this revision to Diff 442549. ldionne marked 2 inline comments as done. ldionne added a comment. Rebase and address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125683/new/ https://reviews.llvm.org/D125683 Files:

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

shraiysh added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2596 // Check for unsupported clauses - if (!S.clauses().empty()) { -// Currently no clause is supported -return false; + for (OMPClause *C : S.clauses()) { +// Currently only simdlen

[PATCH] D124159: [SimplifyCFG] Thread branches on same condition in more cases (PR54980)

nikic added a comment. @nathanchance Thanks for the report. I've applied the obvious fix in https://github.com/llvm/llvm-project/commit/20962c1240691d25b21ce425313c81eed0b1b358. However, I think that this (and similar limitations relating to critical edge splitting) might actually be unnecessar

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 updated this revision to Diff 442555. psoni2628 marked 3 inline comments as done. psoni2628 added a comment. - Create new tests instead of modifying existing ones - Specialize `isSupportedByOpenMPIRBuilder` for `OMPSimdDirective` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2596 // Check for unsupported clauses - if (!S.clauses().empty()) { -// Currently no clause is supported -return false; + for (OMPClause *C : S.clauses()) { +// Currently only simdlen

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:190 : DiagGroup<"deprecated-dynamic-exception-spec">; +def DeprecatedHasBuiltins : DiagGroup<"deprecated-has-builtins">; def DeprecatedImplementations :DiagGroup<"deprecated-imple

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin added inline comments. Comment at: llvm/lib/Support/Unicode.cpp:272 +/// Unicode code points of the Cf category are considered +/// fornatting characters. +bool isFormatting(int UCS) { tahonermann wrote: > Thanks! I made a commit to fix it :) Reposito

[PATCH] D129202: [clang] Add a fixit for warn-self-assign if LHS is a field with the same name as parameter on RHS

njames93 created this revision. njames93 added reviewers: aaron.ballman, rsmith. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a fix-it for the common case of setters/constructors using parameters

[PATCH] D129202: [clang] Add a fixit for warn-self-assign if LHS is a field with the same name as parameter on RHS

njames93 updated this revision to Diff 442559. njames93 added a comment. Remove unnecessary extra include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129202/new/ https://reviews.llvm.org/D129202 Files: clang/include/clang/Basic/DiagnosticSema

[clang] 08e4fe6 - [X86] Add RDPRU instruction

Author: Paul Robinson Date: 2022-07-06T07:17:47-07:00 New Revision: 08e4fe6c61967d5c6c16ef7a4cc63d51c4992b55 URL: https://github.com/llvm/llvm-project/commit/08e4fe6c61967d5c6c16ef7a4cc63d51c4992b55 DIFF: https://github.com/llvm/llvm-project/commit/08e4fe6c61967d5c6c16ef7a4cc63d51c4992b55.diff

[PATCH] D128934: [X86] Add RDPRU instruction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08e4fe6c6196: [X86] Add RDPRU instruction (authored by probinson). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed pr

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

jeanPerier added a comment. In D107082#3632301 , @pengfei wrote: > Hi @jeanPerier , yes, you are right. This patch changes the calling > conversion of fp16 from GPRs to XMMs. So you need to update the runtime. If > you are using compiler-rt, you could s

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

kiranchandramohan added a comment. Nit: Also add to the summary that this patch uses the simdlen support in OpenMPIRBuilder when it is enabled in Clang. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2600 + continue; +else + return false; Nit: El

[PATCH] D128745: [Sema] fix trailing parameter pack handling for function template partial ordering

aaron.ballman added reviewers: erichkeane, clang-language-wg. aaron.ballman added a comment. Thank you for working on this! Can you please add more details to the patch summary about the changes? Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5184 - // FIXME: This mim

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jdoerfert added a comment. Herald added a subscriber: mattd. reverse ping. Are there outstanding issues with this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 _

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 added a comment. In D129149#3632813 , @kiranchandramohan wrote: > Nit: Also add to the summary that this patch uses the simdlen support in > OpenMPIRBuilder when it is enabled in Clang. I just wanted to clarify that below is what you mean?

[PATCH] D127042: [Clang][OpenMP] Enable floating-point operation for `atomic compare` series

tianshilei1992 updated this revision to Diff 442585. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127042/new/ https://reviews.llvm.org/D127042 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/lib/Sema/Sem

[clang] b5b6d3a - [Debugify] Port verify-debuginfo-preserve to NewPM

Author: Nikola Tesic Date: 2022-07-06T17:07:20+02:00 New Revision: b5b6d3a41b4eba23b604f37942b892a382caae57 URL: https://github.com/llvm/llvm-project/commit/b5b6d3a41b4eba23b604f37942b892a382caae57 DIFF: https://github.com/llvm/llvm-project/commit/b5b6d3a41b4eba23b604f37942b892a382caae57.diff

[PATCH] D115351: [Debugify] Port verify-debuginfo-preserve to NewPM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5b6d3a41b4e: [Debugify] Port verify-debuginfo-preserve to NewPM (authored by ntesic, committed by djtodoro). Herald added a project: clang. Herald a

[PATCH] D127042: [Clang][OpenMP] Enable floating-point operation for `atomic compare` series

tianshilei1992 updated this revision to Diff 442588. tianshilei1992 added a comment. remove unrelated changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127042/new/ https://reviews.llvm.org/D127042 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

kiranchandramohan added a comment. In D129149#3632861 , @psoni2628 wrote: > In D129149#3632813 , > @kiranchandramohan wrote: > >> Nit: Also add to the summary that this patch uses the simdlen support in >> OpenM

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei added a comment. Thanks for confirming it! I don't have much experience in compiler-rt. But I think the version of clang matters much to compiler-rt particular in ABI changing cases like this :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille updated this revision to Diff 442592. serge-sans-paille added a comment. Herald added a reviewer: NoQ. Do *not* try to syndicate code across different location. Alhtough that would be benefitial to the project, it also makes this patch too complex and controversial because it w

[PATCH] D129211: [Clang][Doc] Update the release note for clang

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Add the support for `atomic compare` and `atomic

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 updated this revision to Diff 442595. psoni2628 added a comment. - Remove discouraged else after return CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129149/new/ https://reviews.llvm.org/D129149 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/irbuilder_simd.cp

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The changes here LGTM, thank you for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128059/new/ https://reviews.llvm.org/D128

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

jdoerfert added a comment. Generally, this is fine. Some nits. The only reason not to accept this right now is the test. Why manual check lines? Wrt. the function signature. As soon as we have more then SIMD directives to check we refactor things. Keep it simple until you need the functionality.

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:2885 +void OpenMPIRBuilder::applySimdlen(DebugLoc, CanonicalLoopInfo *CanonicalLoop, + llvm::ConstantInt *Simdlen) { + LLVMContext &Ctx = Builder.getContext()

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:608 + /// + /// \param DL Debug location for instructions added by unrolling. + /// \param LoopThe simd loop. jdoerfert wrote: > No debug location needed. Yo

[clang] e3dc568 - [Clang] Add a warning on invalid UTF-8 in comments.

Author: Corentin Jabot Date: 2022-07-06T17:59:44+02:00 New Revision: e3dc56805f1029dd5959e4c69196a287961afb8d URL: https://github.com/llvm/llvm-project/commit/e3dc56805f1029dd5959e4c69196a287961afb8d DIFF: https://github.com/llvm/llvm-project/commit/e3dc56805f1029dd5959e4c69196a287961afb8d.diff

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe3dc56805f10: [Clang] Add a warning on invalid UTF-8 in comments. (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D12805

[PATCH] D129100: [clangd] Support external throttler for preamble builds

anarazel added a comment. This caused llvm builds to fail for me (using clang-14, debug, debian unstable, lld as linker): FAILED: tools/clang/tools/extra/clangd/unittests/ClangdTests : && /usr/bin/clang++-14 -gz=zlib -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=dat

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:608 + /// + /// \param DL Debug location for instructions added by unrolling. + /// \param LoopThe simd loop. psoni2628 wrote: > jdoerfert wrote: > > No debu

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

jyknight added a comment. As I commented on https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101836#c32, > It doesn't make sense to have a mode in which `int array[0]` is accepted but > is not a flex array. > Either that should be a compilation error (as the standard specifies), or it > should be a

[clang-tools-extra] e7fa272 - [clangd] Fix missing key function in PreambleThrottler

Author: Sam McCall Date: 2022-07-06T18:27:09+02:00 New Revision: e7fa272bc6a6a504c2899bb7cf66029678d97890 URL: https://github.com/llvm/llvm-project/commit/e7fa272bc6a6a504c2899bb7cf66029678d97890 DIFF: https://github.com/llvm/llvm-project/commit/e7fa272bc6a6a504c2899bb7cf66029678d97890.diff LO

[PATCH] D129100: [clangd] Support external throttler for preamble builds

sammccall added a comment. In D129100#3633073 , @anarazel wrote: > This caused llvm builds to fail for me (using clang-14, debug, debian > unstable, lld as linker): Thanks, I have a very similar setup but the build passed locally, I'll never understand

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

pscoro updated this revision to Diff 442615. pscoro added a comment. trying to localize calng-format again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129016/new/ https://reviews.llvm.org/D129016 Files: clang/include/clang/Basic/BuiltinsPPC.de

Re: [PATCH] D129100: [clangd] Support external throttler for preamble builds

Hi, On 2022-07-06 16:28:14 +, Sam McCall via Phabricator wrote: > sammccall added a comment. > > In D129100#3633073 , @anarazel > wrote: > > > This caused llvm builds to fail for me (using clang-14, debug, debian > > unstable, lld as linker): > >

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

jyknight added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2644 + +Control which arrays are considered as flexible arrays members. +can be 1 (array of size 0, 1 and undefined are considered), 2 (array of size 0 Docs should also mention

[PATCH] D127042: [Clang][OpenMP] Enable floating-point operation for `atomic compare` series

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG83837a61981c: [Clang][OpenMP] Enable floating-point operation for `atomic compare` series (authored by tianshilei1992). Changed prior to commit: h

[PATCH] D129218: [CMake][Fuchsia] Install static libuwind

phosek created this revision. phosek added a reviewer: abrachet. Herald added a subscriber: mgorny. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This can now be used with -static-libgcc. Repository:

[PATCH] D128921: [Sema] Merge C++20 concept definitions from different modules in same TU

ilya-biryukov updated this revision to Diff 442623. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Update code to match how typedefs behave - remove leftover test from previous version - Add test for C++20 modules, rewrite original test with split-file - use isRea

[PATCH] D128921: [Sema] Merge C++20 concept definitions from different modules in same TU

ilya-biryukov added a comment. Many thanks! I didn't know about `split-file`, it's much nicer indeed! Also incorporating feedback from @rsmith and removing the call to `makeMergedDefinitionVisible`. Keeping just `setPrimaryMergedDecl` is enough here. Richard's reply from the email exchange:

[PATCH] D128921: [Sema] Merge C++20 concept definitions from different modules in same TU

ilya-biryukov added a comment. PS I will make sure to look at the patches you sent my way this week. Wanted to do it earlier, but have been having some personal emergencies I needed to take care of. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128

[PATCH] D129218: [CMake][Fuchsia] Install static libuwind

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd34ce04f98c3: [CMake][Fuchsia] Install static libuwind (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[clang] d34ce04 - [CMake][Fuchsia] Install static libuwind

Author: Petr Hosek Date: 2022-07-06T17:17:40Z New Revision: d34ce04f98c387aa86c13cb502e3e2a8a4d8f38b URL: https://github.com/llvm/llvm-project/commit/d34ce04f98c387aa86c13cb502e3e2a8a4d8f38b DIFF: https://github.com/llvm/llvm-project/commit/d34ce04f98c387aa86c13cb502e3e2a8a4d8f38b.diff LOG: [C

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

thakis added a comment. As far as I can tell, this breaks check-clang everywhere: http://45.33.8.238/ Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128059/new/ https://reviews.llvm.

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2644 + +Control which arrays are considered as flexible arrays members. +can be 1 (array of size 0, 1 and undefined are considered), 2 (array of size 0 jyknight wrote:

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

pscoro updated this revision to Diff 442627. pscoro added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129016/new/ https://reviews.llvm.org/D129016 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Basic/Targets/PP

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:608 + /// + /// \param DL Debug location for instructions added by unrolling. + /// \param LoopThe simd loop. jdoerfert wrote: > psoni2628 wrote: > > jdoerfe

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

pscoro updated this revision to Diff 442630. pscoro added a comment. patch appication troubleshooting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129016/new/ https://reviews.llvm.org/D129016 Files: clang/include/clang/Basic/BuiltinsPPC.def c

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

vangthao marked 5 inline comments as done. vangthao added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123878/new/ https://reviews.llvm.org/D123878 ___ cfe-commits mailing list cfe-commi

[PATCH] D125693: [DebugInfo] Support types, imports and static locals declared in a lexical block (3/5)

ellis added inline comments. Comment at: llvm/test/Instrumentation/InstrProfiling/debug-info-correlate.ll:23 call void @llvm.instrprof.increment(i8* getelementptr inbounds ([3 x i8], [3 x i8]* @__profn_foo, i32 0, i32 0), i64 12345678, i32 2, i32 0) - ret void + ret void, !

[clang] fb06dd3 - Revert "[Clang] Add a warning on invalid UTF-8 in comments."

Author: Corentin Jabot Date: 2022-07-06T19:45:12+02:00 New Revision: fb06dd3e8ca1b89579055a74f2217e7665c3f150 URL: https://github.com/llvm/llvm-project/commit/fb06dd3e8ca1b89579055a74f2217e7665c3f150 DIFF: https://github.com/llvm/llvm-project/commit/fb06dd3e8ca1b89579055a74f2217e7665c3f150.diff

[PATCH] D128921: [Sema] Merge C++20 concept definitions from different modules in same TU

ilya-biryukov updated this revision to Diff 442633. ilya-biryukov added a comment. - Always call PushToScopeChains. This is the right behavior after we stopped calling makeMergedDefinitionVisible Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128921

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin added a comment. In D128059#3633343 , @thakis wrote: > As far as I can tell, this breaks check-clang everywhere: http://45.33.8.238/ > > Please take a look and revert for now if it takes a while to fix. Thanks for letting me know, i hadn't notic

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 updated this revision to Diff 442637. psoni2628 added a comment. - Autogenerate check lines for test case - Use isa instead of dyncast - Remove unused DebugLoc - Remove `llvm::` from `llvm::ConstantInt` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129149/new/ https://reviews.

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 marked 8 inline comments as done. psoni2628 added inline comments. Comment at: clang/test/OpenMP/irbuilder_simdlen.cpp:1 +// RUN: %clang_cc1 -no-opaque-pointers -fopenmp-enable-irbuilder -verify -fopenmp -fopenmp-version=45 -x c++ -triple x86_64-unknown-unknown -emit-l

[PATCH] D128927: [libc++] Always build c++experimental.a

Mordante accepted this revision. Mordante added a comment. I had a look at the changes and still LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128927/new/ https://reviews.llvm.org/D128927 ___ cfe-c

  1   2   >