kiranchandramohan added a comment. Nit: Also add to the summary that this patch uses the simdlen support in OpenMPIRBuilder when it is enabled in Clang.
================ Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2600 + continue; + else + return false; ---------------- Nit: Else after return/continue is discouraged. https://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129149/new/ https://reviews.llvm.org/D129149 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits