[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng updated this revision to Diff 441610. kito-cheng marked 24 inline comments as done. kito-cheng added a comment. Changes: - Address @craig.topper's comment - Address @khchen's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111617/n

[PATCH] D128807: [clang][transformer] Finish plumbing `Note` all the way to the output.

courbet added a comment. In D128807#3622779 , @ymandel wrote: > In D128807#3622727 , @li.zhe.hua > wrote: > >> - A note being a part of an edit seems weird at best. An `ASTEdit` and >> `Edit` are fragments of a

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:114 bool operator>(const PrototypeDescriptor &PD) const { -return !(PD.PT <= PT && PD.VTM <= VTM && PD.TM <= TM); +if (PD.PT != PT) + return PD.PT > PT; --

[clang] 9ac3864 - [ConstExpr] Don't create insertvalue expressions

Author: Nikita Popov Date: 2022-07-01T09:23:28+02:00 New Revision: 9ac386495d3c9578e04c9aeb07a3d255b8cc8413 URL: https://github.com/llvm/llvm-project/commit/9ac386495d3c9578e04c9aeb07a3d255b8cc8413 DIFF: https://github.com/llvm/llvm-project/commit/9ac386495d3c9578e04c9aeb07a3d255b8cc8413.diff

[PATCH] D128792: [ConstExpr] Don't create insertvalue expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ac386495d3c: [ConstExpr] Don't create insertvalue expressions (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-com

[PATCH] D128783: [test] Check for more -fsanitize=array-bounds regressions

serge-sans-paille added inline comments. Comment at: clang/test/CodeGen/bounds-checking-fam.c:59 + // CXX-STRICT-0-NOT: @__ubsan + return p->a[i] + (p->a)[i]; +} Another C++-specific behavior: if the bound results from the substitution of a template parameter,

[clang] b822efc - [FPEnv] Allow CompoundStmt to keep FP options

Author: Serge Pavlov Date: 2022-07-01T14:32:33+07:00 New Revision: b822efc7404bf09ccfdc1ab7657475026966c3b2 URL: https://github.com/llvm/llvm-project/commit/b822efc7404bf09ccfdc1ab7657475026966c3b2 DIFF: https://github.com/llvm/llvm-project/commit/b822efc7404bf09ccfdc1ab7657475026966c3b2.diff

[PATCH] D123952: [FPEnv] Allow CompoundStmt to keep FP options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb822efc7404b: [FPEnv] Allow CompoundStmt to keep FP options (authored by sepavloff). Changed prior to commit: https://reviews.llvm.org/D123952?vs=

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng marked an inline comment as done. kito-cheng added a comment. Oh, have one comment not address yet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111617/new/ https://reviews.llvm.org/D111617 __

[PATCH] D30538: Add documentation for -fno-strict-aliasing

carlosgalvezp added a comment. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. Hi, is this commit still valid? Why hasn't it been pushed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D30538/new/ https://reviews.llvm.org/D30538

[PATCH] D124159: [SimplifyCFG] Thread branches on same condition in more cases (PR54980)

HanKuanChen added a comment. HI, the following code get infinite loop after this commit. ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py ; RUN: opt -passes="simplifycfg" -S < %s | FileCheck %s define void @_Z10alignedboxl(i1 %cmp.a, i1 %cmp.b, i1 %cmp.c) { ;

[clang] 0401fd1 - Fix warning on unhandled enumeration value

Author: Serge Pavlov Date: 2022-07-01T15:17:29+07:00 New Revision: 0401fd12d4aa0553347fe34d666fb236d8719173 URL: https://github.com/llvm/llvm-project/commit/0401fd12d4aa0553347fe34d666fb236d8719173 DIFF: https://github.com/llvm/llvm-project/commit/0401fd12d4aa0553347fe34d666fb236d8719173.diff

[PATCH] D128119: [clang] enforce instantiation of constexpr template functions

serge-sans-paille added a comment. gentle ping o/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128119/new/ https://reviews.llvm.org/D128119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D128892: [clangd] Also mark output arguments of array subscript expressions

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Makes sense. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128892/new/ https://reviews.llvm.org/D128892 ___

[clang] dc34d8d - Revert "[FPEnv] Allow CompoundStmt to keep FP options"

Author: Serge Pavlov Date: 2022-07-01T15:42:39+07:00 New Revision: dc34d8df4c48b3a8f474360970cae8a58e6c84f0 URL: https://github.com/llvm/llvm-project/commit/dc34d8df4c48b3a8f474360970cae8a58e6c84f0 DIFF: https://github.com/llvm/llvm-project/commit/dc34d8df4c48b3a8f474360970cae8a58e6c84f0.diff

[clang-tools-extra] ac511fd - [clangd] Also mark output arguments of array subscript expressions

Author: Christian Kandeler Date: 2022-07-01T04:45:20-04:00 New Revision: ac511fd4392d0f1fad3852378adf3c80738016b7 URL: https://github.com/llvm/llvm-project/commit/ac511fd4392d0f1fad3852378adf3c80738016b7 DIFF: https://github.com/llvm/llvm-project/commit/ac511fd4392d0f1fad3852378adf3c80738016b7.

[PATCH] D128892: [clangd] Also mark output arguments of array subscript expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGac511fd4392d: [clangd] Also mark output arguments of array subscript expressions (authored by ckandeler, committed by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D128783: [test] Check for more -fsanitize=array-bounds regressions

sberg updated this revision to Diff 441640. sberg added a comment. added test involving template argument substitution CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128783/new/ https://reviews.llvm.org/D128783 Files: clang/test/CodeGen/bounds-checking-fam.c Index: clang/test/CodeGe

[PATCH] D128783: [test] Check for more -fsanitize=array-bounds regressions

sberg marked an inline comment as done. sberg added inline comments. Comment at: clang/test/CodeGen/bounds-checking-fam.c:59 + // CXX-STRICT-0-NOT: @__ubsan + return p->a[i] + (p->a)[i]; +} serge-sans-paille wrote: > Another C++-specific behavior: if the bound

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski updated this revision to Diff 441643. awarzynski added a comment. Add a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125788/new/ https://reviews.llvm.org/D125788 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChain

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj updated this revision to Diff 441646. upsj added a comment. don't add reference hints to unresolved parameter packs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124690/new/ https://reviews.llvm.org/D124690 Files: clang-tools-extra/clangd/A

[PATCH] D128974: [AST] [Modules] Handle full cases of DefaultArgStorage::setInherited

ChuanqiXu created this revision. ChuanqiXu added reviewers: erichkeane, iains, vsapsai, v.g.vassilev, dblaikie, rsmith, jansvoboda11, aaron.ballman. ChuanqiXu added projects: clang, clang-modules. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a subscriber:

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

ckandeler created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. That is, mark constructor pa

[PATCH] D128248: [clang] Avoid an assertion in APValue::hasArrayFiller()

tbaeder marked 2 inline comments as done. tbaeder added a comment. In D128248#3622775 , @shafik wrote: > LGTM after addressing all of Aaron's comments. I've already addressed them; did you miss the update or are you saying I haven't addressed them prope

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

Enna1 added inline comments. Comment at: llvm/lib/Analysis/MemoryBuiltins.cpp:288-290 +bool llvm::isNewLikeFn(const Value *V, const TargetLibraryInfo *TLI) { + return getAllocationData(V, OpNewLike, TLI).hasValue(); +} nit: place the definition of `llvm::isNewLi

[PATCH] D127643: [Static Analyzer] Structured bindings to data members

Szelethus added a comment. I read https://en.cppreference.com/w/cpp/language/structured_binding carefully, and there are a number of interesting rules that might deserve their own test case, even if this isn't the patch where you solve that issue, or believe that the solution handles it without

[PATCH] D128981: [C++20][Modules] Implement include translation.

iains created this revision. Herald added a project: All. iains requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This addresses [cpp.include]/7 (when encountering #include header-name) If the header identified by the header-name denotes an

[clang] 14035d5 - Fix this C99 DR to be more robust

Author: Aaron Ballman Date: 2022-07-01T07:33:37-04:00 New Revision: 14035d5147a2e2e910341556cef3b16b66a2be66 URL: https://github.com/llvm/llvm-project/commit/14035d5147a2e2e910341556cef3b16b66a2be66 DIFF: https://github.com/llvm/llvm-project/commit/14035d5147a2e2e910341556cef3b16b66a2be66.diff

[PATCH] D128984: [clang-format] Tweak help text a bit

thakis created this revision. thakis added reviewers: curdeius, MyDeveloperDay. Herald added a project: All. thakis requested review of this revision. In particular, make it clear that `--style=file` is the default, since there's some confusion about this, e.g. here: https://stackoverflow.com/ques

[clang] 83fdf0c - Ensure that the generic associations aren't redundant

Author: Aaron Ballman Date: 2022-07-01T07:48:59-04:00 New Revision: 83fdf0c34e60e61849574d30c39cf7f7324c5271 URL: https://github.com/llvm/llvm-project/commit/83fdf0c34e60e61849574d30c39cf7f7324c5271 DIFF: https://github.com/llvm/llvm-project/commit/83fdf0c34e60e61849574d30c39cf7f7324c5271.diff

[clang] ac8dab8 - Add some more expected warnings to this C99 DR test

Author: Aaron Ballman Date: 2022-07-01T08:11:46-04:00 New Revision: ac8dab8e09d8faee902861343ccb9278982f4306 URL: https://github.com/llvm/llvm-project/commit/ac8dab8e09d8faee902861343ccb9278982f4306 DIFF: https://github.com/llvm/llvm-project/commit/ac8dab8e09d8faee902861343ccb9278982f4306.diff

[PATCH] D128715: [clang-tidy] Fix confusable identifiers interaction with DeclContext

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from some minor style nits. Comment at: clang-tools-extra/clang-tidy/misc/ConfusableIdentifierCheck.cpp:130-132 +if (ND1->getAccess() != AS_private && isMemberOf(ND1, RD0)) { + return true

[PATCH] D128782: [CodeGen] Keep track of decls that were deferred and have been emitted.

junaire updated this revision to Diff 441667. junaire added a comment. - Rebase - turn clang-format off in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128782/new/ https://reviews.llvm.org/D128782 Files: clang/lib/CodeGen/CodeGenModule.cp

[clang] 325e7e8 - [LLVM][LTO][LLD] Enable Profile Guided Layout (--call-graph-profile-sort) for FullLTO

Author: Ben Dunbobbin Date: 2022-07-01T13:57:36+01:00 New Revision: 325e7e8b87423f83ba9fc53b9486ce67329d486c URL: https://github.com/llvm/llvm-project/commit/325e7e8b87423f83ba9fc53b9486ce67329d486c DIFF: https://github.com/llvm/llvm-project/commit/325e7e8b87423f83ba9fc53b9486ce67329d486c.diff

[PATCH] D12669: [libcxxabi] Fix alignment of pointers returned by fallback_malloc

simon_tatham added a comment. Herald added a project: All. @EricWF, I have an updated version of this patch that applies against current `main`. Do you mind if I commandeer this revision and post my updated patch on it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12669/new/ https://

[PATCH] D127448: [wip][pseudo] Implement guard extension.

hokein updated this revision to Diff 441677. hokein marked 8 inline comments as done. hokein added a comment. rebase and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127448/new/ https://reviews.llvm.org/D127448 Files: clang-to

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. @shafik was able to help me figure out how to repro, and I think I've about fixed this, so I'll try another commit soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126907/new/ https://reviews.llvm.org/D126907 _

[PATCH] D127448: [wip][pseudo] Implement guard extension.

hokein updated this revision to Diff 441680. hokein marked 5 inline comments as done. hokein added a comment. fix format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127448/new/ https://reviews.llvm.org/D127448 Files: clang-tools-extra/pseudo/

[PATCH] D127448: [wip][pseudo] Implement guard extension.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:298 auto Pop = [&](const GSS::Node *Head, RuleID RID) { -LLVM_DEBUG(llvm::dbgs() << " Pop " << Params.G.dumpRule(RID) << "\n"); -const auto &Rule = Params.G.lookupRule(RID); +LLVM_DEBUG

[PATCH] D128991: [NFC] Add a missing test for for clang-repl

junaire created this revision. junaire added a reviewer: v.g.vassilev. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds a missing test for 0ecbedc0986bd4b7b90a60a5f31d32337160d4c4

[clang] befa8cf - Re-apply "Deferred Concept Instantiation Implementation""

Author: Erich Keane Date: 2022-07-01T06:51:38-07:00 New Revision: befa8cf087dbb8159a4d9dc8fa4d6748d6d5049a URL: https://github.com/llvm/llvm-project/commit/befa8cf087dbb8159a4d9dc8fa4d6748d6d5049a DIFF: https://github.com/llvm/llvm-project/commit/befa8cf087dbb8159a4d9dc8fa4d6748d6d5049a.diff L

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

aaron.ballman added a comment. Some drive-by comments from the peanut gallery. Comment at: clang/lib/Parse/ParsePragma.cpp:3963 +<< PP.getSpelling(Tok) << "riscv" << /*Expected=*/true << "'intrinsic'"; +return; + } It's fine to warn on this, but t

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng updated this revision to Diff 441684. kito-cheng added a comment. Changes: - Address @craig.topper's comment - Introduce RISCVIntrinsicManager.h and let it become member of Sema, that make sure the it won't outlive than Sema. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D128821: [clangd][ObjC] Fix ObjC method definition completion

dgoldman updated this revision to Diff 441685. dgoldman added a comment. - Use codeCompletionString(Result) for RK_Pattern Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128821/new/ https://reviews.llvm.org/D128821 Files: clang-tools-extra/clangd

[clang-tools-extra] dc6c1f1 - [clangd][ObjC] Fix ObjC method definition completion

Author: David Goldman Date: 2022-07-01T10:02:47-04:00 New Revision: dc6c1f181b8a95b959f590423ce007b819532290 URL: https://github.com/llvm/llvm-project/commit/dc6c1f181b8a95b959f590423ce007b819532290 DIFF: https://github.com/llvm/llvm-project/commit/dc6c1f181b8a95b959f590423ce007b819532290.diff

[PATCH] D128821: [clangd][ObjC] Fix ObjC method definition completion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc6c1f181b8a: [clangd][ObjC] Fix ObjC method definition completion (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D75788: [OpenMP] Provide math functions in OpenMP device code via OpenMP variants

chapuni added inline comments. Herald added subscribers: kosarev, mattd, asavonic, sstefan1, MaskRay. Herald added a project: All. Comment at: clang/lib/Headers/CMakeLists.txt:145 set(openmp_wrapper_files openmp_wrappers/math.h It doesn't contain , intentio

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

probinson added a comment. Seems like for an "auto"-returning function/lambda with a definition, the front-end should have deduced the return type, and so we should emit that in the DWARF, even if we end up emitting DWARF with both a declaration and a separate definition. I accept that a membe

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

chapuni added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:170 + ppc_wrappers/immintrin.h + ppc_wrappers/tmmintrin.h + ppc_wrappers/x86intrin.h It doesn't contain , forgot? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

martong added a comment. Thanks, this is a great addition! - Please use Capitalized names for all the variables (as per the LLVM coding standards suggests here ). - Could you please update the re

RE: [clang] 4821508 - Revert "DebugInfo: Fully integrate ctor type homing into 'limited' debug info"

Hi Dave, The original commit message included Also fix a bug I found along the way that was causing ctor type homing to kick in even when something could be vtable homed Is it reasonable to fix that without removing ctor homing in general? Or would that cause too much test churn, as you'r

[PATCH] D128119: [clang] enforce instantiation of constexpr template functions

aaron.ballman added reviewers: rsmith, clang-language-wg. aaron.ballman added a comment. It's a bummer that patch application failed on precommit CI for reasons unrelated to your patch (as best I can tell, anyway)... Also, please update the patch summary to have some more details about what your

[PATCH] D128119: [clang] enforce instantiation of constexpr template functions

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:4859 << Function; + } else if (!Recursive) { +Function->setInstantiationIsPending(true); This condition seems a little aggressive, and will end

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

beanz added a comment. gentle ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128012/new/ https://reviews.llvm.org/D128012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D128449: [clang] Introduce -Warray-parameter

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:3216 + (Ty->isVariableArrayType() && +cast(Ty)->getSizeModifier() == +ArrayType::ArraySizeModifier::Star); I forgot about this gotcha -- arrays are

[clang-tools-extra] a322c10 - [pseudo] temporary fix for missing generated header after fe66aebd755191fac6

Author: Sam McCall Date: 2022-07-01T16:45:22+02:00 New Revision: a322c104cb5987df93be22b09e527a8a0c932af5 URL: https://github.com/llvm/llvm-project/commit/a322c104cb5987df93be22b09e527a8a0c932af5 DIFF: https://github.com/llvm/llvm-project/commit/a322c104cb5987df93be22b09e527a8a0c932af5.diff LO

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

frasercrmck added a comment. Just nits from me. Comment at: clang/include/clang/Sema/RISCVIntrinsicManager.h:9 +// +// This file defines the RISCVIntrinsicManager, which handle RISC-V vector +// intrinsic functions. `handles` Comment at: clan

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng updated this revision to Diff 441692. kito-cheng marked 18 inline comments as done. kito-cheng added a comment. Changes: - Address @aaron.ballman’s comment - Add 2 new testcase: - riscv-bad-intrnisic-pragma.c - riscv-intrnisic-pragma.c Repository: rG LLVM Github Monorepo

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:3963 +<< PP.getSpelling(Tok) << "riscv" << /*Expected=*/true << "'intrinsic'"; +return; + } aaron.ballman wrote: > It's fine to warn on this, but then you need to eat toke

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:3963 +<< PP.getSpelling(Tok) << "riscv" << /*Expected=*/true << "'intrinsic'"; +return; + } kito-cheng wrote: > aaron.ballman wrote: > > It's fine to warn on this, but

[PATCH] D128706: [Clang] Disable clang-format entirely for clang/test tree.

aaron.ballman commandeered this revision. aaron.ballman edited reviewers, added: mboehme; removed: aaron.ballman. aaron.ballman added a comment. At the off-list request of @mboehme, I'm commandeering this review to take it over the finish line whenever the RFC finishes. Repository: rG LLVM Gi

[PATCH] D128947: [Lex] Introduce `PPCallbacks::LexedFileChanged()` preprocessor callback

akyrtzi updated this revision to Diff 441700. akyrtzi added a comment. Avoid changing the `SourceManager::getFilename()` implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128947/new/ https://reviews.llvm.org/D128947 Files: clang-tool

[clang] 2750985 - [NFC] Add a missing test for for clang-repl

Author: Jun Zhang Date: 2022-07-01T23:26:54+08:00 New Revision: 2750985a5ccb97f4630c3443e75d78ed435d2bd0 URL: https://github.com/llvm/llvm-project/commit/2750985a5ccb97f4630c3443e75d78ed435d2bd0 DIFF: https://github.com/llvm/llvm-project/commit/2750985a5ccb97f4630c3443e75d78ed435d2bd0.diff LOG

[PATCH] D128991: [NFC] Add a missing test for for clang-repl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2750985a5ccb: [NFC] Add a missing test for for clang-repl (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2273-2274 +bool Sema::isOpenMPRebuildMemberExpr(ValueDecl *D) { + if (getCurCapturedRegion() && + getCurCapturedRegion()->CapRegionKind == CR_OpenMP) { +DSAStackTy::DSAVarData DVarPrivate = DSAStac

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam updated this revision to Diff 441702. zahiraam marked 7 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Target

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. Refactored the code as requested and fixed the compound operator promotion for scalar. The operators that are left to complete are compound operators for complex type and ternary operator for scalar and complex types. Then we need to add the option -fexcess-precision. I

[PATCH] D128991: [NFC] Add a missing test for for clang-repl

thakis added a comment. Looks like this breaks tests on Windows: http://45.33.8.238/win/61429/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128991/new/ https://reviews.ll

[PATCH] D112579: Allow non-variadic functions to be attributed with `__attribute__((format))`

fcloutier updated this revision to Diff 441703. fcloutier set the repository for this revision to rG LLVM Github Monorepo. fcloutier added a comment. Thanks, Aaron. I wasn't sure how to follow up given how long it had been since the review started. I understand that we're all busy (which explains

[PATCH] D128991: [NFC] Add a missing test for for clang-repl

junaire added a comment. In D128991#3625194 , @thakis wrote: > Looks like this breaks tests on Windows: > http://45.33.8.238/win/61429/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Thanks for the heads up, I'll revert

[clang] 3668d12 - Revert "[NFC] Add a missing test for for clang-repl"

Author: Jun Zhang Date: 2022-07-01T23:55:55+08:00 New Revision: 3668d1264e2d246f7e222338b8a5cab18ce1bdab URL: https://github.com/llvm/llvm-project/commit/3668d1264e2d246f7e222338b8a5cab18ce1bdab DIFF: https://github.com/llvm/llvm-project/commit/3668d1264e2d246f7e222338b8a5cab18ce1bdab.diff LOG

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2273-2274 +bool Sema::isOpenMPRebuildMemberExpr(ValueDecl *D) { + if (getCurCapturedRegion() && + getCurCapturedRegion()->CapRegionKind == CR_OpenMP) { +DSAStackTy::DSAVarData DVarPrivate = DSAStack->

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2273-2274 +bool Sema::isOpenMPRebuildMemberExpr(ValueDecl *D) { + if (getCurCapturedRegion() && + getCurCapturedRegion()->CapRegionKind == CR_OpenMP) { +DSAStackTy::DSAVarData DVarPrivate = DSAStac

[PATCH] D128472: [pseudo] Check follow-sets instead of tying reduce actions to lookahead tokens.

bjope added a comment. Our downstream bots have failed when using `LLVM_ENABLE_EXPENSIVE_CHECKS=ON` , and I think (unless my bisecting got screwed up) that it started to happen after this patch. We typically get Failed Tests (10): ClangPseudo :: lr-build-basic.test ClangPseudo :: lr-

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

mizvekov added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:52 + + llvm::SmallVector TemplateArgs; + Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128012/new/ https://reviews.llvm.org/D

[PATCH] D128947: [Lex] Introduce `PPCallbacks::LexedFileChanged()` preprocessor callback

akyrtzi added inline comments. Comment at: clang/lib/Lex/PPLexerChange.cpp:136 PPCallbacks::EnterFile, FileType); +FileID PrevFID; +SourceLocation EnterLoc; akyrtzi wrote: > benlangmuir wrote: > > Why does `LexedFileChanged` ha

[PATCH] D128783: [test] Check for more -fsanitize=array-bounds regressions

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. `clang/test/SemaCXX/array-bounds.cpp` has `tailpad` and `metaprogramming` tests which may be added here. Happy when @serge-sans-paille is happy. CHANGES SINCE LAST ACTION https://reviews

[PATCH] D128953: [NFC] refactor compression namespaces making way for a possible introduction of alternatives to zlib compression in the llvm toolchain.

MaskRay added a comment. > [NFC] refactor compression namespaces making way for a possible introduction > of alternatives to zlib compression in the llvm toolchain. I'd use `[NFC] Refactor llvm::zlib namespace` and place supplementary wording to the body. `in the llvm toolchain` is redundant i

[clang] 6213dba - [CMake][Fuchsia] Use libunwind as the default unwinder

Author: Petr Hosek Date: 2022-07-01T17:24:00Z New Revision: 6213dba19fc0d65ab8b366b6d78c56cbd63c9d7d URL: https://github.com/llvm/llvm-project/commit/6213dba19fc0d65ab8b366b6d78c56cbd63c9d7d DIFF: https://github.com/llvm/llvm-project/commit/6213dba19fc0d65ab8b366b6d78c56cbd63c9d7d.diff LOG: [C

[PATCH] D127887: [CMake][Fuchsia] Use libunwind as the default unwinder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6213dba19fc0: [CMake][Fuchsia] Use libunwind as the default unwinder (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin added a comment. @aaron.ballman FYI this is now core-approved Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128059/new/ https://reviews.llvm.org/D128059 ___ cfe-commits mailing list cfe-commits@

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

phosek accepted this revision. phosek added a comment. LGTM Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:122 set(RUNTIMES_${target}_LIBCXXABI_INSTALL_LIBRARY OFF CACHE BOOL "") set(RUNTIMES_${target}_LIBCXX_USE_COMPILER_RT ON CACHE BOOL "") set(RUNTIMES_${

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

tianshilei1992 updated this revision to Diff 441742. tianshilei1992 added a comment. fix unused variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129008/new/ https://reviews.llvm.org/D129008 Files: clang/lib/CodeGen/CGDecl.cpp clang/test/

[PATCH] D128953: [NFC] refactor compression namespaces making way for a possible introduction of alternatives to zlib compression in the llvm toolchain.

MaskRay added inline comments. Comment at: llvm/lib/ProfileData/InstrProf.cpp:154 +OS << ("profile uses " + compression::profile::AlgorithmName + + " compression but the profile reader was built " + "without " + + compression::profile::AlgorithmName + " su

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

LegalizeAdulthood added a comment. I can submit after you address additional comments by Nathan James. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

LegalizeAdulthood added a comment. Please provide the name and email address you wish to use on the commit and I will submit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 ___ cfe-commits mailing

[PATCH] D127807: [clang-tidy] Properly forward clang-tidy output when running tests

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. Thanks for this, like Nathan James this has been pestering me for a while `:)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang] 6450dad - Test a few more C99 DRs

Author: Aaron Ballman Date: 2022-07-01T13:54:11-04:00 New Revision: 6450daddd20a83327118c0c6fa8f844a99cd1f0f URL: https://github.com/llvm/llvm-project/commit/6450daddd20a83327118c0c6fa8f844a99cd1f0f DIFF: https://github.com/llvm/llvm-project/commit/6450daddd20a83327118c0c6fa8f844a99cd1f0f.diff

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

erichkeane added inline comments. Comment at: clang/docs/ReleaseNotes.rst:270 This fixes `Issue 55962 `_. +- Added ``-Winvalid-utf8`` which diagnose invalid UTF-8 code unit sequences in + comments. Reposi

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin updated this revision to Diff 441748. cor3ntin added a comment. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128059/new/ https://reviews.llvm.org/D128059 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagnost

[clang-tools-extra] c998273 - [pseudo] Fix an out-of-bound issue in getReduceRules.

Author: Haojian Wu Date: 2022-07-01T20:16:06+02:00 New Revision: c99827349927a44334f2b04139168efd0bc87cd3 URL: https://github.com/llvm/llvm-project/commit/c99827349927a44334f2b04139168efd0bc87cd3 DIFF: https://github.com/llvm/llvm-project/commit/c99827349927a44334f2b04139168efd0bc87cd3.diff LO

[PATCH] D128472: [pseudo] Check follow-sets instead of tying reduce actions to lookahead tokens.

hokein added a comment. Thanks for the report. There is an out-of-bound issue in LRTable::getReduceRules, fixed in c99827349927a44334f2b04139168efd0bc87cd3 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

ckissane added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:49-51 +namespace profile = llvm::compression::zlib; + +namespace serialize = llvm::compression::zlib; phosek wrote: > I think we will need to support dynamically selecting (de)com

[clang] 258c3ae - Revert "Re-apply "Deferred Concept Instantiation Implementation"""

Author: Erich Keane Date: 2022-07-01T11:20:16-07:00 New Revision: 258c3aee54e11bc5c5d8ac137eb15e8d5bbcc7e4 URL: https://github.com/llvm/llvm-project/commit/258c3aee54e11bc5c5d8ac137eb15e8d5bbcc7e4 DIFF: https://github.com/llvm/llvm-project/commit/258c3aee54e11bc5c5d8ac137eb15e8d5bbcc7e4.diff L

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

vitalybuka added a comment. @erichkeane can you please make sure that committed revisions in git have "Differential Revision: ". Usually it's added by "arc" when you upload review. Also it would be nice if reapply have the same link. Regarding reproducer, you can follow https://github.com/

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3625600 , @vitalybuka wrote: > @erichkeane can you please make sure that committed revisions in git have > "Differential Revision: ". Usually it's added by "arc" when you upload > review. > Also it would be ni

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

ckissane added inline comments. Comment at: llvm/lib/ProfileData/InstrProf.cpp:154 +OS << ("profile uses " + compression::profile::AlgorithmName + + " compression but the profile reader was built " + "without " + + compression::profile::AlgorithmName + " s

[PATCH] D129009: [llvm.analysis] Fix LTO for aliased IFuncs.

SchrodingerZhu created this revision. Herald added subscribers: steakhal, ormris, jeroen.dobbelaere, steven_wu, hiraditya, inglorion. Herald added a project: All. SchrodingerZhu requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commi

[PATCH] D129009: [llvm.analysis] Fix LTO for aliased IFuncs. As https://github.com/llvm/llvm-project/issues/56290 indicates, when an ifunc is aliased in LTO, clang will attempt to create an alias su

SchrodingerZhu updated this revision to Diff 441756. SchrodingerZhu retitled this revision from "[llvm.analysis] Fix LTO for aliased IFuncs." to "[llvm.analysis] Fix LTO for aliased IFuncs. As https://github.com/llvm/llvm-project/issues/56290 indicates, when an ifunc is aliased in LTO, clang wil

  1   2   >