[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

thieta created this revision. thieta added reviewers: steakhal, martong, NoQ. Herald added a subscriber: rnkovacs. Herald added a project: All. thieta requested review of this revision. Herald added a project: clang. When doing CTU analysis setup you pre-compile .cpp to .ast and then you run clang

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

thieta added a comment. This still needs tests - but I wanted to get your early input on the approach here and what you all think. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128704/new/ https://reviews.llvm.org/D128704

[clang] 3f0578d - [clang-cl] Add -emit-ast to clang-cl driver

Author: Tobias Hieta Date: 2022-06-28T09:11:34+02:00 New Revision: 3f0578dd87ee5539eccae507b6a77cfe3354d705 URL: https://github.com/llvm/llvm-project/commit/3f0578dd87ee5539eccae507b6a77cfe3354d705 DIFF: https://github.com/llvm/llvm-project/commit/3f0578dd87ee5539eccae507b6a77cfe3354d705.diff

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f0578dd87ee: [clang-cl] Add -emit-ast to clang-cl driver (authored by thieta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct

jackhong12 added a comment. Sorry, I don't have commit access. @HazardyKnusperkeks, could you help me commit it? If I want to contribute to LLVM in the future, how do I get the commit permission? Does it depend on the number of patches I submit? CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D128706: [Clang] Disable clang-format entirely for clang/test tree.

mboehme created this revision. Herald added a subscriber: JDevlieghere. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. See discussion here: https://github.com/llvm/llvm-project/issues/55982 We don't g

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke updated this revision to Diff 440517. Sockke added a comment. rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org/D127293 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tools-extra/test/clang-ti

[PATCH] D128708: [pseudo] Simplify/loosen the grammar around lambda captures.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. Treat captures as a uniform list, rather than default-captu

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj added a comment. can you give this another look, if you have some time @sammccall? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124690/new/ https://reviews.llvm.org/D124690 ___ cfe-commits mailing

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

nridge added a comment. Thanks for the update! In D127082#3606746 , @daiyousei-qz wrote: > Therefore, I still put definition in front of the expansion in this update. > > Regarding to the size limit of expansion: > Here I'm using a 2048 bytes buffer. I

[PATCH] D128709: [clang-format] Handle Verilog attributes

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://

[PATCH] D128711: [clang-format] Handle Verilog blocks

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Now stuff inside begin-end blocks get indented.

[PATCH] D128712: [clang-format] Handle Verilog modules

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Now things inside hierarchies like modules and

[PATCH] D128713: [clang-format] Handle Verilog user-defined primitives

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://

[PATCH] D128714: [clang-format] Handle Verilog case statements

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These statements are like switch statements in

[PATCH] D128715: [clang-tidy] Fix confusable identifiers interaction with DeclContext

serge-sans-paille created this revision. serge-sans-paille added a reviewer: aaron.ballman. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe

[clang] 5548e80 - [IR] Remove support for extractvalue constant expression

Author: Nikita Popov Date: 2022-06-28T10:40:17+02:00 New Revision: 5548e807b5777fdda167b6795e0e05432a6163f1 URL: https://github.com/llvm/llvm-project/commit/5548e807b5777fdda167b6795e0e05432a6163f1 DIFF: https://github.com/llvm/llvm-project/commit/5548e807b5777fdda167b6795e0e05432a6163f1.diff

[PATCH] D125795: [IR] Remove support for extractvalue constant expression

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5548e807b577: [IR] Remove support for extractvalue constant expression (authored by nikic). Herald added a project: clang. Herald added a subscriber:

[PATCH] D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct

HazardyKnusperkeks added a comment. In D127873#3614559 , @jackhong12 wrote: > Sorry, I don't have commit access. @HazardyKnusperkeks, could you help me > commit it? > > If I want to contribute to LLVM in the future, how do I get the commit > permission

[PATCH] D128649: [clang-cl] Handle some pragma alloc_text corner cases handled by MSVC

hans added a comment. In D128649#3612875 , @steplong wrote: >> Isn't the question whether `f` is considered "extern C" in the end or not? I >> thought `isExternC()` checks that? Are you saying it would return false for >> `f` in your example? > > Yup, `

[PATCH] D128709: [clang-format] Handle Verilog attributes

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Seems straight forward. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128709/new/ https://reviews.llvm.org/D128709

[PATCH] D128712: [clang-format] Handle Verilog modules

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatToken.h:1742 + /// Returns whether \p Tok is a Verilog keyword that opens a module, etc. + bool isVerilogHier(const FormatToken &Tok) const { +if (Tok.endsSequence(kw_function, kw_with)) --

[PATCH] D128645: Update developer policy.

vext01 added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:419-421 -Your first commit to a repository may require the autogenerated email to be -approved by a moderator of the mailing list. -This is normal and will be done when the mailing list owner has time. --

[PATCH] D128714: [clang-format] Handle Verilog case statements

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:1265 LLVMStyle.IndentAccessModifiers = false; - LLVMStyle.IndentCaseLabels = false; + LLVMStyle.IndentCaseLabels = LLVMStyle.isVerilog() ? true : false; LLVMStyle.IndentCaseBlocks = false; -

[PATCH] D127812: [AArch64] Function multiversioning support added.

samtebbs added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11483 +def warn_target_clone_no_impact_options +: Warning<"version list contains no code impact entries">, + InGroup; ilinpv wrote: > erichkeane wrote: > > I'm n

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

thieta updated this revision to Diff 440558. thieta added a comment. Add test. Just repurpose the same test we already have but add a step to generate ast first and then pushing that through extdef-mapping. It should always produce the same result. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

thieta added inline comments. Comment at: clang/tools/clang-extdef-mapping/ClangExtDefMapGen.cpp:122 + + CompilerInstance CI; + Not sure if I can just create a compilerinstance here and if I should feed it anymore data then I already do. Comm

[PATCH] D117432: [RISCV] Implement support for the Zicbom and Zicboz extensions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4f40ca53cefb: [RISCV] Implement support for the Zicbom and Zicboz extensions (authored by asb). Herald added a project: clang. Herald added a subscri

[PATCH] D117433: [RISCV] Implement support for the Zicbop extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7bcfcabbd14e: [RISCV] Implement support for the Zicbop extension (authored by asb). Herald added a project: clang. Herald added a subscriber: cfe-com

[clang] 4f40ca5 - [RISCV] Implement support for the Zicbom and Zicboz extensions

Author: Alex Bradbury Date: 2022-06-28T12:43:25+01:00 New Revision: 4f40ca53cefb725aca6564585d0ec4836a79e21a URL: https://github.com/llvm/llvm-project/commit/4f40ca53cefb725aca6564585d0ec4836a79e21a DIFF: https://github.com/llvm/llvm-project/commit/4f40ca53cefb725aca6564585d0ec4836a79e21a.diff

[clang] 7bcfcab - [RISCV] Implement support for the Zicbop extension

Author: Alex Bradbury Date: 2022-06-28T12:43:26+01:00 New Revision: 7bcfcabbd14e9cd51d150a36aee9edf4f4231724 URL: https://github.com/llvm/llvm-project/commit/7bcfcabbd14e9cd51d150a36aee9edf4f4231724 DIFF: https://github.com/llvm/llvm-project/commit/7bcfcabbd14e9cd51d150a36aee9edf4f4231724.diff

[PATCH] D117432: [RISCV] Implement support for the Zicbom and Zicboz extensions

asb added a comment. In D117432#3599255 , @craig.topper wrote: > Reverse ping. Is anything blocking this being merged? No, thanks for the ping - now landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm updated this revision to Diff 440570. srishti-pm marked 6 inline comments as done. srishti-pm added a comment. Addressed the final comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124750/new/ https://reviews.llvm.org/D124750 File

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm added a comment. @mehdi_amini, I have made sure that the algorithm is good in terms of both time and space complexity. @Mogball, "handling attributes (e.g. cmpi slt vs cmpi sgt)" doesn't seem hard to me. I think this algorithm can be extended with ease to take attributes into accoun

[PATCH] D128612: RISC-V big-endian support implementation

gbenyei updated this revision to Diff 440579. gbenyei marked 7 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128612/new/ https://reviews.llvm.org/D128612 Files: clang/include/clang/Basic/Attr.td clang/lib/Basic/Targets.c

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin added inline comments. Herald added a subscriber: steakhal. Comment at: clang/tools/libclang/CIndex.cpp:3452 continue; - -if (Visit(MakeCursorVariableRef(C->getCapturedVar(), C->getLocation(), -TU))) +//

[PATCH] D128351: [clang] missing outer template levels when checking template constraints

erichkeane added a comment. So I don't think this is the right fix for this... But I DID check and see that the test case seems to be fixed here: https://reviews.llvm.org/D126907 , which does a lot of rework for this sort of thing. That patch is expected to be complete/ready for submission in t

[PATCH] D128726: [RISCV][NFC] Move static global variables into static variable in function.

kito-cheng created this revision. Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, niosHD, s

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam marked an inline comment as done. zahiraam added a comment. In D113107#3606106 , @rjmccall wrote: > In D113107#3606094 , @zahiraam > wrote: > >> In D113107#3605797

[PATCH] D128697: [clang-tidy] Add new check `bugprone-unhandled-exception-at-sto`

Eugene.Zelenko added a comment. I think will be good idea to make check more generic and allow user-defined list of unsafe functions. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:135 +- New :doc:`bugprone-unhandled-exception-at-sto + ` check. Please

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry about the delay. This is complicated stuff and every time I put it down for a day I forget how it works! Thanks for your hard work here. I have some more suggestions but hopefully

[PATCH] D128687: [pseudo] Allow mixed designated/undesignated init lists.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/lib/cxx.bnf:468 designator := . IDENTIFIER +designator := [ expression ] expr-or-braced-init-list := expression I

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

dongjunduo added inline comments. Comment at: clang/include/clang/Driver/Options.td:2819 "'per-pass-run': one report for each pass invocation">; def ftime_trace : Flag<["-"], "ftime-trace">, Group, HelpText<"Turn on time profiler. Generates JSON file based on outp

[PATCH] D128687: [pseudo] Allow mixed designated/undesignated init lists.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/pseudo/lib/cxx.bnf:468 designator := . IDENTIFIER +designator := [ expression ] expr-or-braced-init-list := expression hokein wrote: > I think this is the

[clang-tools-extra] 8cf2858 - [pseudo] Allow mixed designated/undesignated init lists.

Author: Sam McCall Date: 2022-06-28T15:45:41+02:00 New Revision: 8cf28585a40311163a08840beee035097638d41d URL: https://github.com/llvm/llvm-project/commit/8cf28585a40311163a08840beee035097638d41d DIFF: https://github.com/llvm/llvm-project/commit/8cf28585a40311163a08840beee035097638d41d.diff LO

[PATCH] D128687: [pseudo] Allow mixed designated/undesignated init lists.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG8cf28585a403: [pseudo] Allow mixed designated/undesignated init lists. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D128687?vs=4

[clang-tools-extra] aacefc8 - [pseudo] Simplify/loosen the grammar around lambda captures.

Author: Sam McCall Date: 2022-06-28T15:56:12+02:00 New Revision: aacefc817d9385835db5b5e30a21687ddb4f3f93 URL: https://github.com/llvm/llvm-project/commit/aacefc817d9385835db5b5e30a21687ddb4f3f93 DIFF: https://github.com/llvm/llvm-project/commit/aacefc817d9385835db5b5e30a21687ddb4f3f93.diff LO

[PATCH] D128708: [pseudo] Simplify/loosen the grammar around lambda captures.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaacefc817d93: [pseudo] Simplify/loosen the grammar around lambda captures. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128708/new/

[clang-tools-extra] 241557f - [pseudo] Move cxx grammar into the cxx/ directory. NFC

Author: Sam McCall Date: 2022-06-28T16:02:10+02:00 New Revision: 241557fb0600fcef67bdd0698fbbd2fb9a3459e2 URL: https://github.com/llvm/llvm-project/commit/241557fb0600fcef67bdd0698fbbd2fb9a3459e2 DIFF: https://github.com/llvm/llvm-project/commit/241557fb0600fcef67bdd0698fbbd2fb9a3459e2.diff LO

[PATCH] D128645: Update developer policy.

vext01 added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:87 -#. Patches should be made with ``git format-patch``, or similar (see special - commands for `Requesting Phabricator review via the web interface - `_ ). If you use a - different tool, make sure it

[PATCH] D128604: [RISCV] Support Zbpbo extension

sunshaoce updated this revision to Diff 440613. sunshaoce added a comment. Rebased on D128644 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128604/new/ https://reviews.llvm.org/D128604 Files: clang/include/clan

[PATCH] D128649: [clang-cl] Handle some pragma alloc_text corner cases handled by MSVC

steplong updated this revision to Diff 440618. steplong added a comment. - Rework logic for rejecting non-functions and non-extern C functions when C++ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128649/new/ https://reviews.llvm.org/D128649 File

[PATCH] D128649: [clang-cl] Handle some pragma alloc_text corner cases handled by MSVC

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128649/new/ https://reviews.llvm.org/D128649 ___ cfe

[clang] 313f9cd - Update statuses and add tests for C89 DRs

Author: Aaron Ballman Date: 2022-06-28T10:29:20-04:00 New Revision: 313f9cd81d01a3a63d3cdc94ee13b21117b2b3bd URL: https://github.com/llvm/llvm-project/commit/313f9cd81d01a3a63d3cdc94ee13b21117b2b3bd DIFF: https://github.com/llvm/llvm-project/commit/313f9cd81d01a3a63d3cdc94ee13b21117b2b3bd.diff

[PATCH] D128706: [Clang] Disable clang-format entirely for clang/test tree.

aaron.ballman added a comment. The changes here LGTM and I think this is the correct way to go. However, since you discovered that it was perhaps intentional that we did some style checking on tests, do you think we should have a brief community RFC just to make sure everyone's on the same page

[clang-tools-extra] 3f028c0 - [pseudo] Grammar::parseBNF returns Grammar not unique_ptr. NFC

Author: Sam McCall Date: 2022-06-28T16:34:21+02:00 New Revision: 3f028c02ba6a24b7230fd5907a2b7ba076664a8b URL: https://github.com/llvm/llvm-project/commit/3f028c02ba6a24b7230fd5907a2b7ba076664a8b DIFF: https://github.com/llvm/llvm-project/commit/3f028c02ba6a24b7230fd5907a2b7ba076664a8b.diff LO

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. We typically don't add AST matchers until we have a need for them to be used in-tree (ASTMatchers.h is already really expensive to parse; adding matchers for everything possible with AST nodes would be prohibitively ex

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

awarzynski added a comment. In D128333#3613696 , @MaskRay wrote: > True. If it is difficult to override the -pie default from flang side, I am > fine with the code change. Thanks! The proper/long-term fix will require extending Flang's frontend driver

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

masoud.ataei updated this revision to Diff 440625. masoud.ataei added a comment. Test updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128653/new/ https://reviews.llvm.org/D128653 Files: clang/test/CodeGen/lower-mass-end-to-end.c llvm/li

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

awarzynski updated this revision to Diff 440628. awarzynski added a comment. Update the test following the comments from @MaskRay Also added a comment in Linux.cpp and renamed no-pie.f90 as pic-flags.f90 (to avoid FileCheck matching e.g. `! CHECK: pie` against the file name). Repository: rG

[PATCH] D128645: Update developer policy.

aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:87 -#. Patches should be made with ``git format-patch``, or similar (see special - commands for `Requesting Phabricator review via the web interface - `_ ). If you use a - different tool, make

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

sdesmalen updated this revision to Diff 440631. sdesmalen marked 3 inline comments as done. sdesmalen added a comment. - Removed attribute handling from SemaDeclAttr.cpp, so that the type attributes are only handled in SemaType.cpp - Made ArmLocallyStreaming a DeclOrTypeAttribute again. - Added n

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

sdesmalen added a comment. Thanks for your patience reviewing this patch @aaron.ballman! Comment at: clang/include/clang/AST/Type.h:4064 bool HasTrailingReturn : 1; +unsigned AArch64SMEAttributes : 8; Qualifiers TypeQuals; aaron.ballman wrote: > I

[PATCH] D128645: Update developer policy.

vext01 added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:419-421 -Your first commit to a repository may require the autogenerated email to be -approved by a moderator of the mailing list. -This is normal and will be done when the mailing list owner has time. --

[PATCH] D128645: Update developer policy.

xbolva00 added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:87 -#. Patches should be made with ``git format-patch``, or similar (see special - commands for `Requesting Phabricator review via the web interface - `_ ). If you use a - different tool, make sure

[PATCH] D108469: Improve handling of static assert messages.

aaron.ballman added a comment. Patch application is still failing the precommit CI; it'd be nice to get that corrected for some early test feedback. Comment at: clang/docs/ReleaseNotes.rst:275 This fixes `Issue 55962 `_. +

[PATCH] D128645: Update developer policy.

vext01 added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:88 +#. Patches should be unified diffs with "infinte context" (i.e. using something + like `git diff -U 99 main`). + xbolva00 wrote: > main is weird example here imho. How comes? The do

[PATCH] D128319: Survive #pragma once from virtual file.

v.g.vassilev added a comment. Historically, the patch was developed before the extended support of virtual files in Clang. Given that this is very hard to test and it looks like this is not needed on our end anymore. I'd propose to pause this for now. Repository: rG LLVM Github Monorepo CHA

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 440640. cor3ntin added a comment. Try to fix the patch application issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469 Files: clang/docs/ReleaseNotes.rst clang

[PATCH] D108469: Improve handling of static assert messages.

aaron.ballman added a comment. I've removed the parent revision as this review no longer requires it to proceed. That should get precommit CI working again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 440642. cor3ntin added a comment. Trigger a CI rerun Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic

[PATCH] D128715: [clang-tidy] Fix confusable identifiers interaction with DeclContext

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but I have some additional testing requests which might spawn follow-up patches. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc/confusable-

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane updated this revision to Diff 440643. erichkeane added a comment. All tests pass now, I was able to get the template-template checks working correctly, and it passes all the tests I have available. @ChuanqiXu if you could review/run what tests you have, it would be greatly appreciate

[PATCH] D128319: Survive #pragma once from virtual file.

aaron.ballman added a comment. In D128319#3615779 , @v.g.vassilev wrote: > Historically, the patch was developed before the extended support of virtual > files in Clang. Given that this is very hard to test and it looks like this > is not needed on our

[PATCH] D123952: [FPEnv] Allow CompoundStmt to keep FP options

sepavloff updated this revision to Diff 440644. sepavloff added a comment. Updated patch according to reviewers' notes - Rename field of CompoundScopeInfo, - Treat FE_DYNAMIC like other rounding mode arguments in StmtPrinter, - Rename and optimize method for calculation of FP option difference.

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 440645. cor3ntin marked an inline comment as done. cor3ntin added a comment. Fix rst syntax Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469 Files: clang/docs/Relea

[PATCH] D128486: [pseudo] Add error-recovery framework & brace-based recovery

sammccall updated this revision to Diff 440646. sammccall added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128486/new/ https://reviews.llvm.org/D128486 Files: clang-tools-extra/pseudo/include/clang-pseudo/GLR.h clang-tools

[PATCH] D128645: Update developer policy.

xbolva00 added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:88 +#. Patches should be unified diffs with "infinte context" (i.e. using something + like `git diff -U 99 main`). + vext01 wrote: > xbolva00 wrote: > > main is weird example here imh

[PATCH] D128645: Update developer policy.

vext01 updated this revision to Diff 440647. vext01 added a comment. I've addressed the comments. I only linked `llvm-commits` (reusing the already defined rst link) as the other lists are referenced elsewhere. Typo also fixed. After fixing my `-U 99`, grepping the tree for `` in rst f

[PATCH] D128604: [RISCV] Support Zbpbo extension

craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:21 TARGET_BUILTIN(__builtin_riscv_orc_b_64, "WiWi", "nc", "zbb,64bit") -TARGET_BUILTIN(__builtin_riscv_clz_32, "ZiZi", "nc", "zbb") +TARGET_BUILTIN(__builtin_riscv_clz_32, "ZiZi", "nc", "

[PATCH] D128645: Update developer policy.

vext01 added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:88 +#. Patches should be unified diffs with "infinte context" (i.e. using something + like `git diff -U 99 main`). + xbolva00 wrote: > vext01 wrote: > > xbolva00 wrote: > > > main is we

[PATCH] D128700: [AMDGPU][Clang] Skip adding noundef attribute to AMDGPU HIP device functions

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2309 + bool EnableNoundefAttrs = CodeGenOpts.EnableNoundefAttrs && +!(getLangOpts().HIP && getLangOpts().CUDAIsDevice); + Shouldn't be limited to HIP. All language

[PATCH] D128329: [clangd] Also mark output arguments of operator call expressions

ckandeler updated this revision to Diff 440650. ckandeler marked 2 inline comments as done. ckandeler added a comment. Improvements as per review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128329/new/ https://reviews.llvm.org/D128329

[PATCH] D128182: [NFC] Switch FloatModeKind enum class to use bitmask enums

jolanta.jensen updated this revision to Diff 440653. jolanta.jensen added a comment. Correcting computation of RealTypeUsesObjCFPRetMask. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128182/new/ https://reviews.llvm.org/D128182 Files: clang/inc

[PATCH] D123952: [FPEnv] Allow CompoundStmt to keep FP options

sepavloff added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:747 + /// Return difference with the given option set. + FPOptionsOverride diffWith(const FPOptions &Base); + rjmccall wrote: > Can you make direction more obvious in the metho

[PATCH] D128182: [NFC] Switch FloatModeKind enum class to use bitmask enums

jolanta.jensen added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:225-226 unsigned HasAlignMac68kSupport : 1; - unsigned RealTypeUsesObjCFPRetMask : (int)FloatModeKind::Last + 1; + unsigned RealTypeUsesObjCFPRetMask + : (int)FloatModeKind::LLVM_BI

[PATCH] D128645: Update developer policy.

xbolva00 added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:88 +#. Patches should be unified diffs with "infinte context" (i.e. using something + like `git diff -U 99 main`). + vext01 wrote: > xbolva00 wrote: > > vext01 wrote: > > > xbolva00 w

[clang] a2095d1 - Allow mangled names in sanitizer clang IR gen tests.

Author: Mitch Phillips Date: 2022-06-28T09:27:43-07:00 New Revision: a2095d1aff847ab7f7035744fb718c32cf680a01 URL: https://github.com/llvm/llvm-project/commit/a2095d1aff847ab7f7035744fb718c32cf680a01 DIFF: https://github.com/llvm/llvm-project/commit/a2095d1aff847ab7f7035744fb718c32cf680a01.diff

[PATCH] D128726: [RISCV][NFC] Move static global variables into static variable in function.

jrtc27 added a comment. The commit message is poor, because the problem is not the use of static globals, it's the use of globals that have constructors. Moving them to be static function-scoped variables doesn't change the fact that they still have static duration; you change the scope of them

[PATCH] D128645: Update developer policy.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The changes LGTM, but you should wait a bit before landing in case other reviewers/subscribers want to chime in if they still have opinions. Comment at: llvm/d

[PATCH] D108469: Improve handling of static assert messages.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! The precommit CI failures appear to be unrelated as best I can tell. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

scott.linder added a comment. I will let others comment, but I think this is a perfectly reasonable alternative, and I much prefer using indentation over the delimiter-remark approach. LGTM, assuming nobody else objects Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D128202: [clangd] Include "final" when printing class declaration

tom-anders updated this revision to Diff 440676. tom-anders added a comment. Check for FinalAttr instead of using isEffectivelyFinal() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128202/new/ https://reviews.llvm.org/D128202 Files: clang-tools-

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim added a comment. In D127911#3614242 , @thakis wrote: > Looks like this breaks check-clang on windows: > http://45.33.8.238/win/61067/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Thanks. Added a2095d1aff84

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

benlangmuir added a comment. This broke some compiler-rt tests on Darwin: https://green.lab.llvm.org/green/job/clang-stage1-RA/29920/ Test Result (3 failures / +3) Builtins-x86_64-darwin.Builtins-x86_64-darwin.extendhfsf2_test.c Builtins-x86_64-darwin.Builtins-x86_64-darwin.truncdfhf2_test.

[PATCH] D127898: [clang][dataflow] Add API to separate analysis from diagnosis

samestep updated this revision to Diff 440687. samestep added a comment. - Implement Gábor's suggestion - Merge branch 'main' into diagnose-api Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127898/new/ https://reviews.llvm.org/D127898 Files: cl

[clang] eab2a06 - Revert "Reland "[X86] Support `_Float16` on SSE2 and up""

Author: Ben Langmuir Date: 2022-06-28T10:59:03-07:00 New Revision: eab2a06f0fde51eee6b1526bd301d60c4cc9b050 URL: https://github.com/llvm/llvm-project/commit/eab2a06f0fde51eee6b1526bd301d60c4cc9b050 DIFF: https://github.com/llvm/llvm-project/commit/eab2a06f0fde51eee6b1526bd301d60c4cc9b050.diff

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

benlangmuir added a comment. Reverted in eab2a06f0fde due to the Darwin test failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/ https://reviews.llvm.org/D12857

[PATCH] D127898: [clang][dataflow] Add API to separate analysis from diagnosis

ymandel added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.h:126 +std::function +PostVisitStmt = nullptr); Please update comment to mention this new param (and that its optional) =

[PATCH] D128745: [Sema] fix trailing parameter pack handling for function template partial ordering

ychen created this revision. ychen added reviewers: rsmith, aaron.ballman. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D128745 Files:

  1   2   3   >